38991 2010-05-12 07:43:28 -0700 HTMLLabelElement::control() should return HTMLFormControlElement, not HTMLElement 2010-05-12 12:12:08 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned darin oldest_to_newest 224602 0 yael 2010-05-12 07:43:28 -0700 This is from the comment https://bugs.webkit.org/show_bug.cgi?id=38688#c18. This change cannot remove type casting in the code, but it is still the right thing to do. 224603 1 55844 yael 2010-05-12 07:48:46 -0700 Created attachment 55844 Patch 224611 2 55844 mitz 2010-05-12 08:02:43 -0700 Comment on attachment 55844 Patch > +#include "HTMLFormControlElement.h" I think a forward declaration of the class will suffice here, instead of including the header. 224620 3 yael 2010-05-12 08:20:03 -0700 (In reply to comment #2) > (From update of attachment 55844 [details]) > > +#include "HTMLFormControlElement.h" > > I think a forward declaration of the class will suffice here, instead of including the header. Thanks for your review. I added the header due to problem compiling DOMHTMLLabelElement.mm. Perhaps there was a better way to fix the compile error. 224787 4 yael 2010-05-12 12:11:42 -0700 Committed r59248: <http://trac.webkit.org/changeset/59248> 55844 2010-05-12 07:48:46 -0700 2010-05-12 12:12:08 -0700 Patch 38991.patch text/plain 1824 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTIzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMTIgIHlhZWwgYWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEhUTUxMYWJlbEVsZW1lbnQ6OmNvbnRyb2woKSBzaG91bGQgcmV0dXJuIEhUTUxGb3JtQ29udHJv bEVsZW1lbnQsIG5vdCBIVE1MRWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Mzg5OTEKKworICAgICAgICBObyBuZXcgdGVzdHMgc2luY2Ugbm8g bmV3IGZ1bmN0aW9uYWxpdHkgd2FzIGludHJvZHVjZWQuCisKKyAgICAgICAgKiBodG1sL0hUTUxM YWJlbEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTExhYmVsRWxlbWVudDo6Y29u dHJvbCk6CisgICAgICAgICogaHRtbC9IVE1MTGFiZWxFbGVtZW50Lmg6CisKIDIwMTAtMDUtMTIg IEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTExhYmVsRWxlbWVudC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxMYWJlbEVsZW1lbnQuY3BwCShyZXZpc2lvbiA1 OTIyNykKKysrIFdlYkNvcmUvaHRtbC9IVE1MTGFiZWxFbGVtZW50LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNjMsNyArNjMsNyBAQCBib29sIEhUTUxMYWJlbEVsZW1lbnQ6OmlzRm9jdXNhYmxlKCkg Y29uCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi1IVE1MRWxlbWVudCogSFRNTExhYmVsRWxlbWVu dDo6Y29udHJvbCgpCitIVE1MRm9ybUNvbnRyb2xFbGVtZW50KiBIVE1MTGFiZWxFbGVtZW50Ojpj b250cm9sKCkKIHsKICAgICBjb25zdCBBdG9taWNTdHJpbmcmIGNvbnRyb2xJZCA9IGdldEF0dHJp YnV0ZShmb3JBdHRyKTsKICAgICBpZiAoY29udHJvbElkLmlzTnVsbCgpKSB7CkluZGV4OiBXZWJD b3JlL2h0bWwvSFRNTExhYmVsRWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9I VE1MTGFiZWxFbGVtZW50LmgJKHJldmlzaW9uIDU5MjI3KQorKysgV2ViQ29yZS9odG1sL0hUTUxM YWJlbEVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMjUsNiArMjUsNyBAQAogI2RlZmluZSBI VE1MTGFiZWxFbGVtZW50X2gKIAogI2luY2x1ZGUgIkhUTUxFbGVtZW50LmgiCisjaW5jbHVkZSAi SFRNTEZvcm1Db250cm9sRWxlbWVudC5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTQ2 LDcgKzQ3LDcgQEAgcHVibGljOgogICAgIC8vIE92ZXJyaWRkZW4gdG8gZWl0aGVyIGNsaWNrKCkg b3IgZm9jdXMoKSB0aGUgY29ycmVzcG9uZGluZyBjb250cm9sLgogICAgIHZpcnR1YWwgdm9pZCBk ZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50Kik7CiAKLSAgICBIVE1MRWxlbWVudCogY29udHJvbCgp OworICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQqIGNvbnRyb2woKTsKIAogICAgIFN0cmluZyBh Y2Nlc3NLZXkoKSBjb25zdDsKICAgICB2b2lkIHNldEFjY2Vzc0tleShjb25zdCBTdHJpbmcmKTsK