38990 2010-05-12 07:30:10 -0700 Touch events are disabled by default when using V8. 2010-05-14 02:50:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 benm benm andreip android-webkit-unforking commit-queue dglazkov fishd gdk steveblock oldest_to_newest 224597 0 benm 2010-05-12 07:30:10 -0700 With https://bugs.webkit.org/show_bug.cgi?id=37485 and https://bugs.webkit.org/show_bug.cgi?id=38392 a runtime flag was added to configure support for touch events and it is false by default, i.e. touch events are turned off. This means touch events no longer work on Android after this change. Chromium configures this flag independently of the WebCore default and the code inside RuntimeEnabledFeatures.h is protected by the ENABLE(TOUCH_EVENTS) compile time guard. I think it is safe therefore to make the default for this flag inside WebCore true. Patch to follow. 224606 1 55846 benm 2010-05-12 07:56:35 -0700 Created attachment 55846 Patch. 224609 2 steveblock 2010-05-12 08:00:42 -0700 > I think it is safe therefore to make the default for this flag inside WebCore > true. It seems that all runtime-enabled features that are also guarded by a compile flag should default to 'on', particularly if the default is overriden by chromium anyway. 224666 3 55846 fishd 2010-05-12 09:16:56 -0700 Comment on attachment 55846 Patch. R=me, and I agree that it makes sense to enable the rest by default as well. That can be a separate patch though. 225731 4 55846 commit-queue 2010-05-14 02:50:28 -0700 Comment on attachment 55846 Patch. Clearing flags on attachment: 55846 Committed r59459: <http://trac.webkit.org/changeset/59459> 225732 5 commit-queue 2010-05-14 02:50:39 -0700 All reviewed patches have been landed. Closing bug. 55846 2010-05-12 07:56:35 -0700 2010-05-14 02:50:27 -0700 Patch. 38990.txt text/plain 1423 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTIzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDUtMTIgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvdWNo IGV2ZW50cyBhcmUgZGlzYWJsZWQgYnkgZGVmYXVsdCB3aGVuIHVzaW5nIFY4LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg5OTAKKworICAgICAgICBU b3VjaCBldmVudHMgYXJlIHByb3RlY3RlZCBieSBhIGNvbXBpbGUgdGltZSBndWFyZCwgc28gaXQn cyBzYWZlIHRvCisgICAgICAgIGFzc3VtZSB0aGF0IHRoZSBydW50aW1lIGZsYWcgIHNob3VsZCBi ZSBlbmFibGVkIGJ5IGRlZmF1bHQgd2hlbiB0aGlzCisgICAgICAgIGd1YXJkIGlzIHByZXNlbnQu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBidWlsZCBmaXggZm9yIEFuZHJvaWQuCisKKyAgICAg ICAgKiBiaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwOiBlbmFibGUg dG91Y2ggZXZlbnRzIGJ5IGRlZmF1bHQuCisKIDIwMTAtMDUtMTIgIEplciBOb2JsZSAgPGplci5u b2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4 OiBXZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVy ZXMuY3BwCShyZXZpc2lvbiA1OTIzMSkKKysrIFdlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50 aW1lRW5hYmxlZEZlYXR1cmVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDcsNyArNDcsNyBAQCBi b29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzR2VvbG9jYXRpCiBib29sIFJ1bnRpbWVFbmFi bGVkRmVhdHVyZXM6OmlzSW5kZXhlZERCRW5hYmxlZCA9IGZhbHNlOwogYm9vbCBSdW50aW1lRW5h YmxlZEZlYXR1cmVzOjppc1dlYkdMRW5hYmxlZCA9IGZhbHNlOwogYm9vbCBSdW50aW1lRW5hYmxl ZEZlYXR1cmVzOjppc1B1c2hTdGF0ZUVuYWJsZWQgPSBmYWxzZTsKLWJvb2wgUnVudGltZUVuYWJs ZWRGZWF0dXJlczo6aXNUb3VjaEVuYWJsZWQgPSBmYWxzZTsKK2Jvb2wgUnVudGltZUVuYWJsZWRG ZWF0dXJlczo6aXNUb3VjaEVuYWJsZWQgPSB0cnVlOwogCiAjaWYgRU5BQkxFKFZJREVPKQogCg==