38989 2010-05-12 06:52:22 -0700 [Qt] Remove the unneeded check for QWidgetPageClient @QGraphicsWebView::detachCurrentPage 2010-05-12 08:08:35 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 tonikitoo tonikitoo hausmann jesus kenneth oldest_to_newest 224575 0 tonikitoo 2010-05-12 06:52:22 -0700 Bug title says it all. Reasons: - There is no need to check for a QWidgetPageClient-based in QGraphicsWebView. - The client has always to be deleted anyways. patch coming ... 224578 1 55840 tonikitoo 2010-05-12 06:54:57 -0700 Created attachment 55840 patch v1 224580 2 jesus 2010-05-12 07:04:40 -0700 (In reply to comment #1) > Created an attachment (id=55840) [details] > patch v1 I missed that on my PageClient patches. =/ Thanks! LGTM, just remember to add the bug number to the Changelog. :) 224581 3 jesus 2010-05-12 07:09:59 -0700 If we want this to go into the 2.0 release we would need to cherry-pick the PageClient refactor first. https://bugs.webkit.org/show_bug.cgi?id=37856 224583 4 tonikitoo 2010-05-12 07:11:55 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=55840) [details] [details] > > patch v1 > > I missed that on my PageClient patches. =/ > Thanks! LGTM, just remember to add the bug number to the Changelog. :) I can fix that while landing (it is done locally already). Thank you. (In reply to comment #3) > If we want this to go into the 2.0 release we would need to cherry-pick the PageClient refactor first. > https://bugs.webkit.org/show_bug.cgi?id=37856 Sure, removing the block for now. 224587 5 55840 kenneth 2010-05-12 07:17:09 -0700 Comment on attachment 55840 patch v1 WebKit/qt/Api/qgraphicswebview.cpp:451 + delete page->d->client; No need to use an if, delete'ing a null pointer does nothing. 224590 6 55843 tonikitoo 2010-05-12 07:21:26 -0700 Created attachment 55843 patch v2 as requested: - Adds the bugzilla entry to the ChangeLog - Removes the "if" wrapping the delete 224613 7 tonikitoo 2010-05-12 08:08:35 -0700 Committed r59234: <http://trac.webkit.org/changeset/59234> 55840 2010-05-12 06:54:57 -0700 2010-05-12 07:21:26 -0700 patch v1 0001-2010-05-12-Antonio-Gomes-tonikitoo-webkit.org.patch text/plain 2526 tonikitoo RnJvbSBjMDFkZDQ1YjMxMmY3MmQxNTc0ZjVkNGI3ZDVjNGZjMTY1MGJlNGVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogV2VkLCAxMiBNYXkgMjAxMCAwOTo0NTowNCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIw MTAtMDUtMTIgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KCiAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtRdF0gUmVtb3ZlIHRoZSB1bm5l ZWRlZCBjaGVjayBmb3IgUVdpZGdldFBhZ2VDbGllbnQgQFFHcmFwaGljc1dlYlZpZXc6OmRldGFj aFBhZ2UKCiAgICAgICAgUmVhc29uczoKICAgICAgICAtIFRoZXJlIGlzIG5vIG5lZWQgdG8gY2hl Y2sgZm9yIGEgUVdpZGdldFBhZ2VDbGllbnQtYmFzZWQgaW4gUUdyYXBoaWNzV2ViVmlldy4KICAg ICAgICAtIFRoZSBjbGllbnQgaGFzIGFsd2F5cyB0byBiZSBkZWxldGVkIGFueXdheXMuCgogICAg ICAgICogQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwOgogICAgICAgIChRR3JhcGhpY3NXZWJWaWV3 UHJpdmF0ZTo6ZGV0YWNoUGFnZSk6Ci0tLQogV2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3 LmNwcCB8ICAgIDcgKystLS0tLQogV2ViS2l0L3F0L0NoYW5nZUxvZyAgICAgICAgICAgICAgICB8 ICAgMTMgKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA1 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmll dy5jcHAgYi9XZWJLaXQvcXQvQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwCmluZGV4IGY4NTU4ODIu LjFkYTMyODAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAK KysrIGIvV2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcApAQCAtNDQxLDIxICs0NDEs MTggQEAgdm9pZCBRR3JhcGhpY3NXZWJWaWV3UHJpdmF0ZTo6ZGV0YWNoUGFnZSgpCiAgICAgICAg IHJldHVybjsKIAogI2lmIFFUX1ZFUlNJT04gPj0gMHgwNDA2MDAKICAgICBwYWdlLT5kLT52aWV3 LmNsZWFyKCk7CiAjZWxzZQogICAgIHBhZ2UtPmQtPnZpZXcgPSAwOwogI2VuZGlmCiAKLSAgICAv LyBpZiB0aGUgcGFnZSBjbGllbnQgaXMgdGhlIHNwZWNpYWwgY2xpZW50IGNvbnN0cnVjdGVkIGZv cgotICAgIC8vIGRlbGVnYXRpbmcgdGhlIHJlc3BvbnNpYmlsaXRpZXMgdG8gYSBRV2lkZ2V0LCB3 ZSBuZWVkCi0gICAgLy8gdG8gZGVzdHJveSBpdC4KLQotICAgIGlmIChwYWdlLT5kLT5jbGllbnQg JiYgcGFnZS0+ZC0+Y2xpZW50LT5pc1FXaWRnZXRDbGllbnQoKSkKKyAgICAvLyBUaGUgY2xpZW50 IGhhcyBhbHdheXMgdG8gYmUgZGVsZXRlZC4KKyAgICBpZiAocGFnZS0+ZC0+Y2xpZW50KQogICAg ICAgICBkZWxldGUgcGFnZS0+ZC0+Y2xpZW50OwogCiAgICAgcGFnZS0+ZC0+Y2xpZW50ID0gMDsK IAogICAgIC8vIGlmIHRoZSBwYWdlIHdhcyBjcmVhdGVkIGJ5IHVzLCB3ZSBvd24gaXQgYW5kIG5l ZWQgdG8KICAgICAvLyBkZXN0cm95IGl0IGFzIHdlbGwuCiAKICAgICBpZiAocGFnZS0+cGFyZW50 KCkgPT0gcSkKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hh bmdlTG9nCmluZGV4IGU4NjdlOGQuLjFmZTlmNTggMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSw4ICsxLDIxIEBACisyMDEwLTA1 LTEyICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBSZW1vdmUgdGhlIHVubmVl ZGVkIGNoZWNrIGZvciBRV2lkZ2V0UGFnZUNsaWVudCBAUUdyYXBoaWNzV2ViVmlldzo6ZGV0YWNo UGFnZQorCisgICAgICAgIFJlYXNvbnM6CisgICAgICAgIC0gVGhlcmUgaXMgbm8gbmVlZCB0byBj aGVjayBmb3IgYSBRV2lkZ2V0UGFnZUNsaWVudC1iYXNlZCBpbiBRR3JhcGhpY3NXZWJWaWV3Lgor ICAgICAgICAtIFRoZSBjbGllbnQgaGFzIGFsd2F5cyB0byBiZSBkZWxldGVkIGFueXdheXMuCisK KyAgICAgICAgKiBBcGkvcWdyYXBoaWNzd2Vidmlldy5jcHA6CisgICAgICAgIChRR3JhcGhpY3NX ZWJWaWV3UHJpdmF0ZTo6ZGV0YWNoUGFnZSk6CisKIDIwMTAtMDUtMTEgIEFudG9uaW8gR29tZXMg IDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KIAogICAgICAgICBbUXRdIEltcGxlbWVudCBhIGRldGFjaFBhZ2UgbWV0aG9kIGZvciBR R3JhcGhpY3NXZWJWaWV3IGFuZCBRV2ViVmlldwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg5MzkKIAogICAgICAgICB1bnNldFBhZ2VJZkV4aXN0cyBt ZXRob2Qgd2FzIHJlbmFtZWQgdG8gZGV0YWNoUGFnZSBtZXRob2QgYW5kIGlzIG5vdyByZXNwb25z aWJsZQotLSAKMS42LjMuMwoK 55843 2010-05-12 07:21:26 -0700 2010-05-12 07:34:13 -0700 patch v2 0001-2010-05-12-Antonio-Gomes-tonikitoo-webkit.org.patch text/plain 2673 tonikitoo RnJvbSA3N2M0NWUyMjgwZWFkMDc0NmM5YmJkYWJlYWYxMThkNzViNGU4ZmZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogV2VkLCAxMiBNYXkgMjAxMCAwOTo0NTowNCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIw MTAtMDUtMTIgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KCiAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtRdF0gUmVtb3ZlIHRoZSB1bm5l ZWRlZCBjaGVjayBmb3IgUVdpZGdldFBhZ2VDbGllbnQgQFFHcmFwaGljc1dlYlZpZXc6OmRldGFj aFBhZ2UKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg5 ODkKCiAgICAgICAgUmVhc29uczoKICAgICAgICAtIFRoZXJlIGlzIG5vIG5lZWQgdG8gY2hlY2sg Zm9yIGEgUVdpZGdldFBhZ2VDbGllbnQtYmFzZWQgaW4gUUdyYXBoaWNzV2ViVmlldy4KICAgICAg ICAtIFRoZSBjbGllbnQgaGFzIGFsd2F5cyB0byBiZSBkZWxldGVkIGFueXdheXMuCgogICAgICAg ICogQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwOgogICAgICAgIChRR3JhcGhpY3NXZWJWaWV3UHJp dmF0ZTo6ZGV0YWNoUGFnZSk6Ci0tLQogV2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmNw cCB8ICAgIDkgKystLS0tLS0tCiBXZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwg ICAxNCArKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCA3 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmll dy5jcHAgYi9XZWJLaXQvcXQvQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwCmluZGV4IGY4NTU4ODIu LjA3N2VhNTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAK KysrIGIvV2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcApAQCAtNDQxLDIzICs0NDEs MTggQEAgdm9pZCBRR3JhcGhpY3NXZWJWaWV3UHJpdmF0ZTo6ZGV0YWNoUGFnZSgpCiAgICAgICAg IHJldHVybjsKIAogI2lmIFFUX1ZFUlNJT04gPj0gMHgwNDA2MDAKICAgICBwYWdlLT5kLT52aWV3 LmNsZWFyKCk7CiAjZWxzZQogICAgIHBhZ2UtPmQtPnZpZXcgPSAwOwogI2VuZGlmCiAKLSAgICAv LyBpZiB0aGUgcGFnZSBjbGllbnQgaXMgdGhlIHNwZWNpYWwgY2xpZW50IGNvbnN0cnVjdGVkIGZv cgotICAgIC8vIGRlbGVnYXRpbmcgdGhlIHJlc3BvbnNpYmlsaXRpZXMgdG8gYSBRV2lkZ2V0LCB3 ZSBuZWVkCi0gICAgLy8gdG8gZGVzdHJveSBpdC4KLQotICAgIGlmIChwYWdlLT5kLT5jbGllbnQg JiYgcGFnZS0+ZC0+Y2xpZW50LT5pc1FXaWRnZXRDbGllbnQoKSkKLSAgICAgICAgZGVsZXRlIHBh Z2UtPmQtPmNsaWVudDsKLQorICAgIC8vIFRoZSBjbGllbnQgaGFzIGFsd2F5cyB0byBiZSBkZWxl dGVkLgorICAgIGRlbGV0ZSBwYWdlLT5kLT5jbGllbnQ7CiAgICAgcGFnZS0+ZC0+Y2xpZW50ID0g MDsKIAogICAgIC8vIGlmIHRoZSBwYWdlIHdhcyBjcmVhdGVkIGJ5IHVzLCB3ZSBvd24gaXQgYW5k IG5lZWQgdG8KICAgICAvLyBkZXN0cm95IGl0IGFzIHdlbGwuCiAKICAgICBpZiAocGFnZS0+cGFy ZW50KCkgPT0gcSkKICAgICAgICAgZGVsZXRlIHBhZ2U7CiAgICAgZWxzZQpkaWZmIC0tZ2l0IGEv V2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggZTg2N2U4ZC4u ZTg4MDRkZSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQv Q2hhbmdlTG9nCkBAIC0xLDggKzEsMjIgQEAKKzIwMTAtMDUtMTIgIEFudG9uaW8gR29tZXMgIDx0 b25pa2l0b29Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbUXRdIFJlbW92ZSB0aGUgdW5uZWVkZWQgY2hlY2sgZm9yIFFXaWRnZXRQ YWdlQ2xpZW50IEBRR3JhcGhpY3NXZWJWaWV3OjpkZXRhY2hQYWdlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODk4OQorCisgICAgICAgIFJlYXNvbnM6 CisgICAgICAgIC0gVGhlcmUgaXMgbm8gbmVlZCB0byBjaGVjayBmb3IgYSBRV2lkZ2V0UGFnZUNs aWVudC1iYXNlZCBpbiBRR3JhcGhpY3NXZWJWaWV3LgorICAgICAgICAtIFRoZSBjbGllbnQgaGFz IGFsd2F5cyB0byBiZSBkZWxldGVkIGFueXdheXMuCisKKyAgICAgICAgKiBBcGkvcWdyYXBoaWNz d2Vidmlldy5jcHA6CisgICAgICAgIChRR3JhcGhpY3NXZWJWaWV3UHJpdmF0ZTo6ZGV0YWNoUGFn ZSk6CisKIDIwMTAtMDUtMTEgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAogICAgICAgICBbUXRdIElt cGxlbWVudCBhIGRldGFjaFBhZ2UgbWV0aG9kIGZvciBRR3JhcGhpY3NXZWJWaWV3IGFuZCBRV2Vi VmlldwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg5 MzkKIAogICAgICAgICB1bnNldFBhZ2VJZkV4aXN0cyBtZXRob2Qgd2FzIHJlbmFtZWQgdG8gZGV0 YWNoUGFnZSBtZXRob2QgYW5kIGlzIG5vdyByZXNwb25zaWJsZQotLSAKMS42LjMuMwoK