38980 2010-05-12 02:40:36 -0700 [Qt] Slave losts cause build break on bots. 2012-06-12 04:55:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 38969 1 ossy ossy eric hausmann ossy oldest_to_newest 224488 0 ossy 2010-05-12 02:40:36 -0700 When slave lost (internet connection lost) occured, the buildbot slave executes a kill -9 command to kill the build process. It cause some 0 byte sized files is build directory which won't be recompiled at next build, and we will get link error. Only removing 0 byte sized files solve the problem. 224490 1 55821 ossy 2010-05-12 02:43:06 -0700 Created attachment 55821 proposed fix 224509 2 55827 ossy 2010-05-12 03:46:18 -0700 Created attachment 55827 proposed fix Xan noticed me that GTK build has 0 byte sized .dirstamp files in builddir shouldn't be deleted before all build. I modified my patch not to remove any hidden files. I hope other ports don't have necessary 0 byte sized files. :) 224653 3 55827 eric 2010-05-12 08:49:22 -0700 Comment on attachment 55827 proposed fix It should print out status to the user and explain what it's doing. I think this code should only run on Gtk for now. 224654 4 eric 2010-05-12 08:49:34 -0700 Only run on Qt, rather. 224730 5 55871 ossy 2010-05-12 11:03:10 -0700 Created attachment 55871 proposed fix I think this cleanup before build might be useful for other ports too, but I put it into an isQt() block. In the future anybody can enable it for other ports. And now the script dumps which files was removed to stdout. 224846 6 ossy 2010-05-12 13:33:53 -0700 Landed manually: http://trac.webkit.org/changeset/59261 224849 7 55871 eric 2010-05-12 13:36:26 -0700 Comment on attachment 55871 proposed fix I'm not sure thsi really belongs as part of webkit-build, but rather in teh Qt builder config. But this is OK for now. 646802 8 ossy 2012-06-12 04:20:24 -0700 Reopen to attach a minor fix. 646803 9 147051 ossy 2012-06-12 04:21:37 -0700 Created attachment 147051 Patch minor fix 646833 10 147051 ossy 2012-06-12 04:54:51 -0700 Comment on attachment 147051 Patch Landed in http://trac.webkit.org/changeset/120060 55821 2010-05-12 02:43:06 -0700 2010-05-12 03:46:18 -0700 proposed fix 1.patch text/plain 1223 ossy ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0ZTQ4YjM2Li5jM2E2ZDI3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDUt MTIgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFNsYXZlIGxvc3RzIGNhdXNl IGJ1aWxkIGJyZWFrIG9uIGJvdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM4OTgwCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDogUmVt b3ZlIDAgYnl0ZSBzaXplZCBmaWxlcyBmcm9tIHByb2R1Y3REaXIgYmVmb3JlIGJ1aWxkLgorCiAy MDEwLTA1LTA5ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAcmltLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBDaHJpcyBKZXJkb25lay4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMv YnVpbGQtd2Via2l0IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggM2Ez ZWRiOS4uZDRiMzgzMCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJr aXQKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKQEAgLTMxLDYgKzMxLDcg QEAKIAogdXNlIHN0cmljdDsKIHVzZSBGaWxlOjpCYXNlbmFtZTsKK3VzZSBGaWxlOjpGaW5kOwog dXNlIEZpbGU6OlNwZWM7CiB1c2UgRmluZEJpbjsKIHVzZSBHZXRvcHQ6OkxvbmcgcXcoOmNvbmZp ZyBwYXNzX3Rocm91Z2gpOwpAQCAtMjU3LDYgKzI1OCw5IEBAIHNldENvbmZpZ3VyYXRpb24oKTsK IAogbXkgJHByb2R1Y3REaXIgPSBwcm9kdWN0RGlyKCk7CiAKKyMgUmVtb3ZlIDAgYnl0ZSBzaXpl ZCBmaWxlcyBmcm9tIHByb2R1Y3REaXIgYWZ0ZXIgc2xhdmUgbG9zdAorRmlsZTo6RmluZDo6Zmlu ZChzdWIgeyBpZiAoISAtcyAkRmlsZTo6RmluZDo6bmFtZSkgeyB1bmxpbmsoJEZpbGU6OkZpbmQ6 Om5hbWUpIH0gfSwgJHByb2R1Y3REaXIpOworCiAjIENoZWNrIHRoYXQgYWxsIHRoZSBwcm9qZWN0 IGRpcmVjdG9yaWVzIGFyZSB0aGVyZS4KIG15IEBwcm9qZWN0cyA9ICgiSmF2YVNjcmlwdENvcmUi LCAiV2ViQ29yZSIsICJXZWJLaXQiKTsKIAo= 55827 2010-05-12 03:46:18 -0700 2010-05-12 11:03:10 -0700 proposed fix 1.patch text/plain 1318 ossy ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0ZTQ4YjM2Li5jM2E2ZDI3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDUt MTIgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFNsYXZlIGxvc3RzIGNhdXNl IGJ1aWxkIGJyZWFrIG9uIGJvdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM4OTgwCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDogUmVt b3ZlIDAgYnl0ZSBzaXplZCBmaWxlcyBmcm9tIHByb2R1Y3REaXIgYmVmb3JlIGJ1aWxkLgorCiAy MDEwLTA1LTA5ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAcmltLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBDaHJpcyBKZXJkb25lay4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMv YnVpbGQtd2Via2l0IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggM2Ez ZWRiOS4uYzBhNWEzNCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJr aXQKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKQEAgLTMxLDYgKzMxLDcg QEAKIAogdXNlIHN0cmljdDsKIHVzZSBGaWxlOjpCYXNlbmFtZTsKK3VzZSBGaWxlOjpGaW5kOwog dXNlIEZpbGU6OlNwZWM7CiB1c2UgRmluZEJpbjsKIHVzZSBHZXRvcHQ6OkxvbmcgcXcoOmNvbmZp ZyBwYXNzX3Rocm91Z2gpOwpAQCAtMjU3LDYgKzI1OCwxNSBAQCBzZXRDb25maWd1cmF0aW9uKCk7 CiAKIG15ICRwcm9kdWN0RGlyID0gcHJvZHVjdERpcigpOwogCisjIFJlbW92ZSAwIGJ5dGUgc2l6 ZWQgbm90LWhpZGRlbiBmaWxlcyBmcm9tIHByb2R1Y3REaXIgYWZ0ZXIgc2xhdmUgbG9zdAorRmls ZTo6RmluZDo6ZmluZChcJnVubGlua1plcm9GaWxlcywgJHByb2R1Y3REaXIpOworCitzdWIgdW5s aW5rWmVyb0ZpbGVzICgpCit7CisgICAgbXkgJGZpbGUgPSAkRmlsZTo6RmluZDo6bmFtZTsKKyAg ICB1bmxpbmsgJGZpbGUgaWYgKCEoYmFzZW5hbWUoJGZpbGUpPX4vXlwuLykgJiYgISAtcyAkZmls ZSk7Cit9CisKICMgQ2hlY2sgdGhhdCBhbGwgdGhlIHByb2plY3QgZGlyZWN0b3JpZXMgYXJlIHRo ZXJlLgogbXkgQHByb2plY3RzID0gKCJKYXZhU2NyaXB0Q29yZSIsICJXZWJDb3JlIiwgIldlYktp dCIpOwogCg== 55871 2010-05-12 11:03:10 -0700 2012-06-12 04:20:56 -0700 proposed fix 1.patch text/plain 1398 ossy ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0ZTQ4YjM2Li5jM2E2ZDI3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDUt MTIgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFNsYXZlIGxvc3RzIGNhdXNl IGJ1aWxkIGJyZWFrIG9uIGJvdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM4OTgwCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDogUmVt b3ZlIDAgYnl0ZSBzaXplZCBmaWxlcyBmcm9tIHByb2R1Y3REaXIgYmVmb3JlIGJ1aWxkLgorCiAy MDEwLTA1LTA5ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAcmltLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBDaHJpcyBKZXJkb25lay4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMv YnVpbGQtd2Via2l0IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggM2Ez ZWRiOS4uNTVkYmU0ZiAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJr aXQKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKQEAgLTMxLDYgKzMxLDcg QEAKIAogdXNlIHN0cmljdDsKIHVzZSBGaWxlOjpCYXNlbmFtZTsKK3VzZSBGaWxlOjpGaW5kOwog dXNlIEZpbGU6OlNwZWM7CiB1c2UgRmluZEJpbjsKIHVzZSBHZXRvcHQ6OkxvbmcgcXcoOmNvbmZp ZyBwYXNzX3Rocm91Z2gpOwpAQCAtMjU3LDYgKzI1OCwxOCBAQCBzZXRDb25maWd1cmF0aW9uKCk7 CiAKIG15ICRwcm9kdWN0RGlyID0gcHJvZHVjdERpcigpOwogCisjIFJlbW92ZSAwIGJ5dGUgc2l6 ZWQgZmlsZXMgZnJvbSBwcm9kdWN0RGlyIGFmdGVyIHNsYXZlIGxvc3QgZm9yIFF0IGJ1aWxkYm90 cy4KK0ZpbGU6OkZpbmQ6OmZpbmQoXCZ1bmxpbmtaZXJvRmlsZXMsICRwcm9kdWN0RGlyKSBpZiBp c1F0KCk7CisKK3N1YiB1bmxpbmtaZXJvRmlsZXMgKCkKK3sKKyAgICBteSAkZmlsZSA9ICRGaWxl OjpGaW5kOjpuYW1lOworICAgIGlmICghIC1zICRmaWxlKSB7CisgICAgICAgIHVubGluayAkZmls ZTsKKyAgICAgICAgcHJpbnQgIjAgYnl0ZSBzaXplZCBmaWxlIHJlbW92ZWQgZnJvbSBidWlsZCBk aXJlY3Rvcnk6ICRmaWxlXG4iOworICAgIH0KK30KKwogIyBDaGVjayB0aGF0IGFsbCB0aGUgcHJv amVjdCBkaXJlY3RvcmllcyBhcmUgdGhlcmUuCiBteSBAcHJvamVjdHMgPSAoIkphdmFTY3JpcHRD b3JlIiwgIldlYkNvcmUiLCAiV2ViS2l0Iik7CiAK 147051 2012-06-12 04:21:37 -0700 2012-06-12 04:54:50 -0700 Patch bug-38980-20120612042136.patch text/plain 1587 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODEwNjVmZjEyYzk3N2I0YTZjY2YxMGUyNWQyNjI2NWMz Y2U2MzI4ZC4uYjEyMzgxMDlhMTcyMzE0ODlhZWQ2OTgyMjBmMmQ1NDEwOGZhZTFhYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA2LTEyICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1F0XSBTbGF2ZSBsb3N0cyBjYXVzZSBidWlsZCBicmVhayBvbiBib3RzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODk4MAorCisgICAg ICAgIE1pbm9yIGZpeCBhZnRlciByNTkyNjEuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKyAgICAgICAgKHVu bGlua1plcm9GaWxlcyk6IERvbid0IHJlbW92ZSAwIGJ5dGUgc2l6ZWQgZGlyZWN0b3JpZXMsIGJl Y2F1c2UgdGhleSBhcmUgYWx3YXlzIDAgYnl0ZSBzaXplZCBvbiBXaW5kb3dzLgorCiAyMDEyLTA2 LTExICBLYXVzdHViaCBBdHJhd2Fsa2FyICA8a2F1c3R1YmhAbW90b3JvbGEuY29tPgogCiAgICAg ICAgIFtEUlRdIExUQzo6IGNvdW50ZXJWYWx1ZUZvckVsZW1lbnRCeUlkKCkgY291bGQgYmUgbW92 ZWQgdG8gSW50ZXJuYWxzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQg Yi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAppbmRleCA0YmUyZDRiMTA3ZDRjYWMxM2RhNzg3 MWQ2NTk0NjFjYzAyYzQyYWRmLi44YWRlNDA4OTA4MWQ4MzM3NmIxNzczNDk5NzQ3YWI5YjU1OTBk YTkwIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAorKysgYi9Ub29scy9T Y3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtMTgzLDggKzE4MywxMCBAQCBGaWxlOjpGaW5kOjpmaW5k KFwmdW5saW5rWmVyb0ZpbGVzLCAkcHJvZHVjdERpcikgaWYgKGlzUXQoKSAmJiAtZSAkcHJvZHVj dERpcik7CiBzdWIgdW5saW5rWmVyb0ZpbGVzKCkKIHsKICAgICBteSAkZmlsZSA9ICRGaWxlOjpG aW5kOjpuYW1lOwotICAgICMgUmVtb3ZlIDAgc2l6ZSBmaWxlcywgZXhjZXB0IC5kIGZpbGVzIHVz ZWQgZm9yIGRlcGVuZGVuY3kgdHJhY2tpbmcKLSAgICBpZiAoISAtcyAkZmlsZSAmJiAkZmlsZSAh fiBtL1wuZCQvKSB7CisgICAgIyBSZW1vdmUgMCBieXRlIHNpemVkIGZpbGVzLCBleGNlcHQKKyAg ICAjIC0gZGlyZWN0b3JpZXMgKEJlY2F1c2UgdGhleSBhcmUgYWx3YXlzIDAgYnl0ZSBzaXplZCBv biBXaW5kb3dzKQorICAgICMgLSAuZCBmaWxlcyB1c2VkIGZvciBkZXBlbmRlbmN5IHRyYWNraW5n CisgICAgaWYgKCEgLWQgJGZpbGUgJiYgISAtcyAkZmlsZSAmJiAkZmlsZSAhfiBtL1wuZCQvKSB7 CiAgICAgICAgIHVubGluayAkZmlsZTsKICAgICAgICAgcHJpbnQgIjAgYnl0ZSBzaXplZCBmaWxl IHJlbW92ZWQgZnJvbSBidWlsZCBkaXJlY3Rvcnk6ICRmaWxlXG4iOwogICAgIH0K