38961 2010-05-11 17:49:03 -0700 Move some member variables around to reduce class sizes. 2010-05-12 21:00:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 andersca webkit-unassigned levin oldest_to_newest 224299 0 andersca 2010-05-11 17:49:03 -0700 Move some member variables around to reduce class sizes. 224300 1 55787 andersca 2010-05-11 17:51:24 -0700 Created attachment 55787 Patch 224311 2 55787 mrowe 2010-05-11 18:10:44 -0700 Comment on attachment 55787 Patch Do we need comments in any of these places to warn people against moving these members back again? r=me 224314 3 levin 2010-05-11 18:15:40 -0700 (In reply to comment #2) > (From update of attachment 55787 [details]) > Do we need comments in any of these places to warn people against moving these members back again? > > r=me The AtomicString change seems the most likely to be undone by accident as this change will break what http://trac.webkit.org/changeset/56100 tried to accomplish. 224317 4 andersca 2010-05-11 18:28:16 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 55787 [details] [details]) > > Do we need comments in any of these places to warn people against moving these members back again? > > > > r=me > > The AtomicString change seems the most likely to be undone by accident as this change will break what http://trac.webkit.org/changeset/56100 tried to accomplish. We could add a compile time assert that sizeof(AtomicString) == sizeof(String). 224340 5 andersca 2010-05-11 19:28:39 -0700 Committed r59197: <http://trac.webkit.org/changeset/59197> 224363 6 ap 2010-05-11 20:26:58 -0700 > We could add a compile time assert that sizeof(AtomicString) == sizeof(String). Anders added it in <http://trac.webkit.org/changeset/59198>. 225086 7 ddkilzer 2010-05-12 21:00:38 -0700 <rdar://problem/7978054> 55787 2010-05-11 17:51:24 -0700 2010-05-11 18:10:44 -0700 Patch bug-38961-20100511175123.patch text/plain 6652 andersca SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5MTg5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDUtMTEgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mzg5NjEKKyAgICAgICAgTW92ZSBzb21lIG1lbWJlciB2YXJpYWJsZXMgYXJvdW5kIHRv IHJlZHVjZSBjbGFzcyBzaXplcy4KKyAgICAgICAgCisgICAgICAgIE1ha2UgQXRvbWljU3RyaW5n IG5vIGxvbmdlciBpbmhlcml0IGZyb20gRmFzdEFsbG9jQmFzZS4KKworICAgICAgICBTaW5jZSBB dG9taWNTdHJpbmcncyBmaXJzdCAoYW5kIG9ubHkpIG1lbWJlciB2YXJpYWJsZSwgYSBSZWZQdHIs IGFsc28gaW5oZXJpdHMgZnJvbSBGYXN0QWxsb2NCYXNlIHRoaXMKKyAgICAgICAgd2FzIGNhdXNp bmcgdGhlIHNpemUgb2YgQXRvbWljU3RyaW5nIHRvIGNvbnRhaW4gc2l6ZW9mKHZvaWQqKSBieXRl cyBvZiBwYWRkaW5nLgorCisgICAgICAgICogd3RmL3RleHQvQXRvbWljU3RyaW5nLmg6CisKIDIw MTAtMDUtMTEgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFN0ZXZlIEZhbGtlbmJ1cmcgYW5kIEpvbiBIb25leWN1dHQuCkluZGV4 OiBKYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9BdG9taWNTdHJpbmcuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS93dGYvdGV4dC9BdG9taWNTdHJpbmcuaAkocmV2aXNpb24gNTkxNTYpCisr KyBKYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9BdG9taWNTdHJpbmcuaAkod29ya2luZyBjb3B5KQpA QCAtMzgsNyArMzgsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHN0cnVjdCBBdG9taWNTdHJp bmdIYXNoOwogCi1jbGFzcyBBdG9taWNTdHJpbmcgOiBwdWJsaWMgRmFzdEFsbG9jQmFzZSB7Citj bGFzcyBBdG9taWNTdHJpbmcgewogcHVibGljOgogICAgIHN0YXRpYyB2b2lkIGluaXQoKTsKIApJ bmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJ KHJldmlzaW9uIDU5MTkwKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwyMSBAQAorMjAxMC0wNS0xMSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODk2MQorICAgICAgICBN b3ZlIHNvbWUgbWVtYmVyIHZhcmlhYmxlcyBhcm91bmQgdG8gcmVkdWNlIGNsYXNzIHNpemVzLgor CisgICAgICAgIElmIGEgY2xhc3MgaW5oZXJpdHMgKGRpcmVjdGx5IG9yIGluZGlyZWN0bHkpIGZy b20gRmFzdEFsbG9jQmFzZSwgd2UgZG9uJ3Qgd2FudCB0aGUgZmlyc3QgbWVtYmVyIHZhcmlhYmxl CisgICAgICAgIG9mIHRoYXQgY2xhc3MgdG8gYWxzbyBpbmhlcml0IChkaXJlY3RseSBvciBpbmRp cmVjdGx5KSBmcm9tIEZhc3RBbGxvY0Jhc2UgYXMgdGhpcyB3aWxsIGFkZCBwYWRkaW5nIHRvIHRo ZSBjbGFzcworICAgICAgICBhbmQgdGh1cyBpbmNyZWFzaW5nIGl0cyBzaXplLgorCisgICAgICAg ICogY3NzL0NTU1BhcnNlclZhbHVlcy5oOgorICAgICAgICAqIGNzcy9DU1NTZWxlY3Rvci5oOgor ICAgICAgICAoV2ViQ29yZTo6Q1NTU2VsZWN0b3I6OkNTU1NlbGVjdG9yKToKKyAgICAgICAgKFdl YkNvcmU6OkNTU1NlbGVjdG9yOjpSYXJlRGF0YTo6UmFyZURhdGEpOgorICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL0ZvbnRDYWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250UGxhdGZv cm1EYXRhQ2FjaGVLZXk6OkZvbnRQbGF0Zm9ybURhdGFDYWNoZUtleSk6CisKIDIwMTAtMDUtMTEg IEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgRGFyaW4gQWRsZXIu CkluZGV4OiBXZWJDb3JlL2Nzcy9DU1NQYXJzZXJWYWx1ZXMuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2Nzcy9DU1NQYXJzZXJWYWx1ZXMuaAkocmV2aXNpb24gNTkxNTkpCisrKyBXZWJDb3JlL2Nz cy9DU1NQYXJzZXJWYWx1ZXMuaAkod29ya2luZyBjb3B5KQpAQCAtODMsOSArODMsOSBAQCBwdWJs aWM6CiAgICAgYm9vbCBjb250YWluc1ZhcmlhYmxlcygpIGNvbnN0IHsgcmV0dXJuIG1fdmFyaWFi bGVzQ291bnQ7IH0KIAogcHJpdmF0ZToKLSAgICBWZWN0b3I8Q1NTUGFyc2VyVmFsdWUsIDQ+IG1f dmFsdWVzOwogICAgIHVuc2lnbmVkIG1fY3VycmVudDsKICAgICB1bnNpZ25lZCBtX3ZhcmlhYmxl c0NvdW50OworICAgIFZlY3RvcjxDU1NQYXJzZXJWYWx1ZSwgND4gbV92YWx1ZXM7CiB9OwogCiBz dHJ1Y3QgQ1NTUGFyc2VyRnVuY3Rpb24gOiBGYXN0QWxsb2NCYXNlIHsKSW5kZXg6IFdlYkNvcmUv Y3NzL0NTU1NlbGVjdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3Iu aAkocmV2aXNpb24gNTkxNTkpCisrKyBXZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5oCSh3b3JraW5n IGNvcHkpCkBAIC0zMywyNCArMzMsMjQgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIGNsYXNz IENTU1NlbGVjdG9yIDogcHVibGljIE5vbmNvcHlhYmxlIHsKICAgICBwdWJsaWM6CiAgICAgICAg IENTU1NlbGVjdG9yKCkKLSAgICAgICAgICAgIDogbV90YWcoYW55UU5hbWUoKSkKLSAgICAgICAg ICAgICwgbV9yZWxhdGlvbihEZXNjZW5kYW50KQorICAgICAgICAgICAgOiBtX3JlbGF0aW9uKERl c2NlbmRhbnQpCiAgICAgICAgICAgICAsIG1fbWF0Y2goTm9uZSkKICAgICAgICAgICAgICwgbV9w c2V1ZG9UeXBlKFBzZXVkb05vdFBhcnNlZCkKICAgICAgICAgICAgICwgbV9wYXJzZWROdGgoZmFs c2UpCiAgICAgICAgICAgICAsIG1faXNMYXN0SW5TZWxlY3Rvckxpc3QoZmFsc2UpCiAgICAgICAg ICAgICAsIG1faGFzUmFyZURhdGEoZmFsc2UpCisgICAgICAgICAgICAsIG1fdGFnKGFueVFOYW1l KCkpCiAgICAgICAgIHsKICAgICAgICAgfQogCiAgICAgICAgIENTU1NlbGVjdG9yKGNvbnN0IFF1 YWxpZmllZE5hbWUmIHFOYW1lKQotICAgICAgICAgICAgOiBtX3RhZyhxTmFtZSkKLSAgICAgICAg ICAgICwgbV9yZWxhdGlvbihEZXNjZW5kYW50KQorICAgICAgICAgICAgOiBtX3JlbGF0aW9uKERl c2NlbmRhbnQpCiAgICAgICAgICAgICAsIG1fbWF0Y2goTm9uZSkKICAgICAgICAgICAgICwgbV9w c2V1ZG9UeXBlKFBzZXVkb05vdFBhcnNlZCkKICAgICAgICAgICAgICwgbV9wYXJzZWROdGgoZmFs c2UpCiAgICAgICAgICAgICAsIG1faXNMYXN0SW5TZWxlY3Rvckxpc3QoZmFsc2UpCiAgICAgICAg ICAgICAsIG1faGFzUmFyZURhdGEoZmFsc2UpCisgICAgICAgICAgICAsIG1fdGFnKHFOYW1lKQog ICAgICAgICB7CiAgICAgICAgIH0KIApAQCAtMjUyLDkgKzI1Miw2IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKICAgICAgICAgdm9pZCBzZXRMYXN0SW5TZWxlY3Rvckxpc3QoKSB7IG1faXNMYXN0SW5T ZWxlY3Rvckxpc3QgPSB0cnVlOyB9CiAgICAgICAgIGJvb2wgaXNTaW1wbGUoKSBjb25zdDsKIAot ICAgICAgICBtdXRhYmxlIEF0b21pY1N0cmluZyBtX3ZhbHVlOwotICAgICAgICBRdWFsaWZpZWRO YW1lIG1fdGFnOwotCiAgICAgICAgIHVuc2lnbmVkIG1fcmVsYXRpb24gICAgICAgICAgIDogMzsg Ly8gZW51bSBSZWxhdGlvbgogICAgICAgICBtdXRhYmxlIHVuc2lnbmVkIG1fbWF0Y2ggICAgICA6 IDQ7IC8vIGVudW0gTWF0Y2gKICAgICAgICAgbXV0YWJsZSB1bnNpZ25lZCBtX3BzZXVkb1R5cGUg OiA4OyAvLyBQc2V1ZG9UeXBlCkBAIC0yNjgsMjQgKzI2NSwyNCBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKICAgICAgICAgc3RydWN0IFJhcmVEYXRhIDogTm9uY29weWFibGUgewogICAgICAgICAg ICAgUmFyZURhdGEoQ1NTU2VsZWN0b3IqIHRhZ0hpc3RvcnkpCi0gICAgICAgICAgICAgICAgOiBt X3RhZ0hpc3RvcnkodGFnSGlzdG9yeSkKKyAgICAgICAgICAgICAgICA6IG1fYSgwKQorICAgICAg ICAgICAgICAgICwgbV9iKDApCisgICAgICAgICAgICAgICAgLCBtX3RhZ0hpc3RvcnkodGFnSGlz dG9yeSkKICAgICAgICAgICAgICAgICAsIG1fc2ltcGxlU2VsZWN0b3IoMCkKICAgICAgICAgICAg ICAgICAsIG1fYXR0cmlidXRlKGFueVFOYW1lKCkpCiAgICAgICAgICAgICAgICAgLCBtX2FyZ3Vt ZW50KG51bGxBdG9tKQotICAgICAgICAgICAgICAgICwgbV9hKDApCi0gICAgICAgICAgICAgICAg LCBtX2IoMCkKICAgICAgICAgICAgIHsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgYm9v bCBwYXJzZU50aCgpOwogICAgICAgICAgICAgYm9vbCBtYXRjaE50aChpbnQgY291bnQpOwogCisg ICAgICAgICAgICBpbnQgbV9hOyAvLyBVc2VkIGZvciA6bnRoLSoKKyAgICAgICAgICAgIGludCBt X2I7IC8vIFVzZWQgZm9yIDpudGgtKgogICAgICAgICAgICAgT3duUHRyPENTU1NlbGVjdG9yPiBt X3RhZ0hpc3Rvcnk7CiAgICAgICAgICAgICBPd25QdHI8Q1NTU2VsZWN0b3I+IG1fc2ltcGxlU2Vs ZWN0b3I7IC8vIFVzZWQgZm9yIDpub3QuCiAgICAgICAgICAgICBRdWFsaWZpZWROYW1lIG1fYXR0 cmlidXRlOyAvLyB1c2VkIGZvciBhdHRyaWJ1dGUgc2VsZWN0b3IKICAgICAgICAgICAgIEF0b21p Y1N0cmluZyBtX2FyZ3VtZW50OyAvLyBVc2VkIGZvciA6Y29udGFpbnMsIDpsYW5nIGFuZCA6bnRo LSoKLSAgICAgICAgICAgIGludCBtX2E7IC8vIFVzZWQgZm9yIDpudGgtKgotICAgICAgICAgICAg aW50IG1fYjsgLy8gVXNlZCBmb3IgOm50aC0qCiAgICAgICAgIH07CiAKICAgICAgICAgdm9pZCBj cmVhdGVSYXJlRGF0YSgpCkBAIC0zMDEsNiArMjk4LDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICAgICAgICAgICAgIENTU1NlbGVjdG9yKiBtX3RhZ0hpc3Rvcnk7CiAgICAgICAgICAgICBSYXJl RGF0YSogbV9yYXJlRGF0YTsKICAgICAgICAgfSBtX2RhdGE7CisgICAgICAgIAorICAgIHB1Ymxp YzoKKyAgICAgICAgbXV0YWJsZSBBdG9taWNTdHJpbmcgbV92YWx1ZTsKKyAgICAgICAgUXVhbGlm aWVkTmFtZSBtX3RhZzsKICAgICB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBX ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYWNoZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuY3BwCShyZXZpc2lvbiA1OTE1OSkKKysr IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNTYsOSArNTYsOSBAQCBGb250Q2FjaGU6OkZvbnRDYWNoZSgpCiBzdHJ1Y3QgRm9udFBsYXRm b3JtRGF0YUNhY2hlS2V5IDogRmFzdEFsbG9jQmFzZSB7CiAgICAgRm9udFBsYXRmb3JtRGF0YUNh Y2hlS2V5KGNvbnN0IEF0b21pY1N0cmluZyYgZmFtaWx5ID0gQXRvbWljU3RyaW5nKCksIHVuc2ln bmVkIHNpemUgPSAwLCB1bnNpZ25lZCB3ZWlnaHQgPSAwLCBib29sIGl0YWxpYyA9IGZhbHNlLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIGlzUHJpbnRlckZvbnQgPSBmYWxzZSwg Rm9udFJlbmRlcmluZ01vZGUgcmVuZGVyaW5nTW9kZSA9IE5vcm1hbFJlbmRlcmluZ01vZGUpCi0g ICAgICAgIDogbV9mYW1pbHkoZmFtaWx5KQotICAgICAgICAsIG1fc2l6ZShzaXplKQorICAgICAg ICA6IG1fc2l6ZShzaXplKQogICAgICAgICAsIG1fd2VpZ2h0KHdlaWdodCkKKyAgICAgICAgLCBt X2ZhbWlseShmYW1pbHkpCiAgICAgICAgICwgbV9pdGFsaWMoaXRhbGljKQogICAgICAgICAsIG1f cHJpbnRlckZvbnQoaXNQcmludGVyRm9udCkKICAgICAgICAgLCBtX3JlbmRlcmluZ01vZGUocmVu ZGVyaW5nTW9kZSkKQEAgLTc1LDkgKzc1LDkgQEAgc3RydWN0IEZvbnRQbGF0Zm9ybURhdGFDYWNo ZUtleSA6IEZhc3RBbAogICAgICAgICAgICAgICAgbV9yZW5kZXJpbmdNb2RlID09IG90aGVyLm1f cmVuZGVyaW5nTW9kZTsKICAgICB9CiAKLSAgICBBdG9taWNTdHJpbmcgbV9mYW1pbHk7CiAgICAg dW5zaWduZWQgbV9zaXplOwogICAgIHVuc2lnbmVkIG1fd2VpZ2h0OworICAgIEF0b21pY1N0cmlu ZyBtX2ZhbWlseTsKICAgICBib29sIG1faXRhbGljOwogICAgIGJvb2wgbV9wcmludGVyRm9udDsK ICAgICBGb250UmVuZGVyaW5nTW9kZSBtX3JlbmRlcmluZ01vZGU7Cg==