38958 2010-05-11 17:39:57 -0700 Web Inspector: Shorthand Properties Getting Deleted When Editing 2010-05-11 22:51:42 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 0 joepeck webkit-unassigned bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 224293 0 joepeck 2010-05-11 17:39:57 -0700 Shorthand properties are getting deleted when editing. Very annoying! 224295 1 55786 joepeck 2010-05-11 17:42:57 -0700 Created attachment 55786 [PATCH] Easy Fix Easy! 224302 2 joepeck 2010-05-11 17:55:35 -0700 <radr://7972069> 224307 3 55788 joepeck 2010-05-11 17:58:56 -0700 Created attachment 55788 [TEST]: Sample Test Case Steps to Reproduce: 1. Open Test Case html file 2. Right Click + Inspect the Text 3. Double Click to Edit the margin value 4. Put cursor by the number 5. Push Up/Down a few times Expected Results: Only the margin should change. Actual Results: The margin changes, but after a few increments/decrements the border is deleted, without warning! Deselecting and Reselecting the original node shows that it has disappeared. 224347 4 55786 timothy 2010-05-11 19:41:19 -0700 Comment on attachment 55786 [PATCH] Easy Fix Consider landing before the CQ gets to it. 224398 5 pfeldman 2010-05-11 21:51:20 -0700 Thanks for fixing it. Any chance we get a test for this? 224418 6 joepeck 2010-05-11 22:36:18 -0700 (In reply to comment #5) > Thanks for fixing it. Any chance we get a test for this? Do you mean an inspector test? I gave this only a brief thought at the time but figured since it was such a straight forward fix (if shorthand -> getShorthandValue) that I'd just put up the patch. But, now that you mention it, I think it would be nice to have a patch testing the styles output in general. To catch a case like this style manipulation functions can be run. I'll land this, because I feel its something urgent (this hits me quite a bit) and open up a follow up bug that styles need more coverage. 224423 7 joepeck 2010-05-11 22:51:42 -0700 Committed r59210 M WebCore/ChangeLog M WebCore/inspector/front-end/DOMAgent.js r59210 = 0348fb02fde32b1c173f3f2d1e03f3b0d5662603 (refs/remotes/trunk) http://trac.webkit.org/changeset/59210 55786 2010-05-11 17:42:57 -0700 2010-05-11 22:49:11 -0700 [PATCH] Easy Fix fix.patch text/plain 1374 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzZkYjAyMS4uNGU0ZDJlNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxNiBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNob3J0aGFuZCBQcm9wZXJ0 aWVzIEdldHRpbmcgRGVsZXRlZCBXaGVuIEVkaXRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4OTU4CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL0RPTUFnZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFy YXRpb24ucHJvdG90eXBlLnN0eWxlVGV4dFdpdGhTaG9ydGhhbmRzKTogd2FzIGdldHRpbmcgcmVn dWxhciB2YWx1ZXMgaW5zdGVhZCBvZiBzaG9ydGhhbmQgdmFsdWVzCisKKzIwMTAtMDUtMTEgIEpv c2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTaG91bGQgQXV0b2Nv bXBsZXRlIFN0eWxlIFByb3BlcnRpZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM4NDQ4CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9ET01BZ2VudC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2Vu dC5qcwppbmRleCA0NmZmMGJmLi4zMzczYzA0IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvRE9NQWdlbnQuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0RPTUFnZW50LmpzCkBAIC01ODYsNyArNTg2LDcgQEAgV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVj bGFyYXRpb24ucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAg ICAgICAgICBpZiAoc2hvcnRoYW5kUHJvcGVydHkpIHsKLSAgICAgICAgICAgICAgICB2YXIgdmFs dWUgPSB0aGlzLmdldFByb3BlcnR5VmFsdWUoc2hvcnRoYW5kUHJvcGVydHkpOworICAgICAgICAg ICAgICAgIHZhciB2YWx1ZSA9IHRoaXMuZ2V0U2hvcnRoYW5kVmFsdWUoc2hvcnRoYW5kUHJvcGVy dHkpOwogICAgICAgICAgICAgICAgIHZhciBwcmlvcml0eSA9IHRoaXMuZ2V0U2hvcnRoYW5kUHJp b3JpdHkoc2hvcnRoYW5kUHJvcGVydHkpOwogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAg ICAgICAgICB2YXIgdmFsdWUgPSB0aGlzLmdldFByb3BlcnR5VmFsdWUoaW5kaXZpZHVhbFByb3Bl cnR5KTsK 55788 2010-05-11 17:58:56 -0700 2010-05-11 17:58:56 -0700 [TEST]: Sample Test Case test.html text/html 89 joepeck PHN0eWxlPgpoMSB7CiAgICBib3JkZXI6IDFweCBzb2xpZCByZWQ7CiAgICBtYXJnaW46IDEwcHg7 Cn0KPC9zdHlsZT4KPGgxPkhlbGxvIFdvcmxkPC9oMT4=