38949 2010-05-11 16:49:35 -0700 JavaScript unable to invoke methods declared in QML 2010-05-14 03:01:27 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All CLOSED FIXED P2 Normal --- 35784 0 tffeeb webkit-unassigned hausmann oldest_to_newest 224248 0 tffeeb 2010-05-11 16:49:35 -0700 JavaScript code executed by webkit cannot call into QML declared methods, as it does not check for dynamic meta objects. The attached patch addresses this. 224249 1 55775 tffeeb 2010-05-11 16:51:01 -0700 Created attachment 55775 Proposed patch 224250 2 55776 tffeeb 2010-05-11 16:51:33 -0700 Created attachment 55776 Example testcase 225734 3 hausmann 2010-05-14 02:58:39 -0700 Committed r59460: <http://trac.webkit.org/changeset/59460> 225735 4 hausmann 2010-05-14 03:01:09 -0700 Revision r59460 cherry-picked into qtwebkit-2.0 with commit 592fb4ee6db52db805a6cd24552842e1e3dd7515 55775 2010-05-11 16:51:01 -0700 2010-05-11 16:51:01 -0700 Proposed patch code.txt text/plain 1603 tffeeb ZGlmZiAtLWNjIHNyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9icmlkZ2UvcXQvcXRfaW5zdGFu Y2UuY3BwDQppbmRleCBmNmYzNjhiLGRjNmRmMTQuLmQ0MGFiMGINCi0tLSBhL3NyYy8zcmRwYXJ0 eS93ZWJraXQvV2ViQ29yZS9icmlkZ2UvcXQvcXRfaW5zdGFuY2UuY3BwDQorKysgYi9zcmMvM3Jk cGFydHkvd2Via2l0L1dlYkNvcmUvYnJpZGdlL3F0L3F0X2luc3RhbmNlLmNwcA0KQEBAIC0yODcs NyAtMjc5LDcgKzI4Nyw3IEBAQCBKU1ZhbHVlIFF0SW5zdGFuY2U6OnN0cmluZ1ZhbHVlKEV4ZWNT dGENCiAgICAgICAgICAgICAgICAgICAgICB2b2lkICogcWFyZ3NbMV07DQogICAgICAgICAgICAg ICAgICAgICAgcWFyZ3NbMF0gPSByZXQuZGF0YSgpOw0KICANCi0tICAgICAgICAgICAgICAgICAg ICBpZiAob2JqLT5xdF9tZXRhY2FsbChRTWV0YU9iamVjdDo6SW52b2tlTWV0YU1ldGhvZCwgaW5k ZXgsIHFhcmdzKSA8IDApIHsNCisrICAgICAgICAgICAgICAgICAgICBpZiAoUU1ldGFPYmplY3Q6 Om1ldGFjYWxsKG9iaiwgUU1ldGFPYmplY3Q6Okludm9rZU1ldGFNZXRob2QsIGluZGV4LCBxYXJn cykgPCAwKSB7DQogICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChyZXQuaXNWYWxpZCgpICYm IHJldC5jYW5Db252ZXJ0KFFWYXJpYW50OjpTdHJpbmcpKSB7DQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBidWYgPSByZXQudG9TdHJpbmcoKS50b0xhdGluMSgpLmNvbnN0RGF0YSgpOyAv LyAjIyMgTGF0aW4gMT8gQXNjaWk/DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1c2VE ZWZhdWx0ID0gZmFsc2U7DQpkaWZmIC0tY2Mgc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL2Jy aWRnZS9xdC9xdF9ydW50aW1lLmNwcA0KaW5kZXggMTc3NTgxNSwzYmQ1MTkwLi40NTI0ZDk3DQot LS0gYS9zcmMvM3JkcGFydHkvd2Via2l0L1dlYkNvcmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUuY3Bw DQorKysgYi9zcmMvM3JkcGFydHkvd2Via2l0L1dlYkNvcmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUu Y3BwDQpAQEAgLTEzOTcsNyAtMTM5NSw3ICsxMzk3LDcgQEBAIEpTVmFsdWUgUXRSdW50aW1lTWV0 YU1ldGhvZDo6Y2FsbChFeGVjUw0KICAgICAgICAgIGludCBtZXRob2RJbmRleDsNCiAgICAgICAg ICBKU09iamVjdCogZXJyb3JPYmogPSAwOw0KICAgICAgICAgIGlmICgobWV0aG9kSW5kZXggPSBm aW5kTWV0aG9kSW5kZXgoZXhlYywgb2JqLT5tZXRhT2JqZWN0KCksIGQtPm1fc2lnbmF0dXJlLCBk LT5tX2FsbG93UHJpdmF0ZSwgYXJncywgdmFyZ3MsICh2b2lkICoqKXFhcmdzLCAmZXJyb3JPYmop KSAhPSAtMSkgew0KLS0gICAgICAgICAgICBpZiAob2JqLT5xdF9tZXRhY2FsbChRTWV0YU9iamVj dDo6SW52b2tlTWV0YU1ldGhvZCwgbWV0aG9kSW5kZXgsIHFhcmdzKSA+PSAwKQ0KKysgICAgICAg ICAgICBpZiAoUU1ldGFPYmplY3Q6Om1ldGFjYWxsKG9iaiwgUU1ldGFPYmplY3Q6Okludm9rZU1l dGFNZXRob2QsIG1ldGhvZEluZGV4LCBxYXJncykgPj0gMCkNCiAgICAgICAgICAgICAgICAgIHJl dHVybiBqc1VuZGVmaW5lZCgpOw0KICANCiAgICAgICAgICAgICAgaWYgKHZhcmdzWzBdLmlzVmFs aWQoKSkNCg== 55776 2010-05-11 16:51:33 -0700 2010-05-11 16:51:33 -0700 Example testcase test.qml application/octet-stream 313 tffeeb aW1wb3J0IFF0IDQuNwppbXBvcnQgb3JnLndlYmtpdCAxLjAKCldlYlZpZXcgewogICAgamF2YVNj cmlwdFdpbmRvd09iamVjdHM6IFF0T2JqZWN0IHsKICAgICAgICBXZWJWaWV3LndpbmRvd09iamVj dE5hbWU6ICJxbWwiCiAgICAgICAgZnVuY3Rpb24gcW1sQ2FsbCgpIHsgCiAgICAgICAgICAgIGNv bnNvbGUubG9nKCJUaGlzIGNhbGwgaXMgaW4gUU1MISIpOwogICAgICAgIH0KICAgIH0KCiAgICBo dG1sOiAiPHNjcmlwdD5jb25zb2xlLmxvZyhcIlRoaXMgaXMgaW4gV2ViS2l0IVwiKTsgd2luZG93 LnFtbC5xbWxDYWxsKCk7PC9zY3JpcHQ+Igp9Cg==