38948 2010-05-11 16:48:54 -0700 Chromium regression in user gesture handling 2010-05-14 04:21:32 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cevans webkit-unassigned abarth commit-queue oldest_to_newest 224247 0 cevans 2010-05-11 16:48:54 -0700 Full details at http://code.google.com/p/chromium/issues/detail?id=42643 Patch forthcoming. 224259 1 55778 cevans 2010-05-11 17:06:50 -0700 Created attachment 55778 Fix logic. 224260 2 cevans 2010-05-11 17:07:46 -0700 Simple enough. This patch restores the original logic but with Adam's enum elegance :) BTW, please r+ it but don't cq+ it. I want to test my new commit powers... 224264 3 55778 abarth 2010-05-11 17:11:16 -0700 Comment on attachment 55778 Fix logic. Is this not testable? 224286 4 cevans 2010-05-11 17:26:23 -0700 Yeah, it's not really testable as a layout test. Chromium does the popup blocking completely differently to the WebKit built-in blocker. Chromium actually runs with the WebKit blocker _disabled_ and does blocking in the UI. I have a TODO to add a Chromium UI test for all these blocker corner cases once I've fixed them all. 224312 5 55778 commit-queue 2010-05-11 18:12:15 -0700 Comment on attachment 55778 Fix logic. Rejecting patch 55778 from commit-queue. cevans@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. 225749 6 55778 commit-queue 2010-05-14 04:21:26 -0700 Comment on attachment 55778 Fix logic. Clearing flags on attachment: 55778 Committed r59462: <http://trac.webkit.org/changeset/59462> 225750 7 commit-queue 2010-05-14 04:21:32 -0700 All reviewed patches have been landed. Closing bug. 55778 2010-05-11 17:06:50 -0700 2010-05-14 04:21:26 -0700 Fix logic. popup2_3.diff text/plain 4221 cevans SW5kZXg6IFdlYkNvcmUvZG9tL1VzZXJHZXN0dXJlSW5kaWNhdG9yLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2RvbS9Vc2VyR2VzdHVyZUluZGljYXRvci5jcHAJKHJldmlzaW9uIDU5MTQ5KQor KysgV2ViQ29yZS9kb20vVXNlckdlc3R1cmVJbmRpY2F0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yOCwxMyArMjgsMTIgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1ib29sIFVzZXJHZXN0 dXJlSW5kaWNhdG9yOjpzX3Byb2Nlc3NpbmdVc2VyR2VzdHVyZSA9IGZhbHNlOworUHJvY2Vzc2lu Z1VzZXJHZXN0dXJlU3RhdGUgVXNlckdlc3R1cmVJbmRpY2F0b3I6OnNfcHJvY2Vzc2luZ1VzZXJH ZXN0dXJlID0gUG9zc2libHlQcm9jZXNzaW5nVXNlckdlc3R1cmU7CiAKIFVzZXJHZXN0dXJlSW5k aWNhdG9yOjpVc2VyR2VzdHVyZUluZGljYXRvcihQcm9jZXNzaW5nVXNlckdlc3R1cmVTdGF0ZSBz dGF0ZSkKICAgICA6IG1fcHJldmlvdXNWYWx1ZShzX3Byb2Nlc3NpbmdVc2VyR2VzdHVyZSkKIHsK LSAgICBpZiAoc3RhdGUgPT0gRGVmaW5pdGVseVByb2Nlc3NpbmdVc2VyR2VzdHVyZSkKLSAgICAg ICAgc19wcm9jZXNzaW5nVXNlckdlc3R1cmUgPSB0cnVlOworICAgIHNfcHJvY2Vzc2luZ1VzZXJH ZXN0dXJlID0gc3RhdGU7CiB9CiAKIFVzZXJHZXN0dXJlSW5kaWNhdG9yOjp+VXNlckdlc3R1cmVJ bmRpY2F0b3IoKQpJbmRleDogV2ViQ29yZS9kb20vVXNlckdlc3R1cmVJbmRpY2F0b3IuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Vc2VyR2VzdHVyZUluZGljYXRvci5oCShyZXZpc2lvbiA1 OTE0OSkKKysrIFdlYkNvcmUvZG9tL1VzZXJHZXN0dXJlSW5kaWNhdG9yLmgJKHdvcmtpbmcgY29w eSkKQEAgLTMyLDE5ICszMiwyMSBAQAogCiBlbnVtIFByb2Nlc3NpbmdVc2VyR2VzdHVyZVN0YXRl IHsKICAgICBEZWZpbml0ZWx5UHJvY2Vzc2luZ1VzZXJHZXN0dXJlLAotICAgIFBvc3NpYmx5UHJv Y2Vzc2luZ1VzZXJHZXN0dXJlCisgICAgUG9zc2libHlQcm9jZXNzaW5nVXNlckdlc3R1cmUsCisg ICAgRGVmaW5pdGVseU5vdFByb2Nlc3NpbmdVc2VyR2VzdHVyZQogfTsKIAogY2xhc3MgVXNlckdl c3R1cmVJbmRpY2F0b3IgOiBwdWJsaWMgTm9uY29weWFibGUgewogcHVibGljOgotICAgIHN0YXRp YyBib29sIHByb2Nlc3NpbmdVc2VyR2VzdHVyZSgpIHsgcmV0dXJuIHNfcHJvY2Vzc2luZ1VzZXJH ZXN0dXJlOyB9CisgICAgc3RhdGljIGJvb2wgcHJvY2Vzc2luZ1VzZXJHZXN0dXJlKCkgeyByZXR1 cm4gc19wcm9jZXNzaW5nVXNlckdlc3R1cmUgPT0gRGVmaW5pdGVseVByb2Nlc3NpbmdVc2VyR2Vz dHVyZTsgfQorICAgIHN0YXRpYyBQcm9jZXNzaW5nVXNlckdlc3R1cmVTdGF0ZSBnZXRVc2VyR2Vz dHVyZVN0YXRlKCkgeyByZXR1cm4gc19wcm9jZXNzaW5nVXNlckdlc3R1cmU7IH0KIAogICAgIGV4 cGxpY2l0IFVzZXJHZXN0dXJlSW5kaWNhdG9yKFByb2Nlc3NpbmdVc2VyR2VzdHVyZVN0YXRlKTsK ICAgICB+VXNlckdlc3R1cmVJbmRpY2F0b3IoKTsKIAogcHJpdmF0ZToKLSAgICBzdGF0aWMgYm9v bCBzX3Byb2Nlc3NpbmdVc2VyR2VzdHVyZTsKLSAgICBib29sIG1fcHJldmlvdXNWYWx1ZTsKKyAg ICBzdGF0aWMgUHJvY2Vzc2luZ1VzZXJHZXN0dXJlU3RhdGUgc19wcm9jZXNzaW5nVXNlckdlc3R1 cmU7CisgICAgUHJvY2Vzc2luZ1VzZXJHZXN0dXJlU3RhdGUgbV9wcmV2aW91c1ZhbHVlOwogfTsg ICAgCiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA1OTE0OSkKKysrIFdlYkNv cmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDUtMTEg IENocmlzIEV2YW5zICA8Y2V2YW5zQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaHJvbWl1bS1zcGVjaWZpYyBmaXggdG8gcHJl dmVudCB6b21iaWUgaW5mb2JhcnMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM4OTQ4CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRDb250 cm9sbGVyLmNwcAorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2lu Z1VzZXJHZXN0dXJlKToKKyAgICAgICAgICBSZXF1aXJlIGEgbW9yZSBkZWZpbml0ZSAibm8iIHNp Z25hbC4KKyAgICAgICAgKiBsb2FkZXIvUmVkaXJlY3RTY2hlZHVsZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U2NoZWR1bGVkRm9ybVN1Ym1pc3Npb246OmZpcmUpOgorICAgICAgICAgIFVzZSBh IHZlcnkgc3Ryb25nIHllcyAvIG5vIHNpZ25hbDsgbm8gbmVlZCBmb3IgInBvc3NpYmxlIiBoZXJl LgorICAgICAgICAqIGRvbS9Vc2VyR2VzdHVyZUluZGljYXRvci5oOgorICAgICAgICAqIGRvbS9V c2VyR2VzdHVyZUluZGljYXRvci5jcHA6CisgICAgICAgICAgQWRhcHQgdG8gdHJpLXN0YXRlOiBk ZWZpbml0ZWx5IHllczsgZGVmaW5pdGVseSBubzsgbm90IHN1cmUuCisKIDIwMTAtMDUtMTEgIE5p a29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGlyayBTY2h1bHplLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250 cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRy b2xsZXIuY3BwCShyZXZpc2lvbiA1OTE0OSkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0 Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1OCw3ICsxNTgsNyBAQAogICAgIC8v IE5vIHNjcmlwdCBpcyBydW5uaW5nLCBzbyBpdCBpcyB1c2VyLWluaXRpYXRlZCB1bmxlc3MgdGhl IGdlc3R1cmUgc3RhY2sKICAgICAvLyBleHBsaWNpdGx5IHNheXMgaXQgaXMgbm90LgogICAgIGlm ICghYWN0aXZlRnJhbWUpCi0gICAgICAgIHJldHVybiBVc2VyR2VzdHVyZUluZGljYXRvcjo6cHJv Y2Vzc2luZ1VzZXJHZXN0dXJlKCk7CisgICAgICAgIHJldHVybiBVc2VyR2VzdHVyZUluZGljYXRv cjo6Z2V0VXNlckdlc3R1cmVTdGF0ZSgpICE9IERlZmluaXRlbHlOb3RQcm9jZXNzaW5nVXNlckdl c3R1cmU7CiAKICAgICBWOFByb3h5KiBhY3RpdmVQcm94eSA9IGFjdGl2ZUZyYW1lLT5zY3JpcHQo KS0+cHJveHkoKTsKIApJbmRleDogV2ViQ29yZS9sb2FkZXIvUmVkaXJlY3RTY2hlZHVsZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL1JlZGlyZWN0U2NoZWR1bGVyLmNwcAkocmV2 aXNpb24gNTkxNDkpCisrKyBXZWJDb3JlL2xvYWRlci9SZWRpcmVjdFNjaGVkdWxlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE4NCw3ICsxODQsNyBAQAogCiAgICAgdmlydHVhbCB2b2lkIGZpcmUo RnJhbWUqIGZyYW1lKQogICAgIHsKLSAgICAgICAgVXNlckdlc3R1cmVJbmRpY2F0b3IgZ2VzdHVy ZUluZGljYXRvcihtX3dhc1Byb2Nlc3NpbmdVc2VyR2VzdHVyZSA/IERlZmluaXRlbHlQcm9jZXNz aW5nVXNlckdlc3R1cmUgOiBQb3NzaWJseVByb2Nlc3NpbmdVc2VyR2VzdHVyZSk7CisgICAgICAg IFVzZXJHZXN0dXJlSW5kaWNhdG9yIGdlc3R1cmVJbmRpY2F0b3IobV93YXNQcm9jZXNzaW5nVXNl ckdlc3R1cmUgPyBEZWZpbml0ZWx5UHJvY2Vzc2luZ1VzZXJHZXN0dXJlIDogRGVmaW5pdGVseU5v dFByb2Nlc3NpbmdVc2VyR2VzdHVyZSk7CiAKICAgICAgICAgLy8gVGhlIHN1Ym1pdEZvcm0gZnVu Y3Rpb24gd2lsbCBmaW5kIGEgdGFyZ2V0IGZyYW1lIGJlZm9yZSB1c2luZyB0aGUgcmVkaXJlY3Rp b24gdGltZXIuCiAgICAgICAgIC8vIE5vdyB0aGF0IHRoZSB0aW1lciBoYXMgZmlyZWQsIHdlIG5l ZWQgdG8gcmVwZWF0IHRoZSBzZWN1cml0eSBjaGVjayB3aGljaCBub3JtYWxseSBpcyBkb25lIHdo ZW4K