38947 2010-05-11 16:43:08 -0700 [chromium] Expose volume through WebMediaPlayerClient 2010-05-14 05:17:05 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simonjam webkit-unassigned commit-queue fishd levin scherkus oldest_to_newest 224246 0 simonjam 2010-05-11 16:43:08 -0700 This is the WebKit portion of the fix to: http://code.google.com/p/chromium/issues/detail?id=33023 We need to expose the media volume through WebMediaPlayerClient. This is so that Chromium can get the correct volume setting before starting playback. 224283 1 55783 simonjam 2010-05-11 17:24:13 -0700 Created attachment 55783 Adds needed accessors to WebMediaPlayerClient 224306 2 levin 2010-05-11 17:58:31 -0700 This looks fine to scherkus@, since it touches the Chromium public api, I'll leave the final r+ to fishd. 224386 3 55783 fishd 2010-05-11 21:33:07 -0700 Comment on attachment 55783 Adds needed accessors to WebMediaPlayerClient WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:396 + float WebMediaPlayerClientImpl::volume() const It looks like you have not inserted this method definition after the definition of sawUnsupportedTracks. Please fix that so that methods in the .cpp file are defined in the same order in which they are declared in the .h file. Thanks! 224782 4 55883 simonjam 2010-05-12 12:04:37 -0700 Created attachment 55883 Fixed order to match header file 224789 5 55883 eric 2010-05-12 12:15:19 -0700 Comment on attachment 55883 Fixed order to match header file No ChangeLog. r- See http://webkit.org/coding/contributing.html 224964 6 55909 simonjam 2010-05-12 15:55:04 -0700 Created attachment 55909 Patch 225761 7 55909 commit-queue 2010-05-14 05:16:57 -0700 Comment on attachment 55909 Patch Clearing flags on attachment: 55909 Committed r59466: <http://trac.webkit.org/changeset/59466> 225762 8 commit-queue 2010-05-14 05:17:05 -0700 All reviewed patches have been landed. Closing bug. 55783 2010-05-11 17:24:13 -0700 2010-05-12 15:54:55 -0700 Adds needed accessors to WebMediaPlayerClient WebKitChromiumVolume.txt text/plain 1599 simonjam SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJDbGllbnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYk1lZGlhUGxheWVyQ2xpZW50LmgJ KHJldmlzaW9uIDU4NDAwKQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXll ckNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC00OCw2ICs0OCw3IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIHZvaWQgcmF0ZUNoYW5nZWQoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNpemVDaGFu Z2VkKCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzYXdVbnN1cHBvcnRlZFRyYWNrcygpID0gMDsK KyAgICB2aXJ0dWFsIGZsb2F0IHZvbHVtZSgpIGNvbnN0ID0gMDsKIAogcHJvdGVjdGVkOgogICAg IH5XZWJNZWRpYVBsYXllckNsaWVudCgpIHsgfQpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1 bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNwcAkocmV2aXNpb24gNTg0MDApCisrKyBX ZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTM5Myw2ICszOTMsMTMgQEAgTWVkaWFQbGF5ZXI6OlN1cHBvcnRzVHlwZSBXZWJN ZWRpYVBsYXllcgogICAgIHJldHVybiBNZWRpYVBsYXllcjo6SXNOb3RTdXBwb3J0ZWQ7CiB9CiAK K2Zsb2F0IFdlYk1lZGlhUGxheWVyQ2xpZW50SW1wbDo6dm9sdW1lKCkgY29uc3QKK3sKKyAgICBp ZiAobV9tZWRpYVBsYXllcikKKyAgICAgICAgcmV0dXJuIG1fbWVkaWFQbGF5ZXItPnZvbHVtZSgp OworICAgIHJldHVybiAwLjBmOworfQorCiBXZWJNZWRpYVBsYXllckNsaWVudEltcGw6OldlYk1l ZGlhUGxheWVyQ2xpZW50SW1wbCgpCiAgICAgOiBtX21lZGlhUGxheWVyKDApCiB7CkluZGV4OiBX ZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmgJKHJldmlz aW9uIDU4NDAwKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudElt cGwuaAkod29ya2luZyBjb3B5KQpAQCAtNjEsNiArNjEsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCB2b2lkIHJhdGVDaGFuZ2VkKCk7CiAgICAgdmlydHVhbCB2b2lkIHNpemVDaGFuZ2VkKCk7CiAg ICAgdmlydHVhbCB2b2lkIHNhd1Vuc3VwcG9ydGVkVHJhY2tzKCk7CisgICAgdmlydHVhbCBmbG9h dCB2b2x1bWUoKSBjb25zdDsKIAogICAgIC8vIE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSBt ZXRob2RzOgogICAgIHZpcnR1YWwgdm9pZCBsb2FkKGNvbnN0IFdlYkNvcmU6OlN0cmluZyYgdXJs KTsK 55883 2010-05-12 12:04:37 -0700 2010-05-12 15:54:59 -0700 Fixed order to match header file WebKitChromiumVolume2.txt text/plain 1706 simonjam SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJDbGllbnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYk1lZGlhUGxheWVyQ2xpZW50LmgJ KHJldmlzaW9uIDU4NDAwKQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXll ckNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC00OCw2ICs0OCw3IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIHZvaWQgcmF0ZUNoYW5nZWQoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNpemVDaGFu Z2VkKCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzYXdVbnN1cHBvcnRlZFRyYWNrcygpID0gMDsK KyAgICB2aXJ0dWFsIGZsb2F0IHZvbHVtZSgpIGNvbnN0ID0gMDsKIAogcHJvdGVjdGVkOgogICAg IH5XZWJNZWRpYVBsYXllckNsaWVudCgpIHsgfQpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1 bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNwcAkocmV2aXNpb24gNTg0MDApCisrKyBX ZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEzMyw2ICsxMzMsMTMgQEAgdm9pZCBXZWJNZWRpYVBsYXllckNsaWVudEltcGw6 OnNhd1Vuc3VwcAogICAgIG1fbWVkaWFQbGF5ZXItPm1lZGlhUGxheWVyQ2xpZW50KCktPm1lZGlh UGxheWVyU2F3VW5zdXBwb3J0ZWRUcmFja3MobV9tZWRpYVBsYXllcik7CiB9CiAKK2Zsb2F0IFdl Yk1lZGlhUGxheWVyQ2xpZW50SW1wbDo6dm9sdW1lKCkgY29uc3QKK3sKKyAgICBpZiAobV9tZWRp YVBsYXllcikKKyAgICAgICAgcmV0dXJuIG1fbWVkaWFQbGF5ZXItPnZvbHVtZSgpOworICAgIHJl dHVybiAwLjBmOworfQorCiAvLyBNZWRpYVBsYXllclByaXZhdGVJbnRlcmZhY2UgLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiB2b2lkIFdlYk1lZGlh UGxheWVyQ2xpZW50SW1wbDo6bG9hZChjb25zdCBTdHJpbmcmIHVybCkKSW5kZXg6IFdlYktpdC9j aHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuaAkocmV2aXNpb24gNTg0 MDApCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5oCSh3 b3JraW5nIGNvcHkpCkBAIC02MSw2ICs2MSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQg cmF0ZUNoYW5nZWQoKTsKICAgICB2aXJ0dWFsIHZvaWQgc2l6ZUNoYW5nZWQoKTsKICAgICB2aXJ0 dWFsIHZvaWQgc2F3VW5zdXBwb3J0ZWRUcmFja3MoKTsKKyAgICB2aXJ0dWFsIGZsb2F0IHZvbHVt ZSgpIGNvbnN0OwogCiAgICAgLy8gTWVkaWFQbGF5ZXJQcml2YXRlSW50ZXJmYWNlIG1ldGhvZHM6 CiAgICAgdmlydHVhbCB2b2lkIGxvYWQoY29uc3QgV2ViQ29yZTo6U3RyaW5nJiB1cmwpOwo= 55909 2010-05-12 15:55:04 -0700 2010-05-14 05:16:57 -0700 Patch bug-38947-20100512155502.patch text/plain 2618 simonjam ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGYxODgyZmE2Nzc0Zjk4NjBkNGQ5MzIyOWFlNjI3ZmI4MTI4YzE5ZDIu LmMxNmMzZTc0NGYzY2NlOTIyZDJiOTM2ODdkMjBhNjk2MDQ5NmQxOGUgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTA1LTEyICBKYW1lcyBTaW1vbnNlbiAgPHNpbW9uamFtK3dl YmtpdEBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtjaHJvbWl1bV0gRXhwb3NlIHZvbHVtZSB0aHJvdWdoIFdlYk1lZGlhUGxheWVy Q2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z ODk0NworCisgICAgICAgICogcHVibGljL1dlYk1lZGlhUGxheWVyQ2xpZW50Lmg6CisgICAgICAg ICogc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl Yk1lZGlhUGxheWVyQ2xpZW50SW1wbDo6dm9sdW1lKToKKyAgICAgICAgKiBzcmMvV2ViTWVkaWFQ bGF5ZXJDbGllbnRJbXBsLmg6CisKIDIwMTAtMDUtMTIgIEplcmVteSBPcmxvdyAgPGpvcmxvd0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUgQmxvY2suCmRpZmYgLS1n aXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYk1lZGlhUGxheWVyQ2xpZW50LmggYi9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYk1lZGlhUGxheWVyQ2xpZW50LmgKaW5kZXggNDdjZTY0ZTdh ZDU0MzU0Y2QxNjdmZTVhNjYzNTFjZjgxMDllMzQ3OC4uN2U1ZGQ2OGM5MTY4MTY0YWQ2ZWNjYjYx MmZlMzFjZjI4ZTBhNzIxZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJN ZWRpYVBsYXllckNsaWVudC5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQ bGF5ZXJDbGllbnQuaApAQCAtNDgsNiArNDgsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lk IHJhdGVDaGFuZ2VkKCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzaXplQ2hhbmdlZCgpID0gMDsK ICAgICB2aXJ0dWFsIHZvaWQgc2F3VW5zdXBwb3J0ZWRUcmFja3MoKSA9IDA7CisgICAgdmlydHVh bCBmbG9hdCB2b2x1bWUoKSBjb25zdCA9IDA7CiAKIHByb3RlY3RlZDoKICAgICB+V2ViTWVkaWFQ bGF5ZXJDbGllbnQoKSB7IH0KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVk aWFQbGF5ZXJDbGllbnRJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5 ZXJDbGllbnRJbXBsLmNwcAppbmRleCBkN2RiYWRlMWU1Y2M1Y2YzYmQ0YzIxODRlODQ3MGUxY2Iy YmNlZjY5Li4wMzA1MWMzMmJmM2UyNTgzNzczZGQzOGZiMDA5NTIzYmQyNDA1ZDE4IDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAKKysr IGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwCkBAIC0x MzMsNiArMTMzLDEzIEBAIHZvaWQgV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsOjpzYXdVbnN1cHBv cnRlZFRyYWNrcygpCiAgICAgbV9tZWRpYVBsYXllci0+bWVkaWFQbGF5ZXJDbGllbnQoKS0+bWVk aWFQbGF5ZXJTYXdVbnN1cHBvcnRlZFRyYWNrcyhtX21lZGlhUGxheWVyKTsKIH0KIAorZmxvYXQg V2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsOjp2b2x1bWUoKSBjb25zdAoreworICAgIGlmIChtX21l ZGlhUGxheWVyKQorICAgICAgICByZXR1cm4gbV9tZWRpYVBsYXllci0+dm9sdW1lKCk7CisgICAg cmV0dXJuIDAuMGY7Cit9CisKIC8vIE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSAtLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKIHZvaWQgV2ViTWVk aWFQbGF5ZXJDbGllbnRJbXBsOjpsb2FkKGNvbnN0IFN0cmluZyYgdXJsKQpkaWZmIC0tZ2l0IGEv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuaCBiL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmgKaW5kZXggNGFkYmVkMjA2YmJl MDQ0MWY1MmVkNTI3MDM2M2QzZjY2ZTM1ZTMyNC4uNTdjOTNiN2I0YzVkMzdlNGVlZjRlNTNlODU3 MDQxMDM0ODFhODVlYyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBs YXllckNsaWVudEltcGwuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVy Q2xpZW50SW1wbC5oCkBAIC02MSw2ICs2MSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQg cmF0ZUNoYW5nZWQoKTsKICAgICB2aXJ0dWFsIHZvaWQgc2l6ZUNoYW5nZWQoKTsKICAgICB2aXJ0 dWFsIHZvaWQgc2F3VW5zdXBwb3J0ZWRUcmFja3MoKTsKKyAgICB2aXJ0dWFsIGZsb2F0IHZvbHVt ZSgpIGNvbnN0OwogCiAgICAgLy8gTWVkaWFQbGF5ZXJQcml2YXRlSW50ZXJmYWNlIG1ldGhvZHM6 CiAgICAgdmlydHVhbCB2b2lkIGxvYWQoY29uc3QgV2ViQ29yZTo6U3RyaW5nJiB1cmwpOwo=