38942 2010-05-11 15:42:03 -0700 Improve check-webkit-style to detect that FeatureDefines.xcconfig is not in sync 2014-03-12 03:24:41 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED DUPLICATE 125748 P2 Normal --- 1 jianli webkit-unassigned eric gbalogh.u-szeged jianli llango.u-szeged lvidacs.u-szeged mrowe ossy oldest_to_newest 224199 0 jianli 2010-05-11 15:42:03 -0700 All instances of FeatureDefines.xcconfig need to sync up. Otherwise, the build could be broken. See comments from WebCore/Configuration/FeatureDefines.xcconfig. // The contents of this file must be kept in sync with FeatureDefines.xcconfig in JavaScriptCore, // WebCore and WebKit. Also the default values of the ENABLE_FEATURE_NAME macros in build-webkit // should match the values below, but they do not need to be in the same order. To avoid this, we could write a script to compare those FeatureDefines.xcconfig and run it from build-webkit. This should make us detect the problem earlier. 224866 1 ap 2010-05-12 13:52:04 -0700 See also: http://trac.webkit.org/changeset/59181 981985 2 ossy 2014-02-18 10:56:16 -0800 To ensure FeatureDefines.xcconfig files are in sync, the best place is chack-webkit-style. Now they are in sync. If somebody tried to add a change accidentally break it, check-webkit-style or style bot would notice it. 989570 3 ossy 2014-03-12 03:24:41 -0700 *** This bug has been marked as a duplicate of bug 125748 ***