38917 2010-05-11 11:04:38 -0700 [Qt] Cleanup SharedBuffer::createWithContentsOfFile 2010-05-22 12:11:12 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 paroga paroga commit-queue jesus kenneth markus oldest_to_newest 224019 0 paroga 2010-05-11 11:04:38 -0700 see patch 224021 1 55723 paroga 2010-05-11 11:06:24 -0700 Created attachment 55723 The patch 224463 2 markus 2010-05-12 00:52:27 -0700 Looks good to me. 228257 3 55723 eric 2010-05-20 01:16:11 -0700 Comment on attachment 55723 The patch LGTM. 229294 4 55723 commit-queue 2010-05-22 12:11:06 -0700 Comment on attachment 55723 The patch Clearing flags on attachment: 55723 Committed r60009: <http://trac.webkit.org/changeset/60009> 229295 5 commit-queue 2010-05-22 12:11:12 -0700 All reviewed patches have been landed. Closing bug. 55723 2010-05-11 11:06:24 -0700 2010-05-22 12:11:05 -0700 The patch bug-38917.patch text/plain 1438 paroga SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTE1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMTEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBh cm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBDbGVhbnVwIFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlV2l0aENvbnRlbnRzT2ZGaWxlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODkxNworCisg ICAgICAgICogcGxhdGZvcm0vcXQvU2hhcmVkQnVmZmVyUXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U2hhcmVkQnVmZmVyOjpjcmVhdGVXaXRoQ29udGVudHNPZkZpbGUpOgorCiAyMDEwLTA1LTEx ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBH dXN0YXZvIE5vcm9uaGEuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3F0L1NoYXJlZEJ1ZmZlclF0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3F0L1NoYXJlZEJ1ZmZlclF0LmNw cAkocmV2aXNpb24gNTkxNTQpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3F0L1NoYXJlZEJ1ZmZlclF0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzksMTYgKzM5LDkgQEAgUGFzc1JlZlB0cjxTaGFyZWRC dWZmZXI+IFNoYXJlZEJ1ZmZlcjo6YwogICAgIGlmICghZmlsZS5leGlzdHMoKSB8fCAhZmlsZS5v cGVuKFFGaWxlOjpSZWFkT25seSkpCiAgICAgICAgIHJldHVybiAwOwogCi0KLSAgICBSZWZQdHI8 U2hhcmVkQnVmZmVyPiByZXN1bHQgPSBTaGFyZWRCdWZmZXI6OmNyZWF0ZSgpOwotICAgIHJlc3Vs dC0+bV9idWZmZXIucmVzaXplKGZpbGUuc2l6ZSgpKTsKLSAgICBpZiAocmVzdWx0LT5tX2J1ZmZl ci5zaXplKCkgIT0gZmlsZS5zaXplKCkpCi0gICAgICAgIHJldHVybiAwOwotCi0gICAgcmVzdWx0 LT5tX3NpemUgPSByZXN1bHQtPm1fYnVmZmVyLnNpemUoKTsKLQotICAgIGZpbGUucmVhZChyZXN1 bHQtPm1fYnVmZmVyLmRhdGEoKSwgcmVzdWx0LT5tX2J1ZmZlci5zaXplKCkpOwotICAgIHJldHVy biByZXN1bHQucmVsZWFzZSgpOworICAgIFZlY3RvcjxjaGFyPiBidWZmZXIoZmlsZS5zaXplKCkp OworICAgIGZpbGUucmVhZChidWZmZXIuZGF0YSgpLCBidWZmZXIuc2l6ZSgpKTsKKyAgICByZXR1 cm4gU2hhcmVkQnVmZmVyOjphZG9wdFZlY3RvcihidWZmZXIpOwogfQogCi19Cit9IC8vIG5hbWVz cGFjZSBXZWJDb3JlCg==