38909 2010-05-11 08:21:46 -0700 JSDataGridColumnListCustom.cpp doesn't compile 2010-05-14 01:09:33 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 0 gwright webkit-unassigned commit-queue manyoso oldest_to_newest 223930 0 gwright 2010-05-11 08:21:46 -0700 It seems that JSDataGridColumnListCustom.cpp wasn't updated to use the new identifierToAtomicString() function introduced in the patch for https://bugs.webkit.org/show_bug.cgi?id=37735 223934 1 55704 gwright 2010-05-11 08:36:20 -0700 Created attachment 55704 Use identifierToAtomicString Proposed fix. 225697 2 55704 commit-queue 2010-05-14 01:09:28 -0700 Comment on attachment 55704 Use identifierToAtomicString Clearing flags on attachment: 55704 Committed r59448: <http://trac.webkit.org/changeset/59448> 225698 3 commit-queue 2010-05-14 01:09:33 -0700 All reviewed patches have been landed. Closing bug. 55704 2010-05-11 08:36:20 -0700 2010-05-14 01:09:28 -0700 Use identifierToAtomicString patch.diff text/plain 2278 gwright Y29tbWl0IDdlMzI5ZmZmNjZhMjVjM2Y1ZGM3YjBmY2QxM2UwNGQyNGM4YjAxZTgKQXV0aG9yOiBH ZW9yZ2UgV3JpZ2h0IDxnd3JpZ2h0QHJpbS5jb20+CkRhdGU6ICAgVHVlIE1heSAxMSAxNToyNjoy MSAyMDEwICswMDAwCgogICAgMjAxMC0wNS0xMSAgR2VvcmdlIFdyaWdodCAgPGd3cmlnaHRAcmlt LmNvbT4KICAgIAogICAgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mzg5MDkKICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K ICAgIAogICAgICAgICAgICBVcGRhdGUgSlNEYXRhR3JpZENvbHVtbkxpc3RDdXN0b20uY3BwIHRv IGNhbGwgaWRlbnRpZmllclRvQXRvbWljU3RyaW5nKCkKICAgICAgICAgICAgb24gdGhlIHByb3Bl cnR5IG5hbWUuCiAgICAKICAgICAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RhdGFHcmlkQ29sdW1u TGlzdEN1c3RvbS5jcHA6CiAgICAgICAgICAgIChXZWJDb3JlOjpKU0RhdGFHcmlkQ29sdW1uTGlz dDo6Y2FuR2V0SXRlbXNGb3JOYW1lKToKICAgICAgICAgICAgKFdlYkNvcmU6OkpTRGF0YUdyaWRD b2x1bW5MaXN0OjpuYW1lR2V0dGVyKToKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBi L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDM3MGM5ODcuLmIxYWQwZWEgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDUtMTEgIEdlb3JnZSBXcmlnaHQgIDxnd3JpZ2h0QHJpbS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM4OTA5CisKKyAgICAgICAgVXBkYXRlIEpTRGF0YUdyaWRD b2x1bW5MaXN0Q3VzdG9tLmNwcCB0byBjYWxsIGlkZW50aWZpZXJUb0F0b21pY1N0cmluZygpCisg ICAgICAgIG9uIHRoZSBwcm9wZXJ0eSBuYW1lLgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNE YXRhR3JpZENvbHVtbkxpc3RDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNEYXRhR3Jp ZENvbHVtbkxpc3Q6OmNhbkdldEl0ZW1zRm9yTmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpKU0Rh dGFHcmlkQ29sdW1uTGlzdDo6bmFtZUdldHRlcik6CisKIDIwMTAtMDUtMTEgIEJlbmphbWluIFBv dWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNEYXRhR3JpZENvbHVtbkxpc3RDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0RhdGFHcmlkQ29sdW1uTGlzdEN1c3RvbS5jcHAKaW5kZXggOWE2OTgyYS4uNWVlNzkwYyAx MDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RhdGFHcmlkQ29sdW1uTGlzdEN1c3Rv bS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RhdGFHcmlkQ29sdW1uTGlzdEN1c3Rv bS5jcHAKQEAgLTQwLDEzICs0MCwxMyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGJvb2wgSlNE YXRhR3JpZENvbHVtbkxpc3Q6OmNhbkdldEl0ZW1zRm9yTmFtZShFeGVjU3RhdGUqLCBEYXRhR3Jp ZENvbHVtbkxpc3QqIGltcGwsIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSkKIHsKLSAg ICByZXR1cm4gaW1wbC0+aXRlbVdpdGhOYW1lKHByb3BlcnR5TmFtZSk7CisgICAgcmV0dXJuIGlt cGwtPml0ZW1XaXRoTmFtZShpZGVudGlmaWVyVG9BdG9taWNTdHJpbmcocHJvcGVydHlOYW1lKSk7 CiB9CiAKIEpTVmFsdWUgSlNEYXRhR3JpZENvbHVtbkxpc3Q6Om5hbWVHZXR0ZXIoRXhlY1N0YXRl KiBleGVjLCBKU1ZhbHVlIHNsb3RCYXNlLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUp CiB7CiAgICAgSlNEYXRhR3JpZENvbHVtbkxpc3QqIHRoaXNPYmogPSBzdGF0aWNfY2FzdDxKU0Rh dGFHcmlkQ29sdW1uTGlzdCo+KGFzT2JqZWN0KHNsb3RCYXNlKSk7Ci0gICAgcmV0dXJuIHRvSlMo ZXhlYywgdGhpc09iai0+Z2xvYmFsT2JqZWN0KCksIHRoaXNPYmotPmltcGwoKS0+aXRlbVdpdGhO YW1lKHByb3BlcnR5TmFtZSkpOworICAgIHJldHVybiB0b0pTKGV4ZWMsIHRoaXNPYmotPmdsb2Jh bE9iamVjdCgpLCB0aGlzT2JqLT5pbXBsKCktPml0ZW1XaXRoTmFtZShpZGVudGlmaWVyVG9BdG9t aWNTdHJpbmcocHJvcGVydHlOYW1lKSkpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==