38908 2010-05-11 08:15:02 -0700 Android's writeToFile() is buggy 2010-05-12 05:51:42 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned android-webkit-unforking commit-queue oldest_to_newest 223927 0 steveblock 2010-05-11 08:15:02 -0700 Android's version of writeToFile() attempts to handle the case where the write is interrupted part way through such that the number of bytes written is less than the number of bytes requested. However, the implementation is buggy as the data pointer is not updated when the write is re-tried. We should remove the Android-specific version and use the POSIX version. 223946 1 55708 steveblock 2010-05-11 09:11:21 -0700 Created attachment 55708 Patch 224553 2 55708 commit-queue 2010-05-12 05:51:38 -0700 Comment on attachment 55708 Patch Clearing flags on attachment: 55708 Committed r59226: <http://trac.webkit.org/changeset/59226> 224554 3 commit-queue 2010-05-12 05:51:42 -0700 All reviewed patches have been landed. Closing bug. 55708 2010-05-11 09:11:21 -0700 2010-05-12 05:51:37 -0700 Patch bug-38908-20100511171119.patch text/plain 2248 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTE1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMTEgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFuZHJvaWQncyB3cml0ZVRvRmlsZSgpIGlzIGJ1Z2d5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODkwOAorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg YnVpbGQgZml4IG9ubHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9hbmRyb2lkL0ZpbGVTeXN0ZW1B bmRyb2lkLmNwcDogUmVtb3ZlIEFuZHJvaWQncyB2ZXJzaW9uIG9mIHdyaXRlVG9GaWxlKCkuCisg ICAgICAgICogcGxhdGZvcm0vcG9zaXgvRmlsZVN5c3RlbVBPU0lYLmNwcDogVXNlIFBPU0lYIHZl cnNpb24gb2Ygd3JpdGVUb0ZpbGUoKSBvbiBBbmRyb2lkLgorICAgICAgICAoV2ViQ29yZTo6d3Jp dGVUb0ZpbGUpOgorCiAyMDEwLTA1LTExICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91 bGFpbkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJp c3RpYW5zZW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2FuZHJvaWQvRmlsZVN5c3RlbUFuZHJv aWQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vYW5kcm9pZC9GaWxlU3lzdGVt QW5kcm9pZC5jcHAJKHJldmlzaW9uIDU5MTUwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9hbmRyb2lk L0ZpbGVTeXN0ZW1BbmRyb2lkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzUsMjAgKzc1LDYgQEAg Ym9vbCB1bmxvYWRNb2R1bGUoUGxhdGZvcm1Nb2R1bGUgbW9kdWxlKQogICAgIHJldHVybiAhZGxj bG9zZShtb2R1bGUpOwogfQogCi1pbnQgd3JpdGVUb0ZpbGUoUGxhdGZvcm1GaWxlSGFuZGxlIGhh bmRsZSwgY29uc3QgY2hhciogZGF0YSwgaW50IGxlbmd0aCkKLXsKLSAgICBpbnQgdG90YWxCeXRl c1dyaXR0ZW4gPSAwOwotICAgIHdoaWxlICh0b3RhbEJ5dGVzV3JpdHRlbiA8IGxlbmd0aCkgewot ICAgICAgICBpbnQgYnl0ZXNXcml0dGVuID0gd3JpdGUoaGFuZGxlLCBkYXRhLCAoc2l6ZV90KShs ZW5ndGggLSB0b3RhbEJ5dGVzV3JpdHRlbikpOwotICAgICAgICBpZiAoYnl0ZXNXcml0dGVuIDwg MCAmJiBlcnJubyAhPSBFSU5UUikKLSAgICAgICAgICAgIHJldHVybiAtMTsKLSAgICAgICAgaWYg KGJ5dGVzV3JpdHRlbiA+IDApCi0gICAgICAgICAgICB0b3RhbEJ5dGVzV3JpdHRlbiArPSBieXRl c1dyaXR0ZW47Ci0gICAgfQotCi0gICAgcmV0dXJuIHRvdGFsQnl0ZXNXcml0dGVuOwotfQotCiBT dHJpbmcgaG9tZURpcmVjdG9yeVBhdGgoKSAKIHsKICAgICByZXR1cm4gc1BsdWdpblBhdGg7Cklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9wb3NpeC9GaWxlU3lzdGVtUE9TSVguY3BwCShyZXZpc2lv biA1OTE1MCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vcG9zaXgvRmlsZVN5c3RlbVBPU0lYLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTEwLDcgKzExMCw2IEBAIGJvb2wgdHJ1bmNhdGVGaWxlKFBsYXRm b3JtRmlsZUhhbmRsZSBoYW4KICAgICByZXR1cm4gIWZ0cnVuY2F0ZShoYW5kbGUsIG9mZnNldCk7 CiB9CiAKLSNpZiAhUExBVEZPUk0oQU5EUk9JRCkKIGludCB3cml0ZVRvRmlsZShQbGF0Zm9ybUZp bGVIYW5kbGUgaGFuZGxlLCBjb25zdCBjaGFyKiBkYXRhLCBpbnQgbGVuZ3RoKQogewogICAgIGRv IHsKQEAgLTEyMCw3ICsxMTksNiBAQCBpbnQgd3JpdGVUb0ZpbGUoUGxhdGZvcm1GaWxlSGFuZGxl IGhhbmRsCiAgICAgfSB3aGlsZSAoZXJybm8gPT0gRUlOVFIpOwogICAgIHJldHVybiAtMTsKIH0K LSNlbmRpZgogCiBpbnQgcmVhZEZyb21GaWxlKFBsYXRmb3JtRmlsZUhhbmRsZSBoYW5kbGUsIGNo YXIqIGRhdGEsIGludCBsZW5ndGgpCiB7Cg==