38904 2010-05-11 06:27:57 -0700 Fix ScrollbarEfl build 2010-05-12 02:12:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 lucas.de.marchi webkit-unassigned barbieri commit-queue oldest_to_newest 223893 0 lucas.de.marchi 2010-05-11 06:27:57 -0700 ScrollbarEfl.cpp can't be compiled with GCC 4.5. Use ScrollbarEfl instead of ScrollbarEfl::ScrollbarEfl. Attached patch fixes this. 223895 1 55697 lucas.de.marchi 2010-05-11 06:31:08 -0700 Created attachment 55697 Fix ScrollbarEfl 223908 2 55697 jorlow 2010-05-11 07:10:37 -0700 Comment on attachment 55697 Fix ScrollbarEfl r=me WebCore/platform/efl/ScrollbarEfl.cpp:68 + ScrollbarEfl* that = static_cast<ScrollbarEfl*>(data); This is a poor name, but you didn't make it any worse and this is a build fix so.... 224481 3 55697 commit-queue 2010-05-12 02:12:50 -0700 Comment on attachment 55697 Fix ScrollbarEfl Clearing flags on attachment: 55697 Committed r59218: <http://trac.webkit.org/changeset/59218> 224482 4 commit-queue 2010-05-12 02:12:55 -0700 All reviewed patches have been landed. Closing bug. 55697 2010-05-11 06:31:08 -0700 2010-05-12 02:12:50 -0700 Fix ScrollbarEfl scrollbarefl-fix.patch text/plain 1342 lucas.de.marchi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTE0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDUtMTEgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFy Y2hpQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtFRkxdIEl0IGRvZXMgbm90IG1ha2Ugc2Vuc2UgdG8gdXNlIFNjcm9sbGJh ckVmbDo6U2Nyb2xsYmFyRWZsLCBzbworICAgICAgICB1c2UgU2Nyb2xsYmFyRWZsIChHQ0MgNC41 IHNlZW1zIHRvIGJlIHBpY2tpZXIgYWJvdXQgdGhpcykuIFJldmlzaW9uIDU5MDMwCisgICAgICAg IGZpeGVkIGNhc2VzIGZvciBSZW5kZXJUaGVtZUVmbCwgYnV0IG1pc3NlZCB0aGlzIGZvciBTY3Jv bGxiYXJFZmwuCisgICAgICAgIGh0dHA6Ly93ZWJraXQub3JnL2IvMzg5MDQKKworICAgICAgICBO byBuZXcgdGVzdHMgcmVxdWlyZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvU2Nyb2xsYmFy RWZsLmNwcDoKKyAgICAgICAgKHNjcm9sbGJhckVmbEVkamVNZXNzYWdlKToKKwogMjAxMC0wNS0x MSAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERpcmsgU2NodWx6ZS4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJh ckVmbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZs LmNwcAkocmV2aXNpb24gNTkxNDcpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJF ZmwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NSw3ICs2NSw3IEBAIFNjcm9sbGJhckVmbDo6flNj cm9sbGJhckVmbCgpCiAKIHN0YXRpYyB2b2lkIHNjcm9sbGJhckVmbEVkamVNZXNzYWdlKHZvaWQq IGRhdGEsIEV2YXNfT2JqZWN0KiBvLCBFZGplX01lc3NhZ2VfVHlwZSB0eXBlLCBpbnQgaWQsIHZv aWQqIG1zZykKIHsKLSAgICBTY3JvbGxiYXJFZmw6OlNjcm9sbGJhckVmbCogdGhhdCA9IHN0YXRp Y19jYXN0PFNjcm9sbGJhckVmbDo6U2Nyb2xsYmFyRWZsKj4oZGF0YSk7CisgICAgU2Nyb2xsYmFy RWZsKiB0aGF0ID0gc3RhdGljX2Nhc3Q8U2Nyb2xsYmFyRWZsKj4oZGF0YSk7CiAgICAgRWRqZV9N ZXNzYWdlX0Zsb2F0KiBtOwogICAgIGludCB2OwogCg==