38897 2010-05-11 04:13:50 -0700 Fix guard around DatabaseSync 2010-05-21 05:19:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joybro201 webkit-unassigned commit-queue skyul oldest_to_newest 223861 0 joybro201 2010-05-11 04:13:50 -0700 The closing guard must be below the namespace brace. 223863 1 55688 joybro201 2010-05-11 04:20:28 -0700 Created attachment 55688 Patch 223865 2 55688 dumi 2010-05-11 04:25:22 -0700 Comment on attachment 55688 Patch > Index: WebCore/storage/DatabaseSync.cpp > =================================================================== > --- WebCore/storage/DatabaseSync.cpp (revision 59147) > +++ WebCore/storage/DatabaseSync.cpp (working copy) > @@ -107,6 +107,7 @@ ScriptExecutionContext* DatabaseSync::sc > return m_scriptExecutionContext.get(); > } > > +} // namespace WebCore > + > #endif // ENABLE(DATABASE) > > -} // namespace WebCore oops... thanks for noticing this. lgtm, fwiw. 226608 3 skyul 2010-05-16 21:16:55 -0700 > oops... thanks for noticing this. lgtm, fwiw. Ping. review+ and commit-queue+ please. 228250 4 55688 eric 2010-05-20 01:05:52 -0700 Comment on attachment 55688 Patch LGTM. 228866 5 55688 commit-queue 2010-05-21 05:19:16 -0700 Comment on attachment 55688 Patch Clearing flags on attachment: 55688 Committed r59927: <http://trac.webkit.org/changeset/59927> 228867 6 commit-queue 2010-05-21 05:19:21 -0700 All reviewed patches have been landed. Closing bug. 55688 2010-05-11 04:20:28 -0700 2010-05-21 05:19:16 -0700 Patch patch_for_38897 text/plain 906 joybro201 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTE0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMDUtMTEgIFlvdW5nIEhhbiBMZWUgIDxqb3licm9AY29tcGFu eTEwMC5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRml4IGd1YXJkIGFyb3VuZCBEYXRhYmFzZVN5bmMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4ODk3CisKKyAgICAgICAgKiBzdG9yYWdlL0RhdGFi YXNlU3luYy5jcHA6CisKIDIwMTAtMDUtMTEgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFNjaHVsemUuCkluZGV4OiBXZWJD b3JlL3N0b3JhZ2UvRGF0YWJhc2VTeW5jLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3N0b3Jh Z2UvRGF0YWJhc2VTeW5jLmNwcAkocmV2aXNpb24gNTkxNDcpCisrKyBXZWJDb3JlL3N0b3JhZ2Uv RGF0YWJhc2VTeW5jLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA3LDYgKzEwNyw3IEBAIFNjcmlw dEV4ZWN1dGlvbkNvbnRleHQqIERhdGFiYXNlU3luYzo6c2MKICAgICByZXR1cm4gbV9zY3JpcHRF eGVjdXRpb25Db250ZXh0LmdldCgpOwogfQogCit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCisKICNl bmRpZiAvLyBFTkFCTEUoREFUQUJBU0UpCiAKLX0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK