38894 2010-05-11 01:50:28 -0700 [chromium] Remove subframe scrollbar routing (r58937) 2010-05-11 21:30:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony webkit-unassigned abarth eric fishd tonikitoo webkit.review.bot oldest_to_newest 223818 0 tony 2010-05-11 01:50:28 -0700 [chromium] Remove subframe scrollbar routing (r58937) 223819 1 55677 tony 2010-05-11 01:50:58 -0700 Created attachment 55677 Patch 223822 2 tony 2010-05-11 01:53:25 -0700 This is basically a revert of r58937, but it keeps the test. It also runs the test on windows because the test should pass there. This makes Chromium behave like Safari Win and QT in how events to subframe scrollbars are routed. 223909 3 tonikitoo 2010-05-11 07:12:00 -0700 LTGM, thank you Tony. Also there is a few more open issues regarding hittesting or general event handling involving scrollbars. I raised discussion in this thread: http://permalink.gmane.org/gmane.os.opendarwin.webkit.devel/12725 ... feel free to join. 224373 4 55677 tony 2010-05-11 20:53:43 -0700 Comment on attachment 55677 Patch Clearing flags on attachment: 55677 Committed r59203: <http://trac.webkit.org/changeset/59203> 224374 5 tony 2010-05-11 20:53:50 -0700 All reviewed patches have been landed. Closing bug. 224385 6 webkit.review.bot 2010-05-11 21:30:07 -0700 http://trac.webkit.org/changeset/59203 might have broken Qt Linux Release minimal The following changes are on the blame list: http://trac.webkit.org/changeset/59202 http://trac.webkit.org/changeset/59203 55677 2010-05-11 01:50:58 -0700 2010-05-11 20:53:43 -0700 Patch bug-38894-20100511015057.patch text/plain 4174 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2MDZhZWVmNzNlZjY0M2NlYTIzOTA0MDUyMTQ5Y2Q3MWMyMzM2NDgxLi42ODllYzNk MzhmNTVmYjQ5ZTNiZjdlYWRiNmNjODhkMzhiYTNlMGNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDUtMTEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIFJlbW92ZSBz dWJmcmFtZSBzY3JvbGxiYXIgcm91dGluZyAocjU4OTM3KQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg4OTQKKworICAgICAgICAqIHBsYXRmb3JtL3dp bi9Ta2lwcGVkOiBUaGlzIHRlc3Qgc2hvdWxkIHBhc3Mgb24gd2luZG93cy4KKwogMjAxMC0wNS0x MSAgSm9obiBHcmVnZyAgPGpvaG5ueWdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1d IFVwZGF0ZSB3aW4tdmlzdGEgdmVyc2lvbiBvZiB0aGUgYmFzZWxpbmUgcmVjZW50bHkgdXBkYXRl ZCBmb3Igd2luLXhwLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBw ZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBlZAppbmRleCA5MmVlNjg0MTIyMjY2 NzE1Nzk4NDU5ZDE5NzhhYzhlMGE3MzhmMTQ1Li4xZjQ2YjVjYjhiNzMyMGIyNzFkODY4MjVkNDYx ODY5YzFkYzFjNTcwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBl ZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBlZApAQCAtODY2LDkgKzg2Niw2 IEBAIGZhc3QvanMvc3B1dG5pawogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzgzNzYKIG1lZGlhL21lZGlhLWRvY3VtZW50LWF1ZGlvLXNpemUuaHRtbAogCi0jIE5l ZWRzIHNwZWNpYWwgaGFuZGxpbmcgb2YgbW91c2VQcmVzcyBpbiBzdWJmcmFtZXMuIFNlZSBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAyMzYKLWZhc3QvZXZlbnRzL21v dXNlZG93bi1pbi1zdWJmcmFtZS1zY3JvbGxiYXIuaHRtbAotCiAjIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODc5NCAtIGNvbnRhaW5zIGFuIEFMRVJUIG1lc3NhZ2Us IGluZGljYXRpbmcgYSBmYWlsdXJlCiBmYXN0L2Nzcy9kaXNwbGF5LW5vbmUtaW5saW5lLXN0eWxl LWNoYW5nZS1jcmFzaC5odG1sCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggNWZlNzAwNjcyNzk4ZGI1MmFkNmFiZDcxMjYwNzIzNTc1Y2E4 YWEyZS4uOWRlZWE5NmJmZjY4NGJlNjUxYTZjODdiOTE0NzA2Y2VlODAxMWRkNSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx MyBAQAorMjAxMC0wNS0xMSAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVt b3ZlIHN1YmZyYW1lIHNjcm9sbGJhciByb3V0aW5nIChyNTg5MzcpCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODg5NAorCisgICAgICAgICogcGFnZS9j aHJvbWl1bS9FdmVudEhhbmRsZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVu dEhhbmRsZXI6OnBhc3NNb3VzZVByZXNzRXZlbnRUb1N1YmZyYW1lKToKKwogMjAxMC0wNS0xMCAg U2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggYXNz ZXJ0aW5nIEdUSyBidWlsZC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9jaHJvbWl1bS9FdmVu dEhhbmRsZXJDaHJvbWl1bS5jcHAgYi9XZWJDb3JlL3BhZ2UvY2hyb21pdW0vRXZlbnRIYW5kbGVy Q2hyb21pdW0uY3BwCmluZGV4IGJmOWFjYjcyY2RjZDQ0ZGMyYmRhYjc2NjFjNzc0NWVjN2UzYTFm Y2IuLmZmMTYxYWY0YjU0NTQ3ZjQzMTgzYmRkNDBmYWFiYzZhNTY5MTBmYzUgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGFnZS9jaHJvbWl1bS9FdmVudEhhbmRsZXJDaHJvbWl1bS5jcHAKKysrIGIvV2Vi Q29yZS9wYWdlL2Nocm9taXVtL0V2ZW50SGFuZGxlckNocm9taXVtLmNwcApAQCAtNTQsMTIgKzU0 LDExIEBAIGNvbnN0IGRvdWJsZSBFdmVudEhhbmRsZXI6OlRleHREcmFnRGVsYXkgPSAwLjA7CiAK IGJvb2wgRXZlbnRIYW5kbGVyOjpwYXNzTW91c2VQcmVzc0V2ZW50VG9TdWJmcmFtZShNb3VzZUV2 ZW50V2l0aEhpdFRlc3RSZXN1bHRzJiBtZXYsIEZyYW1lKiBzdWJmcmFtZSkKIHsKLSAgICBjb25z dCBQbGF0Zm9ybU1vdXNlRXZlbnQmIG1vdXNlRXZlbnQgPSBtZXYuZXZlbnQoKTsKICAgICAvLyBJ ZiB3ZSdyZSBjbGlja2luZyBpbnRvIGEgZnJhbWUgdGhhdCBpcyBzZWxlY3RlZCwgdGhlIGZyYW1l IHdpbGwgYXBwZWFyCiAgICAgLy8gZ3JleWVkIG91dCBldmVuIHRob3VnaCB3ZSdyZSBjbGlja2lu ZyBvbiB0aGUgc2VsZWN0aW9uLiAgVGhpcyBsb29rcwogICAgIC8vIHJlYWxseSBzdHJhbmdlICho YXZpbmcgdGhlIHdob2xlIGZyYW1lIGJlIGdyZXllZCBvdXQpLCBzbyB3ZSBkZXNlbGVjdCB0aGUK ICAgICAvLyBzZWxlY3Rpb24uCi0gICAgSW50UG9pbnQgcCA9IG1fZnJhbWUtPnZpZXcoKS0+d2lu ZG93VG9Db250ZW50cyhtb3VzZUV2ZW50LnBvcygpKTsKKyAgICBJbnRQb2ludCBwID0gbV9mcmFt ZS0+dmlldygpLT53aW5kb3dUb0NvbnRlbnRzKG1ldi5ldmVudCgpLnBvcygpKTsKICAgICBpZiAo bV9mcmFtZS0+c2VsZWN0aW9uKCktPmNvbnRhaW5zKHApKSB7CiAgICAgICAgIFZpc2libGVQb3Np dGlvbiB2aXNpYmxlUG9zKAogICAgICAgICAgICAgbWV2LnRhcmdldE5vZGUoKS0+cmVuZGVyZXIo KS0+cG9zaXRpb25Gb3JQb2ludChtZXYubG9jYWxQb2ludCgpKSk7CkBAIC02OCwxOSArNjcsNyBA QCBib29sIEV2ZW50SGFuZGxlcjo6cGFzc01vdXNlUHJlc3NFdmVudFRvU3ViZnJhbWUoTW91c2VF dmVudFdpdGhIaXRUZXN0UmVzdWx0cyYgbQogICAgICAgICAgICAgbV9mcmFtZS0+c2VsZWN0aW9u KCktPnNldFNlbGVjdGlvbihuZXdTZWxlY3Rpb24pOwogICAgIH0KIAotICAgIC8vIElmIHRoZSBj bGljayBoaXRzIGEgc2Nyb2xsYmFyLCB3ZSBwYXNzIHRoZSBtb3VzZSBwcmVzcyBldmVudCB0byB0 aGUKLSAgICAvLyBzY3JvbGxiYXIgZGlyZWN0bHkuICBUaGlzIHByZXZlbnRzIHNlbGVjdGVkIHRl eHQgZnJvbSBiZWluZyB1bnNlbGVjdGVkLgotICAgIC8vIFRoaXMgbWF0Y2hlcyB0aGUgV2ViS2l0 IG1hYyBjb2RlIHdoaWNoIHBhc3NlcyB0aGUgbW91c2UgcHJlc3MgZXZlbnQKLSAgICAvLyB0byBh biBOU1Njcm9sbGVyLgotICAgIEZyYW1lVmlldyogdmlldyA9IHN1YmZyYW1lLT52aWV3KCk7Ci0g ICAgU2Nyb2xsYmFyKiBzY3JvbGxiYXIgPSB2aWV3ID8gdmlldy0+c2Nyb2xsYmFyQXRQb2ludCht b3VzZUV2ZW50LnBvcygpKSA6IDA7Ci0gICAgaWYgKHNjcm9sbGJhcikgewotICAgICAgICBIaXRU ZXN0UmVxdWVzdCByZXF1ZXN0KEhpdFRlc3RSZXF1ZXN0OjpBY3RpdmUpOwotICAgICAgICBJbnRQ b2ludCBkb2N1bWVudFBvaW50ID0gdmlldy0+d2luZG93VG9Db250ZW50cyhtb3VzZUV2ZW50LnBv cygpKTsKLSAgICAgICAgTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyBzdWJmcmFtZU1vdXNl RXZlbnQgPSBzdWJmcmFtZS0+ZG9jdW1lbnQoKS0+cHJlcGFyZU1vdXNlRXZlbnQocmVxdWVzdCwg ZG9jdW1lbnRQb2ludCwgbW91c2VFdmVudCk7Ci0gICAgICAgIHN1YmZyYW1lLT5ldmVudEhhbmRs ZXIoKS0+cGFzc01vdXNlUHJlc3NFdmVudFRvU2Nyb2xsYmFyKHN1YmZyYW1lTW91c2VFdmVudCwg c2Nyb2xsYmFyKTsKLSAgICB9IGVsc2UKLSAgICAgICAgc3ViZnJhbWUtPmV2ZW50SGFuZGxlcigp LT5oYW5kbGVNb3VzZVByZXNzRXZlbnQobW91c2VFdmVudCk7CisgICAgc3ViZnJhbWUtPmV2ZW50 SGFuZGxlcigpLT5oYW5kbGVNb3VzZVByZXNzRXZlbnQobWV2LmV2ZW50KCkpOwogICAgIHJldHVy biB0cnVlOwogfQogCg==