38873 2010-05-10 15:41:34 -0700 [V8] Fix V8 code generator script to generate the correct code for converting ScriptString 2010-05-10 16:39:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jianli jianli abarth oldest_to_newest 223545 0 jianli 2010-05-10 15:41:34 -0700 This is caused by r58921 which I introduced the wrong V8 generator code. 223549 1 55613 jianli 2010-05-10 15:46:47 -0700 Created attachment 55613 Proposed Patch 223555 2 55613 abarth 2010-05-10 15:51:16 -0700 Comment on attachment 55613 Proposed Patch WebCore/bindings/scripts/CodeGeneratorV8.pm:  + return "v8StringOrNull(exec, $value)" if $conv; Oh, sorry. I should have caught that in review. :( 223582 3 jianli 2010-05-10 16:39:06 -0700 Committed as http://trac.webkit.org/changeset/59104. 55613 2010-05-10 15:46:47 -0700 2010-05-10 15:51:16 -0700 Proposed Patch 38873 text/plain 3520 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTZiMWNjYy4uMjRhMmY3MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wNS0xMCAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1Y4XSBGaXggVjggY29kZSBnZW5lcmF0b3Igc2NyaXB0IHRvIGdlbmVyYXRl IHRoZSBjb3JyZWN0IGNvZGUgZm9yCisgICAgICAgIGNvbnZlcnRpbmcgU2NyaXB0U3RyaW5nLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg4NzMKKwor ICAgICAgICBVcGRhdGVkIHRoZSBiaW5kaW5ncyB0ZXN0IHJlc3VsdC4gTm90ZSB0aGF0IHRoZSBy ZXN1bHQgaXMgYWxzbyB1cGRhdGVkCisgICAgICAgIHRvIHJlZmxlY3Qgb3RoZXIgc2NyaXB0IGdl bmVyYXRvciBjaGFuZ2VzIG5vdCBpbnRyb2R1Y2VkIGJ5IHRoaXMgcGF0Y2guCisKKyAgICAgICAg KiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAgKiBiaW5kaW5n cy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2FsbGJhY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SlNUZXN0Q2FsbGJhY2s6OkpTVGVzdENhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OkpTVGVz dENhbGxiYWNrOjp+SlNUZXN0Q2FsbGJhY2spOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv dGVzdC9KUy9KU1Rlc3RDYWxsYmFjay5oOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVz dC9WOC9WOFRlc3RPYmouY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGVzdE9iakludGVybmFsOjpz Y3JpcHRTdHJpbmdBdHRyQXR0ckdldHRlcik6CisKIDIwMTAtMDUtMTAgIEFsZXhleSBQcm9za3Vy eWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBt IGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCA5NTUz YjhiLi44ZWMwOTgxIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvclY4LnBtCisrKyBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y VjgucG0KQEAgLTMwNjcsNyArMzA2Nyw3IEBAIHN1YiBSZXR1cm5OYXRpdmVUb0pTVmFsdWUKICAg ICAgICAgICAgIGRpZSAiVW5rbm93biB2YWx1ZSBmb3IgQ29udmVydE51bGxTdHJpbmdUbyBleHRl bmRlZCBhdHRyaWJ1dGUiOwogICAgICAgICB9CiAgICAgICAgICRjb252ID0gJHNpZ25hdHVyZS0+ ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkNvbnZlcnRTY3JpcHRTdHJpbmcifTsKLSAgICAgICAgcmV0 dXJuICJ2OFN0cmluZ09yTnVsbChleGVjLCAkdmFsdWUpIiBpZiAkY29udjsKKyAgICAgICAgcmV0 dXJuICJyZXR1cm4gdjhTdHJpbmdPck51bGwoJHZhbHVlKSIgaWYgJGNvbnY7CiAgICAgICAgIHJl dHVybiAicmV0dXJuIHY4U3RyaW5nKCR2YWx1ZSkiOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2FsbGJhY2suY3BwIGIvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2FsbGJhY2suY3BwCmluZGV4IDJkMGNm YWUuLmRmNDAzYzYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pT L0pTVGVzdENhbGxiYWNrLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9K Uy9KU1Rlc3RDYWxsYmFjay5jcHAKQEAgLTM3LDEyICszNywxMyBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiBKU1Rlc3RDYWxsYmFjazo6SlNUZXN0Q2FsbGJhY2soSlNPYmplY3QqIGNhbGxiYWNrLCBK U0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0KQogICAgIDogbV9kYXRhKG5ldyBKU0NhbGxi YWNrRGF0YShjYWxsYmFjaywgZ2xvYmFsT2JqZWN0KSkKICAgICAsIG1faXNvbGF0ZWRXb3JsZChn bG9iYWxPYmplY3QtPndvcmxkKCkpCisgICAgLCBtX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQoZ2xv YmFsT2JqZWN0LT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpCiB7CiB9CiAKIEpTVGVzdENhbGxi YWNrOjp+SlNUZXN0Q2FsbGJhY2soKQogewotICAgIGNhbGxPbk1haW5UaHJlYWQoSlNDYWxsYmFj a0RhdGE6OmRlbGV0ZURhdGEsIG1fZGF0YSk7CisgICAgbV9zY3JpcHRFeGVjdXRpb25Db250ZXh0 LT5wb3N0VGFzayhEZWxldGVDYWxsYmFja0RhdGFUYXNrOjpjcmVhdGUobV9kYXRhKSk7CiAjaWZu ZGVmIE5ERUJVRwogICAgIG1fZGF0YSA9IDA7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdENhbGxiYWNrLmggYi9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RDYWxsYmFjay5oCmluZGV4IDZlOGYwODMuLjQ3YTVl OTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdENh bGxiYWNrLmgKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2Fs bGJhY2suaApAQCAtNDksNiArNDksNyBAQCBwcml2YXRlOgogCiAgICAgSlNDYWxsYmFja0RhdGEq IG1fZGF0YTsKICAgICBSZWZQdHI8RE9NV3JhcHBlcldvcmxkPiBtX2lzb2xhdGVkV29ybGQ7Cisg ICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogbV9zY3JpcHRFeGVjdXRpb25Db250ZXh0OwogfTsK IAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmNwcCBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L1Y4L1Y4VGVzdE9iai5jcHAKaW5kZXggOTRkY2Q1ZS4uMjJjYmFhNSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmNwcAorKysgYi9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPYmouY3BwCkBAIC0yMDMsNyArMjAz LDcgQEAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBzY3JpcHRTdHJpbmdBdHRyQXR0ckdl dHRlcih2ODo6TG9jYWw8djg6OlN0cmluZz4gbmEKIHsKICAgICBJTkNfU1RBVFMoIkRPTS5UZXN0 T2JqLnNjcmlwdFN0cmluZ0F0dHIuX2dldCIpOwogICAgIFRlc3RPYmoqIGltcCA9IFY4VGVzdE9i ajo6dG9OYXRpdmUoaW5mby5Ib2xkZXIoKSk7Ci0gICAgdjhTdHJpbmdPck51bGwoZXhlYywgaW1w LT5zY3JpcHRTdHJpbmdBdHRyKCkpOworICAgIHJldHVybiB2OFN0cmluZ09yTnVsbChpbXAtPnNj cmlwdFN0cmluZ0F0dHIoKSk7CiB9CiAKIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdm9p ZE1ldGhvZENhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCg==