38869 2010-05-10 14:49:29 -0700 [Chromium] Chromium's SQLite VFS implementation on Linux doesn't need a dir fd 2010-05-12 14:52:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 dumi dumi dglazkov michaeln oldest_to_newest 223526 0 dumi 2010-05-10 14:49:29 -0700 SQLite's default VFS implementation on POSIX systems stores the file descriptor of the directory where all DB files are stored. SQLite uses dirfd to sync the DB files if it is compiled with -DSQLITE_NO_SYNC. Chromium compiles its SQLite library without -DSQLITE_NO_SYNC. Therefore, storing the dirfd is unnecessary and can actually be a security problem. We should clean up that code. 223689 1 55647 dumi 2010-05-10 19:31:10 -0700 Created attachment 55647 patch 224858 2 55647 dglazkov 2010-05-12 13:46:06 -0700 Comment on attachment 55647 patch ok. 224920 3 dumi 2010-05-12 14:52:49 -0700 Landed as r59273. 55647 2010-05-10 19:31:10 -0700 2010-05-12 13:46:06 -0700 patch patch text/plain 5798 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTExOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMTAgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmluZyB0aGUgdW5uZWNlc3NhcnkgZGlyZmQgcGFyYW1ldGVyLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg4NjkKKworICAgICAgICAqIHBs YXRmb3JtL2Nocm9taXVtL0Nocm9taXVtQnJpZGdlLmg6CisgICAgICAgICogcGxhdGZvcm0vc3Fs L2Nocm9taXVtL1NRTGl0ZUZpbGVTeXN0ZW1DaHJvbWl1bVBvc2l4LmNwcDoKKwogMjAxMC0wNS0x MCAgRHVtaXRydSBEYW5pbGl1YyAgPGR1bWlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEJyYWR5IEVpZHNvbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hy b21pdW1CcmlkZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0No cm9taXVtQnJpZGdlLmgJKHJldmlzaW9uIDU5MTE4KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9DaHJvbWl1bUJyaWRnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzQsNyArMTM0LDcgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAvLyBIVE1MNSBEQiAtLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogI2lmIEVOQUJMRShE QVRBQkFTRSkKICAgICAgICAgLy8gUmV0dXJucyBhIGhhbmRsZSB0byB0aGUgREIgZmlsZSBhbmQg b29wdGlvbmFsbHkgYSBoYW5kbGUgdG8gaXRzIGNvbnRhaW5pbmcgZGlyZWN0b3J5Ci0gICAgICAg IHN0YXRpYyBQbGF0Zm9ybUZpbGVIYW5kbGUgZGF0YWJhc2VPcGVuRmlsZShjb25zdCBTdHJpbmcm IHZmc0ZsZU5hbWUsIGludCBkZXNpcmVkRmxhZ3MsIFBsYXRmb3JtRmlsZUhhbmRsZSogZGlySGFu ZGxlID0gMCk7CisgICAgICAgIHN0YXRpYyBQbGF0Zm9ybUZpbGVIYW5kbGUgZGF0YWJhc2VPcGVu RmlsZShjb25zdCBTdHJpbmcmIHZmc0ZsZU5hbWUsIGludCBkZXNpcmVkRmxhZ3MpOwogICAgICAg ICAvLyBSZXR1cm5zIGEgU1FMaXRlIGNvZGUgKFNRTElURV9PSyA9IDAsIG9uIHN1Y2Nlc3MpCiAg ICAgICAgIHN0YXRpYyBpbnQgZGF0YWJhc2VEZWxldGVGaWxlKGNvbnN0IFN0cmluZyYgdmZzRmls ZU5hbWUsIGJvb2wgc3luY0RpciA9IGZhbHNlKTsKICAgICAgICAgLy8gUmV0dXJucyB0aGUgYXR0 cmlidXRlcyBvZiB0aGUgREIgZmlsZQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9zcWwvY2hyb21p dW0vU1FMaXRlRmlsZVN5c3RlbUNocm9taXVtUG9zaXguY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vc3FsL2Nocm9taXVtL1NRTGl0ZUZpbGVTeXN0ZW1DaHJvbWl1bVBvc2l4LmNw cAkocmV2aXNpb24gNTkxMTgpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3NxbC9jaHJvbWl1bS9TUUxp dGVGaWxlU3lzdGVtQ2hyb21pdW1Qb3NpeC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY0LDE2ICs2 NCwxNSBAQCBpbnQgY2hyb21pdW1PcGVuKHNxbGl0ZTNfdmZzKiB2ZnMsIGNvbnN0CiB7CiAgICAg Y2hyb21pdW1fc3FsaXRlM19pbml0aWFsaXplX3VuaXhfc3FsaXRlM19maWxlKGlkKTsKICAgICBp bnQgZmQgPSAtMTsKLSAgICBpbnQgZGlyZmQgPSAtMTsKICAgICBpbnQgcmVzdWx0ID0gY2hyb21p dW1fc3FsaXRlM19nZXRfcmV1c2FibGVfZmlsZV9oYW5kbGUoaWQsIGZpbGVOYW1lLCBkZXNpcmVk RmxhZ3MsICZmZCk7CiAgICAgaWYgKHJlc3VsdCAhPSBTUUxJVEVfT0spCiAgICAgICAgIHJldHVy biByZXN1bHQ7CiAKICAgICBpZiAoZmQgPCAwKSB7Ci0gICAgICAgIGZkID0gQ2hyb21pdW1Ccmlk Z2U6OmRhdGFiYXNlT3BlbkZpbGUoZmlsZU5hbWUsIGRlc2lyZWRGbGFncywgJmRpcmZkKTsKKyAg ICAgICAgZmQgPSBDaHJvbWl1bUJyaWRnZTo6ZGF0YWJhc2VPcGVuRmlsZShmaWxlTmFtZSwgZGVz aXJlZEZsYWdzKTsKICAgICAgICAgaWYgKChmZCA8IDApICYmIChkZXNpcmVkRmxhZ3MgJiBTUUxJ VEVfT1BFTl9SRUFEV1JJVEUpKSB7CiAgICAgICAgICAgICBpbnQgbmV3RmxhZ3MgPSAoZGVzaXJl ZEZsYWdzICYgfihTUUxJVEVfT1BFTl9SRUFEV1JJVEUgfCBTUUxJVEVfT1BFTl9DUkVBVEUpKSB8 IFNRTElURV9PUEVOX1JFQURPTkxZOwotICAgICAgICAgICAgZmQgPSBDaHJvbWl1bUJyaWRnZTo6 ZGF0YWJhc2VPcGVuRmlsZShmaWxlTmFtZSwgbmV3RmxhZ3MsICZkaXJmZCk7CisgICAgICAgICAg ICBmZCA9IENocm9taXVtQnJpZGdlOjpkYXRhYmFzZU9wZW5GaWxlKGZpbGVOYW1lLCBuZXdGbGFn cyk7CiAgICAgICAgIH0KICAgICB9CiAgICAgaWYgKGZkIDwgMCkgewpAQCAtODYsMTMgKzg1LDEx IEBAIGludCBjaHJvbWl1bU9wZW4oc3FsaXRlM192ZnMqIHZmcywgY29uc3QKICAgICBjaHJvbWl1 bV9zcWxpdGUzX3VwZGF0ZV9yZXVzYWJsZV9maWxlX2hhbmRsZShpZCwgZmQsIGRlc2lyZWRGbGFn cyk7CiAKICAgICBmY250bChmZCwgRl9TRVRGRCwgZmNudGwoZmQsIEZfR0VURkQpIHwgRkRfQ0xP RVhFQyk7Ci0gICAgaWYgKGRpcmZkID49IDApCi0gICAgICAgIGZjbnRsKGRpcmZkLCBGX1NFVEZE LCBmY250bChmZCwgRl9HRVRGRCkgfCBGRF9DTE9FWEVDKTsKIAogICAgIC8vIFRoZSBtYXNrIDB4 MDAwMDdGMDAgZ2l2ZXMgdXMgdGhlIDcgYml0cyB0aGF0IGRldGVybWluZSB0aGUgdHlwZSBvZiB0 aGUgZmlsZSBTUUxpdGUgaXMgdHJ5aW5nIHRvIG9wZW4uCiAgICAgaW50IGZpbGVUeXBlID0gZGVz aXJlZEZsYWdzICYgMHgwMDAwN0YwMDsKICAgICBpbnQgbm9Mb2NrID0gKGZpbGVUeXBlICE9IFNR TElURV9PUEVOX01BSU5fREIpOwotICAgIHJlc3VsdCA9IGNocm9taXVtX3NxbGl0ZTNfZmlsbF9p bl91bml4X3NxbGl0ZTNfZmlsZSh2ZnMsIGZkLCBkaXJmZCwgaWQsIGZpbGVOYW1lLCBub0xvY2sp OworICAgIHJlc3VsdCA9IGNocm9taXVtX3NxbGl0ZTNfZmlsbF9pbl91bml4X3NxbGl0ZTNfZmls ZSh2ZnMsIGZkLCAtMSwgaWQsIGZpbGVOYW1lLCBub0xvY2spOwogICAgIGlmIChyZXN1bHQgIT0g U1FMSVRFX09LKQogICAgICAgICBjaHJvbWl1bV9zcWxpdGUzX2Rlc3Ryb3lfcmV1c2FibGVfZmls ZV9oYW5kbGUoaWQpOwogICAgIHJldHVybiByZXN1bHQ7CkluZGV4OiBXZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlz aW9uIDU5MTE4KQorKysgV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDEwLTA1LTEwICBEdW1pdHJ1IERhbmlsaXVjICA8ZHVtaUBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZpbmcgdGhlIHVubmVjZXNzYXJ5IGRpcmZkIHBhcmFtZXRlci4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4ODY5CisKKyAgICAgICAgKiBw dWJsaWMvV2ViS2l0Q2xpZW50Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYktpdENsaWVudDo6ZGF0 YWJhc2VPcGVuRmlsZSk6CisgICAgICAgICogc3JjL0Nocm9taXVtQnJpZGdlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNocm9taXVtQnJpZGdlOjpkYXRhYmFzZU9wZW5GaWxlKToKKwogMjAxMC0w NS0xMCAgSm9obiBBYmQtRWwtTWFsZWsgIDxqYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhcmluIEZpc2hlci4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi S2l0Q2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXRD bGllbnQuaAkocmV2aXNpb24gNTkxMTgpCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktp dENsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzUsNyArMTM1LDcgQEAgcHVibGljOgogICAg IC8vIE9wZW5zIGEgZGF0YWJhc2UgZmlsZTsgZGlySGFuZGxlIHNob3VsZCBiZSAwIGlmIHRoZSBj YWxsZXIgZG9lcyBub3QgbmVlZAogICAgIC8vIGEgaGFuZGxlIHRvIHRoZSBkaXJlY3RvcnkgY29u dGFpbmluZyB0aGlzIGZpbGUKICAgICB2aXJ0dWFsIEZpbGVIYW5kbGUgZGF0YWJhc2VPcGVuRmls ZSgKLSAgICAgICAgY29uc3QgV2ViU3RyaW5nJiB2ZnNGaWxlTmFtZSwgaW50IGRlc2lyZWRGbGFn cywgRmlsZUhhbmRsZSogZGlySGFuZGxlKSB7IHJldHVybiBGaWxlSGFuZGxlKCk7IH0KKyAgICAg ICAgY29uc3QgV2ViU3RyaW5nJiB2ZnNGaWxlTmFtZSwgaW50IGRlc2lyZWRGbGFncykgeyByZXR1 cm4gRmlsZUhhbmRsZSgpOyB9CiAKICAgICAvLyBEZWxldGVzIGEgZGF0YWJhc2UgZmlsZSBhbmQg cmV0dXJucyB0aGUgZXJyb3IgY29kZQogICAgIHZpcnR1YWwgaW50IGRhdGFiYXNlRGVsZXRlRmls ZShjb25zdCBXZWJTdHJpbmcmIHZmc0ZpbGVOYW1lLCBib29sIHN5bmNEaXIpIHsgcmV0dXJuIDA7 IH0KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21pdW1CcmlkZ2UuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21pdW1CcmlkZ2UuY3BwCShyZXZpc2lvbiA1 OTExOCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21pdW1CcmlkZ2UuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC00MzIsOSArNDMyLDkgQEAgR2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdlKiBDaHJv bWl1bUJyaWRnZQogLy8gSFRNTDUgREIgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiAjaWYgRU5BQkxFKERBVEFCQVNF KQotUGxhdGZvcm1GaWxlSGFuZGxlIENocm9taXVtQnJpZGdlOjpkYXRhYmFzZU9wZW5GaWxlKGNv bnN0IFN0cmluZyYgdmZzRmlsZU5hbWUsIGludCBkZXNpcmVkRmxhZ3MsIFBsYXRmb3JtRmlsZUhh bmRsZSogZGlySGFuZGxlKQorUGxhdGZvcm1GaWxlSGFuZGxlIENocm9taXVtQnJpZGdlOjpkYXRh YmFzZU9wZW5GaWxlKGNvbnN0IFN0cmluZyYgdmZzRmlsZU5hbWUsIGludCBkZXNpcmVkRmxhZ3Mp CiB7Ci0gICAgcmV0dXJuIHdlYktpdENsaWVudCgpLT5kYXRhYmFzZU9wZW5GaWxlKFdlYlN0cmlu Zyh2ZnNGaWxlTmFtZSksIGRlc2lyZWRGbGFncywgZGlySGFuZGxlKTsKKyAgICByZXR1cm4gd2Vi S2l0Q2xpZW50KCktPmRhdGFiYXNlT3BlbkZpbGUoV2ViU3RyaW5nKHZmc0ZpbGVOYW1lKSwgZGVz aXJlZEZsYWdzKTsKIH0KIAogaW50IENocm9taXVtQnJpZGdlOjpkYXRhYmFzZURlbGV0ZUZpbGUo Y29uc3QgU3RyaW5nJiB2ZnNGaWxlTmFtZSwgYm9vbCBzeW5jRGlyKQo=