38866 2010-05-10 14:12:50 -0700 webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietveld ID 2010-05-12 16:55:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan webkit-unassigned abarth eric jparent oldest_to_newest 223508 0 ojan 2010-05-10 14:12:50 -0700 webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietveld ID 223509 1 55602 ojan 2010-05-10 14:16:25 -0700 Created attachment 55602 Patch 223510 2 ojan 2010-05-10 14:20:06 -0700 Julie is changing bugzilla to have a has_rietveld flag and to use the bugzilla ID as the rietveld issue ID. Once we have that, I'll update the upload script to set that bit on the uploaded attachment as well. Then all we'll need to get this all working is a bot that polls new patches and uploads them to rietveld. 224944 3 55602 abarth 2010-05-12 15:20:47 -0700 Comment on attachment 55602 Patch LGTM. I like this design better. 224981 4 ojan 2010-05-12 16:55:40 -0700 Committed r59284: <http://trac.webkit.org/changeset/59284> 55602 2010-05-10 14:16:25 -0700 2010-05-12 15:20:47 -0700 Patch bug-38866-20100510141624.patch text/plain 6606 ojan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2ZTBmMmI0NjcxMTQ5YmE1ODBkMTA1MTljNWViNGRhZTMwMTc0NGVlLi44YjU5NmQ4 NTNkMmMwZGY4NmE4YTllMTAzMDA3YzkxN2U0ZWY3MjEwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTAtMDUtMTAgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB3ZWJraXQtcGF0Y2ggdXBsb2Fk IC0tZmFuY3ktcmV2aWV3IG5vdyB1c2VzIHRoZSBidWd6aWxsYSBidWcgSUQgYXMgdGhlIHJpZXR2 ZWxkIElECisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z ODg2NgorCisgICAgICAgIHdrcmlldHZlbGQuYXBwc3BvdC5jb20gaGFzIGFscmVhZHkgYmVlbiB1 cGRhdGVkIHRvIGFsbG93IHlvdSB0bworICAgICAgICBwYXNzIC0taXNzdWUgZm9yIHRoZSBpc3N1 ZSBjcmVhdGlvbiBhcyB3ZWxsIGFzIHN1YnNlcXVlbnQgdXBsb2Fkcy4KKworICAgICAgICBBbHNv LCByZW1vdmUgdGhlIGV4dHJhIGNvZGUgZm9yIHRyeWluZyB0byByZWFkIG91dCB0aGUgaXNzdWUg SUQKKyAgICAgICAgZnJvbSB0aGUgY2hhbmdlbG9nIGRlc2NyaXB0aW9uIHNpbmNlIHdlIGp1c3Qg dXNlIHRoZSBidWd6aWxsYSBJRCBub3cuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jb25maWcvX19pbml0X18ucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21t b24vbmV0L3JpZXR2ZWxkLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVw cy9wb3N0Y29kZXJldmlldy5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3Rl cHMvcG9zdGRpZmYucHk6CisKIDIwMTAtMDUtMTAgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvX19pbml0X18ucHkg Yi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvX19pbml0X18ucHkK aW5kZXggMDNmMWJjN2Q3Njk4MGNhMWQxZTFhZWYyMGU1NzcxOGIwNTcxYjI1YS4uNjJkMTI5ZTBl NTBlZDY1MGM0NDAwMTJjZDYzMzg2MWQzOTRmZTk2OSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL19faW5pdF9fLnB5CisrKyBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9fX2luaXRfXy5weQpAQCAtMyw1ICsz LDQgQEAKIGltcG9ydCByZQogCiBjb2RlcmV2aWV3X3NlcnZlcl9ob3N0ID0gIndrcmlldHZlbGQu YXBwc3BvdC5jb20iCi1jb2RlcmV2aWV3X3NlcnZlcl9yZWdleCA9ICJodHRwcz86Ly8lcy8iICUg cmUuc3ViKCdcLicsICdcXC4nLCBjb2RlcmV2aWV3X3NlcnZlcl9ob3N0KQogY29kZXJldmlld19z ZXJ2ZXJfdXJsID0gImh0dHBzOi8vJXMvIiAlIGNvZGVyZXZpZXdfc2VydmVyX2hvc3QKZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9yaWV0dmVsZC5w eSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9yaWV0dmVsZC5weQpp bmRleCA5Y2M5N2YyOGVkMWFjMzg3YTNiNTA3ZmJjNTM5NjAzMjRjMjRjMDhjLi5jMGQ2MTE5NTlh MTg3NWY4M2UyYTExNjBmOGNiZGUwMWQ4YzVmMjA5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvcmlldHZlbGQucHkKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L3JpZXR2ZWxkLnB5CkBAIC0zNywxNiArMzcsNiBA QCBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZlIGltcG9ydCBTY3JpcHRFcnJv cgogaW1wb3J0IHdlYmtpdHB5LnRoaXJkcGFydHkuYXV0b2luc3RhbGxlZC5yaWV0dmVsZC51cGxv YWQgYXMgdXBsb2FkCiAKIAotZGVmIHBhcnNlX2NvZGVyZXZpZXdfaXNzdWUobWVzc2FnZSk6Ci0g ICAgaWYgbm90IG1lc3NhZ2U6Ci0gICAgICAgIHJldHVybiBOb25lCi0gICAgbWF0Y2ggPSByZS5z ZWFyY2goY29uZmlnLmNvZGVyZXZpZXdfc2VydmVyX3JlZ2V4ICsKLSAgICAgICAgICAgICAgICAg ICAgICAiKD9QPGNvZGVyZXZpZXdfaXNzdWU+XGQrKSIsCi0gICAgICAgICAgICAgICAgICAgICAg bWVzc2FnZSkKLSAgICBpZiBtYXRjaDoKLSAgICAgICAgcmV0dXJuIGludChtYXRjaC5ncm91cCgn Y29kZXJldmlld19pc3N1ZScpKQotCi0KIGNsYXNzIFJpZXR2ZWxkKG9iamVjdCk6CiAgICAgZGVm IF9faW5pdF9fKHNlbGYsIGV4ZWN1dGl2ZSwgZHJ5cnVuPUZhbHNlKToKICAgICAgICAgc2VsZi5k cnlydW4gPSBkcnlydW4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9zdGVwcy9wb3N0Y29kZXJldmlldy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9zdGVwcy9wb3N0Y29kZXJldmlldy5weQppbmRleCAxOThjZmNlNmNmNzAzNmE1NzA4 ZDZhOGJlYWIxN2I0MDA5ZDQyM2QzLi44Mzk3NTE5MDI4NDU3YzIwY2FkYjM1ZTlmNzU1NGNiOWQ3 MjAxYWNjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3Rl cHMvcG9zdGNvZGVyZXZpZXcucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL3N0ZXBzL3Bvc3Rjb2RlcmV2aWV3LnB5CkBAIC00MiwzMyArNDIsMzIgQEAgY2xhc3MgUG9z dENvZGVSZXZpZXcoQWJzdHJhY3RTdGVwKToKICAgICBkZWYgcnVuKHNlbGYsIHN0YXRlKToKICAg ICAgICAgaWYgbm90IHNlbGYuX29wdGlvbnMuZmFuY3lfcmV2aWV3OgogICAgICAgICAgICAgcmV0 dXJuCi0gICAgICAgICMgRklYTUU6IFRoaXMgd2lsbCBhbHdheXMgYmUgTm9uZSBiZWNhdXNlIHdl IGRvbid0IHJldHJpZXZlIHRoZSBpc3N1ZQotICAgICAgICAjICAgICAgICBudW1iZXIgZnJvbSB0 aGUgQ2hhbmdlTG9nIHlldC4KLSAgICAgICAgY29kZXJldmlld19pc3N1ZSA9IHN0YXRlLmdldCgi Y29kZXJldmlld19pc3N1ZSIpCisKKyAgICAgICAgYnVnX2lkID0gc3RhdGUuZ2V0KCJidWdfaWQi KQorICAgICAgICBpZiBub3QgYnVnX2lkOgorICAgICAgICAgICAgcmFpc2UgU2NyaXB0RXJyb3Io bWVzc2FnZT0iQ2Fubm90IHVwbG9hZCBhIGZhbmN5IHJldmlldyB3aXRob3V0IGEgYnVnIElELiIp CisKICAgICAgICAgbWVzc2FnZSA9IHNlbGYuX29wdGlvbnMuZGVzY3JpcHRpb24KICAgICAgICAg aWYgbm90IG1lc3NhZ2U6CiAgICAgICAgICAgICAjIElmIHdlIGhhdmUgYW4gaXNzdWUgbnVtYmVy LCB0aGVuIHRoZSBtZXNzYWdlIGJlY29tZXMgdGhlIGxhYmVsCiAgICAgICAgICAgICAjIG9mIHRo ZSBuZXcgcGF0Y2guIE90aGVyd2lzZSwgaXQgYmVjb21lcyB0aGUgdGl0bGUgb2YgdGhlIHdob2xl CiAgICAgICAgICAgICAjIGlzc3VlLgotICAgICAgICAgICAgaWYgY29kZXJldmlld19pc3N1ZToK LSAgICAgICAgICAgICAgICBtZXNzYWdlID0gIlVwZGF0ZWQgcGF0Y2giCi0gICAgICAgICAgICBl bGlmIHN0YXRlLmdldCgiYnVnX3RpdGxlIik6CisgICAgICAgICAgICBpZiBzdGF0ZS5nZXQoImJ1 Z190aXRsZSIpOgogICAgICAgICAgICAgICAgICMgVGhpcyBpcyB0aGUgY29tbW9uIGNhc2UgZm9y IHRoZSB0aGUgZmlyc3QgInVwbG9hZCIgY29tbWFuZC4KICAgICAgICAgICAgICAgICBtZXNzYWdl ID0gc3RhdGUuZ2V0KCJidWdfdGl0bGUiKQotICAgICAgICAgICAgZWxpZiBzdGF0ZS5nZXQoImJ1 Z19pZCIpOgorICAgICAgICAgICAgZWxpZiBidWdfaWQ6CiAgICAgICAgICAgICAgICAgIyBUaGlz IGlzIHRoZSBjb21tb24gY2FzZSBmb3IgdGhlICJwb3N0IiBjb21tYW5kIGFuZAotICAgICAgICAg ICAgICAgICMgc3Vic2VxdWVudCBydW5zIG9mIHRoZSAidXBsb2FkIiBjb21tYW5kLiAgSW4gdGhp cyBjYXNlLAotICAgICAgICAgICAgICAgICMgSSdkIHJhdGhlciBhZGQgdGhlIG5ldyBwYXRjaCB0 byB0aGUgZXhpc3RpbmcgaXNzdWUsIGJ1dAotICAgICAgICAgICAgICAgICMgdGhhdCdzIG5vdCBp bXBsZW1lbnRlZCB5ZXQuCi0gICAgICAgICAgICAgICAgbWVzc2FnZSA9ICJDb2RlIHJldmlldyBm b3IgJXMiICUgc2VsZi5fdG9vbC5idWdzLmJ1Z191cmxfZm9yX2J1Z19pZChzdGF0ZVsiYnVnX2lk Il0pCisgICAgICAgICAgICAgICAgIyBzdWJzZXF1ZW50IHJ1bnMgb2YgdGhlICJ1cGxvYWQiIGNv bW1hbmQuCisgICAgICAgICAgICAgICAgbWVzc2FnZSA9ICJDb2RlIHJldmlldyBmb3IgJXMiICUg c2VsZi5fdG9vbC5idWdzLmJ1Z191cmxfZm9yX2J1Z19pZChidWdfaWQpCiAgICAgICAgICAgICBl bHNlOgogICAgICAgICAgICAgICAgICMgVW5yZWFjaGFibGUgd2l0aCBvdXIgY3VycmVudCBjb21t YW5kcywgYnV0IHdlIG1pZ2h0IGhpdAogICAgICAgICAgICAgICAgICMgdGhpcyBjYXNlIGlmIHdl IHN1cHBvcnQgYnVnLWxlc3MgY29kZSByZXZpZXdzLgogICAgICAgICAgICAgICAgIG1lc3NhZ2Ug PSAiQ29kZSByZXZpZXciCisKKyAgICAgICAgIyBVc2UgdGhlIGJ1ZyBJRCBhcyB0aGUgcmlldHZl bGQgaXNzdWUgbnVtYmVyLiBUaGlzIG1lYW5zIHJpZXR2ZWxkIGNvZGUgcmV2aWV3cworICAgICAg ICAjIHdoZW4gdGhlcmUgYXJlIG11bHRpcGxlIGRpZmZlcmVudCBwYXRjaGVzIG9uIGEgYnVnIHdp bGwgYmUgYSBiaXQgd29ua3ksIGJ1dAorICAgICAgICAjIHdlYmtpdC1wYXRjaCBhc3N1bWVzIG9u ZS1wYXRjaC1wZXItYnVnLgogICAgICAgICBjcmVhdGVkX2lzc3VlID0gc2VsZi5fdG9vbC5jb2Rl cmV2aWV3LnBvc3QoZGlmZj1zZWxmLmNhY2hlZF9sb29rdXAoc3RhdGUsICJkaWZmIiksCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtZXNzYWdlPW1l c3NhZ2UsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjb2RlcmV2aWV3X2lzc3VlPWNvZGVyZXZpZXdfaXNzdWUsCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb2RlcmV2aWV3X2lzc3VlPWJ1Z19pZCwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNjPXNl bGYuX29wdGlvbnMuY2MpCi0gICAgICAgIGlmIGNyZWF0ZWRfaXNzdWU6Ci0gICAgICAgICAgICAj IEZJWE1FOiBSZWNvcmQgdGhlIGlzc3VlIG51bWJlciBpbiB0aGUgQ2hhbmdlTG9nLgotICAgICAg ICAgICAgc3RhdGVbImNvZGVyZXZpZXdfaXNzdWUiXSA9IGNyZWF0ZWRfaXNzdWUKZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9wb3N0ZGlmZi5weSBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9wb3N0ZGlmZi5weQppbmRl eCBhNTQyZGJhOTdiZDM5NjZkNzJmOTY3OTYyMGU2OTE1YzY2YTUwY2UzLi43OTczOWNkMDdjNGJh YjE5ZDcyMGY2MzBmNGFhZTE1YjE3MjE5MzIxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcG9zdGRpZmYucHkKKysrIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3Bvc3RkaWZmLnB5CkBAIC00NCwxMSArNDQsNiBAQCBj bGFzcyBQb3N0RGlmZihBYnN0cmFjdFN0ZXApOgogICAgICAgICBkaWZmID0gc2VsZi5jYWNoZWRf bG9va3VwKHN0YXRlLCAiZGlmZiIpCiAgICAgICAgIGRlc2NyaXB0aW9uID0gc2VsZi5fb3B0aW9u cy5kZXNjcmlwdGlvbiBvciAiUGF0Y2giCiAgICAgICAgIGNvbW1lbnRfdGV4dCA9IE5vbmUKLSAg ICAgICAgY29kZXJldmlld19pc3N1ZSA9IHN0YXRlLmdldCgiY29kZXJldmlld19pc3N1ZSIpCi0g ICAgICAgICMgSW5jbHVkZSBjb2RlcmV2aWV3IGlzc3VlIG51bWJlciBpbiBwYXRjaCBuYW1lLiBU aGlzIGlzIGEgYml0IG9mIGEgaGFjaywKLSAgICAgICAgIyBidXQgaXQgbWFrZXMgZG9pbmcgdGhl IHJpZXR2ZWxkIGludGVncmF0aW9uIGEgbG90IGVhc2llci4KLSAgICAgICAgaWYgY29kZXJldmll d19pc3N1ZToKLSAgICAgICAgICAgIGRlc2NyaXB0aW9uICs9ICItJXMiICUgc3RhdGVbImNvZGVy ZXZpZXdfaXNzdWUiXQogICAgICAgICBzZWxmLl90b29sLmJ1Z3MuYWRkX3BhdGNoX3RvX2J1Zyhz dGF0ZVsiYnVnX2lkIl0sIGRpZmYsIGRlc2NyaXB0aW9uLCBjb21tZW50X3RleHQ9Y29tbWVudF90 ZXh0LCBtYXJrX2Zvcl9yZXZpZXc9c2VsZi5fb3B0aW9ucy5yZXZpZXcsIG1hcmtfZm9yX2NvbW1p dF9xdWV1ZT1zZWxmLl9vcHRpb25zLnJlcXVlc3RfY29tbWl0KQogICAgICAgICBpZiBzZWxmLl9v cHRpb25zLm9wZW5fYnVnOgogICAgICAgICAgICAgc2VsZi5fdG9vbC51c2VyLm9wZW5fdXJsKHNl bGYuX3Rvb2wuYnVncy5idWdfdXJsX2Zvcl9idWdfaWQoc3RhdGVbImJ1Z19pZCJdKSkK