38863 2010-05-10 12:56:19 -0700 [Qt] Detect debug mode consistently 2010-05-14 01:48:33 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All CLOSED FIXED Qt P2 Normal --- 35784 1 laszlo.gombos webkit-unassigned cshu hausmann koshuin norbert.leser ossy oldest_to_newest 223470 0 laszlo.gombos 2010-05-10 12:56:19 -0700 CONFIG(debug, debug|release) is not the same as !CONFIG(release, debug|release). This subtly difference only has impact in a few build environments. This difference has caused some hard to find build-breaks on Symbian. The proposal is to use only either CONFIG(release, debug|release) or CONFIG(debug, debug|release) conditions everywhere but do not mix them. 223474 1 55595 laszlo.gombos 2010-05-10 13:01:34 -0700 Created attachment 55595 use the CONFIG(release, debug|release) test everywhere 224870 2 ossy 2010-05-12 13:59:04 -0700 Landed: http://trac.webkit.org/changeset/59264 225713 3 hausmann 2010-05-14 01:42:52 -0700 <cherry-pick-for-backport: r59264> 225719 4 hausmann 2010-05-14 01:48:01 -0700 Revision r59264 cherry-picked into qtwebkit-2.0 with commit 4ee9c252c187832cec8bf0b82e89e6016aec5388 55595 2010-05-10 13:01:34 -0700 2010-05-13 08:34:42 -0700 use the CONFIG(release, debug|release) test everywhere 38863.patch text/plain 4947 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU5MDky KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDUt MTAgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRGV0ZWN0IGRlYnVn IG1vZGUgY29uc2lzdGVudGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zODg2MworCisgICAgICAgICogV2ViS2l0LnByaToKKwogMjAxMC0wNS0wOCAg TGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBXZWJLaXQucHJpCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC5wcmkJKHJldmlzaW9uIDU5MDkxKQorKysgV2ViS2l0LnByaQko d29ya2luZyBjb3B5KQpAQCAtMjIsNyArMjIsNyBAQCBidWlsZGluZy1saWJzIHsKICAgICAgICAg ICAgIFFNQUtFX0ZSQU1FV09SS1BBVEggPSAkJE9VVFBVVF9ESVIvbGliICQkUU1BS0VfRlJBTUVX T1JLUEFUSAogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgd2luMzItKnx3aW5jZSogewot ICAgICAgICAgICAgICAgIENPTkZJRyhkZWJ1ZywgZGVidWd8cmVsZWFzZSk6YnVpbGRfcGFzczog UVRXRUJLSVRMSUJOQU1FID0gJCR7UVRXRUJLSVRMSUJOQU1FfWQKKyAgICAgICAgICAgICAgICAh Q09ORklHKHJlbGVhc2UsIGRlYnVnfHJlbGVhc2UpOmJ1aWxkX3Bhc3M6IFFUV0VCS0lUTElCTkFN RSA9ICQke1FUV0VCS0lUTElCTkFNRX1kCiAgICAgICAgICAgICAgICAgUVRXRUJLSVRMSUJOQU1F ID0gJCR7UVRXRUJLSVRMSUJOQU1FfSQke1FUX01BSk9SX1ZFUlNJT059CiAgICAgICAgICAgICAg ICAgd2luMzItZysrOiBMSUJTICs9IC1sJCRRVFdFQktJVExJQk5BTUUKICAgICAgICAgICAgICAg ICBlbHNlOiBMSUJTICs9ICQke1FUV0VCS0lUTElCTkFNRX0ubGliCkluZGV4OiBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShy ZXZpc2lvbiA1OTA5MikKKysrIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA1LTEwICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEu Z29tYm9zQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbUXRdIERldGVjdCBkZWJ1ZyBtb2RlIGNvbnNpc3RlbnRseQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg4NjMKKworICAgICAgICAq IEphdmFTY3JpcHRDb3JlLnByaToKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS5wcm86CisgICAg ICAgICoganNjLnBybzoKKyAgICAgICAgKiBxdC9hcGkvUXRTY3JpcHQucHJvOgorCiAyMDEwLTA1 LTEwICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL0phdmFTY3Jp cHRDb3JlLnByaQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5w cmkJKHJldmlzaW9uIDU5MDkxKQorKysgSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJp CSh3b3JraW5nIGNvcHkpCkBAIC0xLDYgKzEsNiBAQAogIyBKYXZhU2NyaXB0Q29yZSAtIFF0NCBi dWlsZCBpbmZvCiBWUEFUSCArPSAkJFBXRAotQ09ORklHKGRlYnVnLCBkZWJ1Z3xyZWxlYXNlKSB7 CishQ09ORklHKHJlbGVhc2UsIGRlYnVnfHJlbGVhc2UpIHsKICAgICAjIE91dHB1dCBpbiBKYXZh U2NyaXB0Q29yZS88Y29uZmlnPgogICAgIEpBVkFTQ1JJUFRDT1JFX0RFU1RESVIgPSBkZWJ1Zwog ICAgICMgVXNlIGEgY29uZmlnLXNwZWNpZmljIHRhcmdldCB0byBwcmV2ZW50IHBhcmFsbGVsIGJ1 aWxkcyBmaWxlIGNsYXNoZXMgb24gTWFjCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0 Q29yZS5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJv CShyZXZpc2lvbiA1OTA5MSkKKysrIEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnBybwko d29ya2luZyBjb3B5KQpAQCAtMjEsNyArMjEsNyBAQCBDT05GSUcoUVRESVJfYnVpbGQpIHsKICAg ICAjIFRoaXMgbGluZSB3YXMgZXh0cmFjdGVkIGZyb20gcWJhc2UucHJpIGluc3RlYWQgb2YgaW5j bHVkaW5nIHRoZSB3aG9sZSBmaWxlCiAgICAgd2luMzJ8bWFjOiFtYWN4LXhjb2RlOkNPTkZJRyAr PSBkZWJ1Z19hbmRfcmVsZWFzZQogfSBlbHNlIHsKLSAgICBDT05GSUcoZGVidWcsIGRlYnVnfHJl bGVhc2UpIHsKKyAgICAhQ09ORklHKHJlbGVhc2UsIGRlYnVnfHJlbGVhc2UpIHsKICAgICAgICAg T0JKRUNUU19ESVIgPSBvYmovZGVidWcKICAgICB9IGVsc2UgeyAjIFJlbGVhc2UKICAgICAgICAg T0JKRUNUU19ESVIgPSBvYmovcmVsZWFzZQpJbmRleDogSmF2YVNjcmlwdENvcmUvanNjLnBybwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9qc2MucHJvCShyZXZpc2lvbiA1OTA5MSkKKysr IEphdmFTY3JpcHRDb3JlL2pzYy5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTE1LDcgKzE1LDcgQEAg Q09ORklHICs9IGxpbmtfcGtnY29uZmlnCiAKIFFNQUtFX1JQQVRIRElSICs9ICQkT1VUUFVUX0RJ Ui9saWIKIAotQ09ORklHKGRlYnVnLCBkZWJ1Z3xyZWxlYXNlKSB7CishQ09ORklHKHJlbGVhc2Us IGRlYnVnfHJlbGVhc2UpIHsKICAgICBPQkpFQ1RTX0RJUiA9IG9iai9kZWJ1ZwogfSBlbHNlIHsg IyBSZWxlYXNlCiAgICAgT0JKRUNUU19ESVIgPSBvYmovcmVsZWFzZQpJbmRleDogSmF2YVNjcmlw dENvcmUvcXQvYXBpL1F0U2NyaXB0LnBybwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9x dC9hcGkvUXRTY3JpcHQucHJvCShyZXZpc2lvbiA1OTA5MSkKKysrIEphdmFTY3JpcHRDb3JlL3F0 L2FwaS9RdFNjcmlwdC5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTcsNyArNyw3IEBAIElOQ0xVREVQ QVRIICs9ICQkUFdECiBDT05GSUcgKz0gYnVpbGRpbmctbGlicwogCiBpc0VtcHR5KEpTQ19HRU5F UkFURURfU09VUkNFU19ESVIpOkpTQ19HRU5FUkFURURfU09VUkNFU19ESVIgPSAuLi8uLi9nZW5l cmF0ZWQKLUNPTkZJRyhkZWJ1ZywgZGVidWd8cmVsZWFzZSkgeworIUNPTkZJRyhyZWxlYXNlLCBk ZWJ1Z3xyZWxlYXNlKSB7CiAgICAgT0JKRUNUU19ESVIgPSBvYmovZGVidWcKIH0gZWxzZSB7ICMg UmVsZWFzZQogICAgIE9CSkVDVFNfRElSID0gb2JqL3JlbGVhc2UKSW5kZXg6IFdlYkNvcmUvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA1OTA5MikK KysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIw MTAtMDUtMTAgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRGV0ZWN0 IGRlYnVnIG1vZGUgY29uc2lzdGVudGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zODg2MworCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGVyZSBp cyBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIFdlYkNvcmUucHJvOgorCiAyMDEw LTA1LTEwICBKb2huIEdyZWdnICA8am9obm55Z0Bnb29nbGUuY29tPgogCiAgICAgICAgIFtjaHJv bWl1bV0gVHJ5IHRvIGZpeCB0aGUgY2hyb21pdW0gYnVpbGQgYWZ0ZXIgcjU5MDg1IGJ5CkluZGV4 OiBXZWJDb3JlL1dlYkNvcmUucHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvV2ViQ29yZS5wcm8J KHJldmlzaW9uIDU5MDkxKQorKysgV2ViQ29yZS9XZWJDb3JlLnBybwkod29ya2luZyBjb3B5KQpA QCAtNTksNyArNTksNyBAQCBDT05GSUcoc3RhbmRhbG9uZV9wYWNrYWdlKSB7CiAgICAgaXNFbXB0 eShXQ19HRU5FUkFURURfU09VUkNFU19ESVIpOldDX0dFTkVSQVRFRF9TT1VSQ0VTX0RJUiA9IGdl bmVyYXRlZAogICAgIGlzRW1wdHkoSlNDX0dFTkVSQVRFRF9TT1VSQ0VTX0RJUik6SlNDX0dFTkVS QVRFRF9TT1VSQ0VTX0RJUiA9IC4uL0phdmFTY3JpcHRDb3JlL2dlbmVyYXRlZAogCi0gICAgQ09O RklHKGRlYnVnLCBkZWJ1Z3xyZWxlYXNlKSB7CisgICAgIUNPTkZJRyhyZWxlYXNlLCBkZWJ1Z3xy ZWxlYXNlKSB7CiAgICAgICAgIE9CSkVDVFNfRElSID0gb2JqL2RlYnVnCiAgICAgfSBlbHNlIHsg IyBSZWxlYXNlCiAgICAgICAgIE9CSkVDVFNfRElSID0gb2JqL3JlbGVhc2UK