38861 2010-05-10 12:39:20 -0700 new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL 2010-05-10 12:47:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth maruel ojan oldest_to_newest 223450 0 eric 2010-05-10 12:39:20 -0700 new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL 223451 1 55591 eric 2010-05-10 12:41:12 -0700 Created attachment 55591 Patch 223454 2 55591 abarth 2010-05-10 12:43:10 -0700 Comment on attachment 55591 Patch Ok, but you need to make these comments compile. :) WebKitTools/Scripts/webkitpy/common/system/executive_unittest.py:79 + # Note: Can't use a ternary since signal.SIGKILL is undefined for platform.sys == "windows" What is platform.sys ? 223455 3 eric 2010-05-10 12:43:35 -0700 Traceback (most recent call last): File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\new-run-webkit-tests", line 33, in <module> import webkitpy.layout_tests.run_webkit_tests as run_webkit_tests File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 77, in <module> from webkitpy.common.system.executive import Executive File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\common\system\executive.py", line 93, in <module> class Executive(object): File "C:\b\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\common\system\executive.py", line 174, in Executive _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE = 0 if sys.platform == "windows" else -signal.SIGKILL AttributeError: 'module' object has no attribute 'SIGKILL' Was the exception. I've not tested this code on sys.platform == "windows" as I don't currently have such a setup. We need to get the chromium canary bots to run test-webkitpy. 223456 4 eric 2010-05-10 12:44:35 -0700 Oops. Fixed to sys.platform in comment. Thanks. 223462 5 eric 2010-05-10 12:47:48 -0700 Committed r59090: <http://trac.webkit.org/changeset/59090> 55591 2010-05-10 12:41:12 -0700 2010-05-10 12:43:10 -0700 Patch bug-38861-20100510124108.patch text/plain 4051 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjMzJmMjU3NzcwMDNiMDBiMmY1Njg5MTUxZWE1NGNiZDc3ZjMxYzM5Li4zNDIwNTI3 ZDUyMjZhZmQ2OTRmNWY4ZDRkNzE4MzEyYjQ0NDE3YTkwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDUtMTAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3Rz IGZhaWxzIHdoZW4gcnVuIHVuZGVyIHN5cy5wbGF0Zm9ybSA9PSAid2luZG93cyIgZHVlIHRvIHVu ZGVmaW5lZCBzaWduYWwuU0lHS0lMTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Mzg4NjEKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9u L3N5c3RlbS9leGVjdXRpdmUucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24v c3lzdGVtL2V4ZWN1dGl2ZV91bml0dGVzdC5weToKKwogMjAxMC0wNS0xMCAgSmVyIE5vYmxlICA8 amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLgpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weSBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkK aW5kZXggMTE2Y2NjNWUyODk5MmRmNjViZmM5YzU1NDIyNDZhNjllY2IxMGYyZS4uZDAzYjU1NDQ1 NTU5MDI4MDU1MTQ5ZDUzNTdkYzI0OTQxNjgyNDE3OSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQorKysgYi9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5CkBAIC0xNjcs MTMgKzE2Nyw2IEBAIGNsYXNzIEV4ZWN1dGl2ZShvYmplY3QpOgogICAgICAgICAjIG1hY2hpbmVz LgogICAgICAgICByZXR1cm4gMgogCi0gICAgIyBFeGVjdXRpdmUgdW5pdCB0ZXN0cyB1c2VzIHRo aXMgaW5mb3JtYXRpb24gdG8gdmFsaWRhdGUgdGhhdAotICAgICMga2lsbF9wcm9jZXNzL2tpbGxf YWxsIHdvcmsgYXMgZXhwZWN0ZWQgYW4gY2F1c2UgdGhlIGV4cGVjdGVkIGV4aXQgY29kZXMuCi0g ICAgIyBXZSBzdG9yZSB0aGlzIGluZm9ybWF0aW9uIGluIHRoaXMgZmlsZSB0byBrZWVwIGl0IG5l eHQgdG8gdGhlIHBsYXRmb3JtIGlmcy4KLSAgICAjIHRhc2traWxsLmV4ZSBjYXVzZXMgcHJvY2Vz c2VzIHRvIGV4aXQgMCwgb3RoZXJ3aXNlIHByb2Nlc3NlcyBleGl0IC1TSUdOQUwKLSAgICBfS0lM TF9QUk9DRVNTX0tJTExFRF9QUk9DRVNTX0VYSVRfQ09ERSA9IDAgaWYgc3lzLnBsYXRmb3JtID09 ICJ3aW5kb3dzIiBlbHNlIC1zaWduYWwuU0lHS0lMTAotICAgIF9LSUxMX0FMTF9LSUxMRURfUFJP Q0VTU19FWElUX0NPREUgPSAwIGlmIHN5cy5wbGF0Zm9ybSBpbiAoIndpbmRvd3MiLCAiY3lnd2lu IikgZWxzZSAtc2lnbmFsLlNJR1RFUk0KLQogICAgIGRlZiBraWxsX3Byb2Nlc3Moc2VsZiwgcGlk KToKICAgICAgICAgIiIiQXR0ZW1wdHMgdG8ga2lsbCB0aGUgZ2l2ZW4gcGlkLgogICAgICAgICBX aWxsIGZhaWwgc2lsZW50bHkgaWYgcGlkIGRvZXMgbm90IGV4aXN0IG9yIGluc3VmZmljaWVudCBw ZXJtaXNzc2lvbnMuIiIiCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZV91bml0dGVzdC5weQppbmRleCAwYzU4 YTgwMTEzNmFkODBhZTM3NTlmNGNhMmRmOWVmYzljY2RhMTRmLi5lYjc3MTQzYjU0ZWFiZWMzNjIx OTc0YTJhYWIwYzRjNmEzNTQ5NGNjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlX3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmVfdW5pdHRlc3QucHkK QEAgLTcyLDEyICs3MiwxNiBAQCBjbGFzcyBFeGVjdXRpdmVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNl KToKIAogICAgIGRlZiB0ZXN0X2tpbGxfcHJvY2VzcyhzZWxmKToKICAgICAgICAgZXhlY3V0aXZl ID0gRXhlY3V0aXZlKCkKLSAgICAgICAgIyBGSVhNRTogVGhpcyBtYXkgbmVlZCBlZGl0cyB0byB3 b3JrIHJpZ2h0IG9uIHdpbmRvd3MuCiAgICAgICAgICMgV2UgdXNlICJ5ZXMiIGJlY2F1c2UgaXQg bG9vcHMgZm9yZXZlci4KICAgICAgICAgcHJvY2VzcyA9IHN1YnByb2Nlc3MuUG9wZW4oWyJ5ZXMi XSwgc3Rkb3V0PXN1YnByb2Nlc3MuUElQRSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwcm9j ZXNzLnBvbGwoKSwgTm9uZSkgICMgUHJvY2VzcyBpcyBydW5uaW5nCiAgICAgICAgIGV4ZWN1dGl2 ZS5raWxsX3Byb2Nlc3MocHJvY2Vzcy5waWQpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocHJv Y2Vzcy53YWl0KCksIGV4ZWN1dGl2ZS5fS0lMTF9QUk9DRVNTX0tJTExFRF9QUk9DRVNTX0VYSVRf Q09ERSkKKyAgICAgICAgIyBOb3RlOiBDYW4ndCB1c2UgYSB0ZXJuYXJ5IHNpbmNlIHNpZ25hbC5T SUdLSUxMIGlzIHVuZGVmaW5lZCBmb3IgcGxhdGZvcm0uc3lzID09ICJ3aW5kb3dzIgorICAgICAg ICBpZiBzeXMucGxhdGZvcm0gPT0gIndpbmRvd3MiOgorICAgICAgICAgICAgZXhwZWN0ZWRfZXhp dF9jb2RlID0gMCAgIyB0YXNra2lsbC5leGUgcmVzdWx0cyBpbiBleGl0KDApCisgICAgICAgIGVs c2U6CisgICAgICAgICAgICBleHBlY3RlZF9leGl0X2NvZGUgPSAtc2lnbmFsLlNJR0tJTEwKKyAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChwcm9jZXNzLndhaXQoKSwgZXhwZWN0ZWRfZXhpdF9jb2Rl KQogICAgICAgICAjIEtpbGxpbmcgYWdhaW4gc2hvdWxkIGZhaWwgc2lsZW50bHkuCiAgICAgICAg IGV4ZWN1dGl2ZS5raWxsX3Byb2Nlc3MocHJvY2Vzcy5waWQpCiAKQEAgLTk3LDExICsxMDEsMTUg QEAgY2xhc3MgRXhlY3V0aXZlVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICBkZWYgdGVz dF9raWxsX2FsbChzZWxmKToKICAgICAgICAgZXhlY3V0aXZlID0gRXhlY3V0aXZlKCkKLSAgICAg ICAgIyBGSVhNRTogVGhpcyBtYXkgbmVlZCBlZGl0cyB0byB3b3JrIHJpZ2h0IG9uIHdpbmRvd3Mu CiAgICAgICAgICMgV2UgdXNlICJ5ZXMiIGJlY2F1c2UgaXQgbG9vcHMgZm9yZXZlci4KICAgICAg ICAgcHJvY2VzcyA9IHN1YnByb2Nlc3MuUG9wZW4oWyJ5ZXMiXSwgc3Rkb3V0PXN1YnByb2Nlc3Mu UElQRSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwcm9jZXNzLnBvbGwoKSwgTm9uZSkgICMg UHJvY2VzcyBpcyBydW5uaW5nCiAgICAgICAgIGV4ZWN1dGl2ZS5raWxsX2FsbCgieWVzIikKLSAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChwcm9jZXNzLndhaXQoKSwgZXhlY3V0aXZlLl9LSUxMX0FM TF9LSUxMRURfUFJPQ0VTU19FWElUX0NPREUpCisgICAgICAgICMgTm90ZTogQ2FuJ3QgdXNlIGEg dGVybmFyeSBzaW5jZSBzaWduYWwuU0lHVEVSTSBpcyB1bmRlZmluZWQgZm9yIHBsYXRmb3JtLnN5 cyA9PSAid2luZG93cyIKKyAgICAgICAgaWYgc3lzLnBsYXRmb3JtIGluICgid2luZG93cyIsICJj eWd3aW4iKToKKyAgICAgICAgICAgIGV4cGVjdGVkX2V4aXRfY29kZSA9IDAgICMgdGFza2tpbGwu ZXhlIHJlc3VsdHMgaW4gZXhpdCgwKQorICAgICAgICBlbHNlOgorICAgICAgICAgICAgZXhwZWN0 ZWRfZXhpdF9jb2RlID0gLXNpZ25hbC5TSUdURVJNCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwo cHJvY2Vzcy53YWl0KCksIGV4cGVjdGVkX2V4aXRfY29kZSkKICAgICAgICAgIyBLaWxsaW5nIGFn YWluIHNob3VsZCBmYWlsIHNpbGVudGx5LgogICAgICAgICBleGVjdXRpdmUua2lsbF9hbGwoInll cyIpCg==