38855 2010-05-10 10:08:56 -0700 check-webkit-style issue with lower/upper case 2013-03-12 19:17:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 1 jam alancutter abarth alancutter dpranke eric levin webkit.review.bot oldest_to_newest 223375 0 jam 2010-05-10 10:08:56 -0700 I got a warning for this #include "Scrollbar.h" #include "ScrollbarTheme.h" #include "ScrollTypes.h" But I believe this is ordered correctly, and the problem is because it thinks "T" is before "b" because of the ASCII representation. 853971 1 192849 alancutter 2013-03-12 18:23:36 -0700 Created attachment 192849 Patch 853996 2 192849 levin 2013-03-12 19:09:37 -0700 Comment on attachment 192849 Patch The bug wasn't filed by someone familiar with WebKit style: Other #include statements should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command). Don't bother to organize them in a logical order. -- http://www.webkit.org/coding/coding-style.html 854003 3 alancutter 2013-03-12 19:17:13 -0700 (In reply to comment #2) > (From update of attachment 192849 [details]) > The bug wasn't filed by someone familiar with WebKit style: > > Other #include statements should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command). Don't bother to organize them in a logical order. > -- http://www.webkit.org/coding/coding-style.html Thanks for clarifying, closing bug. 192849 2013-03-12 18:23:36 -0700 2013-03-12 19:09:36 -0700 Patch bug-38855-20130313121933.patch text/plain 3043 alancutter U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1NDg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZThjZGFkZjljODVkODdkMjlkZDU0OWY1YzgwNjc0ZTZl ZWY1Njc4Ny4uZTYwZWUxNzViZTlmNTdlN2Y3NjQwMjk2OTNhNjVkZjcxNDBmMGFhYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTAzLTEyICBBbGFuIEN1dHRlciAgPGFsYW5jdXR0ZXJAY2hyb21pdW0ub3JnPgor CisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBpc3N1ZSB3aXRoIGxvd2VyL3VwcGVyIGNhc2UK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4ODU1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlZCBp bmNsdWRlIG9yZGVyIGNoZWNraW5nIHRvIGJlIGNhc2UgaW5zZW5zaXRpdmUgZm9yIGNoZWNrLXdl YmtpdC1zdHlsZSB3aXRoIENQUCBmaWxlcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAoY2hlY2tfaW5jbHVkZV9saW5lKToKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToK KyAgICAgICAgKE9yZGVyT2ZJbmNsdWRlc1Rlc3QudGVzdF9jaGVja19hbHBoYWJldGljYWxfaW5j bHVkZV9vcmRlcik6CisKIDIwMTMtMDMtMTEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUu Y29tPgogCiAgICAgICAgIFtNYWNdW1dLMV0gQWRkIHN1cHBvcnQgZm9yIGFsZXJ0KCkgaW4gTWlu aUJyb3dzZXIuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 CmluZGV4IDgxZjVjYmI4MjY3MTdjOGM3ODNjODYzMWRjMzA5MDhmNmIyNjliM2QuLjlkMjMzZjRj ZjFkNTI3ZTU0MDhhZDEzZDNlZDNiMmQyOTVjNDA0YTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0yODc1LDcgKzI4NzUsNyBAQCBkZWYgY2hl Y2tfaW5jbHVkZV9saW5lKGZpbGVuYW1lLCBmaWxlX2V4dGVuc2lvbiwgY2xlYW5fbGluZXMsIGxp bmVfbnVtYmVyLCBpbmNsdQogICAgICAgICAgICAgcHJldmlvdXNfbWF0Y2ggPSBfUkVfUEFUVEVS Tl9JTkNMVURFLnNlYXJjaChwcmV2aW91c19saW5lKQogICAgICAgICAgaWYgcHJldmlvdXNfbWF0 Y2g6CiAgICAgICAgICAgICBwcmV2aW91c19oZWFkZXJfdHlwZSA9IGluY2x1ZGVfc3RhdGUuaGVh ZGVyX3R5cGVzW3ByZXZpb3VzX2xpbmVfbnVtYmVyXQotICAgICAgICAgICAgaWYgcHJldmlvdXNf aGVhZGVyX3R5cGUgPT0gX09USEVSX0hFQURFUiBhbmQgcHJldmlvdXNfbGluZS5zdHJpcCgpID4g bGluZS5zdHJpcCgpOgorICAgICAgICAgICAgaWYgcHJldmlvdXNfaGVhZGVyX3R5cGUgPT0gX09U SEVSX0hFQURFUiBhbmQgcHJldmlvdXNfbGluZS5zdHJpcCgpLmxvd2VyKCkgPiBsaW5lLnN0cmlw KCkubG93ZXIoKToKICAgICAgICAgICAgICAgICAjIFRoaXMgdHlwZSBvZiBlcnJvciBpcyBwb3Rl bnRpYWxseSBhIHByb2JsZW0gd2l0aCB0aGlzIGxpbmUgb3IgdGhlIHByZXZpb3VzIG9uZSwKICAg ICAgICAgICAgICAgICAjIHNvIGlmIHRoZSBlcnJvciBpcyBmaWx0ZXJlZCBmb3Igb25lIGxpbmUs IHJlcG9ydCBpdCBmb3IgdGhlIG5leHQuIFRoaXMgaXMgc28gdGhhdAogICAgICAgICAgICAgICAg ICMgd2UgcHJvcGVybHkgaGFuZGxlIHBhdGNoZXMsIGZvciB3aGljaCBvbmx5IG1vZGlmaWVkIGxp bmVzIHByb2R1Y2UgZXJyb3JzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQppbmRleCA4ZGU5OWRmN2U3MDg2N2Q3MTYwMGZi MzJlYzk3NGYxNzYyNTc4ZmZkLi5mMzUzMzljODM5MjFkMzQ4Y2ZmYThkZjg5YTY2MGIwY2I0MDk1 OGFkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcF91bml0dGVzdC5weQpAQCAtMjU4Myw2ICsyNTgzLDEyIEBAIGNsYXNzIE9yZGVyT2ZJbmNs dWRlc1Rlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICdBbHBoYWJldGljYWwgc29ydGluZyBwcm9ibGVtLiAgW2J1aWxkL2luY2x1 ZGVfb3JkZXJdIFs0XScpCiAKICAgICAgICAgc2VsZi5hc3NlcnRfbGFuZ3VhZ2VfcnVsZXNfY2hl Y2soJ2Zvby5oJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNp bmNsdWRlICJBLmgiXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICcjaW5jbHVkZSAiQy5oIlxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAnI2luY2x1ZGUgImIuaCJcbicsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICdBbHBoYWJldGljYWwgc29ydGluZyBwcm9ibGVtLiAgW2J1aWxkL2luY2x1ZGVf b3JkZXJdIFs0XScpCisKKyAgICAgICAgc2VsZi5hc3NlcnRfbGFuZ3VhZ2VfcnVsZXNfY2hlY2so J2Zvby5oJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNs dWRlICJhLmgiXG4nCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcj aW5jbHVkZSAiYi5oIlxuJwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAnI2luY2x1ZGUgImMuaCJcbicsCg==