38836 2010-05-10 02:05:53 -0700 SMIL Animation does not starts 2012-06-23 18:42:07 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED http://svg.kvalitne.cz/mix/spirit2.svg P2 Normal --- 41761 1 marek.raida webkit-unassigned krit pdr robin.webkit zimmermann oldest_to_newest 223203 0 55529 marek.raida 2010-05-10 02:05:53 -0700 Created attachment 55529 Two files inside, one working, one not, diff is pretty easy to see... If there is SMIL animation inside of mask element, it does not not starts at all. http://svg.kvalitne.cz/mix/spirit2.svg But by simple adding one more animate element to the document, see http://svg.kvalitne.cz/mix/spirit.svg it is working as expected. I consider this to be a bug, since it is working properly in other browsers. The only difference is presence of one more animate element... 223520 1 ap 2010-05-10 14:38:55 -0700 Confirmed with r58908. 232680 2 robin.webkit 2010-06-01 04:50:55 -0700 The root cause of this bug is: the masker is not updated during animation. This problem can only reproduce with 'animateTransform' and 'animateMotion'. Other animation elements use a different mechanism: Everything is routed through 'setAttribute' calls, then the masker gets invalidated in attribute changed callback SVGStyledElement::svgAttributeChanged'. I have a quick fix for this bug. Add the following code to the end of SVGAnimateTransformElement::applyResultsToTarget() if (targetElement->isStyled()) static_cast<SVGStyledElement*>(targetElement)->invalidateResourcesInAncestorChain(); It works, but i'm not sure if this is the correct solution. Dirk, do you have any suggestions? 232691 3 krit 2010-06-01 05:21:31 -0700 (In reply to comment #2) > The root cause of this bug is: the masker is not updated during animation. > This problem can only reproduce with 'animateTransform' and 'animateMotion'. Other animation elements use a different mechanism: > Everything is routed through 'setAttribute' calls, then the masker gets invalidated in attribute changed callback SVGStyledElement::svgAttributeChanged'. > > I have a quick fix for this bug. > Add the following code to the end of SVGAnimateTransformElement::applyResultsToTarget() > > if (targetElement->isStyled()) > static_cast<SVGStyledElement*>(targetElement)->invalidateResourcesInAncestorChain(); > > It works, but i'm not sure if this is the correct solution. > > Dirk, do you have any suggestions? Well, isn't it better to do it like other elements (SVGRectElement, SVGGElement, ...)? It would look like this: RenderObject* renderer = targetElement->renderer(); if (targetElement->isStyled()) { renderer->setNeedsTransformUpdate(); renderer->setNeedsLayout(true); } else renderer->setNeedsLayout(true); This is untested, but telling the renderer to just update the transform is maybe faster. And it's my opinion, that the code shouldn't handle resources manually here. Niko may know it better, since he changed layouting lately. 232697 4 krit 2010-06-01 05:40:30 -0700 (In reply to comment #3) > (In reply to comment #2) > > The root cause of this bug is: the masker is not updated during animation. > > This problem can only reproduce with 'animateTransform' and 'animateMotion'. Other animation elements use a different mechanism: > > Everything is routed through 'setAttribute' calls, then the masker gets invalidated in attribute changed callback SVGStyledElement::svgAttributeChanged'. > > > > I have a quick fix for this bug. > > Add the following code to the end of SVGAnimateTransformElement::applyResultsToTarget() > > > > if (targetElement->isStyled()) > > static_cast<SVGStyledElement*>(targetElement)->invalidateResourcesInAncestorChain(); > > > > It works, but i'm not sure if this is the correct solution. > > > > Dirk, do you have any suggestions? > > Well, isn't it better to do it like other elements (SVGRectElement, SVGGElement, ...)? It would look like this: > > RenderObject* renderer = targetElement->renderer(); > if (targetElement->isStyled()) { > renderer->setNeedsTransformUpdate(); > renderer->setNeedsLayout(true); > } else > renderer->setNeedsLayout(true); > > This is untested, but telling the renderer to just update the transform is maybe faster. And it's my opinion, that the code shouldn't handle resources manually here. > > Niko may know it better, since he changed layouting lately. Sorry, looked at SVGAnimateTransformElement again. We're already calling relayouting. It looks like you're right with invalidateResourcesInAncestorChain(), but you also need to call registerFromResources(renderer), see SVGStyledElement::svgAttributeChanged. I still believe that this should be done in layout() on the renderer, but it's ok to handle it here for the moment. 656146 5 pdr 2012-06-23 18:42:07 -0700 This has been fixed. Possibly with the recent SMIL changes. 55529 2010-05-10 02:05:53 -0700 2010-05-10 02:05:53 -0700 Two files inside, one working, one not, diff is pretty easy to see... webkit-bug.zip application/zip 6292 marek.raida UEsDBBQAAgAIAA5XqjziX04t4gsAAOQZAAALAAAAc3Bpcml0Mi5zdmedmdtuG8kRhq83QN5hwkWg NTAa9fmwa+7F5iJXyVXyALRESYxlUSBpy377fFXdM9TKWgSIAastsqb67zr89ff4/fHL3fC8uznd r1fOmNVwv93d3Z/WK+v55eunh8fjenV/Oj39fHX1/Pw8Pftpf7i7wtRc8Wg3+fnrw+7x41uGttZ6 pd+ufv3zn97fbG+Psj5tTvfD7ma9et582a4G/vEPF0cbzSCLYcljzYM3Yw2D92O1g49jqYMvY0lD sGPxQwhjsUNIYy5DqGNOQ3RjDkOMY3ZDzGM2QzJjKkPyY0pDSmMKQypj8kO2Y7JDDmMyQ85jrEOu YyxDcWPMQ4n6s4wxDdXoT68/k/7EMk0x52icscnlBAxr7MRZq/NG/1iLi8mYnJyp1pmEJUZhygEj 4+LZKJkcLH9zdN5mscoTRtXm2FyBqUw+h2hC8Kb6WGwcrDWTw8yGZmZBWCdvYskh8bsPNmPkFJV1 HRWBMJOvuYQYU03W+YBRVFSmdlRExU4pJIAUn3PwSTwVBWVSBxUJ42RCzD4CyRdby2CdVUzGd0wS 8SnK9j7F4pyt2HiFZGyHhE2aCGKwwZVkSq2EwCWBVGrpkDJpnEwNmXizmQ9RjKpAKjV2SIWMT8YX 4ERTsi2czTtBVKpbEGU3kSxfvS0lu5SA5INAKtUskHIAksdzNsG4EMRTVkg8M0PKVEEoJhBIYzAl AMEoJMK7QCoTOUrVkc5ojadUgldMpScYo2Inn0gJXWcT2MQoKqbcQTkqfmJzIJXi2DBRAqEoJGos dps0BT4J2dkQrMv4iVYRSZq6TZ3IuLcxBR+KDWITFFA2ufupdsq1pGBK8qZwNmyS4kml48GI1HIW 742PiaIkRlSgAEqxA6Jz8+SiTRRvAaUzeEpOEXXQalSb7+UTjKJCirVDCtCCwzlgTGW7SmKwyvog WWoPCnnEKZToayD1RDiwIVUhqGJYUFlTJnrXSMpzBRHVlL3CiraDSKO0GKmkkahJ3EkYyLngCuWM y/opuoAbR9YtHYJVUVzaiB2XTYSdLwpVHuAkS84FVfAdldiUiUBaSZeRsqbtSlBUwZxR0WSmRJMS n5KgSAJLVlQ+d1R5lDYL0WZnSqgQlBRnaWHuldCsaH1HZ4IGooIBBlud4vKu4ypY5YlWJKYwF1HL tEyNisvV5oyQ0o2UZUmJoGQSzoa1KCyXGiyMPCypGSTMMRCNAY+KyoUzKu9BBYGZAGXwdMLKKyp+ XVyBQOozkPzkgscmKSZbFkyeoo3BSusFoWqHUVVMNnZMDivYNUJZNeWavWCySubFdjIXTxWeBkX2 bAolR4yUzIvtZO4pBdo/VSEM6hc7AW6VzEtvLfofK9jVAQuuploElFMuh0rOoIKDp6VjaIsg3e6c cnkxncsZi2IkIwdyYxwZsVEqp15fYKIQnAtSWJQMB8RKuTzXzuXdiiphAJF/Ylrx5ZXMc+1kzgAW K1KbIHy+KJG2gY0FFdXfUaXFF11ZfZJ6w0r5nHx3XGnGRR04glUVvVdCx3HHlecTBkNPu+AYSAOL 4iruBS4NFqMh0Fp0LEZK6bmzFUNhDnv0UAgmiAnqVFHl/AKVZpA2p1wYSRhFpfScwxlUKwZqsfJp hdqwUk7PuXO67NfKqrKZcVAycY/K6TnVM6hWoYw0mtAzssRKWT2nTodhLvWC94SFYbukrJ6TfwFK myZlhl/1MrOwUl7nLHnxpP0HTxRJmJVaT0rsOfZQhd7JEFbKBL7C8RgpsVNm50g1UsisTJIK9SPa lNlzN1JXwi+JXo+eUUn/YKTMrt5mI6EqurcyiLMjrxgpseeQz6CU9SBPb5PPEJUrSus5hCVOjT+R JDAtRQQFYa6Qgj0HSpmYvrQcUviT4xVldXp/waSkHok20BOHlP2U1LNPC6Y2H2SOI2+iEU9VWZ0k LKDaqGEo89PxvMVIST17s8SpTa1CU5MGxhvIq3J6dnnB1AZgYFoF54uTWmmTs9dvM0ICCYuKWONP cqhoZfTs3IxJh7IyCxVDw4uN8jkxiXMbt/Ge6VFKzqMoMFI+pwpnSKoTKgoIzNmkEgdvlc6zDTOi pjcyQqQInaPqrXJ5tnbGo7IlenoFWkx0KDbK5dmUOUQqf4qXwS67ObFRKoc5ZjhNRkEXdBTOIU3v lMmz8TMc1WPkiozBJCQKGyXybMyMpwk7gYO+ZSpwB3FK46nmJT4qEalHEgs/o6+4qCiNwx8zoKY1 OSmDm9xKMryyeKpuASSaFRKnPkS5OrnwKItD1jOgJn5FIuEJxSV+lMNTSXOAmopOkBnnkgoZmKCK p/gZT1PjkCSKnCEtF6qg/A1fz3iarEdjWcm8hbExUvpOuSyA9ILgmUvIhpLVkZI3pbEAkpsG40r2 QhyDJypzQyszHr2xQKVoX8jYSVJjkHuY5/qG/KHX2qLXL1LWFr2YwZZtCW1JainXOBa5x+FFLnJy acxyz/Nc5bj0ofzlBuirXgdBKHdD1IFcFMOcD/SyN0LLJJNPtRWT7a0Ye14RTQ7BKAwCT2oYO82I id4ghAhoNWqtcmvVPpS4zm6kzjIanOFN66Fo4SmNoul9GH2/QKDlbLUV8KC02ofcAWY8rfCF9bPQ CDcoqkkBmd6HMeiVGe0r92dkJCkLrsrNml6Raza3AblzByiy8l0wQjisTtiJVbQ1e4civDeAR0iS 1Qujsope5vtYhau5ljshdladAqyiNnGfjQwYVlWDrFFGF6sMQ+yKlaHIKtMKfyXJvGWtMpy56Is2 4rmqY59VRcJAIERSsPq+pr6WRZBwkyU2cHoaiKbkItrO03nRI6qWjXQJRsrT3NpaMs5yRBgaISxi Co0tyYimF0de1IjsxM2RTTHS8ojdkRqpGkGyIGDo6yE6rY5o3BmRahEGgAvSYhzSaXUIptlNkyIU qxFpQLFHp8UhbTb7USFChSIh4EwvL0e8VgdmC54mRKieCtdxgQKRV55mti+IVIhwvS9MKfQIFYWh QiqdqMssRJiLULFYcXyvTI3zhqnMQiQmue0yCKkcBLFiKn7B1IQImsYK9RNpjJSruQYumJoOISn6 xgIxiZGSdegZMfM9B91A1qQnJSVRyTrksGBqOgQwHh2FzMZTVLaGmsx8uqZDEgROFoQgMFK6ljv+ jKkJEW4rtCtsHOWllPJ1SGmJU9MhQV59cN+Tewecq5iSXzA1HUL3GZGJhBQjZWw57OJJdAiV7ul8 V7m9YKSMjTR1s6emQ9jMQ1pWBl9MStkhxiVOqkOSvLUCmrz9GWJW0iYwSz01HQK5GUKQaQOMVG53 idy2Ux0SuwwB1FtG/YVfNKsreS34aXP8qK8F7+73x5O8MRyG99e7w/XDdrj+ul5hN1x/a+uhLbe7 h4f16vl+d9qqDx44bK9PA9Z82237C0778gVnfvvh7cPD7un4++1SZDt+d5mV3/3y6IeHzfXHhpNn /3J5uXncfdqctsPmdDrsPnw+bf+5+bRdXxy+XQyH7dN2c/rb/vPjaX2xe7zZ3u4e2fhi+LC92z2u L8zxYviyefi8Pa4vfPiFwPzCUL0Ybj4f1hf2eHF1edkgXnWMfwzYd8C69t/fOOvdDPxuOB02j8fb /eHTenW83jxsf5rcu/bhA8f56ZIpP8J671bD8XTYf9xe9pCa+YP16nH/uH0zLmzwGYD6Fvjn+8P2 dr36Ud/7Xv0vg5ewzmCo1tG8W55+f7Wco0f/X/NTr9KwWtzh+dvT9oXTVc+CHEgCvjJTPHKaw56t 2Y4H9sQ3yL9eJnJ1TuQcVYXz/kpqWf7Bobabw98Pm5vd9pG6tLrHV0c5Up/tt29Ol7tu9G/cHder /Yf/UMm/sc/N7vHut/3X1bk3rvcPEt4f3h9P+6dhf3t73ALG/FXSsX+65Os9h/iRdlNYr+zCd4Y3 NzdvGab42nC7lYP+8J0lvfXadLPZtLa++n0M9KP5fwLu3s6x/B+AJcmvCnVubdd62517O71o7fKq P69eP96e/gNisOJVsrdefT48/PSjxvvd7PH8Ecd8971r33z7l87Pvt0rZNql8Xsv6f/3Mtdf+3n8 cvfrfwFQSwMEFAACAAgARlFrPChgL/faCwAA3xkAAAoAAABzcGlyaXQuc3ZnnZnbbhvJEYavEyDv MOAi0BqYHfX5sGvuxeYiV8lV8gC0REmMaVEgact++3xV3TPUyloEiIFVS2RN9d91+Ovv2fenL/fD 8+72/LBeOWNWw8N2d/9wXq+s54+vn/aPp/Xq4Xx++vn6+vn5eXr20+F4f42puebRbvLz1/3u8eNb hrbWeq3frn79y5/f327vTrI+bc4Pw+52vXrefNmuBn75h4ujjWaQxbDksebBm7GGwfux2sHHsdTB l7GkIdix+CGEsdghpDGXIdQxpyG6MYchxjG7IeYxmyGZMZUh+TGlIaUxhSGVMfkh2zHZIYcxmSHn MdYh1zGWobgx5qFE/VnGmIZq9KfXn0l/YpmmmHM0ztjkcgKGNXbirNV5o/+sxcVkTE7OVOtMwhKj MOWAkXHxYpRMDpb/cnTeZrHKE0bV5thcgalMPodoQvCm+lhsHKw1k8PMhmZmQVgnb2LJIfG3DzZj 5BSVdR0VgTCTr7mEGFNN1vmAUVRUpnZURMVOKSSAFJ9z8Ek8FQVlUgcVCeNkQsw+AskXW8tgnVVM xndMEvEpyvY+xeKcrdh4hWRsh4RNmghisMGVZEqthMAlgVRq6ZAyaZxMDZl4s5kPUYyqQCo1dkiF jE/GF+BEU7ItnM07QVSqWxBlN5EsX70tJbuUgOSDQCrVLJByAJLHczbBuBDEU1ZIPDNDylRBKCYQ SGMwJQDBKCTCu0AqEzlK1ZHOaI2nVIJXTKUnGKNiJ59ICV1nE9jEKCqm3EE5Kn5icyCV4tgwUQKh KCRqLHabNAU+CdnZEKzL+IlWEUmauk2dyLi3MQUfig1iExRQNrn7qXbKtaRgSvKmcDZskuJJpePB iNRyFu+Nj4miJEZUoABKsQOic/Pkok0UbwGlM3hKThF10GpUm+/lE4yiQoq1QwrQgsM5YExlu0pi sMr6IFlqDwp5xCmU6Gsg9UQ4sCFVIahiWFBZUyZ610jKcwUR1ZS9woq2g0ijtBippJGoSdxJGMi5 4Arlgsv6KbqAG0fWLR2CVVFc2ogdl02EnS8KVR7gJEvOBVXwHZXYlIlAWkmXkbKm7UpQVMFcUNFk pkSTEp+SoEgCS1ZUPndUeZQ2C9FmZ0qoEJQUZ2lh7pXQrGh9R2eCBqKCAQZbneLyruMqWOWJViSm MBdRy7RMjYrL1eaMkNKNlGVJiaBkEs6GtSgslxosjDwsqRkkzDEQjQGPisqFCyrvQQWBmQBl8HTC yisq/lxcgUDqM5D85ILHJikmWxZMnqKNwUrrBaFqh1FVTDZ2TA4r2DVCWTXlmr1gskrmxXYyF08V ngZF9mwKJUeMlMyL7WTuKQXaP1UhDOoXOwFulcxLby36HyvY1QELrqZaBJRTLodKLqCCg6elY2iL IN3unHJ5MZ3LGYtiJCMHcmMcGbFRKqdeX2CiEJwLUliUDAfESrk8187l3YoqYQCRf2Ja8eWVzHPt ZM4AFitSmyB8viiRtoGNBRXV31GlxRddWX2SesNK+Zx8d1xpxkUdOIJVFb1XQsdxx5XnEwZDT7vg GEgDi+Iq7gUuDRajIdBadCxGSum5sxVDYQ579FAIJogJ6lRR5fwClWaQNqdcGEkYRaX0nMMFVCsG arHyaYXasFJOz7lzuuzXyqqymXFQMnGPyuk51QuoVqGMNJrQM7LESlk9p06HYS71gveEhWG7pKye k38BSpsmZYZf9TKzsFJe5yx58aT9B08USZiVWk9K7Dn2UIXeyRBWygS+wvEYKbFTZpdINVLIrEyS CvUj2pTZczdSV8IviV6PnlFJ/2CkzK7eZiOhKrq3MoizI68YKbHnkC+glPUgT2+TzxCVK0rrOYQl To0/kSQwLUUEBWGukIK9BEqZmL60HFL4k+MVZXV6f8GkpB6JNtATh5T9lNSzTwumNh9kjiNvohFP VVmdJCyg2qhhKPPT8bzFSEk9e7PEqU2tQlOTBsYbyKtyenZ5wdQGYGBaBeeLk1ppk7PXbzNCAgmL iljjX3KoaGX07NyMSYeyMgsVQ8OLjfI5MYlzG7fxnulRSs6jKDBSPqcKZ0iqEyoKCMzZpBIHb5XO sw0zoqY3MkKkCJ2j6q1yebZ2xqOyJXp6BVpMdCg2yuXZlDlEKn+Kl8EuuzmxUSqHOWY4TUZBF3QU ziFN75TJs/EzHNVj5IqMwSQkChsl8mzMjKcJO4GDvmUqcAdxSuOp5iU+KhGpRxILP6OvuKgojcMf M6CmNTkpg5vcSjK8sniqbgEkmhUSpz5EuTq58CiLQ9YzoCZ+RSLhCcUlfpTDU0lzgJqKTpAZ55IK GZigiqf4GU9T45AkipwhLReqoPwNX894mqxHY1nJvIWxMVL6TrksgPSC4JlLyIaS1ZGSN6WxAJKb BuNK9kIcgycqc0MrMx69sUClaF/I2ElSY5B7mOf6hvyh19qi1y9S1ha9mMGWbQltSWop1zgWucfh RS5ycmnMcs/zXOW49KH85Qboq14HQSh3Q9SBXBTDnA/0sjdCyySTT7UVk+2tGHteEU0OwSgMAk9q GDvNiIneIIQIaDVqrXJr1T6UuM5upM4yGpzhTeuhaOEpjaLpfRh9v0Cg5Wy1FfCgtNqH3AFmPK3w hfWz0Ag3KKpJAZnehzHolRntK/dnZCQpC67KzZpekWs2twG5cwcosvJdMEI4rE7YiVW0NXuHIrw3 gEdIktULo7KKXub7WIWruZY7IXZWnQKsojZxn40MGFZVg6xRRherDEPsipWhyCrTCn8lybxlrTKc ueiLNuK5qmOfVUXCQCBEUrD6vqa+lkWQcJMlNnB6Goim5CLaztN50SOqlo10CUbK09zaWjIuckQY GiEsYgqNLcmIphdHXtSI7MTNkU0x0vKI3ZEaqRpBsiBg6OshOq2OaNwFkWoRBoAL0mIc0ml1CKbZ TZMiFKsRaUCxR6fFIW02+1EhQoUiIeBMLy9HvFYHZgueJkSongrXcYECkVeeZrYviFSIcL0vTCn0 CBWFoUIqnajLLESYi1CxWHF8r0yN84apzEIkJrntMgipHASxYip+wdSECJrGCvUTaYyUq7kGLpia DiEp+sYCMYmRknXoGTHzPQfdQNakJyUlUck65LBgajoEMB4dhczGU1S2hprMfLqmQxIEThaEIDBS upY7/oypCRFuK7QrbBzlpZTydUhpiVPTIUFefXDfk3sHnKuYkl8wNR1C9xmRiYQUI2VsOeziSXQI le7pfFe5vWCkjI00dbOnpkPYzENaVgZfTErZIcYlTqpDkry1Apq8/RliVtImMEs9NR0CuRlCkGkD jFRud4nctlMdErsMAdRbRv2FXzSra3kt+Glz+qivBe8fDqezvDEchvc3u+PNfjvcfF2vsBtuvrX1 2Ja73X6/Xj0/7M5b9cEDx+3NecCab7ttf8FpX77gzG8/vN3vd0+n32+XItvxt8us/O2XRz/sNzcf G06e3TzuPm3O22FzPh93Hz6ft//cfNqur47frobj9mm7Of/t8PnxvL7aPd5u73aP7Ho1fNje7x7X V+Z0NXzZ7D9vT+srH34hKr8wUa+G28/H9ZU9XXV01x3eH2P1Hauu/e83jnk/Y74fzsfN4+nucPy0 Xp1uNvvtj5N71z7cc5gff2LAjxDeu9VwOh8PH7c/9Wia+YP16vHwuH0zJGzwGYD6Avjnh+P2br36 QV/5Xv8vg5ewLmAo1NG8W55+f33/Kvb/mp96lYTV4g7P3562L5yueg7kQBLulZniidMcD2zNdjxw IL5BfnuZxtUljXNUFc77aylj+YVDbTfHvx83t7vtIyVpdY+vjkqkNNtf35wu993o37g7rVeHD/+h iH9jn9vd4/1vh6+rS1vcHPYS3j+9P50PT8Ph7u60BYz5q6Tj8PQTXx84xA90msJ6ZRe+M7y9vX3L MMXXhtutHPRP31nSVq9NN5tN6+jr38dAP5r/J8D92zmW1/+WJL8q1LmrXWtrd2nr9KKry6vWvH79 eHv6DzjBilfJ3nr1+bj/8QeN97vZ4+Ujjvnue9e++fYvnV98u1fItEvj917S/+9lrr/28/Tl/tf/ AlBLAQIUABQAAgAIAA5XqjziX04t4gsAAOQZAAALAAAAAAAAAAAAIAAAAAAAAABzcGlyaXQyLnN2 Z1BLAQIUABQAAgAIAEZRazwoYC/32gsAAN8ZAAAKAAAAAAAAAAAAIAAAAAsMAABzcGlyaXQuc3Zn UEsFBgAAAAACAAIAcQAAAA0YAAAAAA==