38833 2010-05-10 00:16:05 -0700 [chromium] detect num processors to pass to make -j on Linux 2010-05-11 20:51:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony webkit-unassigned commit-queue evan oldest_to_newest 223176 0 tony 2010-05-10 00:16:05 -0700 [chromium] detect num processors to pass to make -j on Linux 223177 1 55523 tony 2010-05-10 00:17:20 -0700 Created attachment 55523 Patch 223178 2 tony 2010-05-10 00:18:00 -0700 Since evan knows perl, maybe he can review? The previous code was hard coded to use -j4. 223420 3 evan 2010-05-10 11:27:15 -0700 This looks fine to me. I ran it by a perl-hacker friend and he suggested the following. Note that if the grep fails for some reason in your original code your numCpus ends up being 0, which might be bad. my $numCpus = (grep /processor/, `cat /proc/cpuinfox`) || 1; In list context, `` splits on lines so the grep works linewise, and then when you stuff the list that grep returns into scalar context (numCpus) it gets the length of the list. Perl is so awesome in a scary sort of way! Your original code LGTM as well. 223578 4 55620 tony 2010-05-10 16:34:48 -0700 Created attachment 55620 Patch 223580 5 55620 tony 2010-05-10 16:35:48 -0700 Comment on attachment 55620 Patch Updated to use perl's grep and to have a fallback in case of failure. 224371 6 55620 tony 2010-05-11 20:51:25 -0700 Comment on attachment 55620 Patch Clearing flags on attachment: 55620 Committed r59201: <http://trac.webkit.org/changeset/59201> 224372 7 tony 2010-05-11 20:51:30 -0700 All reviewed patches have been landed. Closing bug. 55523 2010-05-10 00:17:20 -0700 2010-05-10 16:34:45 -0700 Patch bug-38833-20100510001719.patch text/plain 1229 tony ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0ZTQ4YjM2NGE0YzEyMjY5MDc0ZGFmYWYyNmI0YjRkMzAzMTI5NTJmLi42YjFhY2Ux NzEzYjdhMjU2ZDg5YWE3YzdhMGYyZDc0ZTYzMWZmZTA4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDUtMTAgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGRldGVjdCBu dW0gcHJvY2Vzc29ycyB0byBwYXNzIHRvIG1ha2UgLWogb24gTGludXgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4ODMzCisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdGRpcnMucG06CisKIDIwMTAtMDUtMDkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0By aW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENocmlzIEplcmRvbmVrLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRkaXJzLnBtCmluZGV4IDRmZWNmNmI1Mjk4ODM1NTE3MmU2ZTNhNDA5MGJmMTdjYjA2 YjAzYzguLjFlNjhkNWZhYzQyY2VmYjYyYTI5ZTBmNmQ0YjZjNGMzYmEwMzQ4MGYgMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE0MjcsNyArMTQyNyw4IEBAIHN1YiBidWlsZENocm9t aXVtTWFrZWZpbGUoJCQkKQogICAgICAgICByZXR1cm4gc3lzdGVtIHF3KHJtIC1yZiBvdXQpOwog ICAgIH0KICAgICBteSAkY29uZmlnID0gY29uZmlndXJhdGlvbigpOwotICAgIG15IEBjb21tYW5k ID0gKCJtYWtlIiwgIi1qNCIsICJCVUlMRFRZUEU9JGNvbmZpZyIsICR0YXJnZXQpOworICAgIGNo b21wKG15ICRudW1DcHVzID0gYGdyZXAgcHJvY2Vzc29yIC9wcm9jL2NwdWluZm8gfCB3YyAtbGAp OworICAgIG15IEBjb21tYW5kID0gKCJtYWtlIiwgIi1qJG51bUNwdXMiLCAiQlVJTERUWVBFPSRj b25maWciLCAkdGFyZ2V0KTsKICAgICBwcmludCBqb2luKCIgIiwgQGNvbW1hbmQpIC4gIlxuIjsK ICAgICByZXR1cm4gc3lzdGVtIEBjb21tYW5kOwogfQo= 55620 2010-05-10 16:34:48 -0700 2010-05-11 20:51:25 -0700 Patch bug-38833-20100510163447.patch text/plain 1228 tony ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0ZTQ4YjM2NGE0YzEyMjY5MDc0ZGFmYWYyNmI0YjRkMzAzMTI5NTJmLi42YjFhY2Ux NzEzYjdhMjU2ZDg5YWE3YzdhMGYyZDc0ZTYzMWZmZTA4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDUtMTAgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGRldGVjdCBu dW0gcHJvY2Vzc29ycyB0byBwYXNzIHRvIG1ha2UgLWogb24gTGludXgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4ODMzCisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdGRpcnMucG06CisKIDIwMTAtMDUtMDkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0By aW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENocmlzIEplcmRvbmVrLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRkaXJzLnBtCmluZGV4IDRmZWNmNmI1Mjk4ODM1NTE3MmU2ZTNhNDA5MGJmMTdjYjA2 YjAzYzguLjA0YzQ4MDI3MTdmMWQ5ODQxYWU1YzNiNTdmNDUzNzM3OGJiMTAyZmYgMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE0MjcsNyArMTQyNyw4IEBAIHN1YiBidWlsZENocm9t aXVtTWFrZWZpbGUoJCQkKQogICAgICAgICByZXR1cm4gc3lzdGVtIHF3KHJtIC1yZiBvdXQpOwog ICAgIH0KICAgICBteSAkY29uZmlnID0gY29uZmlndXJhdGlvbigpOwotICAgIG15IEBjb21tYW5k ID0gKCJtYWtlIiwgIi1qNCIsICJCVUlMRFRZUEU9JGNvbmZpZyIsICR0YXJnZXQpOworICAgIG15 ICRudW1DcHVzID0gKGdyZXAgL3Byb2Nlc3Nvci8sIGBjYXQgL3Byb2MvY3B1aW5mb2ApIHx8IDE7 CisgICAgbXkgQGNvbW1hbmQgPSAoIm1ha2UiLCAiLWokbnVtQ3B1cyIsICJCVUlMRFRZUEU9JGNv bmZpZyIsICR0YXJnZXQpOwogICAgIHByaW50IGpvaW4oIiAiLCBAY29tbWFuZCkgLiAiXG4iOwog ICAgIHJldHVybiBzeXN0ZW0gQGNvbW1hbmQ7CiB9Cg==