38825 2010-05-09 17:12:05 -0700 HTMLInputElement::size not available through Chromium WebInputElement interface 2010-05-11 15:39:38 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 0 dhollowa webkit-unassigned commit-queue dhollowa fishd webkit.review.bot oldest_to_newest 223114 0 dhollowa 2010-05-09 17:12:05 -0700 The Chromium WebInputElement interface does not provide an accessor to HTMLInputElement::size(). During form AutoFill Chromium needs to access the input element's size attribute in aid of form matching and filling heuristics. Files in question: WebKit/chromium/public/WebInputElement.h WebKit/chromium/src/WebInputElement.cpp Expected: WebKit::WebInputElement::size() method should exist and provide value of HTMLInputElement::siz(). 223115 1 55512 dhollowa 2010-05-09 17:20:05 -0700 Created attachment 55512 Patch 223406 2 55574 dhollowa 2010-05-10 11:00:29 -0700 Created attachment 55574 Rewording in change log. Rewording in change log. 223407 3 webkit.review.bot 2010-05-10 11:07:27 -0700 Attachment 55574 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/chromium/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 223443 4 55574 fishd 2010-05-10 12:19:15 -0700 Comment on attachment 55574 Rewording in change log. WebKit/chromium/ChangeLog:7 + access the input element's size attribute in aid of form matching and replace tabs with spaces. otherwise LGTM 223464 5 55592 dhollowa 2010-05-10 12:51:17 -0700 Created attachment 55592 Removed tabs. Removed tabs. 224194 6 55592 commit-queue 2010-05-11 15:39:32 -0700 Comment on attachment 55592 Removed tabs. Clearing flags on attachment: 55592 Committed r59176: <http://trac.webkit.org/changeset/59176> 224195 7 commit-queue 2010-05-11 15:39:38 -0700 All reviewed patches have been landed. Closing bug. 55512 2010-05-09 17:20:05 -0700 2010-05-10 11:00:29 -0700 Patch chromium_web_input_element.patch text/plain 2014 dhollowa SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTkwNjMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDUtMDkgIERhdmlk IEhvbGxvd2F5ICA8ZGhvbGxvd2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gVGhlIFdlYklucHV0RWxlbWVu dCBpbnRlcmZhY2UgZG9lcyBub3QgcHJvdmlkZSBhbiBhY2Nlc3NvciB0bworICAgICAgICBIVE1M SW5wdXRFbGVtZW50OjpzaXplKCkuICBEdXJpbmcgZm9ybSBBdXRvRmlsbCBDaHJvbWl1bSBuZWVk cyB0byBhY2Nlc3MgCisgICAgICAgIHRoZSBpbnB1dCBlbGVtZW50J3Mgc2l6ZSBhdHRyaWJ1dGUg aW4gYWlkIG9mIGZvcm0gbWF0Y2hpbmcgYW5kIGZpbGxpbmcKKyAgICAgICAgaGV1cmlzdGljcy4K KyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zODgyNQorCisgICAgICAgICogcHVibGljL1dlYklucHV0RWxlbWVudC5oOgorICAgICAgICAq IHNyYy9XZWJJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnB1dEVsZW1l bnQ6OnNpemUpOgorCiAyMDEwLTA1LTA4ICBKZW5zIEFsZmtlICA8c25lakBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYklucHV0RWxlbWVudC5oCShyZXZpc2lvbiA1OTA2MykKKysrIFdlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTg1LDYg Kzg1LDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAgICAgICAgIFdFQktJVF9BUEkgaW50IG1heExl bmd0aCgpIGNvbnN0OwogICAgICAgICBXRUJLSVRfQVBJIGJvb2wgaXNBY3RpdmF0ZWRTdWJtaXQo KSBjb25zdDsKICAgICAgICAgV0VCS0lUX0FQSSB2b2lkIHNldEFjdGl2YXRlZFN1Ym1pdChib29s KTsKKyAgICAgICAgV0VCS0lUX0FQSSBpbnQgc2l6ZSgpIGNvbnN0OwogICAgICAgICBXRUJLSVRf QVBJIHZvaWQgc2V0VmFsdWUoY29uc3QgV2ViU3RyaW5nJiB2YWx1ZSk7CiAgICAgICAgIFdFQktJ VF9BUEkgV2ViU3RyaW5nIHZhbHVlKCkgY29uc3Q7CiAgICAgICAgIFdFQktJVF9BUEkgdm9pZCBz ZXRBdXRvZmlsbGVkKGJvb2wpOwpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVs ZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVt ZW50LmNwcAkocmV2aXNpb24gNTkwNjMpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0 RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcwLDYgKzcwLDExIEBAIHZvaWQgV2ViSW5w dXRFbGVtZW50OjpzZXRBY3RpdmF0ZWRTdWJtaXQKICAgICB1bndyYXA8SFRNTElucHV0RWxlbWVu dD4oKS0+c2V0QWN0aXZhdGVkU3VibWl0KGFjdGl2YXRlZCk7CiB9CiAKK2ludCBXZWJJbnB1dEVs ZW1lbnQ6OnNpemUoKSBjb25zdAoreworICAgIHJldHVybiBjb25zdFVud3JhcDxIVE1MSW5wdXRF bGVtZW50PigpLT5zaXplKCk7Cit9CisKIHZvaWQgV2ViSW5wdXRFbGVtZW50OjpzZXRWYWx1ZShj b25zdCBXZWJTdHJpbmcmIHZhbHVlKQogewogICAgIHVud3JhcDxIVE1MSW5wdXRFbGVtZW50Pigp LT5zZXRWYWx1ZSh2YWx1ZSk7Cg== 55574 2010-05-10 11:00:29 -0700 2010-05-10 12:51:17 -0700 Rewording in change log. chromium_web_input_element2.patch text/plain 2004 dhollowa SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTkwNjMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDUtMDkgIERhdmlk IEhvbGxvd2F5ICA8ZGhvbGxvd2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIHNpemUgbWV0aG9kIHRv IFdlYklucHV0RWxlbWVudCBjbGFzcywgcHJvdmlkaW5nIHNhbWUgZGF0YQorICAgICAgICBhcyBI VE1MSW5wdXRFbGVtZW50OjpzaXplKCkuICBEdXJpbmcgZm9ybSBBdXRvRmlsbCBDaHJvbWl1bSBu ZWVkcyB0bworCQlhY2Nlc3MgdGhlIGlucHV0IGVsZW1lbnQncyBzaXplIGF0dHJpYnV0ZSBpbiBh aWQgb2YgZm9ybSBtYXRjaGluZyBhbmQKKwkJZmlsbGluZyBoZXVyaXN0aWNzLgorICAgICAgICAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4ODI1CisK KyAgICAgICAgKiBwdWJsaWMvV2ViSW5wdXRFbGVtZW50Lmg6CisgICAgICAgICogc3JjL1dlYklu cHV0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYklucHV0RWxlbWVudDo6c2l6ZSk6 CisKIDIwMTAtMDUtMDggIEplbnMgQWxma2UgIDxzbmVqQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYklucHV0RWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViSW5wdXRFbGVtZW50LmgJKHJldmlzaW9uIDU5MDYzKQorKysgV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtODUsNiArODUsNyBAQCBu YW1lc3BhY2UgV2ViS2l0IHsKICAgICAgICAgV0VCS0lUX0FQSSBpbnQgbWF4TGVuZ3RoKCkgY29u c3Q7CiAgICAgICAgIFdFQktJVF9BUEkgYm9vbCBpc0FjdGl2YXRlZFN1Ym1pdCgpIGNvbnN0Owog ICAgICAgICBXRUJLSVRfQVBJIHZvaWQgc2V0QWN0aXZhdGVkU3VibWl0KGJvb2wpOworICAgICAg ICBXRUJLSVRfQVBJIGludCBzaXplKCkgY29uc3Q7CiAgICAgICAgIFdFQktJVF9BUEkgdm9pZCBz ZXRWYWx1ZShjb25zdCBXZWJTdHJpbmcmIHZhbHVlKTsKICAgICAgICAgV0VCS0lUX0FQSSBXZWJT dHJpbmcgdmFsdWUoKSBjb25zdDsKICAgICAgICAgV0VCS0lUX0FQSSB2b2lkIHNldEF1dG9maWxs ZWQoYm9vbCk7CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RWxlbWVudC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCShy ZXZpc2lvbiA1OTA2MykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNw cAkod29ya2luZyBjb3B5KQpAQCAtNzAsNiArNzAsMTEgQEAgdm9pZCBXZWJJbnB1dEVsZW1lbnQ6 OnNldEFjdGl2YXRlZFN1Ym1pdAogICAgIHVud3JhcDxIVE1MSW5wdXRFbGVtZW50PigpLT5zZXRB Y3RpdmF0ZWRTdWJtaXQoYWN0aXZhdGVkKTsKIH0KIAoraW50IFdlYklucHV0RWxlbWVudDo6c2l6 ZSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIGNvbnN0VW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+KCkt PnNpemUoKTsKK30KKwogdm9pZCBXZWJJbnB1dEVsZW1lbnQ6OnNldFZhbHVlKGNvbnN0IFdlYlN0 cmluZyYgdmFsdWUpCiB7CiAgICAgdW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+KCktPnNldFZhbHVl KHZhbHVlKTsK 55592 2010-05-10 12:51:17 -0700 2010-05-11 15:39:32 -0700 Removed tabs. chromium_web_input_element3.patch text/plain 2016 dhollowa SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTkwNjMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDUtMDkgIERhdmlk IEhvbGxvd2F5ICA8ZGhvbGxvd2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIHNpemUgbWV0aG9kIHRv IFdlYklucHV0RWxlbWVudCBjbGFzcywgcHJvdmlkaW5nIHNhbWUgZGF0YQorICAgICAgICBhcyBI VE1MSW5wdXRFbGVtZW50OjpzaXplKCkuICBEdXJpbmcgZm9ybSBBdXRvRmlsbCBDaHJvbWl1bSBu ZWVkcyB0bworICAgICAgICBhY2Nlc3MgdGhlIGlucHV0IGVsZW1lbnQncyBzaXplIGF0dHJpYnV0 ZSBpbiBhaWQgb2YgZm9ybSBtYXRjaGluZyBhbmQKKyAgICAgICAgZmlsbGluZyBoZXVyaXN0aWNz LgorICAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM4ODI1CisKKyAgICAgICAgKiBwdWJsaWMvV2ViSW5wdXRFbGVtZW50Lmg6CisgICAgICAg ICogc3JjL1dlYklucHV0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYklucHV0RWxl bWVudDo6c2l6ZSk6CisKIDIwMTAtMDUtMDggIEplbnMgQWxma2UgIDxzbmVqQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYklucHV0RWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViSW5wdXRFbGVtZW50LmgJKHJldmlzaW9uIDU5MDYzKQorKysgV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtODUs NiArODUsNyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKICAgICAgICAgV0VCS0lUX0FQSSBpbnQgbWF4 TGVuZ3RoKCkgY29uc3Q7CiAgICAgICAgIFdFQktJVF9BUEkgYm9vbCBpc0FjdGl2YXRlZFN1Ym1p dCgpIGNvbnN0OwogICAgICAgICBXRUJLSVRfQVBJIHZvaWQgc2V0QWN0aXZhdGVkU3VibWl0KGJv b2wpOworICAgICAgICBXRUJLSVRfQVBJIGludCBzaXplKCkgY29uc3Q7CiAgICAgICAgIFdFQktJ VF9BUEkgdm9pZCBzZXRWYWx1ZShjb25zdCBXZWJTdHJpbmcmIHZhbHVlKTsKICAgICAgICAgV0VC S0lUX0FQSSBXZWJTdHJpbmcgdmFsdWUoKSBjb25zdDsKICAgICAgICAgV0VCS0lUX0FQSSB2b2lk IHNldEF1dG9maWxsZWQoYm9vbCk7CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0 RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVs ZW1lbnQuY3BwCShyZXZpc2lvbiA1OTA2MykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5w dXRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzAsNiArNzAsMTEgQEAgdm9pZCBXZWJJ bnB1dEVsZW1lbnQ6OnNldEFjdGl2YXRlZFN1Ym1pdAogICAgIHVud3JhcDxIVE1MSW5wdXRFbGVt ZW50PigpLT5zZXRBY3RpdmF0ZWRTdWJtaXQoYWN0aXZhdGVkKTsKIH0KIAoraW50IFdlYklucHV0 RWxlbWVudDo6c2l6ZSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIGNvbnN0VW53cmFwPEhUTUxJbnB1 dEVsZW1lbnQ+KCktPnNpemUoKTsKK30KKwogdm9pZCBXZWJJbnB1dEVsZW1lbnQ6OnNldFZhbHVl KGNvbnN0IFdlYlN0cmluZyYgdmFsdWUpCiB7CiAgICAgdW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+ KCktPnNldFZhbHVlKHZhbHVlKTsK