38821 2010-05-09 15:17:19 -0700 Calling Node::setDocument() to change the document has no effect 2010-05-10 05:00:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 cjerdonek cjerdonek abarth commit-queue eric webkit.review.bot oldest_to_newest 223098 0 cjerdonek 2010-05-09 15:17:19 -0700 Node::setDocument() does nothing if the caller attempts to change the document of a node using it. To avoid the mistake of trying to use setDocument() to change the document of a node (without first removing the node from its document), we may want to assert at the beginning that the caller is not attempting to do this. 223112 1 55511 cjerdonek 2010-05-09 16:54:15 -0700 Created attachment 55511 Proposed patch 223249 2 55511 commit-queue 2010-05-10 04:41:05 -0700 Comment on attachment 55511 Proposed patch Clearing flags on attachment: 55511 Committed r59072: <http://trac.webkit.org/changeset/59072> 223250 3 commit-queue 2010-05-10 04:41:09 -0700 All reviewed patches have been landed. Closing bug. 223256 4 webkit.review.bot 2010-05-10 05:00:54 -0700 http://trac.webkit.org/changeset/59072 might have broken Qt Linux ARMv5 Release 55511 2010-05-09 16:54:15 -0700 2010-05-10 04:41:05 -0700 Proposed patch _patch-38821-1.diff text/plain 1799 cjerdonek ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTRiNzdiYS4uOTZkYzI5ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNS0wOSAgQ2hyaXMgSmVyZG9u ZWsgIDxjamVyZG9uZWtAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBc3NlcnRlZCB0aGF0IE5vZGU6OnNldERvY3VtZW50KCkgaXMg bm90IGJlaW5nIHVzZWQgdG8gY2hhbmdlCisgICAgICAgIHRoZSBkb2N1bWVudCBvZiBhIG5vZGUu CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4ODIx CisKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjpzZXRE b2N1bWVudCk6CisgICAgICAgICAgQWRkZWQgYW4gQVNTRVJUIGF0IHRoZSBiZWdpbm5pbmcgb2Yg dGhlIGZ1bmN0aW9uLgorICAgICAgICAqIGRvbS9Ob2RlLmg6CisgICAgICAgICAgRG9jdW1lbnRl ZCB0aGF0IE5vZGU6OnNldERvY3VtZW50KCkgc2hvdWxkIG5vdCBiZSB1c2VkIHRvIGNoYW5nZSB0 aGUKKyAgICAgICAgICBkb2N1bWVudCBvZiBhIG5vZGUgdW50aWwgYWZ0ZXIgdGhlIG5vZGUgaGFz IGJlZW4gcmVtb3ZlZCBmcm9tIGl0cworICAgICAgICAgIHByaW9yIGRvY3VtZW50LgorCiAyMDEw LTA1LTEwICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBOb3QgcmV2aWV3ZWQ6IHJvbGxiYWNrIHRoZSBjb21taXQgcjU5MDYyCmRpZmYgLS1naXQgYS9X ZWJDb3JlL2RvbS9Ob2RlLmNwcCBiL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IDg4MGRkZjku LmM4OTkxNGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL05vZGUuY3BwCisrKyBiL1dlYkNvcmUv ZG9tL05vZGUuY3BwCkBAIC00MTYsNiArNDE2LDcgQEAgc3RhdGljIHZvaWQgc2V0RGlkTW92ZVRv TmV3T3duZXJEb2N1bWVudFdhc0NhbGxlZChib29sIHdhc0NhbGxlZCkKICAgICAKIHZvaWQgTm9k ZTo6c2V0RG9jdW1lbnQoRG9jdW1lbnQqIGRvY3VtZW50KQogeworICAgIEFTU0VSVCghaW5Eb2N1 bWVudCgpIHx8IG1fZG9jdW1lbnQgPT0gZG9jdW1lbnQpOwogICAgIGlmIChpbkRvY3VtZW50KCkg fHwgbV9kb2N1bWVudCA9PSBkb2N1bWVudCkKICAgICAgICAgcmV0dXJuOwogCmRpZmYgLS1naXQg YS9XZWJDb3JlL2RvbS9Ob2RlLmggYi9XZWJDb3JlL2RvbS9Ob2RlLmgKaW5kZXggOGEzYzY1OC4u ZDZiYThkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vTm9kZS5oCisrKyBiL1dlYkNvcmUvZG9t L05vZGUuaApAQCAtMzU0LDYgKzM1NCw5IEBAIHB1YmxpYzoKICAgICAgICAgQVNTRVJUKG1fZG9j dW1lbnQgfHwgKG5vZGVUeXBlKCkgPT0gRE9DVU1FTlRfVFlQRV9OT0RFICYmICFpbkRvY3VtZW50 KCkpKTsKICAgICAgICAgcmV0dXJuIG1fZG9jdW1lbnQ7CiAgICAgfQorCisgICAgLy8gRG8gbm90 IHVzZSB0aGlzIG1ldGhvZCB0byBjaGFuZ2UgdGhlIGRvY3VtZW50IG9mIGEgbm9kZSB1bnRpbCBh ZnRlciB0aGUgbm9kZSBoYXMgYmVlbgorICAgIC8vIHJlbW92ZWQgZnJvbSBpdHMgcHJldmlvdXMg ZG9jdW1lbnQuCiAgICAgdm9pZCBzZXREb2N1bWVudChEb2N1bWVudCopOwogCiAgICAgLy8gUmV0 dXJucyB0cnVlIGlmIHRoaXMgbm9kZSBpcyBhc3NvY2lhdGVkIHdpdGggYSBkb2N1bWVudCBhbmQg aXMgaW4gaXRzIGFzc29jaWF0ZWQgZG9jdW1lbnQncwo=