38815 2010-05-09 03:57:14 -0700 Fixed version of: "Optimized o[s] where o is a cell and s is a string" 2010-05-09 04:50:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 223034 0 mjs 2010-05-09 03:57:14 -0700 Fixed version of: "Optimized o[s] where o is a cell and s is a string" 223035 1 55500 mjs 2010-05-09 04:07:11 -0700 Created attachment 55500 Patch 223036 2 55500 oliver 2010-05-09 04:15:30 -0700 Comment on attachment 55500 Patch r=me 223038 3 mjs 2010-05-09 04:18:52 -0700 Committed r59055: <http://trac.webkit.org/changeset/59055> 223040 4 webkit.review.bot 2010-05-09 04:50:42 -0700 http://trac.webkit.org/changeset/59055 might have broken Qt Linux ARMv7 Release 55500 2010-05-09 04:07:11 -0700 2010-05-09 04:15:29 -0700 Patch bug-38815-20100509040709.patch text/plain 5379 mjs SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5MDUzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDUtMDkgIE1hY2llaiBT dGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBGaXhlZCB2ZXJzaW9uIG9mOiAi T3B0aW1pemVkIG9bc10gd2hlcmUgbyBpcyBhIGNlbGwgYW5kIHMgaXMgYSBzdHJpbmciCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODgxNQorICAgICAg ICAKKyAgICAgICAgRml4ZWQgdGhlIHByZXZpb3VzIHBhdGNoIGZvciB0aGlzIGZyb20gR2VvZmYg R2FyZW4uCisgICAgICAgIAorICAgICAgICBUaGUgdHdvIHByb2JsZW1zIHdlcmUgYSBtaXNzaW5n IGV4Y2VwdGlvbiBjaGVjayBhbmQgYSBQcm9wZXJ0eVNsb3QKKyAgICAgICAgaW5pdGlhbGl6ZWQg aW1wcm9wZXJseSwgbGVhZGluZyB0byBjcmFzaGVzIGFuZCBmYWlsdXJlcyBpbiB0aGUgY2FzZQor ICAgICAgICBvZiBnZXR0ZXJzIGFjY2Vzc2VkIHdpdGggYnJhY2tldCBzeW50YXguCisKKyAgICBQ cmV2aW91cyBwYXRjaDoKKworICAgICAgICBPcHRpbWl6ZWQgb1tzXSB3aGVyZSBvIGlzIGEgY2Vs bCBhbmQgcyBpcyBhIHN0cmluZywgcmVtb3Zpbmcgc29tZSBvbGQKKyAgICAgICAgY29kZSB0aGF0 IHdhc24ndCByZWFsbHkgdHVuZWQgZm9yIHRoZSBKSVQuCisgICAgICAgIAorICAgICAgICBTdW5T cGlkZXIgc2F5cyAwLjglIGZhc3Rlci4KKworICAgICAgICAqIGppdC9KSVRTdHVicy5jcHA6Cisg ICAgICAgIChKU0M6OkRFRklORV9TVFVCX0ZVTkNUSU9OKToKKyAgICAgICAgKiBydW50aW1lL0pT Q2VsbC5oOgorCiAyMDEwLTA1LTA4ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5v a2lhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCkluZGV4OiBKYXZhU2Ny aXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2pp dC9KSVRTdHVicy5jcHAJKHJldmlzaW9uIDU5MDUzKQorKysgSmF2YVNjcmlwdENvcmUvaml0L0pJ VFN0dWJzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA4NywzMSArMjA4NywzNiBAQCBERUZJTkVf U1RVQl9GVU5DVElPTihFbmNvZGVkSlNWYWx1ZSwgb3BfCiAgICAgSlNWYWx1ZSBiYXNlVmFsdWUg PSBzdGFja0ZyYW1lLmFyZ3NbMF0uanNWYWx1ZSgpOwogICAgIEpTVmFsdWUgc3Vic2NyaXB0ID0g c3RhY2tGcmFtZS5hcmdzWzFdLmpzVmFsdWUoKTsKIAotICAgIEpTVmFsdWUgcmVzdWx0OworICAg IGlmIChMSUtFTFkoYmFzZVZhbHVlLmlzQ2VsbCgpICYmIHN1YnNjcmlwdC5pc1N0cmluZygpKSkg eworICAgICAgICBJZGVudGlmaWVyIHByb3BlcnR5TmFtZShjYWxsRnJhbWUsIGFzU3RyaW5nKHN1 YnNjcmlwdCktPnZhbHVlKGNhbGxGcmFtZSkpOworICAgICAgICBQcm9wZXJ0eVNsb3Qgc2xvdChh c0NlbGwoYmFzZVZhbHVlKSk7CisgICAgICAgIGlmIChhc0NlbGwoYmFzZVZhbHVlKS0+ZmFzdEdl dE93blByb3BlcnR5U2xvdChjYWxsRnJhbWUsIHByb3BlcnR5TmFtZSwgc2xvdCkpIHsKKyAgICAg ICAgICAgIEpTVmFsdWUgcmVzdWx0ID0gc2xvdC5nZXRWYWx1ZShjYWxsRnJhbWUsIHByb3BlcnR5 TmFtZSk7CisgICAgICAgICAgICBDSEVDS19GT1JfRVhDRVBUSU9OKCk7CisgICAgICAgICAgICBy ZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHJlc3VsdCk7CisgICAgICAgIH0KKyAgICB9CiAKLSAgICBp ZiAoTElLRUxZKHN1YnNjcmlwdC5pc1VJbnQzMigpKSkgeworICAgIGlmIChzdWJzY3JpcHQuaXNV SW50MzIoKSkgewogICAgICAgICB1aW50MzJfdCBpID0gc3Vic2NyaXB0LmFzVUludDMyKCk7Ci0g ICAgICAgIGlmIChpc0pTQXJyYXkoZ2xvYmFsRGF0YSwgYmFzZVZhbHVlKSkgewotICAgICAgICAg ICAgSlNBcnJheSoganNBcnJheSA9IGFzQXJyYXkoYmFzZVZhbHVlKTsKLSAgICAgICAgICAgIGlm IChqc0FycmF5LT5jYW5HZXRJbmRleChpKSkKLSAgICAgICAgICAgICAgICByZXN1bHQgPSBqc0Fy cmF5LT5nZXRJbmRleChpKTsKLSAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICByZXN1 bHQgPSBqc0FycmF5LT5KU0FycmF5OjpnZXQoY2FsbEZyYW1lLCBpKTsKLSAgICAgICAgfSBlbHNl IGlmIChpc0pTU3RyaW5nKGdsb2JhbERhdGEsIGJhc2VWYWx1ZSkgJiYgYXNTdHJpbmcoYmFzZVZh bHVlKS0+Y2FuR2V0SW5kZXgoaSkpIHsKLSAgICAgICAgICAgIC8vIEFsbCBmYXN0IGJ5dGUgYXJy YXkgYWNjZXNzZXMgYXJlIHNhZmUgZnJvbSBleGNlcHRpb25zIHNvIHJldHVybiBpbW1lZGlhdGVs eSB0byBhdm9pZCBleGNlcHRpb24gY2hlY2tzLgorICAgICAgICBpZiAoaXNKU1N0cmluZyhnbG9i YWxEYXRhLCBiYXNlVmFsdWUpICYmIGFzU3RyaW5nKGJhc2VWYWx1ZSktPmNhbkdldEluZGV4KGkp KSB7CiAgICAgICAgICAgICBjdGlQYXRjaENhbGxCeVJldHVybkFkZHJlc3MoY2FsbEZyYW1lLT5j b2RlQmxvY2soKSwgU1RVQl9SRVRVUk5fQUREUkVTUywgRnVuY3Rpb25QdHIoY3RpX29wX2dldF9i eV92YWxfc3RyaW5nKSk7Ci0gICAgICAgICAgICByZXN1bHQgPSBhc1N0cmluZyhiYXNlVmFsdWUp LT5nZXRJbmRleChjYWxsRnJhbWUsIGkpOwotICAgICAgICB9IGVsc2UgaWYgKGlzSlNCeXRlQXJy YXkoZ2xvYmFsRGF0YSwgYmFzZVZhbHVlKSAmJiBhc0J5dGVBcnJheShiYXNlVmFsdWUpLT5jYW5B Y2Nlc3NJbmRleChpKSkgeworICAgICAgICAgICAgSlNWYWx1ZSByZXN1bHQgPSBhc1N0cmluZyhi YXNlVmFsdWUpLT5nZXRJbmRleChjYWxsRnJhbWUsIGkpOworICAgICAgICAgICAgQ0hFQ0tfRk9S X0VYQ0VQVElPTigpOworICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQp OworICAgICAgICB9CisgICAgICAgIGlmIChpc0pTQnl0ZUFycmF5KGdsb2JhbERhdGEsIGJhc2VW YWx1ZSkgJiYgYXNCeXRlQXJyYXkoYmFzZVZhbHVlKS0+Y2FuQWNjZXNzSW5kZXgoaSkpIHsKICAg ICAgICAgICAgIC8vIEFsbCBmYXN0IGJ5dGUgYXJyYXkgYWNjZXNzZXMgYXJlIHNhZmUgZnJvbSBl eGNlcHRpb25zIHNvIHJldHVybiBpbW1lZGlhdGVseSB0byBhdm9pZCBleGNlcHRpb24gY2hlY2tz LgogICAgICAgICAgICAgY3RpUGF0Y2hDYWxsQnlSZXR1cm5BZGRyZXNzKGNhbGxGcmFtZS0+Y29k ZUJsb2NrKCksIFNUVUJfUkVUVVJOX0FERFJFU1MsIEZ1bmN0aW9uUHRyKGN0aV9vcF9nZXRfYnlf dmFsX2J5dGVfYXJyYXkpKTsKICAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoYXNC eXRlQXJyYXkoYmFzZVZhbHVlKS0+Z2V0SW5kZXgoY2FsbEZyYW1lLCBpKSk7Ci0gICAgICAgIH0g ZWxzZQotICAgICAgICAgICAgcmVzdWx0ID0gYmFzZVZhbHVlLmdldChjYWxsRnJhbWUsIGkpOwot ICAgIH0gZWxzZSB7Ci0gICAgICAgIElkZW50aWZpZXIgcHJvcGVydHkoY2FsbEZyYW1lLCBzdWJz Y3JpcHQudG9TdHJpbmcoY2FsbEZyYW1lKSk7Ci0gICAgICAgIHJlc3VsdCA9IGJhc2VWYWx1ZS5n ZXQoY2FsbEZyYW1lLCBwcm9wZXJ0eSk7CisgICAgICAgIH0KKyAgICAgICAgSlNWYWx1ZSByZXN1 bHQgPSBiYXNlVmFsdWUuZ2V0KGNhbGxGcmFtZSwgaSk7CisgICAgICAgIENIRUNLX0ZPUl9FWENF UFRJT04oKTsKKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOwogICAgIH0K LQorICAgIAorICAgIElkZW50aWZpZXIgcHJvcGVydHkoY2FsbEZyYW1lLCBzdWJzY3JpcHQudG9T dHJpbmcoY2FsbEZyYW1lKSk7CisgICAgSlNWYWx1ZSByZXN1bHQgPSBiYXNlVmFsdWUuZ2V0KGNh bGxGcmFtZSwgcHJvcGVydHkpOwogICAgIENIRUNLX0ZPUl9FWENFUFRJT05fQVRfRU5EKCk7CiAg ICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOwogfQpJbmRleDogSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0NlbGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTQ2VsbC5oCShyZXZpc2lvbiA1OTA1MykKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlND ZWxsLmgJKHdvcmtpbmcgY29weSkKQEAgLTExMSwxMiArMTExLDE3IEBAIG5hbWVzcGFjZSBKU0Mg ewogICAgICAgICB2b2lkKiB2cHRyKCkgeyByZXR1cm4gKnJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCoq Pih0aGlzKTsgfQogICAgICAgICB2b2lkIHNldFZQdHIodm9pZCogdnB0cikgeyAqcmVpbnRlcnBy ZXRfY2FzdDx2b2lkKio+KHRoaXMpID0gdnB0cjsgfQogCisgICAgICAgIC8vIEZJWE1FOiBSZW5h bWUgZ2V0T3duUHJvcGVydHlTbG90IHRvIHZpcnR1YWxHZXRPd25Qcm9wZXJ0eVNsb3QsIGFuZAor ICAgICAgICAvLyBmYXN0R2V0T3duUHJvcGVydHlTbG90IHRvIGdldE93blByb3BlcnR5U2xvdC4g Q2FsbGVycyBzaG91bGQgYWx3YXlzCisgICAgICAgIC8vIGNhbGwgdGhpcyBmdW5jdGlvbiwgbm90 IGl0cyBzbG93ZXIgdmlydHVhbCBjb3VudGVycGFydC4gKEZvciBpbnRlZ2VyCisgICAgICAgIC8v IHByb3BlcnR5IG5hbWVzLCB3ZSB3YW50IGEgc2ltaWxhciBpbnRlcmZhY2Ugd2l0aCBhcHByb3By aWF0ZSBvcHRpbWl6YXRpb25zLikKKyAgICAgICAgYm9vbCBmYXN0R2V0T3duUHJvcGVydHlTbG90 KEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgUHJvcGVydHlTbG90 Jik7CisKICAgICBwcm90ZWN0ZWQ6CiAgICAgICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBBbm9u eW1vdXNTbG90Q291bnQgPSAwOwogCiAgICAgcHJpdmF0ZToKICAgICAgICAgLy8gQmFzZSBpbXBs ZW1lbnRhdGlvbjsgZm9yIG5vbi1vYmplY3QgY2xhc3NlcyBpbXBsZW1lbnRzIGdldFByb3BlcnR5 U2xvdC4KLSAgICAgICAgYm9vbCBmYXN0R2V0T3duUHJvcGVydHlTbG90KEV4ZWNTdGF0ZSosIGNv bnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgUHJvcGVydHlTbG90Jik7CiAgICAgICAgIHZp cnR1YWwgYm9vbCBnZXRPd25Qcm9wZXJ0eVNsb3QoRXhlY1N0YXRlKiwgY29uc3QgSWRlbnRpZmll ciYgcHJvcGVydHlOYW1lLCBQcm9wZXJ0eVNsb3QmKTsKICAgICAgICAgdmlydHVhbCBib29sIGdl dE93blByb3BlcnR5U2xvdChFeGVjU3RhdGUqLCB1bnNpZ25lZCBwcm9wZXJ0eU5hbWUsIFByb3Bl cnR5U2xvdCYpOwogICAgICAgICAK