38773 2010-05-07 13:39:49 -0700 REGRESSION(r58963): Broke Chromium layout tests. (Requested by dcheng on #webkit). 2010-05-07 14:45:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 38711 1 webkit.review.bot webkit-unassigned commit-queue jianli johnnyg oldest_to_newest 222594 0 webkit.review.bot 2010-05-07 13:39:49 -0700 http://trac.webkit.org/changeset/58963 broke the build: Broke Chromium layout tests. (Requested by dcheng on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 222595 1 55416 webkit.review.bot 2010-05-07 13:40:05 -0700 Created attachment 55416 ROLLOUT of r58963 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 222606 2 55416 commit-queue 2010-05-07 14:13:27 -0700 Comment on attachment 55416 ROLLOUT of r58963 Rejecting patch 55416 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Last 500 characters of output: nning build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 18315 test cases. fast/js/sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.4/15.7.4.2_Number.prototype.toString/S15.7.4.2_A2_T34.html -> failed Exiting early after 1 failures. 11842 tests run. 180.69s total testing time 11841 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/2171043 222633 3 55416 johnnyg 2010-05-07 14:45:04 -0700 Comment on attachment 55416 ROLLOUT of r58963 Clearing flags on attachment: 55416 Committed r58973: <http://trac.webkit.org/changeset/58973> 222634 4 johnnyg 2010-05-07 14:45:10 -0700 All reviewed patches have been landed. Closing bug. 55416 2010-05-07 13:40:05 -0700 2010-05-07 14:45:04 -0700 ROLLOUT of r58963 bug-38773-20100507204002.patch text/plain 1760 webkit.review.bot ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTdjMDM5Yzg1YWQzNTIwZWMyOGIzODZiZmZjZGMyMDBjODc5YjA1ZC4uZDlkZGFmYzU0MmFhOTk1 YWM2MzAxOWZmMjU0OWE4ODlkZjM0ZGEyZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNS0wNyAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjU4OTYzLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC81ODk2MworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mzg3NzMKKworICAgICAgICBCcm9rZSBDaHJvbWl1bSBsYXlvdXQgdGVzdHMuIChS ZXF1ZXN0ZWQgYnkgZGNoZW5nIG9uICN3ZWJraXQpLgorCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vRHJhZ0RhdGFDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEcmFnRGF0YTo6 YXNVUkwpOgorCiAyMDEwLTA1LTA3ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEgU2lsdmEuCmRpZmYg LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0RyYWdEYXRhQ2hyb21pdW0uY3BwIGIv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9EcmFnRGF0YUNocm9taXVtLmNwcAppbmRleCA2MWY1 OTM4Y2RhMzUxMGNiYzJkMjMwNWI2MGZmOTVlZjdkOTU3NTA2Li44ZmI0MGRlN2NhYzE2NjRjMDlj MTUxNGQwN2QyZjllNTljODVkZjY3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9t aXVtL0RyYWdEYXRhQ2hyb21pdW0uY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v RHJhZ0RhdGFDaHJvbWl1bS5jcHAKQEAgLTY2LDExICs2NiwxMSBAQCBTdHJpbmcgRHJhZ0RhdGE6 OmFzVVJMKFN0cmluZyogdGl0bGUpIGNvbnN0CiAgICAgU3RyaW5nIHVybDsKICAgICBpZiAobV9w bGF0Zm9ybURyYWdEYXRhLT5oYXNWYWxpZFVSTCgpKQogICAgICAgICB1cmwgPSBtX3BsYXRmb3Jt RHJhZ0RhdGEtPmdldFVSTCgpLnN0cmluZygpOwotICAgIGVsc2UgaWYgKCFtX3BsYXRmb3JtRHJh Z0RhdGEtPmZpbGVuYW1lcy5pc0VtcHR5KCkpIHsKKyAgICBlbHNlIGlmIChtX3BsYXRmb3JtRHJh Z0RhdGEtPmZpbGVuYW1lcy5zaXplKCkgPT0gMSkgewogICAgICAgICBTdHJpbmcgZmlsZU5hbWUg PSBtX3BsYXRmb3JtRHJhZ0RhdGEtPmZpbGVuYW1lc1swXTsKICAgICAgICAgZmlsZU5hbWUgPSBD aHJvbWl1bUJyaWRnZTo6Z2V0QWJzb2x1dGVQYXRoKGZpbGVOYW1lKTsKLSAgICAgICAgLy8gVGhl IGxvYWRlciB3aWxsIGRvIHRoZSByaWdodCB0aGluZyBpZiB0aGUgZmlsZW5hbWUgaXMgaW52YWxp ZCBmb3Igb25lIHJlYXNvbiBvciBhbm90aGVyLgotICAgICAgICB1cmwgPSBDaHJvbWl1bUJyaWRn ZTo6ZmlsZVBhdGhUb1VSTChmaWxlTmFtZSkuc3RyaW5nKCk7CisgICAgICAgIGlmIChmaWxlRXhp c3RzKGZpbGVOYW1lKSAmJiAhQ2hyb21pdW1CcmlkZ2U6OmlzRGlyZWN0b3J5KGZpbGVOYW1lKSkK KyAgICAgICAgICAgIHVybCA9IENocm9taXVtQnJpZGdlOjpmaWxlUGF0aFRvVVJMKGZpbGVOYW1l KS5zdHJpbmcoKTsKICAgICB9CiAgCiAgICAgLy8gfHRpdGxlfCBjYW4gYmUgTlVMTAo=