38768 2010-05-07 12:49:48 -0700 SunSpider computes incorrect two-sample t statistics 2010-05-13 10:18:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 aroben aroben eric mjs oldest_to_newest 222564 0 aroben 2010-05-07 12:49:48 -0700 SunSpider computes incorrect two-sample t statistics 222565 1 55410 aroben 2010-05-07 12:52:50 -0700 Created attachment 55410 Patch 222978 2 eric 2010-05-08 23:16:58 -0700 Attachment 55410 was posted by a committer and has review+, assigning to Adam Roben for commit. 223281 3 aroben 2010-05-10 06:32:23 -0700 I wonder if we need to somehow communicate that SunSpider was buggy in this way? I guess not, since the t statistics (or any values derived from them) don't get persisted in the run results that people might save for the future; they're only used when actually comparing two runs. 223298 4 aroben 2010-05-10 07:13:03 -0700 (In reply to comment #3) > I wonder if we need to somehow communicate that SunSpider was buggy in this way? I guess not, since the t statistics (or any values derived from them) don't get persisted in the run results that people might save for the future; they're only used when actually comparing two runs. In fact, my patch doesn't change the versions of SunSpider hosted on webkit.org, so this is definitely not necessary at the moment. I wonder if we should change those versions, though? 225360 5 aroben 2010-05-13 10:12:05 -0700 Committed r59370: <http://trac.webkit.org/changeset/59370> 225362 6 aroben 2010-05-13 10:18:46 -0700 Maciej, do you think we should apply this change to the public versions of SunSpider? 55410 2010-05-07 12:52:50 -0700 2010-05-07 17:06:25 -0700 Patch bug-38768-20100507155248.patch text/plain 1683 aroben ZGlmZiAtLWdpdCBhL1N1blNwaWRlci9DaGFuZ2VMb2cgYi9TdW5TcGlkZXIvQ2hhbmdlTG9nCmlu ZGV4IGQwZWMxMTMwZjg2NzRkNjQ5OGMyY2JjNTMxYzI1NTk4ODc5OGE1YWEuLjkxZWVhNGI0ODAy MDdiYWQ4OTMzYjIxNjYzNTY2MDEzOTMzYmQ1YTAgMTAwNjQ0Ci0tLSBhL1N1blNwaWRlci9DaGFu Z2VMb2cKKysrIGIvU3VuU3BpZGVyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTA1 LTA3ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggdHlwbyBp biBzdW5zcGlkZXItY29tcGFyZS1yZXN1bHRzLmpzIHRoYXQgY2F1c2VkIGluY29ycmVjdAorICAg ICAgICB0d28tc2FtcGxlIHQgc3RhdGlzdGljcyB0byBiZSBjb21wdXRlZAorCisgICAgICAgIEZp eGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzM4NzY4PiBTdW5TcGlkZXIgY29tcHV0ZXMgaW5jb3Jy ZWN0CisgICAgICAgIHR3by1zYW1wbGUgdCBzdGF0aXN0aWNzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZXNvdXJjZXMvc3Vuc3BpZGVyLWNvbXBh cmUtcmVzdWx0cy5qczoKKyAgICAgICAgKHN1bnNwaWRlckNvbXBhcmVSZXN1bHRzLnJlc3VsdExp bmUpOiBGaXhlZCB0aGUgY2FsY3VsYXRpb24gb2YgdGhlIHQKKyAgICAgICAgdmFyaWFibGUgdG8g bWF0Y2ggdGhlIGRlZmluaXRpb24gb2YgYSB0d28tc2FtcGxlIHQgc3RhdGlzdGljLiBMb29rcwor ICAgICAgICBsaWtlIHRoaXMgd2FzIGp1c3QgYSBzaW1wbGUgdHlwby4KKwogMjAxMC0wNC0wNSAg RGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlZCB0aGUgaWdu b3JlIHByb3BlcnR5IGZvciBjaGFuZ2VzIHRvIHRoZSBjb250ZW50cyBoZXJlLgpkaWZmIC0tZ2l0 IGEvU3VuU3BpZGVyL3Jlc291cmNlcy9zdW5zcGlkZXItY29tcGFyZS1yZXN1bHRzLmpzIGIvU3Vu U3BpZGVyL3Jlc291cmNlcy9zdW5zcGlkZXItY29tcGFyZS1yZXN1bHRzLmpzCmluZGV4IDg4N2I4 ZGI0MWEyNjQ2YWRhZWZkYmExODJkYWQwZmE3MzdkZTZkYTcuLjI0NjcxZWE3MWIyNmI0YWNmMTk4 NzE5MzNkMWIzOGM2MGQ0Y2Q2MmEgMTAwNjQ0Ci0tLSBhL1N1blNwaWRlci9yZXNvdXJjZXMvc3Vu c3BpZGVyLWNvbXBhcmUtcmVzdWx0cy5qcworKysgYi9TdW5TcGlkZXIvcmVzb3VyY2VzL3N1bnNw aWRlci1jb21wYXJlLXJlc3VsdHMuanMKQEAgLTI5Nyw3ICsyOTcsNyBAQCBmdW5jdGlvbiBzdW5z cGlkZXJDb21wYXJlUmVzdWx0cyhvdXRwdXQxLCBvdXRwdXQyKQogICAgICAgICByZXN1bHQgKz0g bGFiZWwgKyAiOiAiOwogICAgICAgICByZXN1bHQgPSBwYWQocmVzdWx0LCBsYWJlbFdpZHRoICsg Mik7CiAgICAgICAgIAotICAgICAgICB2YXIgdCA9IChtZWFuMSAtIG1lYW4yKSAvIChNYXRoLnNx cnQoKHN0ZEVycjEgKiBzdGRFcnIxKSArIChzdGRFcnIxICogc3RkRXJyMikpKTsgCisgICAgICAg IHZhciB0ID0gKG1lYW4xIC0gbWVhbjIpIC8gKE1hdGguc3FydCgoc3RkRXJyMSAqIHN0ZEVycjEp ICsgKHN0ZEVycjIgKiBzdGRFcnIyKSkpOwogICAgICAgICB2YXIgZGYgPSBjb3VudDEgKyBjb3Vu dDIgLSAyOwogICAgICAgICAKICAgICAgICAgdmFyIHN0YXRpc3RpY2FsbHlTaWduaWZpY2FudCA9 IChNYXRoLmFicyh0KSA+IHREaXN0KGRmKzEpKTsK