38755 2010-05-07 09:28:24 -0700 Web Inspector: come up with InjectedScript._className that works for both JSC and V8. 2010-05-07 09:59:49 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 222420 0 pfeldman 2010-05-07 09:28:24 -0700 There is a conceptual difference between the engines: JSC: typeof Document === "object" V8: typeof Document === "function" As a result, getting the class names using same code is challenging. I gave up and made a fork. 222429 1 55385 pfeldman 2010-05-07 09:36:10 -0700 Created attachment 55385 [PATCH] Proposed fix. 222435 2 55385 timothy 2010-05-07 09:41:56 -0700 Comment on attachment 55385 [PATCH] Proposed fix. Should we file a bug with V8 or JSC? 222437 3 pfeldman 2010-05-07 09:44:35 -0700 (In reply to comment #2) > (From update of attachment 55385 [details]) > Should we file a bug with V8 or JSC? I am afraid teams are not interested in fixing it one way or the other - we are the only clients suffering so far. I'll follow up with the V8 folks locally. 222448 4 pfeldman 2010-05-07 09:59:49 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/InjectedScript.js Committed r58953 55385 2010-05-07 09:36:10 -0700 2010-05-07 09:41:56 -0700 [PATCH] Proposed fix. class_name text/plain 1775 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGYzNmExYS4uYzI4YjEyMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNS0wNyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBjb21lIHVwIHdpdGggSW5qZWN0ZWRT Y3JpcHQuX2NsYXNzTmFtZSB0aGF0IHdvcmtzIGZvciBib3RoIEpTQyBhbmQgVjguCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NzU1CisKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzOgorICAgICAgICAoaW5q ZWN0ZWRTY3JpcHRDb25zdHJ1Y3Rvcik6CisKIDIwMTAtMDUtMDYgIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJldGggRGFraW4uCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMgYi9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKaW5kZXggYTU0YTEwYi4u ODVhYjQ5NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVk U2NyaXB0LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlw dC5qcwpAQCAtMTAxMyw4ICsxMDEzLDE5IEBAIEluamVjdGVkU2NyaXB0Ll90b1N0cmluZyA9IGZ1 bmN0aW9uKG9iaikKIAogSW5qZWN0ZWRTY3JpcHQuX2NsYXNzTmFtZSA9IGZ1bmN0aW9uKG9iaikK IHsKLSAgICB2YXIgc3RyID0gaW5zcGVjdGVkV2luZG93Lk9iamVjdCA/IGluc3BlY3RlZFdpbmRv dy5PYmplY3QucHJvdG90eXBlLnRvU3RyaW5nLmNhbGwob2JqKSA6IEluamVjdGVkU2NyaXB0Ll90 b1N0cmluZyhvYmopOwotICAgIHJldHVybiBzdHIucmVwbGFjZSgvXlxbb2JqZWN0ICguKilcXSQv aSwgIiQxIik7CisgICAgLy8gV2UgY2FuJ3QgdXNlIHRoZSBzYW1lIGNvZGUgZm9yIGZldGNoaW5n IGNsYXNzIG5hbWVzIG9mIHRoZSBkb20gYmluZGluZ3MgcHJvdG90eXBlIGNoYWluLgorICAgIC8v IEJvdGggb2YgdGhlIG1ldGhvZHMgYmVsb3cgcmVzdWx0IGluICJPYmplY3QiIG5hbWVzIG9uIHRo ZSBmb3JlaWduIGVuZ2luZSBiaW5kaW5ncy4KKyAgICAvLyBJIGdhdmUgdXAgYW5kIGFtIHVzaW5n IGEgY2hlY2sgYmVsb3cgdG8gZGlzdGluZ3Vpc2ggYmV0d2VlbiB0aGUgZWdpbmUgYmluZ2luZ3Mu CisKKyAgICBpZiAodHlwZW9mIERvY3VtZW50ID09PSAib2JqZWN0IikgeworICAgICAgICAvLyBK U0MKKyAgICAgICAgdmFyIHN0ciA9IGluc3BlY3RlZFdpbmRvdy5PYmplY3QgPyBpbnNwZWN0ZWRX aW5kb3cuT2JqZWN0LnByb3RvdHlwZS50b1N0cmluZy5jYWxsKG9iaikgOiBJbmplY3RlZFNjcmlw dC5fdG9TdHJpbmcob2JqKTsKKyAgICAgICAgcmV0dXJuIHN0ci5yZXBsYWNlKC9eXFtvYmplY3Qg KC4qKVxdJC9pLCAiJDEiKTsKKyAgICB9CisgICAgLy8gVjgKKyAgICBpZiAob2JqID09PSBudWxs KQorICAgICAgICByZXR1cm4gIm51bGwiOworICAgIHJldHVybiBvYmouY29uc3RydWN0b3IubmFt ZTsKIH0KIAogSW5qZWN0ZWRTY3JpcHQuX2VzY2FwZUNoYXJhY3RlcnMgPSBmdW5jdGlvbihzdHIs IGNoYXJzKQo=