38749 2010-05-07 07:54:47 -0700 [Chromium] Pipe RTL info into WebPopupMenuInfo 2010-05-11 16:04:53 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 avi webkit-unassigned commit-queue fishd levin xji oldest_to_newest 222364 0 avi 2010-05-07 07:54:47 -0700 Bug 29612 fixed right-alignment for RTL <select> widgets. This extends that work to pipe right-alignment status out to the API level in WebPopupMenuInfo so that Chromium Mac can properly right-align popups in the correct circumstances. 222366 1 55374 avi 2010-05-07 07:57:01 -0700 Created attachment 55374 A patch to fill in a "right aligned" attr in the menu info 222370 2 55374 playmobil 2010-05-07 08:04:23 -0700 Comment on attachment 55374 A patch to fill in a "right aligned" attr in the menu info Ob-Disclaimer: I'm not a WebKit reviewer. WebKit/chromium/src/ChromeClientImpl.cpp:694 + info->rightAligned = popupClient->menuStyle().textDirection() == RTL; It's not really text alignment, but directionality - IMHO rename to rtl, directionality [and use an enum] or somesuch. Otherwise, lgtm. 222389 3 avi 2010-05-07 08:27:16 -0700 (In reply to comment #2) > It's not really text alignment It is really text alignment. This is intended to be an alignment flag, not a directionality flag. In the client end I'm using it to signal to the system alignment (NSRightTextAlignment, as seen in http://codereview.chromium.org/1992006 ). Yes, it's determined from directionality, but that's not what it is. 222457 4 55374 levin 2010-05-07 10:09:55 -0700 Comment on attachment 55374 A patch to fill in a "right aligned" attr in the menu info Since this has a change to a public api file, I'll leave it for Darin Fisher to give a r+/r-, but here's a comment on a minor WebKit style issue that it would be good to fix. > Index: WebCore/page/chromium/ChromeClientChromium.h > virtual void popupOpened(PopupContainer* popupContainer, const IntRect& bounds, > + bool handleExternal, PopupMenuClient* popupClient) = 0; Style nit: Since the parameter name "popupClient" provide no new information, it shouldn't be here. (The same is true for popupContainer but that itsn't part of your change.) > Index: WebKit/chromium/src/ChromeClientImpl.h > virtual void popupOpened(WebCore::PopupContainer* popupContainer, > const WebCore::IntRect& bounds, > + bool handleExternally, > + WebCore::PopupMenuClient* popupClient); Ditto. > + void getPopupMenuInfo(WebCore::PopupContainer*, WebPopupMenuInfo*, WebCore::PopupMenuClient* popupClient); Ditto. 222504 5 55374 fishd 2010-05-07 11:30:12 -0700 Comment on attachment 55374 A patch to fill in a "right aligned" attr in the menu info WebKit/chromium/public/WebPopupMenuInfo.h:47 + bool rightAligned; Use the WebTextDirection enum here? WebKit/chromium/src/ChromeClientImpl.cpp:694 + info->rightAligned = popupClient->menuStyle().textDirection() == RTL; Why not just get the PopupMenuStyle object from the PopupContainer? You could add a method on PopupContainer that returns PopupMenuStyle*. It doesn't seem necessary to plumb PopupMenuClient* through the layers when you have PopupContainer at your disposal. 222680 6 xji 2010-05-07 16:02:04 -0700 (In reply to comment #2) > (From update of attachment 55374 [details]) > Ob-Disclaimer: I'm not a WebKit reviewer. > > WebKit/chromium/src/ChromeClientImpl.cpp:694 > + info->rightAligned = popupClient->menuStyle().textDirection() == RTL; > It's not really text alignment, but directionality - IMHO rename to rtl, > directionality [and use an enum] or somesuch. > > Otherwise, lgtm. We are currently using popup's text direction to direct the alignment (align right if the <select> is RTL, align right if the <input> is RTL). Webkit always align popup left (at least in Mac, when writing direction is natural) in RenderMenuList::adjustInnerStyle() (refer to Bug 19785). We need to add text alignment in PopupMenuStyle, so that we can display the text in <select> box using natural writing direction, and draw the texts in popup box in desired alignment. I am opening another Bug 38780 223402 7 55571 avi 2010-05-10 10:57:25 -0700 Created attachment 55571 Update 223404 8 avi 2010-05-10 10:59:12 -0700 If everyone wants it to be text direction, then I'll make it text direction. Otherwise it's simplified as per fishd's recommendation (which makes it work much better; thanks!) 223416 9 xji 2010-05-10 11:17:37 -0700 @@ -44,6 +45,7 @@ struct WebPopupMenuInfo { int itemFontSize; int selectedIndex; WebVector<WebMenuItemInfo> items; + WebTextDirection textDirection; }; Maybe I made you confused. You were right in your comment #3. It is a alignment, not text direction, and it is used in client side as alignment. We are currently using the text direction to guide the alignment, which is not totally correct. Hence Bug 38780 is filed. 223496 10 55599 avi 2010-05-10 13:50:12 -0700 Created attachment 55599 Alignment it is. 224224 11 55599 commit-queue 2010-05-11 16:04:46 -0700 Comment on attachment 55599 Alignment it is. Clearing flags on attachment: 55599 Committed r59179: <http://trac.webkit.org/changeset/59179> 224225 12 commit-queue 2010-05-11 16:04:53 -0700 All reviewed patches have been landed. Closing bug. 55374 2010-05-07 07:57:01 -0700 2010-05-10 10:57:25 -0700 A patch to fill in a "right aligned" attr in the menu info rtl.patch text/plain 7177 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODk0NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMDcgIEF2aSBEcmlzc21hbiAgPGF2aUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0No cm9taXVtXSBQaXBlIFJUTCBpbmZvIGludG8gV2ViUG9wdXBNZW51SW5mbworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg3NDkKKworICAgICAgICAqIHBh Z2UvY2hyb21pdW0vQ2hyb21lQ2xpZW50Q2hyb21pdW0uaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9j aHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3B1cENv bnRhaW5lcjo6c2hvd1BvcHVwKToKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwQ29udGFpbmVyOjpz aG93RXh0ZXJuYWwpOgorCiAyMDEwLTA1LTA3ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0 YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5 IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpJbmRleDogV2ViQ29yZS9wYWdlL2Nocm9taXVt L0Nocm9tZUNsaWVudENocm9taXVtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL2Nocm9t aXVtL0Nocm9tZUNsaWVudENocm9taXVtLmgJKHJldmlzaW9uIDU4OTQ1KQorKysgV2ViQ29yZS9w YWdlL2Nocm9taXVtL0Nocm9tZUNsaWVudENocm9taXVtLmgJKHdvcmtpbmcgY29weSkKQEAgLTM4 LDYgKzM4LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgQWNjZXNzaWJpbGl0eU9iamVj dDsKIGNsYXNzIEludFJlY3Q7CiBjbGFzcyBQb3B1cENvbnRhaW5lcjsKK2NsYXNzIFBvcHVwTWVu dUNsaWVudDsKIAogLy8gQ29udGFpbnMgQ2hyb21pdW0tc3BlY2lmaWMgZXh0ZW5zaW9ucyB0byB0 aGUgQ2hyb21lQ2xpZW50LiAgT25seSBwdXQKIC8vIHRoaW5ncyBoZXJlIHRoYXQgZG9uJ3QgbWFr ZSBzZW5zZSBmb3Igb3RoZXIgcG9ydHMuCkBAIC00OCw4ICs0OSw4IEBAIHB1YmxpYzoKICAgICAv LyBJZiBoYW5kbGVFeHRlcm5hbCBpcyB0cnVlLCB0aGVuIGRyYXdpbmcgYW5kIGlucHV0IGhhbmRs aW5nIGZvciB0aGUKICAgICAvLyBwb3B1cCB3aWxsIGJlIGhhbmRsZWQgYnkgdGhlIGV4dGVybmFs IGVtYmVkZGVyLgogICAgIHZpcnR1YWwgdm9pZCBwb3B1cE9wZW5lZChQb3B1cENvbnRhaW5lciog cG9wdXBDb250YWluZXIsIGNvbnN0IEludFJlY3QmIGJvdW5kcywKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgYm9vbCBoYW5kbGVFeHRlcm5hbCkgPSAwOwotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCBoYW5kbGVFeHRl cm5hbCwgUG9wdXBNZW51Q2xpZW50KiBwb3B1cENsaWVudCkgPSAwOworCiAgICAgLy8gTm90aWZp ZXMgdGhlIGNsaWVudCBhIHBvcHVwIHdhcyBjbG9zZWQuCiAgICAgdmlydHVhbCB2b2lkIHBvcHVw Q2xvc2VkKFBvcHVwQ29udGFpbmVyKiBwb3B1cENvbnRhaW5lcikgPSAwOwogCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkocmV2aXNp b24gNTg5NDUpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVt LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzY3LDcgKzM2Nyw3IEBAIHZvaWQgUG9wdXBDb250YWlu ZXI6OnNob3dQb3B1cChGcmFtZVZpZXcKICAgICAgICAgICAgICAgICAgICAgd2lkZ2V0UmVjdC5t b3ZlKDAsIC0od2lkZ2V0UmVjdC5oZWlnaHQoKSArIHNlbGVjdEhlaWdodCkpOwogICAgICAgICAg ICAgfQogICAgICAgICB9Ci0gICAgICAgIGNocm9tZUNsaWVudC0+cG9wdXBPcGVuZWQodGhpcywg d2lkZ2V0UmVjdCwgZmFsc2UpOworICAgICAgICBjaHJvbWVDbGllbnQtPnBvcHVwT3BlbmVkKHRo aXMsIHdpZGdldFJlY3QsIGZhbHNlLCBtX2xpc3RCb3gtPm1fcG9wdXBDbGllbnQpOwogICAgICAg ICBtX3BvcHVwT3BlbiA9IHRydWU7CiAgICAgfQogCkBAIC00MDIsNyArNDAyLDcgQEAgdm9pZCBQ b3B1cENvbnRhaW5lcjo6c2hvd0V4dGVybmFsKGNvbnN0IAogCiAgICAgLy8gR2V0IHRoZSBDaHJv bWVDbGllbnQgYW5kIHBhc3MgaXQgdGhlIHBvcHVwIG1lbnUncyBsaXN0Ym94IGRhdGEuCiAgICAg bV9mcmFtZVZpZXcgPSB2OwotICAgIGNocm9tZUNsaWVudENocm9taXVtKCktPnBvcHVwT3BlbmVk KHRoaXMsIHBvcHVwUmVjdCwgdHJ1ZSk7CisgICAgY2hyb21lQ2xpZW50Q2hyb21pdW0oKS0+cG9w dXBPcGVuZWQodGhpcywgcG9wdXBSZWN0LCB0cnVlLCBtX2xpc3RCb3gtPm1fcG9wdXBDbGllbnQp OwogCiAgICAgLy8gVGhlIHBvcHVwIHNlbmRzIGl0cyAiY2xvc2VkIiBub3RpZmljYXRpb24gdGhy b3VnaCBpdHMgcGFyZW50LiBTZXQgdGhlCiAgICAgLy8gcGFyZW50LCBldmVuIHRob3VnaCBleHRl cm5hbCBwb3B1cHMgaGF2ZSBubyByZWFsIG9uLXNjcmVlbiB3aWRnZXQgYnV0IGEKSW5kZXg6IFdl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZwkocmV2aXNpb24gNTg5NDYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDUtMDcgIEF2aSBEcmlzc21hbiAg PGF2aUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0Nocm9taXVtXSBQaXBlIFJUTCBpbmZvIGludG8gV2ViUG9wdXBNZW51SW5m bworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg3NDkK KworICAgICAgICAqIHB1YmxpYy9XZWJQb3B1cE1lbnVJbmZvLmg6CisgICAgICAgICogc3JjL0No cm9tZUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnRJbXBsOjpw b3B1cE9wZW5lZCk6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OmdldFBvcHVw TWVudUluZm8pOgorICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmg6CisKIDIwMTAtMDUt MDYgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUG9w dXBNZW51SW5mby5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUG9w dXBNZW51SW5mby5oCShyZXZpc2lvbiA1ODk0NSkKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViUG9wdXBNZW51SW5mby5oCSh3b3JraW5nIGNvcHkpCkBAIC00NCw2ICs0NCw3IEBAIHN0cnVj dCBXZWJQb3B1cE1lbnVJbmZvIHsKICAgICBpbnQgaXRlbUZvbnRTaXplOwogICAgIGludCBzZWxl Y3RlZEluZGV4OwogICAgIFdlYlZlY3RvcjxXZWJNZW51SXRlbUluZm8+IGl0ZW1zOworICAgIGJv b2wgcmlnaHRBbGlnbmVkOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBXZWJL aXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDU4OTQ1KQorKysg V2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNjEwLDcgKzYxMCw4IEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6Y2hvb3NlSWNvbkZvckZp bGUKIAogdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpwb3B1cE9wZW5lZChQb3B1cENvbnRhaW5lciog cG9wdXBDb250YWluZXIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IEludFJlY3QmIGJvdW5kcywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9v bCBoYW5kbGVFeHRlcm5hbGx5KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBi b29sIGhhbmRsZUV4dGVybmFsbHksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IFBvcHVwTWVudUNsaWVudCogcG9wdXBDbGllbnQpCiB7CiAgICAgaWYgKCFtX3dlYlZpZXctPmNs aWVudCgpKQogICAgICAgICByZXR1cm47CkBAIC02MTgsNyArNjE5LDcgQEAgdm9pZCBDaHJvbWVD bGllbnRJbXBsOjpwb3B1cE9wZW5lZChQb3B1cAogICAgIFdlYldpZGdldCogd2Vid2lkZ2V0Owog ICAgIGlmIChoYW5kbGVFeHRlcm5hbGx5KSB7CiAgICAgICAgIFdlYlBvcHVwTWVudUluZm8gcG9w dXBJbmZvOwotICAgICAgICBnZXRQb3B1cE1lbnVJbmZvKHBvcHVwQ29udGFpbmVyLCAmcG9wdXBJ bmZvKTsKKyAgICAgICAgZ2V0UG9wdXBNZW51SW5mbyhwb3B1cENvbnRhaW5lciwgJnBvcHVwSW5m bywgcG9wdXBDbGllbnQpOwogICAgICAgICB3ZWJ3aWRnZXQgPSBtX3dlYlZpZXctPmNsaWVudCgp LT5jcmVhdGVQb3B1cE1lbnUocG9wdXBJbmZvKTsKICAgICB9IGVsc2UgewogICAgICAgICB3ZWJ3 aWRnZXQgPSBtX3dlYlZpZXctPmNsaWVudCgpLT5jcmVhdGVQb3B1cE1lbnUoCkBAIC02NTcsNyAr NjU4LDggQEAgdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpmb3JtU3RhdGVEaWRDaGFuZwogfQogCiB2 b2lkIENocm9tZUNsaWVudEltcGw6OmdldFBvcHVwTWVudUluZm8oUG9wdXBDb250YWluZXIqIHBv cHVwQ29udGFpbmVyLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdl YlBvcHVwTWVudUluZm8qIGluZm8pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgV2ViUG9wdXBNZW51SW5mbyogaW5mbywKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBQb3B1cE1lbnVDbGllbnQqIHBvcHVwQ2xpZW50KQogewogICAgIGNvbnN0 IFZlY3RvcjxQb3B1cEl0ZW0qPiYgaW5wdXRJdGVtcyA9IHBvcHVwQ29udGFpbmVyLT5wb3B1cERh dGEoKTsKIApAQCAtNjg5LDYgKzY5MSw3IEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6Z2V0UG9w dXBNZW51SW5mbygKICAgICBpbmZvLT5pdGVtRm9udFNpemUgPSBwb3B1cENvbnRhaW5lci0+bWVu dUl0ZW1Gb250U2l6ZSgpOwogICAgIGluZm8tPnNlbGVjdGVkSW5kZXggPSBwb3B1cENvbnRhaW5l ci0+c2VsZWN0ZWRJbmRleCgpOwogICAgIGluZm8tPml0ZW1zLnN3YXAob3V0cHV0SXRlbXMpOwor ICAgIGluZm8tPnJpZ2h0QWxpZ25lZCA9IHBvcHVwQ2xpZW50LT5tZW51U3R5bGUoKS50ZXh0RGly ZWN0aW9uKCkgPT0gUlRMOwogfQogCiB2b2lkIENocm9tZUNsaWVudEltcGw6OmRpZENoYW5nZUFj Y2Vzc2liaWxpdHlPYmplY3RTdGF0ZShBY2Nlc3NpYmlsaXR5T2JqZWN0KiBvYmopCkluZGV4OiBX ZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuaAkocmV2aXNpb24gNTg5NDUpCisrKyBX ZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuaAkod29ya2luZyBjb3B5KQpAQCAt MzgsNiArMzgsNyBAQCBjbGFzcyBBY2Nlc3NpYmlsaXR5T2JqZWN0OwogY2xhc3MgRmlsZUNob29z ZXI7CiBjbGFzcyBIVE1MUGFyc2VyUXVpcmtzOwogY2xhc3MgUG9wdXBDb250YWluZXI7CitjbGFz cyBQb3B1cE1lbnVDbGllbnQ7CiBjbGFzcyBTZWN1cml0eU9yaWdpbjsKIHN0cnVjdCBXaW5kb3dG ZWF0dXJlczsKIH0KQEAgLTE0OSw3ICsxNTAsOCBAQCBwdWJsaWM6CiAgICAgLy8gQ2hyb21lQ2xp ZW50Q2hyb21pdW0gbWV0aG9kczoKICAgICB2aXJ0dWFsIHZvaWQgcG9wdXBPcGVuZWQoV2ViQ29y ZTo6UG9wdXBDb250YWluZXIqIHBvcHVwQ29udGFpbmVyLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiBib3VuZHMsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGJvb2wgaGFuZGxlRXh0ZXJuYWxseSk7CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGJvb2wgaGFuZGxlRXh0ZXJuYWxseSwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgV2ViQ29yZTo6UG9wdXBNZW51Q2xpZW50KiBwb3B1cENsaWVudCk7CiAgICAgdmlydHVh bCB2b2lkIHBvcHVwQ2xvc2VkKFdlYkNvcmU6OlBvcHVwQ29udGFpbmVyKiBwb3B1cENvbnRhaW5l cik7CiAgICAgdmlydHVhbCB2b2lkIGRpZENoYW5nZUFjY2Vzc2liaWxpdHlPYmplY3RTdGF0ZShX ZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0Kik7CiAKQEAgLTE1OCw3ICsxNjAsNyBAQCBwdWJs aWM6CiAgICAgdm9pZCBzZXRDdXJzb3JGb3JQbHVnaW4oY29uc3QgV2ViQ3Vyc29ySW5mbyYgY3Vy c29yKTsKIAogcHJpdmF0ZToKLSAgICB2b2lkIGdldFBvcHVwTWVudUluZm8oV2ViQ29yZTo6UG9w dXBDb250YWluZXIqLCBXZWJQb3B1cE1lbnVJbmZvKik7CisgICAgdm9pZCBnZXRQb3B1cE1lbnVJ bmZvKFdlYkNvcmU6OlBvcHVwQ29udGFpbmVyKiwgV2ViUG9wdXBNZW51SW5mbyosIFdlYkNvcmU6 OlBvcHVwTWVudUNsaWVudCogcG9wdXBDbGllbnQpOwogCiAgICAgV2ViVmlld0ltcGwqIG1fd2Vi VmlldzsgIC8vIHdlYWsgcG9pbnRlcgogICAgIGJvb2wgbV90b29sYmFyc1Zpc2libGU7Cg== 55571 2010-05-10 10:57:25 -0700 2010-05-10 13:50:12 -0700 Update rtl.patch text/plain 3686 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTA4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMTAgIEF2aSBEcmlzc21hbiAgPGF2aUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0No cm9taXVtXSBQaXBlIFJUTCBpbmZvIGludG8gV2ViUG9wdXBNZW51SW5mbworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg3NDkKKworICAgICAgICAqIHBs YXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlBvcHVwQ29udGFpbmVyOjptZW51U3R5bGUpOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVt L1BvcHVwTWVudUNocm9taXVtLmg6CisKIDIwMTAtMDUtMDkgIEtlbm5ldGggUnVzc2VsbCAgPGti ckBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5k ZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3Bw CShyZXZpc2lvbiA1OTA4MikKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51 Q2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzMsNiArNTczLDExIEBAIGludCBQb3B1 cENvbnRhaW5lcjo6bWVudUl0ZW1Gb250U2l6ZSgpIGMKICAgICByZXR1cm4gbV9saXN0Qm94LT5n ZXRSb3dGb250KDApLnNpemUoKTsKIH0KIAorUG9wdXBNZW51U3R5bGUgUG9wdXBDb250YWluZXI6 Om1lbnVTdHlsZSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fbGlzdEJveC0+bV9wb3B1cENsaWVu dC0+bWVudVN0eWxlKCk7Cit9CisKIGNvbnN0IFdURjo6VmVjdG9yPFBvcHVwSXRlbSo+JiBQb3B1 cENvbnRhaW5lcjo6IHBvcHVwRGF0YSgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1fbGlzdEJveC0+ aXRlbXMoKTsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21p dW0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNo cm9taXVtLmgJKHJldmlzaW9uIDU5MDgyKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Q b3B1cE1lbnVDaHJvbWl1bS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNzUsNiArMTc1LDkgQEAgcHVi bGljOgogICAgIC8vIFRoZSBzaXplIG9mIHRoZSBmb250IGJlaW5nIHVzZWQuCiAgICAgaW50IG1l bnVJdGVtRm9udFNpemUoKSBjb25zdDsKIAorICAgIC8vIFRoZSBzdHlsZSBvZiB0aGUgbWVudSBi ZWluZyB1c2VkLgorICAgIFBvcHVwTWVudVN0eWxlIG1lbnVTdHlsZSgpIGNvbnN0OworCiAgICAg UG9wdXBUeXBlIHBvcHVwVHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1fcG9wdXBUeXBlOyB9CiAKIHBy aXZhdGU6CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5MDg1KQorKysgV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEwLTA1LTEw ICBBdmkgRHJpc3NtYW4gIDxhdmlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gUGlwZSBSVEwgaW5mbyBpbnRv IFdlYlBvcHVwTWVudUluZm8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM4NzQ5CisKKyAgICAgICAgKiBwdWJsaWMvV2ViUG9wdXBNZW51SW5mby5oOgor ICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hy b21lQ2xpZW50SW1wbDo6Z2V0UG9wdXBNZW51SW5mbyk6CisKIDIwMTAtMDUtMTAgIEhhbnMgV2Vu bmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkg T3Jsb3cuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBvcHVwTWVudUluZm8uaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBvcHVwTWVudUluZm8uaAko cmV2aXNpb24gNTkwODIpCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBvcHVwTWVudUlu Zm8uaAkod29ya2luZyBjb3B5KQpAQCAtMzIsNiArMzIsNyBAQAogI2RlZmluZSBXZWJQb3B1cE1l bnVJbmZvX2gKIAogI2luY2x1ZGUgIldlYk1lbnVJdGVtSW5mby5oIgorI2luY2x1ZGUgIldlYlRl eHREaXJlY3Rpb24uaCIKICNpbmNsdWRlICJXZWJWZWN0b3IuaCIKIAogbmFtZXNwYWNlIFdlYktp dCB7CkBAIC00NCw2ICs0NSw3IEBAIHN0cnVjdCBXZWJQb3B1cE1lbnVJbmZvIHsKICAgICBpbnQg aXRlbUZvbnRTaXplOwogICAgIGludCBzZWxlY3RlZEluZGV4OwogICAgIFdlYlZlY3RvcjxXZWJN ZW51SXRlbUluZm8+IGl0ZW1zOworICAgIFdlYlRleHREaXJlY3Rpb24gdGV4dERpcmVjdGlvbjsK IH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9D aHJvbWVDbGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0No cm9tZUNsaWVudEltcGwuY3BwCShyZXZpc2lvbiA1OTA4MikKKysrIFdlYktpdC9jaHJvbWl1bS9z cmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY4OSw2ICs2ODksMTAg QEAgdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpnZXRQb3B1cE1lbnVJbmZvKAogICAgIGluZm8tPml0 ZW1Gb250U2l6ZSA9IHBvcHVwQ29udGFpbmVyLT5tZW51SXRlbUZvbnRTaXplKCk7CiAgICAgaW5m by0+c2VsZWN0ZWRJbmRleCA9IHBvcHVwQ29udGFpbmVyLT5zZWxlY3RlZEluZGV4KCk7CiAgICAg aW5mby0+aXRlbXMuc3dhcChvdXRwdXRJdGVtcyk7CisgICAgaWYgKHBvcHVwQ29udGFpbmVyLT5t ZW51U3R5bGUoKS50ZXh0RGlyZWN0aW9uKCkgPT0gUlRMKQorICAgICAgaW5mby0+dGV4dERpcmVj dGlvbiA9IFdlYktpdDo6V2ViVGV4dERpcmVjdGlvblJpZ2h0VG9MZWZ0OworICAgIGVsc2UKKyAg ICAgIGluZm8tPnRleHREaXJlY3Rpb24gPSBXZWJLaXQ6OldlYlRleHREaXJlY3Rpb25MZWZ0VG9S aWdodDsKIH0KIAogdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpkaWRDaGFuZ2VBY2Nlc3NpYmlsaXR5 T2JqZWN0U3RhdGUoQWNjZXNzaWJpbGl0eU9iamVjdCogb2JqKQo= 55599 2010-05-10 13:50:12 -0700 2010-05-11 16:04:46 -0700 Alignment it is. rtl.patch text/plain 3392 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1OTA4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMTAgIEF2aSBEcmlzc21hbiAgPGF2aUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0No cm9taXVtXSBQaXBlIFJUTCBpbmZvIGludG8gV2ViUG9wdXBNZW51SW5mbworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg3NDkKKworICAgICAgICAqIHBs YXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlBvcHVwQ29udGFpbmVyOjptZW51U3R5bGUpOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVt L1BvcHVwTWVudUNocm9taXVtLmg6CisKIDIwMTAtMDUtMDkgIEtlbm5ldGggUnVzc2VsbCAgPGti ckBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5k ZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3Bw CShyZXZpc2lvbiA1OTA4MikKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51 Q2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzMsNiArNTczLDExIEBAIGludCBQb3B1 cENvbnRhaW5lcjo6bWVudUl0ZW1Gb250U2l6ZSgpIGMKICAgICByZXR1cm4gbV9saXN0Qm94LT5n ZXRSb3dGb250KDApLnNpemUoKTsKIH0KIAorUG9wdXBNZW51U3R5bGUgUG9wdXBDb250YWluZXI6 Om1lbnVTdHlsZSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fbGlzdEJveC0+bV9wb3B1cENsaWVu dC0+bWVudVN0eWxlKCk7Cit9CisKIGNvbnN0IFdURjo6VmVjdG9yPFBvcHVwSXRlbSo+JiBQb3B1 cENvbnRhaW5lcjo6IHBvcHVwRGF0YSgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1fbGlzdEJveC0+ aXRlbXMoKTsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21p dW0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNo cm9taXVtLmgJKHJldmlzaW9uIDU5MDgyKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Q b3B1cE1lbnVDaHJvbWl1bS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNzUsNiArMTc1LDkgQEAgcHVi bGljOgogICAgIC8vIFRoZSBzaXplIG9mIHRoZSBmb250IGJlaW5nIHVzZWQuCiAgICAgaW50IG1l bnVJdGVtRm9udFNpemUoKSBjb25zdDsKIAorICAgIC8vIFRoZSBzdHlsZSBvZiB0aGUgbWVudSBi ZWluZyB1c2VkLgorICAgIFBvcHVwTWVudVN0eWxlIG1lbnVTdHlsZSgpIGNvbnN0OworCiAgICAg UG9wdXBUeXBlIHBvcHVwVHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1fcG9wdXBUeXBlOyB9CiAKIHBy aXZhdGU6CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5MDg1KQorKysgV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEwLTA1LTEw ICBBdmkgRHJpc3NtYW4gIDxhdmlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gUGlwZSBSVEwgaW5mbyBpbnRv IFdlYlBvcHVwTWVudUluZm8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM4NzQ5CisKKyAgICAgICAgKiBwdWJsaWMvV2ViUG9wdXBNZW51SW5mby5oOgor ICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hy b21lQ2xpZW50SW1wbDo6Z2V0UG9wdXBNZW51SW5mbyk6CisKIDIwMTAtMDUtMTAgIEhhbnMgV2Vu bmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkg T3Jsb3cuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBvcHVwTWVudUluZm8uaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBvcHVwTWVudUluZm8uaAko cmV2aXNpb24gNTkwODIpCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBvcHVwTWVudUlu Zm8uaAkod29ya2luZyBjb3B5KQpAQCAtNDQsNiArNDQsNyBAQCBzdHJ1Y3QgV2ViUG9wdXBNZW51 SW5mbyB7CiAgICAgaW50IGl0ZW1Gb250U2l6ZTsKICAgICBpbnQgc2VsZWN0ZWRJbmRleDsKICAg ICBXZWJWZWN0b3I8V2ViTWVudUl0ZW1JbmZvPiBpdGVtczsKKyAgICBib29sIHJpZ2h0QWxpZ25l ZDsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJbmRleDogV2ViS2l0L2Nocm9taXVtL3Ny Yy9DaHJvbWVDbGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3Jj L0Nocm9tZUNsaWVudEltcGwuY3BwCShyZXZpc2lvbiA1OTA4MikKKysrIFdlYktpdC9jaHJvbWl1 bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY4OSw2ICs2ODks NyBAQCB2b2lkIENocm9tZUNsaWVudEltcGw6OmdldFBvcHVwTWVudUluZm8oCiAgICAgaW5mby0+ aXRlbUZvbnRTaXplID0gcG9wdXBDb250YWluZXItPm1lbnVJdGVtRm9udFNpemUoKTsKICAgICBp bmZvLT5zZWxlY3RlZEluZGV4ID0gcG9wdXBDb250YWluZXItPnNlbGVjdGVkSW5kZXgoKTsKICAg ICBpbmZvLT5pdGVtcy5zd2FwKG91dHB1dEl0ZW1zKTsKKyAgICBpbmZvLT5yaWdodEFsaWduZWQg PSBwb3B1cENvbnRhaW5lci0+bWVudVN0eWxlKCkudGV4dERpcmVjdGlvbigpID09IFJUTDsKIH0K IAogdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpkaWRDaGFuZ2VBY2Nlc3NpYmlsaXR5T2JqZWN0U3Rh dGUoQWNjZXNzaWJpbGl0eU9iamVjdCogb2JqKQo=