38747 2010-05-07 07:15:20 -0700 mingw-w64 and JIT support 2010-05-11 03:22:32 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows 7 CLOSED FIXED P2 Normal --- 35784 0 vanboxem.ruben webkit-unassigned abarth aroben benjamin commit-queue eric hausmann kenneth laszlo.gombos loki ossy vanboxem.ruben webkit.review.bot oldest_to_newest 222347 0 vanboxem.ruben 2010-05-07 07:15:20 -0700 Since the recently landed patches for bug https://bugs.webkit.org/show_bug.cgi?id=35607 (which have been introduced in QtWebkit as well), I have stumbled upon a serious issue with mingw-w64 and enabled JIT. The above patches (see bug report) enable JIT for a X86_64 Windows when using mingw-w64. This was a mistake, as even MSVC x64 builds don't enable it and the JIT crashes any webkit program using the build. Without it, everything is perfectly fine. I'm sorry I didn't upload a patch, but there are only two lines to be removed (line 943-944 (trunk) of JavaScriptCore/wtf/Platform.h, those enabling JIT on the x64 Windows builds with mingw-w64). It would of course be better to fix JIT on Win64, but I am in no position (knowledge or otherwise) to do so, and I'm leaving that to more experienced people. 222350 1 benjamin 2010-05-07 07:20:44 -0700 Thanks for adding me in CC. This is blocking for QtWebKit. 223015 2 vanboxem.ruben 2010-05-09 02:15:11 -0700 Any chance this could still be pushed to 4.7 before release? The true fixing for Win64 JIT can come later... 223044 3 kenneth 2010-05-09 09:14:54 -0700 (In reply to comment #2) > Any chance this could still be pushed to 4.7 before release? > > The true fixing for Win64 JIT can come later... It is already blocking on the release bug, so we will have to look at this before the release, yes. 223068 4 55509 laszlo.gombos 2010-05-09 13:59:36 -0700 Created attachment 55509 proposed patch 223070 5 laszlo.gombos 2010-05-09 14:01:31 -0700 Gabor, any idea what is involved actually fixing JIT for MINGW64 ? 223137 6 55509 darin 2010-05-09 19:25:19 -0700 Comment on attachment 55509 proposed patch Seems OK, rs=me 223161 7 loki 2010-05-09 23:20:14 -0700 At first I do not see why it is not working. JSValue64 is enabled, JIT stubs routines are there for GCC. There's nothing missing here. I am going to ask Ossy or someone else to reproduce the error. 223269 8 55509 commit-queue 2010-05-10 06:07:41 -0700 Comment on attachment 55509 proposed patch Clearing flags on attachment: 55509 Committed r59074: <http://trac.webkit.org/changeset/59074> 223270 9 commit-queue 2010-05-10 06:07:49 -0700 All reviewed patches have been landed. Closing bug. 223277 10 loki 2010-05-10 06:23:19 -0700 Unfortunately, we were not able to build QtWebKit with mingw-w64. It would be nice if someone writes a "works-for-me" section for mingw-w64 at http://trac.webkit.org/wiki/BuildingQtOnWindows wiki. Apart from that, no other magic should be needed to fire JIT up with mingw-w64. In additional, the x86_64 based QtWebKit runs fine on linux, see at http://www.sed.hu/webkit/qtbuildbot/builders/x86-64%20Linux%20Qt%20Release. It is red, but the JIT runs (only 3 layout tests fail). The JIT only has the following OS dependent sections: memory allocation, make a mem. range executable, flush a mem. region on some targets, and the function call abi (nothing else). So if this problem is not related to mingw-w64 compiler, the bug should be in ExecutableAllocator or JITStubs (or maybe in privateCompileCTIMachineTrampolines), but they look nice. Well, a good back-trace is essential for efficient debugging. ;) Could someone make a detailed bug report for mingw-w64 JIT? 223283 11 webkit.review.bot 2010-05-10 06:37:59 -0700 http://trac.webkit.org/changeset/59074 might have broken Qt Linux ARMv5 Release 223291 12 vanboxem.ruben 2010-05-10 06:50:39 -0700 By popular demand: https://trac.webkit.org/wiki/BuildingQtOnWindows#AWorksForMeStep-by-StepGuidetobuildingQtWebKitonWindowsusingmingw-w64w32 If it doesn't work, please say so, then I may have missed a step... 223848 13 hausmann 2010-05-11 03:22:18 -0700 Revision r59074 cherry-picked into qtwebkit-2.0 with commit dc5821c3df2ef60456d85263160852f5335cf946 55509 2010-05-09 13:59:36 -0700 2010-05-10 06:07:40 -0700 proposed patch 38747.patch text/plain 1306 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU5MDU4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDUtMDkgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRGlzYWJsZSBKSVQgc3VwcG9ydCBmb3Ig bWluZ3ctdzY0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zODc0NworCisgICAgICAgIERpc2FsZSBKSVQgZm9yIG1pbmd3LXc2NCBhcyBpdCBpcyByZXBv cnRlZGx5CisgICAgICAgIHVuc3RhYmxlLgorCisgICAgICAgIFRoYW5rcyBmb3IgVmFuYm94ZW0g UnJ1YmVuIGZvciB0aGUgaW52ZXN0aWdhdGlvbi4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5o OgorCiAyMDEwLTA1LTA5ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93 dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0u aAkocmV2aXNpb24gNTkwNDIpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29y a2luZyBjb3B5KQpAQCAtOTQwLDggKzk0MCw2IEBAIG9uIE1pbkdXLiBTZWUgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2gKICNlbGlmIENQVShYODYpICYmIE9TKFdJTkRPV1MpICYmIENPTVBJTEVS KE1JTkdXKSAmJiBHQ0NfVkVSU0lPTiA+PSA0MDEwMAogICAgICNkZWZpbmUgRU5BQkxFX0pJVCAx CiAgICAgI2RlZmluZSBXVEZfVVNFX0pJVF9TVFVCX0FSR1VNRU5UX1ZBX0xJU1QgMQotI2VsaWYg Q1BVKFg4Nl82NCkgJiYgT1MoV0lORE9XUykgJiYgQ09NUElMRVIoTUlOR1c2NCkgJiYgR0NDX1ZF UlNJT04gPj0gNDAxMDAKLSAgICAjZGVmaW5lIEVOQUJMRV9KSVQgMQogI2VsaWYgQ1BVKFg4Nikg JiYgT1MoV0lORE9XUykgJiYgQ09NUElMRVIoTVNWQykKICAgICAjZGVmaW5lIEVOQUJMRV9KSVQg MQogICAgICNkZWZpbmUgV1RGX1VTRV9KSVRfU1RVQl9BUkdVTUVOVF9SRUdJU1RFUiAxCg==