38746 2010-05-07 06:53:40 -0700 [GTK] Fails to build on GTK+ < 2.14 2010-05-07 07:14:58 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned ossy rgabor webkit.review.bot oldest_to_newest 222329 0 gustavo 2010-05-07 06:53:40 -0700 Because we are now using gtk_adjustment_configure. 222331 1 55370 gustavo 2010-05-07 06:55:08 -0700 Created attachment 55370 proposed fix 222334 2 webkit.review.bot 2010-05-07 06:56:04 -0700 Attachment 55370 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/gtk/ScrollViewGtk.cpp:78: Extra space before ( in function call [whitespace/parens] [4] WebCore/platform/gtk/ScrollViewGtk.cpp:89: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/gtk/ScrollViewGtk.cpp:94: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 222337 3 55370 gustavo 2010-05-07 06:58:54 -0700 Comment on attachment 55370 proposed fix I'll commit manually with style fixed. 222346 4 55370 gustavo 2010-05-07 07:14:42 -0700 Comment on attachment 55370 proposed fix Landed as 58946 with rs by kenne. 55370 2010-05-07 06:55:08 -0700 2010-05-07 07:14:42 -0700 proposed fix 0001-Build-fix.patch text/plain 2278 gustavo RnJvbSA3NmVkNzVkN2MxOTI4Yjc0ZTE3YjIyYTFkMGViNDUxMDkzM2Q2MzQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IEZyaSwgNyBNYXkgMjAxMCAxMDo1NDoyMyAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIEJ1 aWxkIGZpeC4KCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgfCAg IDEyICsrKysrKysrKysrKwogV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsVmlld0d0ay5jcHAg fCAgIDIzICsrKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDM1IGluc2Vy dGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3YTkyZDQ2Li40NGUyNmNiIDEwMDY0NAotLS0gYS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBA CiAyMDEwLTA1LTA3ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29s bGFib3JhLmNvLnVrPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtHVEtdIEZhaWxzIHRvIGJ1aWxkIG9uIEdUSysgPCAyLjE0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODc0NgorCisgICAgICAgIEJ1aWxk IGZpeCBvbmx5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Njcm9sbFZpZXdHdGsuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6QWRqdXN0bWVudENvbmZpZ3VyZSk6CisKKzIwMTAtMDUtMDcgIEd1 c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CisK ICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgWGFuIExvcGV6LgogCiAgICAgICAgIENyYXNoIHdp dGggTWdPcGVuTW9kZXJuYSBmb250LCB3aXRoIG5vbi1VVEYtOCBjaGFyYWN0ZXIKZGlmZiAtLWdp dCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbFZpZXdHdGsuY3BwIGIvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvU2Nyb2xsVmlld0d0ay5jcHAKaW5kZXggZmU0MzE5Mi4uMGUxZjI5NyAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsVmlld0d0ay5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsVmlld0d0ay5jcHAKQEAgLTcyLDYgKzcyLDI5IEBAIFBhc3NS ZWZQdHI8U2Nyb2xsYmFyPiBTY3JvbGxWaWV3OjpjcmVhdGVTY3JvbGxiYXIoU2Nyb2xsYmFyT3Jp ZW50YXRpb24gb3JpZW50YXRpCiAgICAgICAgIHJldHVybiBTY3JvbGxiYXI6OmNyZWF0ZU5hdGl2 ZVNjcm9sbGJhcih0aGlzLCBvcmllbnRhdGlvbiwgUmVndWxhclNjcm9sbGJhcik7CiB9CiAKKyNp ZiAhR1RLX0NIRUNLX1ZFUlNJT04oMiwgMTQsIDApCisjZGVmaW5lIGd0a19hZGp1c21lbnRfY29u ZmlndXJlIEFkanVzdG1lbnRDb25maWd1cmUKKworc3RhdGljIHZvaWQgQWRqdXN0bWVudENvbmZp Z3VyZSAoR3RrQWRqdXN0bWVudCogYWRqdXN0bWVudCwgZ2RvdWJsZSB2YWx1ZSwgZ2RvdWJsZSBs b3dlciwgZ2RvdWJsZSB1cHBlciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdk b3VibGUgc3RlcEluY3JlbWVudCwgZ2RvdWJsZSBwYWdlSW5jcmVtZW50LCBnZG91YmxlIHBhZ2VT aXplKQoreworICAgIGdfb2JqZWN0X2ZyZWV6ZV9ub3RpZnkoR19PQkpFQ1QoYWRqdXN0bWVudCkp OworCisgICAgZ19vYmplY3Rfc2V0KGFkanVzdG1lbnQsCisgICAgICAgICAgICAgICAgICJsb3dl ciIsIGxvd2VyLAorICAgICAgICAgICAgICAgICAidXBwZXIiLCB1cHBlciwKKyAgICAgICAgICAg ICAgICAgInN0ZXAtaW5jcmVtZW50Iiwgc3RlcEluY3JlbWVudCwKKyAgICAgICAgICAgICAgICAg InBhZ2UtaW5jcmVtZW50IiwgcGFnZUluY3JlbWVudCwKKyAgICAgICAgICAgICAgICAgInBhZ2Ut c2l6ZSIsIHBhZ2VTaXplLAorICAgICAgICAgICAgICAgICBOVUxMKTsKKworICAgIGdfb2JqZWN0 X3RoYXdfbm90aWZ5KEdfT0JKRUNUKGFkanVzdG1lbnQpKTsKKworICAgIGd0a19hZGp1c3RtZW50 X2NoYW5nZWQoYWRqdXN0bWVudCk7CisgICAgZ3RrX2FkanVzdG1lbnRfdmFsdWVfY2hhbmdlZCAo YWRqdXN0bWVudCk7Cit9CisjZW5kaWYKKwogLyoKICAqIFRoZSBmb2xsb3dpbmcgaXMgYXNzdW1l ZDoKICAqICAgKGhhZGogJiYgdmFkaikgfHwgKCFoYWRqICYmICF2YWRqKQotLSAKMS43LjEKCg==