38741 2010-05-07 05:06:04 -0700 Fix halfword loads on ARM 2010-05-12 03:51:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 loki webkit-unassigned barraclough commit-queue hausmann laszlo.gombos oldest_to_newest 222278 0 loki 2010-05-07 05:06:04 -0700 The BaseIndex and ImplicitAddress are contain 32bit wide offset, but the load16 functions were working with 8 bit data (encoded in the instruction). If the offset cannot be encoded in an instruction, it should be stored in a temporary register. 222280 1 55363 loki 2010-05-07 05:07:16 -0700 Created attachment 55363 Fix halfword loads on ARM 222934 2 55363 commit-queue 2010-05-08 13:03:40 -0700 Comment on attachment 55363 Fix halfword loads on ARM Clearing flags on attachment: 55363 Committed r59038: <http://trac.webkit.org/changeset/59038> 222935 3 commit-queue 2010-05-08 13:03:46 -0700 All reviewed patches have been landed. Closing bug. 224507 4 hausmann 2010-05-12 03:41:04 -0700 Laszlo, this patch doesn't apply at all in the branch. There's no load16() function in MacroAssembler ARM. Is the branch affected by this issue at all? (Removing from the blocker list until we have something to cherry-pick :) 224510 5 loki 2010-05-12 03:51:26 -0700 This patch fixed both load16 functions. The load16(ImplicitAddress) is a newer function. I guess this one is missing from the Qt branch. You can add the load16(ImplicitAddress) function as well or inline its body into the load16(BaseIndex) function. 55363 2010-05-07 05:07:16 -0700 2010-05-08 13:03:40 -0700 Fix halfword loads on ARM 0001-Fix-halfword-loads-on-ARM.patch text/plain 3845 loki RnJvbSA4M2YzYWYyODBlMjJlY2FjYWIwNjMwMGRiZTg4ZDM0N2Q0N2IxMmJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogRnJpLCA3IE1heSAyMDEwIDE0OjAxOjAwICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGhh bGZ3b3JkIGxvYWRzIG9uIEFSTQoKU2lnbmVkLW9mZi1ieTogR2Fib3IgTG9raSA8bG9raUBpbmYu dS1zemVnZWQuaHU+Ci0tLQogSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgfCAgIDE3ICsrKysrKysrKysrKysrKysrCiBKYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv QVJNQXNzZW1ibGVyLmggICAgICB8ICAgIDkgKysrKysrKysrCiBKYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaCB8ICAgMTEgKysrKy0tLS0tLS0KIDMgZmlsZXMgY2hh bmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggOTdj ODhjYS4uNjg2NWRhMSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBi L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEwLTA1LTA3ICBH YWJvciBMb2tpICA8bG9raUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBoYWxmd29yZCBsb2FkcyBvbiBBUk0KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NzQxCisKKyAgICAgICAg VGhlIEJhc2VJbmRleCBhbmQgSW1wbGljaXRBZGRyZXNzIGFyZSBjb250YWluIDMyYml0IHdpZGUg b2Zmc2V0LCBidXQKKyAgICAgICAgdGhlIGxvYWQxNiBmdW5jdGlvbnMgd2VyZSB3b3JraW5nIHdp dGggOCBiaXQgZGF0YSAoZW5jb2RlZCBpbiB0aGUKKyAgICAgICAgaW5zdHJ1Y3Rpb24pLiBJZiB0 aGUgb2Zmc2V0IGNhbm5vdCBiZSBlbmNvZGVkIGluIGFuIGluc3RydWN0aW9uLCBpdAorICAgICAg ICBzaG91bGQgYmUgc3RvcmVkIGluIGEgdGVtcG9yYXJ5IHJlZ2lzdGVyLgorCisgICAgICAgICog YXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpBUk1Bc3NlbWJsZXI6Omdl dE9mZnNldEZvckhhbGZ3b3JkRGF0YVRyYW5zZmVyKToKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFj cm9Bc3NlbWJsZXJBUk0uaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06OmxvYWQx Nik6CisKIDIwMTAtMDUtMDYgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpk aWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oIGIvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oCmluZGV4IDJjYTA5NDkuLmExOTg2 NGEgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuaAor KysgYi9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmgKQEAgLTgyNSw2ICs4 MjUsMTUgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHZvaWQgbW92ZUltbShBUk1Xb3JkIGlt bSwgaW50IGRlc3QpOwogICAgICAgICBBUk1Xb3JkIGVuY29kZUNvbXBsZXhJbW0oQVJNV29yZCBp bW0sIGludCBkZXN0KTsKIAorICAgICAgICBBUk1Xb3JkIGdldE9mZnNldEZvckhhbGZ3b3JkRGF0 YVRyYW5zZmVyKEFSTVdvcmQgaW1tLCBpbnQgdG1wUmVnKQorICAgICAgICB7CisgICAgICAgICAg ICAvLyBFbmNvZGUgaW1tZWRpYXRlIGRhdGEgaW4gdGhlIGluc3RydWN0aW9uIGlmIGl0IGlzIHBv c3NpYmxlCisgICAgICAgICAgICBpZiAoaW1tIDw9IDB4ZmYpCisgICAgICAgICAgICAgICAgcmV0 dXJuIGdldE9wMkJ5dGUoaW1tKTsKKyAgICAgICAgICAgIC8vIE90aGVyd2lzZSwgc3RvcmUgdGhl IGRhdGEgaW4gYSB0ZW1wb3JhcnkgcmVnaXN0ZXIKKyAgICAgICAgICAgIHJldHVybiBlbmNvZGVD b21wbGV4SW1tKGltbSwgdG1wUmVnKTsKKyAgICAgICAgfQorCiAgICAgICAgIC8vIE1lbW9yeSBs b2FkL3N0b3JlIGhlbHBlcnMKIAogICAgICAgICB2b2lkIGRhdGFUcmFuc2ZlcjMyKGJvb2wgaXNM b2FkLCBSZWdpc3RlcklEIHNyY0RzdCwgUmVnaXN0ZXJJRCBiYXNlLCBpbnQzMl90IG9mZnNldCwg Ym9vbCBieXRlcyA9IGZhbHNlKTsKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlckFSTS5oIGIvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyQVJNLmgKaW5kZXggNDBkMmU0YS4uN2YxMWNhOSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKKysrIGIvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKQEAgLTI2NywxOSArMjY3LDE2IEBAIHB1Ymxp YzoKIAogICAgIHZvaWQgbG9hZDE2KEJhc2VJbmRleCBhZGRyZXNzLCBSZWdpc3RlcklEIGRlc3Qp CiAgICAgewotICAgICAgICBtX2Fzc2VtYmxlci5hZGRfcihBUk1SZWdpc3RlcnM6OlMwLCBhZGRy ZXNzLmJhc2UsIG1fYXNzZW1ibGVyLmxzbChhZGRyZXNzLmluZGV4LCBhZGRyZXNzLnNjYWxlKSk7 Ci0gICAgICAgIGlmIChhZGRyZXNzLm9mZnNldD49MCkKLSAgICAgICAgICAgIG1fYXNzZW1ibGVy LmxkcmhfdShkZXN0LCBBUk1SZWdpc3RlcnM6OlMwLCBBUk1Bc3NlbWJsZXI6OmdldE9wMkJ5dGUo YWRkcmVzcy5vZmZzZXQpKTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgbV9hc3NlbWJsZXIu bGRyaF9kKGRlc3QsIEFSTVJlZ2lzdGVyczo6UzAsIEFSTUFzc2VtYmxlcjo6Z2V0T3AyQnl0ZSgt YWRkcmVzcy5vZmZzZXQpKTsKKyAgICAgICAgbV9hc3NlbWJsZXIuYWRkX3IoQVJNUmVnaXN0ZXJz OjpTMSwgYWRkcmVzcy5iYXNlLCBtX2Fzc2VtYmxlci5sc2woYWRkcmVzcy5pbmRleCwgYWRkcmVz cy5zY2FsZSkpOworICAgICAgICBsb2FkMTYoQWRkcmVzcyhBUk1SZWdpc3RlcnM6OlMxLCBhZGRy ZXNzLm9mZnNldCksIGRlc3QpOwogICAgIH0KICAgICAKICAgICB2b2lkIGxvYWQxNihJbXBsaWNp dEFkZHJlc3MgYWRkcmVzcywgUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKICAgICAgICAgaWYgKGFk ZHJlc3Mub2Zmc2V0ID49IDApCi0gICAgICAgICAgICBtX2Fzc2VtYmxlci5sZHJoX3UoZGVzdCwg YWRkcmVzcy5iYXNlLCBBUk1Bc3NlbWJsZXI6OmdldE9wMkJ5dGUoYWRkcmVzcy5vZmZzZXQpKTsK KyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmxkcmhfdShkZXN0LCBhZGRyZXNzLmJhc2UsIG1fYXNz ZW1ibGVyLmdldE9mZnNldEZvckhhbGZ3b3JkRGF0YVRyYW5zZmVyKGFkZHJlc3Mub2Zmc2V0LCBB Uk1SZWdpc3RlcnM6OlMwKSk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIG1fYXNzZW1ibGVy LmxkcmhfZChkZXN0LCBhZGRyZXNzLmJhc2UsIEFSTUFzc2VtYmxlcjo6Z2V0T3AyQnl0ZSgtYWRk cmVzcy5vZmZzZXQpKTsgICAKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmxkcmhfZChkZXN0LCBh ZGRyZXNzLmJhc2UsIG1fYXNzZW1ibGVyLmdldE9mZnNldEZvckhhbGZ3b3JkRGF0YVRyYW5zZmVy KC1hZGRyZXNzLm9mZnNldCwgQVJNUmVnaXN0ZXJzOjpTMCkpOwogICAgIH0KIAogICAgIERhdGFM YWJlbDMyIHN0b3JlMzJXaXRoQWRkcmVzc09mZnNldFBhdGNoKFJlZ2lzdGVySUQgc3JjLCBBZGRy ZXNzIGFkZHJlc3MpCi0tIAoxLjUuNC4zCgo=