38740 2010-05-07 04:42:06 -0700 Web Inspector: On Linux/Windows panel history is traversed while iterating over words in text prompt. 2010-05-07 10:03:58 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman webkit-unassigned bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 222271 0 pfeldman 2010-05-07 04:42:06 -0700 Patch to follow. 222272 1 55362 pfeldman 2010-05-07 04:46:21 -0700 Created attachment 55362 [PATCH] Proposed fix. 222381 2 55362 joepeck 2010-05-07 08:13:31 -0700 Comment on attachment 55362 [PATCH] Proposed fix. > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index e498aa5..a279f5a 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,16 @@ > +2010-05-07 Pavel Feldman <pfeldman@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Web Inspector: On Linux/Windows panel history is traversed while iterating over words in text prompt. > + > + https://bugs.webkit.org/show_bug.cgi?id=38740 > + > + * inspector/front-end/TextPrompt.js: > + (WebInspector.TextPrompt): > + * inspector/front-end/inspector.js: > + (WebInspector.documentKeyDown): > + NIT: ChangeLog could include an explanation about why this didn't work. Thanks for catching this. 222453 3 pfeldman 2010-05-07 10:03:38 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TextPrompt.js M WebCore/inspector/front-end/inspector.js Committed r58954 55362 2010-05-07 04:46:21 -0700 2010-05-07 10:03:58 -0700 [PATCH] Proposed fix. panel_followup text/plain 2840 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTQ5OGFhNS4uYTI3OWY1YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNS0wNyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBPbiBMaW51eC9XaW5kb3dzIHBhbmVs IGhpc3RvcnkgaXMgdHJhdmVyc2VkIHdoaWxlIGl0ZXJhdGluZyBvdmVyIHdvcmRzIGluIHRleHQg cHJvbXB0LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zODc0MAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQpOgorICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvaW5zcGVjdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5 RG93bik6CisKIDIwMTAtMDUtMDYgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzIGIvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKaW5kZXggZDE3OWE5YS4uN2ZjY2U4YyAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKKysrIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKQEAgLTI5LDYgKzI5LDcg QEAKIFdlYkluc3BlY3Rvci5UZXh0UHJvbXB0ID0gZnVuY3Rpb24oZWxlbWVudCwgY29tcGxldGlv bnMsIHN0b3BDaGFyYWN0ZXJzKQogewogICAgIHRoaXMuZWxlbWVudCA9IGVsZW1lbnQ7CisgICAg dGhpcy5lbGVtZW50LmFkZFN0eWxlQ2xhc3MoInRleHQtcHJvbXB0Iik7CiAgICAgdGhpcy5jb21w bGV0aW9ucyA9IGNvbXBsZXRpb25zOwogICAgIHRoaXMuY29tcGxldGlvblN0b3BDaGFyYWN0ZXJz ID0gc3RvcENoYXJhY3RlcnM7CiAgICAgdGhpcy5oaXN0b3J5ID0gW107CmRpZmYgLS1naXQgYS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzIGIvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRleCA0YjA3MDFjLi5lZGQ1NGJkIDEwMDY0NAot LS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCisrKyBiL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKQEAgLTY4NSw2ICs2ODUsNyBAQCBX ZWJJbnNwZWN0b3IuZG9jdW1lbnRLZXlEb3duID0gZnVuY3Rpb24oZXZlbnQpCiAgICAgaWYgKFdl Ykluc3BlY3Rvci5pc0VkaXRpbmdBbnlGaWVsZCgpKQogICAgICAgICByZXR1cm47CiAKKyAgICB2 YXIgaXNJblRleHRQcm9tcHQgPSBldmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhD bGFzcygidGV4dC1wcm9tcHQiKTsKICAgICBpZiAodGhpcy5jdXJyZW50Rm9jdXNFbGVtZW50ICYm IHRoaXMuY3VycmVudEZvY3VzRWxlbWVudC5oYW5kbGVLZXlFdmVudCkgewogICAgICAgICB0aGlz LmN1cnJlbnRGb2N1c0VsZW1lbnQuaGFuZGxlS2V5RXZlbnQoZXZlbnQpOwogICAgICAgICBpZiAo ZXZlbnQuaGFuZGxlZCkgewpAQCAtNzA0LDExICs3MDUsNyBAQCBXZWJJbnNwZWN0b3IuZG9jdW1l bnRLZXlEb3duID0gZnVuY3Rpb24oZXZlbnQpCiAgICAgdmFyIGlzTWFjID0gV2ViSW5zcGVjdG9y LmlzTWFjKCk7CiAgICAgc3dpdGNoIChldmVudC5rZXlJZGVudGlmaWVyKSB7CiAgICAgICAgIGNh c2UgIkxlZnQiOgotICAgICAgICAgICAgaWYgKGlzTWFjKQotICAgICAgICAgICAgICAgIHZhciBp c0JhY2tLZXkgPSBldmVudC5tZXRhS2V5OwotICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAg ICAgIHZhciBpc0JhY2tLZXkgPSBldmVudC5jdHJsS2V5OwotCisgICAgICAgICAgICB2YXIgaXNC YWNrS2V5ID0gIWlzSW5UZXh0UHJvbXB0ICYmIChpc01hYyA/IGV2ZW50Lm1ldGFLZXkgOiBldmVu dC5jdHJsS2V5KTsKICAgICAgICAgICAgIGlmIChpc0JhY2tLZXkgJiYgdGhpcy5fcGFuZWxIaXN0 b3J5LmNhbkdvQmFjaygpKSB7CiAgICAgICAgICAgICAgICAgdGhpcy5fcGFuZWxIaXN0b3J5Lmdv QmFjaygpOwogICAgICAgICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CkBAIC03MTYs MTEgKzcxMyw3IEBAIFdlYkluc3BlY3Rvci5kb2N1bWVudEtleURvd24gPSBmdW5jdGlvbihldmVu dCkKICAgICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgIGNhc2UgIlJpZ2h0IjoKLSAgICAgICAg ICAgIGlmIChpc01hYykKLSAgICAgICAgICAgICAgICB2YXIgaXNGb3J3YXJkS2V5ID0gZXZlbnQu bWV0YUtleTsKLSAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICB2YXIgaXNGb3J3YXJk S2V5ID0gZXZlbnQuY3RybEtleTsKLQorICAgICAgICAgICAgdmFyIGlzRm9yd2FyZEtleSA9ICFp c0luVGV4dFByb21wdCAmJiAoaXNNYWMgPyBldmVudC5tZXRhS2V5IDogZXZlbnQuY3RybEtleSk7 CiAgICAgICAgICAgICBpZiAoaXNGb3J3YXJkS2V5ICYmIHRoaXMuX3BhbmVsSGlzdG9yeS5jYW5H b0ZvcndhcmQoKSkgewogICAgICAgICAgICAgICAgIHRoaXMuX3BhbmVsSGlzdG9yeS5nb0Zvcndh cmQoKTsKICAgICAgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwo=