38735 2010-05-07 03:46:04 -0700 ImageBuffer::transformColorSpace : linear RGB -> sRGB conversion formula error 2010-05-07 23:32:06 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zherczeg webkit-unassigned eric krit oliver zimmermann oldest_to_newest 222259 0 zherczeg 2010-05-07 03:46:04 -0700 let f(x) = ((x + 0.055) / 1.055) ^ 2.4 f(x)^(-1) (inverted formula) is ((x ^ (1 / 2.4)) * 1.055) - 0.055 instead of ((x * 1.055) ^ (1 / 2.4)) - 0.055 222260 1 55357 zherczeg 2010-05-07 03:57:13 -0700 Created attachment 55357 patch 222262 2 55359 zherczeg 2010-05-07 04:10:16 -0700 Created attachment 55359 Updated ChangeLog 222724 3 55359 darin 2010-05-07 17:31:51 -0700 Comment on attachment 55359 Updated ChangeLog > + color = (pow(color, 1.0f / 2.4f) * 1.055f) - 0.055f; Shouldn't this be powf? Using pow means we'll convert to double and then back to float. 222785 4 55458 zherczeg 2010-05-07 21:08:54 -0700 Created attachment 55458 change pow to powf Darin, nice catch. 222788 5 krit 2010-05-07 21:48:39 -0700 (In reply to comment #3) > (From update of attachment 55359 [details]) > > + color = (pow(color, 1.0f / 2.4f) * 1.055f) - 0.055f; > > Shouldn't this be powf? Using pow means we'll convert to double and then back > to float. Right, sorry. Didn't see that. 222798 6 zimmermann 2010-05-07 22:17:40 -0700 This does not affect mac pixel tests? 222799 7 krit 2010-05-07 22:23:15 -0700 (In reply to comment #5) > (In reply to comment #3) > > (From update of attachment 55359 [details] [details]) > > > + color = (pow(color, 1.0f / 2.4f) * 1.055f) - 0.055f; > > > > Shouldn't this be powf? Using pow means we'll convert to double and then back > > to float. > > Right, sorry. Didn't see that. No it doesn't. The code is just used for Chromium Gtk and Qt. 222827 8 zherczeg 2010-05-07 23:32:06 -0700 Landed in r59002 : http://trac.webkit.org/changeset/59002 Closing bug. 55357 2010-05-07 03:57:13 -0700 2010-05-07 04:10:16 -0700 patch 0001-transformColorSpace.patch text/plain 2289 zherczeg RnJvbSAwNDdlOTk2ZTRlMGUyNjM0Y2IzN2U5MGM4ZmFmN2IyZDg1ZTQ4Y2Q2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBGcmksIDcgTWF5IDIwMTAgMTI6NTA6NDcgKzAyMDAKU3ViamVjdDogW1BBVENI XSB0cmFuc2Zvcm1Db2xvclNwYWNlCgpTaWduZWQtb2ZmLWJ5OiBab2x0YW4gSGVyY3plZyA8emhl cmN6ZWdAaW5mLnUtc3plZ2VkLmh1PgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9JbWFnZUJ1ZmZlci5jcHAgfCAgICA1ICsrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE2IGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlNDk4YWE1Li45ZTU1NDcxIDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEwLTA1LTA3ICBab2x0YW4gSGVyY3plZyAgPHpoZXJjemVnQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgdGhl IGludmVyc2UgZnVuY3Rpb24gb2YgZih4KSA9ICgoeCArIDAuMDU1KSAvIDEuMDU1KSBeIDIuNAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg3MzUKKwor ICAgICAgICBJdCBpcyAoKHggXiAoMSAvIDIuNCkpICogMS4wNTUpIC0gMC4wNTUKKworICAgICAg ICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0lt YWdlQnVmZmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlQnVmZmVyOjp0cmFuc2Zvcm1D b2xvclNwYWNlKToKKwogMjAxMC0wNS0wNiAgRnVtaXRvc2hpIFVrYWkgIDx1a2FpQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5jcHAgYi9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmNwcAppbmRleCA1NTMwNWQxLi45OGZjNDRk IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmNwcAor KysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmNwcApAQCAtNDIsNyAr NDIsNiBAQCB2b2lkIEltYWdlQnVmZmVyOjp0cmFuc2Zvcm1Db2xvclNwYWNlKEltYWdlQ29sb3JT cGFjZSBzcmNDb2xvclNwYWNlLCBJbWFnZUNvbG9yUwogICAgICAgICAoZHN0Q29sb3JTcGFjZSAh PSBMaW5lYXJSR0IgJiYgZHN0Q29sb3JTcGFjZSAhPSBEZXZpY2VSR0IpKQogICAgICAgICByZXR1 cm47CiAKLSAgICBWZWN0b3I8aW50PiBsb29rVXBUYWJsZTsKICAgICBpZiAoZHN0Q29sb3JTcGFj ZSA9PSBMaW5lYXJSR0IpIHsKICAgICAgICAgaWYgKG1fbGluZWFyUmdiTFVULmlzRW1wdHkoKSkg ewogICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IDI1NjsgaSsrKSB7CkBAIC01 Nyw4ICs1Niw4IEBAIHZvaWQgSW1hZ2VCdWZmZXI6OnRyYW5zZm9ybUNvbG9yU3BhY2UoSW1hZ2VD b2xvclNwYWNlIHNyY0NvbG9yU3BhY2UsIEltYWdlQ29sb3JTCiAgICAgfSBlbHNlIGlmIChkc3RD b2xvclNwYWNlID09IERldmljZVJHQikgewogICAgICAgICBpZiAobV9kZXZpY2VSZ2JMVVQuaXNF bXB0eSgpKSB7CiAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgMjU2OyBpKysp IHsKLSAgICAgICAgICAgICAgICBmbG9hdCBjb2xvciA9IGkgIC8gMjU1LjBmOwotICAgICAgICAg ICAgICAgIGNvbG9yID0gcG93KDEuMDU1ZiAqIGNvbG9yLCAxLjBmIC8gMi40ZikgLSAwLjA1NWY7 CisgICAgICAgICAgICAgICAgZmxvYXQgY29sb3IgPSBpIC8gMjU1LjBmOworICAgICAgICAgICAg ICAgIGNvbG9yID0gKHBvdyhjb2xvciwgMS4wZiAvIDIuNGYpICogMS4wNTVmKSAtIDAuMDU1ZjsK ICAgICAgICAgICAgICAgICBjb2xvciA9IHN0ZDo6bWF4KDAuMGYsIGNvbG9yKTsKICAgICAgICAg ICAgICAgICBjb2xvciA9IHN0ZDo6bWluKDEuMGYsIGNvbG9yKTsKICAgICAgICAgICAgICAgICBt X2RldmljZVJnYkxVVC5hcHBlbmQoc3RhdGljX2Nhc3Q8aW50Pihjb2xvciAqIDI1NSkpOwotLSAK MS42LjAuNAoK 55359 2010-05-07 04:10:16 -0700 2010-05-07 22:08:08 -0700 Updated ChangeLog 0001-transformColorSpace.patch text/plain 2364 zherczeg RnJvbSAwNDdlOTk2ZTRlMGUyNjM0Y2IzN2U5MGM4ZmFmN2IyZDg1ZTQ4Y2Q2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogWm9sdGFuIEhlcmN6ZWcgPHpoZXJjemVnQGluZi51LXN6ZWdl ZC5odT4NCkRhdGU6IEZyaSwgNyBNYXkgMjAxMCAxMjo1MDo0NyArMDIwMA0KU3ViamVjdDogW1BB VENIXSB0cmFuc2Zvcm1Db2xvclNwYWNlDQoNClNpZ25lZC1vZmYtYnk6IFpvbHRhbiBIZXJjemVn IDx6aGVyY3plZ0BpbmYudS1zemVnZWQuaHU+DQotLS0NCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysNCiBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmNwcCB8ICAgIDUgKystLS0NCiAyIGZpbGVzIGNoYW5n ZWQsIDE2IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9XZWJD b3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nDQppbmRleCBlNDk4YWE1Li45ZTU1NDcx IDEwMDY0NA0KLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cNCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n DQpAQCAtMSwzICsxLDE3IEBADQorMjAxMC0wNS0wNyAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3pl Z0B3ZWJraXQub3JnPg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQor DQorICAgICAgICBGaXhlZCB0aGUgaW52ZXJzZSBmdW5jdGlvbiBvZiBmKHgpID0gKCh4ICsgMC4w NTUpIC8gMS4wNTUpIF4gMi40DQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mzg3MzUNCisNCisgICAgICAgIEl0IGlzICgoeCBeICgxIC8gMi40KSkgKiAx LjA1NSkgLSAwLjA1NQ0KKw0KKyAgICAgICAgQ2hyb21pdW0gcGl4ZWwgdGVzdHMgY292ZXIgdGhl IGlzc3VlLg0KKw0KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5jcHA6 DQorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OnRyYW5zZm9ybUNvbG9yU3BhY2UpOg0K Kw0KIDIwMTAtMDUtMDYgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+DQogDQog ICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292Lg0KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5jcHANCmluZGV4IDU1MzA1ZDEuLjk4ZmM0NGQgMTAwNjQ0 DQotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmNwcA0KKysrIGIv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5jcHANCkBAIC00Miw3ICs0Miw2 IEBAIHZvaWQgSW1hZ2VCdWZmZXI6OnRyYW5zZm9ybUNvbG9yU3BhY2UoSW1hZ2VDb2xvclNwYWNl IHNyY0NvbG9yU3BhY2UsIEltYWdlQ29sb3JTDQogICAgICAgICAoZHN0Q29sb3JTcGFjZSAhPSBM aW5lYXJSR0IgJiYgZHN0Q29sb3JTcGFjZSAhPSBEZXZpY2VSR0IpKQ0KICAgICAgICAgcmV0dXJu Ow0KIA0KLSAgICBWZWN0b3I8aW50PiBsb29rVXBUYWJsZTsNCiAgICAgaWYgKGRzdENvbG9yU3Bh Y2UgPT0gTGluZWFyUkdCKSB7DQogICAgICAgICBpZiAobV9saW5lYXJSZ2JMVVQuaXNFbXB0eSgp KSB7DQogICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IDI1NjsgaSsrKSB7DQpA QCAtNTcsOCArNTYsOCBAQCB2b2lkIEltYWdlQnVmZmVyOjp0cmFuc2Zvcm1Db2xvclNwYWNlKElt YWdlQ29sb3JTcGFjZSBzcmNDb2xvclNwYWNlLCBJbWFnZUNvbG9yUw0KICAgICB9IGVsc2UgaWYg KGRzdENvbG9yU3BhY2UgPT0gRGV2aWNlUkdCKSB7DQogICAgICAgICBpZiAobV9kZXZpY2VSZ2JM VVQuaXNFbXB0eSgpKSB7DQogICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IDI1 NjsgaSsrKSB7DQotICAgICAgICAgICAgICAgIGZsb2F0IGNvbG9yID0gaSAgLyAyNTUuMGY7DQot ICAgICAgICAgICAgICAgIGNvbG9yID0gcG93KDEuMDU1ZiAqIGNvbG9yLCAxLjBmIC8gMi40Zikg LSAwLjA1NWY7DQorICAgICAgICAgICAgICAgIGZsb2F0IGNvbG9yID0gaSAvIDI1NS4wZjsNCisg ICAgICAgICAgICAgICAgY29sb3IgPSAocG93KGNvbG9yLCAxLjBmIC8gMi40ZikgKiAxLjA1NWYp IC0gMC4wNTVmOw0KICAgICAgICAgICAgICAgICBjb2xvciA9IHN0ZDo6bWF4KDAuMGYsIGNvbG9y KTsNCiAgICAgICAgICAgICAgICAgY29sb3IgPSBzdGQ6Om1pbigxLjBmLCBjb2xvcik7DQogICAg ICAgICAgICAgICAgIG1fZGV2aWNlUmdiTFVULmFwcGVuZChzdGF0aWNfY2FzdDxpbnQ+KGNvbG9y ICogMjU1KSk7DQotLSANCjEuNi4wLjQNCg0K 55458 2010-05-07 21:08:54 -0700 2010-05-07 22:07:47 -0700 change pow to powf transformColorSpace.patch text/plain 2365 zherczeg RnJvbSAwNDdlOTk2ZTRlMGUyNjM0Y2IzN2U5MGM4ZmFmN2IyZDg1ZTQ4Y2Q2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogWm9sdGFuIEhlcmN6ZWcgPHpoZXJjemVnQGluZi51LXN6ZWdl ZC5odT4NCkRhdGU6IEZyaSwgNyBNYXkgMjAxMCAxMjo1MDo0NyArMDIwMA0KU3ViamVjdDogW1BB VENIXSB0cmFuc2Zvcm1Db2xvclNwYWNlDQoNClNpZ25lZC1vZmYtYnk6IFpvbHRhbiBIZXJjemVn IDx6aGVyY3plZ0BpbmYudS1zemVnZWQuaHU+DQotLS0NCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysNCiBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmNwcCB8ICAgIDUgKystLS0NCiAyIGZpbGVzIGNoYW5n ZWQsIDE2IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9XZWJD b3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nDQppbmRleCBlNDk4YWE1Li45ZTU1NDcx IDEwMDY0NA0KLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cNCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n DQpAQCAtMSwzICsxLDE3IEBADQorMjAxMC0wNS0wNyAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3pl Z0B3ZWJraXQub3JnPg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQor DQorICAgICAgICBGaXhlZCB0aGUgaW52ZXJzZSBmdW5jdGlvbiBvZiBmKHgpID0gKCh4ICsgMC4w NTUpIC8gMS4wNTUpIF4gMi40DQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mzg3MzUNCisNCisgICAgICAgIEl0IGlzICgoeCBeICgxIC8gMi40KSkgKiAx LjA1NSkgLSAwLjA1NQ0KKw0KKyAgICAgICAgQ2hyb21pdW0gcGl4ZWwgdGVzdHMgY292ZXIgdGhl IGlzc3VlLg0KKw0KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5jcHA6 DQorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OnRyYW5zZm9ybUNvbG9yU3BhY2UpOg0K Kw0KIDIwMTAtMDUtMDYgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+DQogDQog ICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292Lg0KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5jcHANCmluZGV4IDU1MzA1ZDEuLjk4ZmM0NGQgMTAwNjQ0 DQotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmNwcA0KKysrIGIv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5jcHANCkBAIC00Miw3ICs0Miw2 IEBAIHZvaWQgSW1hZ2VCdWZmZXI6OnRyYW5zZm9ybUNvbG9yU3BhY2UoSW1hZ2VDb2xvclNwYWNl IHNyY0NvbG9yU3BhY2UsIEltYWdlQ29sb3JTDQogICAgICAgICAoZHN0Q29sb3JTcGFjZSAhPSBM aW5lYXJSR0IgJiYgZHN0Q29sb3JTcGFjZSAhPSBEZXZpY2VSR0IpKQ0KICAgICAgICAgcmV0dXJu Ow0KIA0KLSAgICBWZWN0b3I8aW50PiBsb29rVXBUYWJsZTsNCiAgICAgaWYgKGRzdENvbG9yU3Bh Y2UgPT0gTGluZWFyUkdCKSB7DQogICAgICAgICBpZiAobV9saW5lYXJSZ2JMVVQuaXNFbXB0eSgp KSB7DQogICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IDI1NjsgaSsrKSB7DQpA QCAtNTcsOCArNTYsOCBAQCB2b2lkIEltYWdlQnVmZmVyOjp0cmFuc2Zvcm1Db2xvclNwYWNlKElt YWdlQ29sb3JTcGFjZSBzcmNDb2xvclNwYWNlLCBJbWFnZUNvbG9yUw0KICAgICB9IGVsc2UgaWYg KGRzdENvbG9yU3BhY2UgPT0gRGV2aWNlUkdCKSB7DQogICAgICAgICBpZiAobV9kZXZpY2VSZ2JM VVQuaXNFbXB0eSgpKSB7DQogICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IDI1 NjsgaSsrKSB7DQotICAgICAgICAgICAgICAgIGZsb2F0IGNvbG9yID0gaSAgLyAyNTUuMGY7DQot ICAgICAgICAgICAgICAgIGNvbG9yID0gcG93KDEuMDU1ZiAqIGNvbG9yLCAxLjBmIC8gMi40Zikg LSAwLjA1NWY7DQorICAgICAgICAgICAgICAgIGZsb2F0IGNvbG9yID0gaSAvIDI1NS4wZjsNCisg ICAgICAgICAgICAgICAgY29sb3IgPSAocG93Zihjb2xvciwgMS4wZiAvIDIuNGYpICogMS4wNTVm KSAtIDAuMDU1ZjsNCiAgICAgICAgICAgICAgICAgY29sb3IgPSBzdGQ6Om1heCgwLjBmLCBjb2xv cik7DQogICAgICAgICAgICAgICAgIGNvbG9yID0gc3RkOjptaW4oMS4wZiwgY29sb3IpOw0KICAg ICAgICAgICAgICAgICBtX2RldmljZVJnYkxVVC5hcHBlbmQoc3RhdGljX2Nhc3Q8aW50Pihjb2xv ciAqIDI1NSkpOw0KLS0gDQoxLjYuMC40DQoNCg==