38732 2010-05-07 02:31:41 -0700 Web Inspector: Cosmetic changes in Timeline Panel. 2010-05-10 09:17:07 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo loislo abarth commit-queue eric pfeldman timothy webkit.review.bot yurys oldest_to_newest 222248 0 loislo 2010-05-07 02:31:41 -0700 1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child. 2) Standard tooltips for resource links are clashing with Popover. 3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows). 222249 1 55351 loislo 2010-05-07 02:34:24 -0700 Created attachment 55351 [patch] Initial version. 222864 2 55351 commit-queue 2010-05-08 05:11:37 -0700 Comment on attachment 55351 [patch] Initial version. Rejecting patch 55351 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 18317 test cases. inspector/timeline-event-dispatch.html -> failed Exiting early after 1 failures. 14662 tests run. 265.54s total testing time 14661 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 7 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/2170072 222968 3 eric 2010-05-08 23:13:51 -0700 Attachment 55351 was posted by a committer and has review+, assigning to Ilya Tikhonovsky for commit. 223092 4 webkit.review.bot 2010-05-09 14:56:37 -0700 http://trac.webkit.org/changeset/59062 might have broken GTK Linux 32-bit Release 223094 5 55351 joepeck 2010-05-09 15:03:28 -0700 Comment on attachment 55351 [patch] Initial version. > + console.log(WebInspector.linkifyResourceAsNode(record.data.url, "scripts", record.data.lineNumber, "", "")); This looks like debug, it should not go in. > + else if (typeof tooltipText !== "string" || tooltipText.length != 0) The second half of this should either be: tooltipText.length !== 0 or: !tooltipText.length Personally I'm a fan of the "!== 0" in cases of "length". But I don't think there is a style rule for this yet. 223351 6 loislo 2010-05-10 09:17:07 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TimelinePanel.js M WebCore/inspector/front-end/inspector.js Committed r59080 55351 2010-05-07 02:34:24 -0700 2010-05-09 15:03:28 -0700 [patch] Initial version. patch text/plain 6291 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTFkZTE5MC4uOGMwMGEzMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNS0wNyAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBDb3NtZXRpYyBjaGFuZ2VzLgorICAg ICAgICAxKSBJbm5lciBGdW5jdGlvbiBDYWxsIGV2ZW50IG9mIFRpbWVyIEZpcmUgc2hvdWxkIGJl IG1lcmdlZCBpbnRvIHBhcmVudCBldmVuIGlmIGl0IGlzIG5vdCB0aGUgb25seSBjaGlsZC4KKyAg ICAgICAgMikgU3RhbmRhcmQgdG9vbHRpcHMgZm9yIHJlc291cmNlIGxpbmtzIGFyZSBjbGFzaGlu ZyB3aXRoIFBvcG92ZXIuCisgICAgICAgIDMpIFJlY2FsY3VsYXRlIFN0eWxlIGNhbGxlciBpbmZv IGFyZSBkdXBsaWNhdGluZyBpbiBEZXRhaWxzIFBvcG92ZXIgKENhbGxlciBhbmQgRGV0YWlscyBy b3dzKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4 NzMyCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90b3R5cGUuX2lubmVyQWRkUmVj b3JkVG9UaW1lbGluZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5Gb3Jt YXR0ZWRSZWNvcmQucHJvdG90eXBlLl9nZW5lcmF0ZVBvcHVwQ29udGVudCk6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5Gb3JtYXR0ZWRSZWNvcmQucHJvdG90eXBlLl9nZXRS ZWNvcmREZXRhaWxzKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5saW5raWZ5VVJMQXNOb2RlKToKKwogMjAxMC0wNC0y NyAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Rp bWVsaW5lUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5l bC5qcwppbmRleCA0ZmY5ZDVhLi5kYzUzMGYwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvVGltZWxpbmVQYW5lbC5qcwpAQCAtMjkyLDEyICsyOTIsMTMgQEAgV2ViSW5zcGVjdG9y LlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgfQogICAgICAgICB9CiAK LSAgICAgICAgaWYgKHJlY29yZC50eXBlID09IHJlY29yZFR5cGVzLlRpbWVyRmlyZSAmJiByZWNv cmQuY2hpbGRyZW4gJiYgcmVjb3JkLmNoaWxkcmVuLmxlbmd0aCA9PT0gMSkgeworICAgICAgICBp ZiAocmVjb3JkLnR5cGUgPT0gcmVjb3JkVHlwZXMuVGltZXJGaXJlICYmIHJlY29yZC5jaGlsZHJl bikgewogICAgICAgICAgICAgdmFyIGNoaWxkUmVjb3JkID0gcmVjb3JkLmNoaWxkcmVuWzBdOwog ICAgICAgICAgICAgaWYgKCBjaGlsZFJlY29yZC50eXBlID09PSByZWNvcmRUeXBlcy5GdW5jdGlv bkNhbGwpIHsKICAgICAgICAgICAgICAgICByZWNvcmQuZGF0YS5zY3JpcHROYW1lID0gY2hpbGRS ZWNvcmQuZGF0YS5zY3JpcHROYW1lOwogICAgICAgICAgICAgICAgIHJlY29yZC5kYXRhLnNjcmlw dExpbmUgPSBjaGlsZFJlY29yZC5kYXRhLnNjcmlwdExpbmU7Ci0gICAgICAgICAgICAgICAgcmVj b3JkLmNoaWxkcmVuID0gY2hpbGRSZWNvcmQuY2hpbGRyZW47CisgICAgICAgICAgICAgICAgcmVj b3JkLmNoaWxkcmVuLnNoaWZ0KCk7CisgICAgICAgICAgICAgICAgcmVjb3JkLmNoaWxkcmVuID0g Y2hpbGRSZWNvcmQuY2hpbGRyZW4uY29uY2F0KHJlY29yZC5jaGlsZHJlbik7CiAgICAgICAgICAg ICB9CiAgICAgICAgIH0KIApAQCAtOTI4LDYgKzkyOSw4IEBAIFdlYkluc3BlY3Rvci5UaW1lbGlu ZVBhbmVsLkZvcm1hdHRlZFJlY29yZC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBjYXNlIHJl Y29yZFR5cGVzLlBhaW50OgogICAgICAgICAgICAgICAgIGNvbnRlbnRIZWxwZXIuX2FwcGVuZFRl eHRSb3coIkxvY2F0aW9uIiwgdGhpcy5kYXRhLnggKyAiXHUyMDA5XHUwMGQ3XHUyMDA5IiArIHRo aXMuZGF0YS55KTsKICAgICAgICAgICAgICAgICBjb250ZW50SGVscGVyLl9hcHBlbmRUZXh0Um93 KCJEaW1lbnNpb25zIiwgdGhpcy5kYXRhLndpZHRoICsgIlx1MjAwOVx1MDBkN1x1MjAwOSIgKyB0 aGlzLmRhdGEuaGVpZ2h0KTsKKyAgICAgICAgICAgIGNhc2UgcmVjb3JkVHlwZXMuUmVjYWxjdWxh dGVTdHlsZXM6IC8vIFdlIGRvbid0IHdhbnQgdG8gc2VlIGRlZmF1bHQgZGV0YWlscy4KKyAgICAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICAgICAg aWYgKHRoaXMuZGV0YWlscykKICAgICAgICAgICAgICAgICAgICAgY29udGVudEhlbHBlci5fYXBw ZW5kVGV4dFJvdygiRGV0YWlscyIsIHRoaXMuZGV0YWlscyk7CkBAIC05NTIsMjEgKzk1NSwyMiBA QCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5Gb3JtYXR0ZWRSZWNvcmQucHJvdG90eXBlID0g ewogICAgICAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuVGltZWxpbmVBZ2VudC5SZWNvcmRUeXBl LkdDRXZlbnQ6CiAgICAgICAgICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygi JXMgY29sbGVjdGVkIiwgTnVtYmVyLmJ5dGVzVG9TdHJpbmcocmVjb3JkLmRhdGEudXNlZEhlYXBT aXplRGVsdGEpKTsKICAgICAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLlRpbWVsaW5lQWdlbnQu UmVjb3JkVHlwZS5UaW1lckZpcmU6Ci0gICAgICAgICAgICAgICAgcmV0dXJuIHJlY29yZC5kYXRh LnNjcmlwdE5hbWUgPyBXZWJJbnNwZWN0b3IubGlua2lmeVJlc291cmNlQXNOb2RlKHJlY29yZC5k YXRhLnNjcmlwdE5hbWUsICJzY3JpcHRzIiwgcmVjb3JkLmRhdGEuc2NyaXB0TGluZSkgOiByZWNv cmQuZGF0YS50aW1lcklkOworICAgICAgICAgICAgICAgIHJldHVybiByZWNvcmQuZGF0YS5zY3Jp cHROYW1lID8gV2ViSW5zcGVjdG9yLmxpbmtpZnlSZXNvdXJjZUFzTm9kZShyZWNvcmQuZGF0YS5z Y3JpcHROYW1lLCAic2NyaXB0cyIsIHJlY29yZC5kYXRhLnNjcmlwdExpbmUsICIiLCAiIikgOiBy ZWNvcmQuZGF0YS50aW1lcklkOwogICAgICAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuVGltZWxp bmVBZ2VudC5SZWNvcmRUeXBlLkZ1bmN0aW9uQ2FsbDoKLSAgICAgICAgICAgICAgICByZXR1cm4g cmVjb3JkLmRhdGEuc2NyaXB0TmFtZSA/IFdlYkluc3BlY3Rvci5saW5raWZ5UmVzb3VyY2VBc05v ZGUocmVjb3JkLmRhdGEuc2NyaXB0TmFtZSwgInNjcmlwdHMiLCByZWNvcmQuZGF0YS5zY3JpcHRM aW5lKSA6IG51bGw7CisgICAgICAgICAgICAgICAgcmV0dXJuIHJlY29yZC5kYXRhLnNjcmlwdE5h bWUgPyBXZWJJbnNwZWN0b3IubGlua2lmeVJlc291cmNlQXNOb2RlKHJlY29yZC5kYXRhLnNjcmlw dE5hbWUsICJzY3JpcHRzIiwgcmVjb3JkLmRhdGEuc2NyaXB0TGluZSwgIiIsICIiKSA6IG51bGw7 CiAgICAgICAgICAgICBjYXNlIFdlYkluc3BlY3Rvci5UaW1lbGluZUFnZW50LlJlY29yZFR5cGUu RXZlbnREaXNwYXRjaDoKICAgICAgICAgICAgICAgICByZXR1cm4gcmVjb3JkLmRhdGEgPyByZWNv cmQuZGF0YS50eXBlIDogbnVsbDsKICAgICAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLlRpbWVs aW5lQWdlbnQuUmVjb3JkVHlwZS5QYWludDoKICAgICAgICAgICAgICAgICByZXR1cm4gcmVjb3Jk LmRhdGEud2lkdGggKyAiXHUyMDA5XHUwMGQ3XHUyMDA5IiArIHJlY29yZC5kYXRhLmhlaWdodDsK ICAgICAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLlRpbWVsaW5lQWdlbnQuUmVjb3JkVHlwZS5U aW1lckluc3RhbGw6CiAgICAgICAgICAgICBjYXNlIFdlYkluc3BlY3Rvci5UaW1lbGluZUFnZW50 LlJlY29yZFR5cGUuVGltZXJSZW1vdmU6Ci0gICAgICAgICAgICAgICAgcmV0dXJuIHRoaXMuY2Fs bGVyU2NyaXB0TmFtZSA/IFdlYkluc3BlY3Rvci5saW5raWZ5UmVzb3VyY2VBc05vZGUodGhpcy5j YWxsZXJTY3JpcHROYW1lLCAic2NyaXB0cyIsIHRoaXMuY2FsbGVyU2NyaXB0TGluZSkgOiByZWNv cmQuZGF0YS50aW1lcklkOworICAgICAgICAgICAgICAgIHJldHVybiB0aGlzLmNhbGxlclNjcmlw dE5hbWUgPyBXZWJJbnNwZWN0b3IubGlua2lmeVJlc291cmNlQXNOb2RlKHRoaXMuY2FsbGVyU2Ny aXB0TmFtZSwgInNjcmlwdHMiLCB0aGlzLmNhbGxlclNjcmlwdExpbmUsICIiLCAiIikgOiByZWNv cmQuZGF0YS50aW1lcklkOwogICAgICAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuVGltZWxpbmVB Z2VudC5SZWNvcmRUeXBlLlBhcnNlSFRNTDoKICAgICAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9y LlRpbWVsaW5lQWdlbnQuUmVjb3JkVHlwZS5SZWNhbGN1bGF0ZVN0eWxlczoKLSAgICAgICAgICAg ICAgICByZXR1cm4gdGhpcy5jYWxsZXJTY3JpcHROYW1lID8gV2ViSW5zcGVjdG9yLmxpbmtpZnlS ZXNvdXJjZUFzTm9kZSh0aGlzLmNhbGxlclNjcmlwdE5hbWUsICJzY3JpcHRzIiwgdGhpcy5jYWxs ZXJTY3JpcHRMaW5lKSA6IG51bGw7CisgICAgICAgICAgICAgICAgcmV0dXJuIHRoaXMuY2FsbGVy U2NyaXB0TmFtZSA/IFdlYkluc3BlY3Rvci5saW5raWZ5UmVzb3VyY2VBc05vZGUodGhpcy5jYWxs ZXJTY3JpcHROYW1lLCAic2NyaXB0cyIsIHRoaXMuY2FsbGVyU2NyaXB0TGluZSwgIiIsICIiKSA6 IG51bGw7CiAgICAgICAgICAgICBjYXNlIFdlYkluc3BlY3Rvci5UaW1lbGluZUFnZW50LlJlY29y ZFR5cGUuRXZhbHVhdGVTY3JpcHQ6Ci0gICAgICAgICAgICAgICAgcmV0dXJuIHJlY29yZC5kYXRh LnVybCA/IFdlYkluc3BlY3Rvci5saW5raWZ5UmVzb3VyY2VBc05vZGUocmVjb3JkLmRhdGEudXJs LCAic2NyaXB0cyIsIHJlY29yZC5kYXRhLmxpbmVOdW1iZXIpIDogbnVsbDsKKyAgICAgICAgICAg ICAgICBjb25zb2xlLmxvZyhXZWJJbnNwZWN0b3IubGlua2lmeVJlc291cmNlQXNOb2RlKHJlY29y ZC5kYXRhLnVybCwgInNjcmlwdHMiLCByZWNvcmQuZGF0YS5saW5lTnVtYmVyLCAiIiwgIiIpKTsK KyAgICAgICAgICAgICAgICByZXR1cm4gcmVjb3JkLmRhdGEudXJsID8gV2ViSW5zcGVjdG9yLmxp bmtpZnlSZXNvdXJjZUFzTm9kZShyZWNvcmQuZGF0YS51cmwsICJzY3JpcHRzIiwgcmVjb3JkLmRh dGEubGluZU51bWJlciwgIiIsICIiKSA6IG51bGw7CiAgICAgICAgICAgICBjYXNlIFdlYkluc3Bl Y3Rvci5UaW1lbGluZUFnZW50LlJlY29yZFR5cGUuWEhSUmVhZHlTdGF0ZUNoYW5nZToKICAgICAg ICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLlRpbWVsaW5lQWdlbnQuUmVjb3JkVHlwZS5YSFJMb2Fk OgogICAgICAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuVGltZWxpbmVBZ2VudC5SZWNvcmRUeXBl LlJlc291cmNlU2VuZFJlcXVlc3Q6CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvaW5zcGVjdG9yLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rv ci5qcwppbmRleCA0YjA3MDFjLi42MTQzMTlhIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9pbnNwZWN0b3IuanMKQEAgLTE2NTIsNyArMTY1MiwxMCBAQCBXZWJJbnNwZWN0b3IubGlua2lm eVVSTEFzTm9kZSA9IGZ1bmN0aW9uKHVybCwgbGlua1RleHQsIGNsYXNzZXMsIGlzRXh0ZXJuYWws IHRvbwogICAgIHZhciBhID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYSIpOwogICAgIGEuaHJl ZiA9IHVybDsKICAgICBhLmNsYXNzTmFtZSA9IGNsYXNzZXM7Ci0gICAgYS50aXRsZSA9IHRvb2x0 aXBUZXh0IHx8IHVybDsKKyAgICBpZiAodHlwZW9mIHRvb2x0aXBUZXh0ID09PSAidW5kZWZpbmVk IikKKyAgICAgICAgYS50aXRsZSA9IHVybDsKKyAgICBlbHNlIGlmICh0eXBlb2YgdG9vbHRpcFRl eHQgIT09ICJzdHJpbmciIHx8IHRvb2x0aXBUZXh0Lmxlbmd0aCAhPSAwKQorICAgICAgICBhLnRp dGxlID0gdG9vbHRpcFRleHQ7CiAgICAgYS50YXJnZXQgPSAiX2JsYW5rIjsKICAgICBhLnRleHRD b250ZW50ID0gbGlua1RleHQ7CiAK