38726 2010-05-06 23:35:17 -0700 Web Inspector: Expand UI element should be extracted as separate class from TimelineRecordGraphRow for future reuse. 2010-05-08 04:49:08 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 38643 0 loislo webkit-unassigned commit-queue pfeldman timothy yurys oldest_to_newest 222201 0 loislo 2010-05-06 23:35:17 -0700 This is the first part of changes for fixing https://bugs.webkit.org/show_bug.cgi?id=38643. 222211 1 55344 loislo 2010-05-07 00:10:29 -0700 Created attachment 55344 [patch] Initial version. 222862 2 55344 commit-queue 2010-05-08 04:49:03 -0700 Comment on attachment 55344 [patch] Initial version. Clearing flags on attachment: 55344 Committed r59019: <http://trac.webkit.org/changeset/59019> 222863 3 commit-queue 2010-05-08 04:49:08 -0700 All reviewed patches have been landed. Closing bug. 55344 2010-05-07 00:10:29 -0700 2010-05-08 04:49:03 -0700 [patch] Initial version. patch text/plain 6878 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTFkZTE5MC4uYjE2NzYwZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNS0wNiAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViSW5zZWN0b3I6IFJlY29yZCBleHBhbmQgVUkgZWxlbWVu dCBzaG91bGQgYmUgZXh0cmFjdGVkIGZyb20gVGltZWxpbmVSZWNvcmRHcmFwaFJvdyBhcyBzZXBh cmF0ZSBjbGFzcyBmb3IgZnV0dXJlIHJldXNlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg3MjYKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvVGltZWxpbmVQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVs KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZS5fcmVmcmVz aFJlY29yZHMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkR3JhcGhSb3cp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkR3JhcGhSb3cucHJvdG90eXBl LnVwZGF0ZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVFeHBhbmRhYmxlRWxlbWVu dCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVFeHBhbmRhYmxlRWxlbWVudC5wcm90 b3R5cGUuX3VwZGF0ZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVFeHBhbmRhYmxl RWxlbWVudC5wcm90b3R5cGUuX2Rpc3Bvc2UpOgorCiAyMDEwLTA0LTI3ICBUb255IENoYW5nICA8 dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcyBi L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzCmluZGV4IDRmZjlk NWEuLjE2MDEzZjggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1l bGluZVBhbmVsLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBh bmVsLmpzCkBAIC05OSw2ICs5OSw4IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsID0gZnVu Y3Rpb24oKQogICAgIHRoaXMuX2V4cGFuZE9mZnNldCA9IDE1OwogfQogCisvLyBEZWZpbmUgcm93 IGhlaWdodCwgc2hvdWxkIGJlIGluIHN5bmMgd2l0aCBzdHlsZXMgZm9yIHRpbWVsaW5lIGdyYXBo cy4KK1dlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnJvd0hlaWdodCA9IDE4OwogV2ViSW5zcGVj dG9yLlRpbWVsaW5lUGFuZWwuc2hvcnRSZWNvcmRUaHJlc2hvbGQgPSAwLjAxNTsKIAogV2ViSW5z cGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0gewpAQCAtNDkxLDggKzQ5Myw3IEBAIFdl Ykluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIHZpc2li bGVUb3AgPSB0aGlzLl9zY3JvbGxUb3A7CiAgICAgICAgIHZhciB2aXNpYmxlQm90dG9tID0gdmlz aWJsZVRvcCArIHRoaXMuX2NvbnRhaW5lckVsZW1lbnQuY2xpZW50SGVpZ2h0OwogCi0gICAgICAg IC8vIERlZmluZSByb3cgaGVpZ2h0LCBzaG91bGQgYmUgaW4gc3luYyB3aXRoIHN0eWxlcyBmb3Ig dGltZWxpbmUgZ3JhcGhzLgotICAgICAgICBjb25zdCByb3dIZWlnaHQgPSAxODsKKyAgICAgICAg Y29uc3Qgcm93SGVpZ2h0ID0gV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucm93SGVpZ2h0Owog CiAgICAgICAgIC8vIENvbnZlcnQgdmlzaWJsZSBhcmVhIHRvIHZpc2libGUgaW5kZXhlcy4gQWx3 YXlzIGluY2x1ZGUgdG9wLWxldmVsIHJlY29yZCBmb3IgYSB2aXNpYmxlIG5lc3RlZCByZWNvcmQu CiAgICAgICAgIHZhciBzdGFydEluZGV4ID0gTWF0aC5tYXgoMCwgTWF0aC5taW4oTWF0aC5mbG9v cih2aXNpYmxlVG9wIC8gcm93SGVpZ2h0KSAtIDEsIHJlY29yZHNJbldpbmRvdy5sZW5ndGggLSAx KSk7CkBAIC03MDgsNyArNzA5LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkTGlzdFJv dy5wcm90b3R5cGUgPSB7CiAgICAgfQogfQogCi1XZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRH cmFwaFJvdyA9IGZ1bmN0aW9uKGdyYXBoQ29udGFpbmVyLCBzY2hlZHVsZVJlZnJlc2gsIHJvd0hl aWdodCkKK1dlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZEdyYXBoUm93ID0gZnVuY3Rpb24oZ3Jh cGhDb250YWluZXIsIHNjaGVkdWxlUmVmcmVzaCkKIHsKICAgICB0aGlzLmVsZW1lbnQgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICB0aGlzLmVsZW1lbnQucm93ID0gdGhpczsK QEAgLTczMiwxNiArNzMzLDggQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkR3JhcGhSb3cg PSBmdW5jdGlvbihncmFwaENvbnRhaW5lciwgc2NoZWR1bGVSZWZyZXNoLAogICAgIHRoaXMuX2Jh ckVsZW1lbnQucm93ID0gdGhpczsKICAgICB0aGlzLl9iYXJBcmVhRWxlbWVudC5hcHBlbmRDaGls ZCh0aGlzLl9iYXJFbGVtZW50KTsKIAotICAgIHRoaXMuX2V4cGFuZEVsZW1lbnQgPSBkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKLSAgICB0aGlzLl9leHBhbmRFbGVtZW50LmNsYXNzTmFt ZSA9ICJ0aW1lbGluZS1leHBhbmRhYmxlIjsKLSAgICBncmFwaENvbnRhaW5lci5hcHBlbmRDaGls ZCh0aGlzLl9leHBhbmRFbGVtZW50KTsKLQotICAgIHZhciBsZWZ0Qm9yZGVyID0gZG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgiZGl2Iik7Ci0gICAgbGVmdEJvcmRlci5jbGFzc05hbWUgPSAidGltZWxp bmUtZXhwYW5kYWJsZS1sZWZ0IjsKLSAgICB0aGlzLl9leHBhbmRFbGVtZW50LmFwcGVuZENoaWxk KGxlZnRCb3JkZXIpOwotCi0gICAgdGhpcy5fZXhwYW5kRWxlbWVudC5hZGRFdmVudExpc3RlbmVy KCJjbGljayIsIHRoaXMuX29uQ2xpY2suYmluZCh0aGlzKSk7Ci0gICAgdGhpcy5fcm93SGVpZ2h0 ID0gcm93SGVpZ2h0OworICAgIHRoaXMuX2V4cGFuZEVsZW1lbnQgPSBuZXcgV2ViSW5zcGVjdG9y LlRpbWVsaW5lRXhwYW5kYWJsZUVsZW1lbnQoZ3JhcGhDb250YWluZXIpOworICAgIHRoaXMuX2V4 cGFuZEVsZW1lbnQuX2VsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl9vbkNs aWNrLmJpbmQodGhpcykpOwogCiAgICAgdGhpcy5fc2NoZWR1bGVSZWZyZXNoID0gc2NoZWR1bGVS ZWZyZXNoOwogfQpAQCAtNzU4LDI0ICs3NTEsNyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNv cmRHcmFwaFJvdy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2JhckVsZW1lbnQuc3R5bGUu d2lkdGggPSAgYmFyUG9zaXRpb24ud2lkdGggKyAicHgiOwogICAgICAgICB0aGlzLl9iYXJDcHVF bGVtZW50LnN0eWxlLmxlZnQgPSBiYXJQb3NpdGlvbi5sZWZ0ICsgZXhwYW5kT2Zmc2V0ICsgInB4 IjsKICAgICAgICAgdGhpcy5fYmFyQ3B1RWxlbWVudC5zdHlsZS53aWR0aCA9IGJhclBvc2l0aW9u LmNwdVdpZHRoICsgInB4IjsKLQotICAgICAgICBpZiAocmVjb3JkLl92aXNpYmxlQ2hpbGRyZW5D b3VudCB8fCByZWNvcmQuX2ludmlzaWJsZUNoaWxkcmVuQ291bnQpIHsKLSAgICAgICAgICAgIHRo aXMuX2V4cGFuZEVsZW1lbnQuc3R5bGUudG9wID0gaW5kZXggKiB0aGlzLl9yb3dIZWlnaHQgKyAi cHgiOwotICAgICAgICAgICAgdGhpcy5fZXhwYW5kRWxlbWVudC5zdHlsZS5sZWZ0ID0gYmFyUG9z aXRpb24ubGVmdCArICJweCI7Ci0gICAgICAgICAgICB0aGlzLl9leHBhbmRFbGVtZW50LnN0eWxl LndpZHRoID0gTWF0aC5tYXgoMTIsIGJhclBvc2l0aW9uLndpZHRoICsgMjUpICsgInB4IjsKLSAg ICAgICAgICAgIGlmICghcmVjb3JkLmNvbGxhcHNlZCkgewotICAgICAgICAgICAgICAgIHRoaXMu X2V4cGFuZEVsZW1lbnQuc3R5bGUuaGVpZ2h0ID0gKHJlY29yZC5fdmlzaWJsZUNoaWxkcmVuQ291 bnQgKyAxKSAqIHRoaXMuX3Jvd0hlaWdodCArICJweCI7Ci0gICAgICAgICAgICAgICAgdGhpcy5f ZXhwYW5kRWxlbWVudC5hZGRTdHlsZUNsYXNzKCJ0aW1lbGluZS1leHBhbmRhYmxlLWV4cGFuZGVk Iik7Ci0gICAgICAgICAgICAgICAgdGhpcy5fZXhwYW5kRWxlbWVudC5yZW1vdmVTdHlsZUNsYXNz KCJ0aW1lbGluZS1leHBhbmRhYmxlLWNvbGxhcHNlZCIpOwotICAgICAgICAgICAgfSBlbHNlIHsK LSAgICAgICAgICAgICAgICB0aGlzLl9leHBhbmRFbGVtZW50LnN0eWxlLmhlaWdodCA9IHRoaXMu X3Jvd0hlaWdodCArICJweCI7Ci0gICAgICAgICAgICAgICAgdGhpcy5fZXhwYW5kRWxlbWVudC5h ZGRTdHlsZUNsYXNzKCJ0aW1lbGluZS1leHBhbmRhYmxlLWNvbGxhcHNlZCIpOwotICAgICAgICAg ICAgICAgIHRoaXMuX2V4cGFuZEVsZW1lbnQucmVtb3ZlU3R5bGVDbGFzcygidGltZWxpbmUtZXhw YW5kYWJsZS1leHBhbmRlZCIpOwotICAgICAgICAgICAgfQotICAgICAgICAgICAgdGhpcy5fZXhw YW5kRWxlbWVudC5yZW1vdmVTdHlsZUNsYXNzKCJoaWRkZW4iKTsKLSAgICAgICAgfSBlbHNlIHsK LSAgICAgICAgICAgIHRoaXMuX2V4cGFuZEVsZW1lbnQuYWRkU3R5bGVDbGFzcygiaGlkZGVuIik7 Ci0gICAgICAgIH0KKyAgICAgICAgdGhpcy5fZXhwYW5kRWxlbWVudC5fdXBkYXRlKHJlY29yZCwg aW5kZXgsIGJhclBvc2l0aW9uKTsKICAgICB9LAogCiAgICAgX29uQ2xpY2s6IGZ1bmN0aW9uKGV2 ZW50KQpAQCAtNzg3LDcgKzc2Myw3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZEdyYXBo Um93LnByb3RvdHlwZSA9IHsKICAgICBkaXNwb3NlOiBmdW5jdGlvbigpCiAgICAgewogICAgICAg ICB0aGlzLmVsZW1lbnQucGFyZW50RWxlbWVudC5yZW1vdmVDaGlsZCh0aGlzLmVsZW1lbnQpOwot ICAgICAgICB0aGlzLl9leHBhbmRFbGVtZW50LnBhcmVudEVsZW1lbnQucmVtb3ZlQ2hpbGQodGhp cy5fZXhwYW5kRWxlbWVudCk7CisgICAgICAgIHRoaXMuX2V4cGFuZEVsZW1lbnQuX2Rpc3Bvc2Uo KTsKICAgICB9CiB9CiAKQEAgLTEwNDgsMyArMTAyNCw0MyBAQCBXZWJJbnNwZWN0b3IuVGltZWxp bmVQYW5lbC5Qb3B1cENvbnRlbnRIZWxwZXIucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9h cHBlbmRFbGVtZW50Um93KHRpdGxlLCBsaW5rKTsKICAgICB9CiB9CisKK1dlYkluc3BlY3Rvci5U aW1lbGluZUV4cGFuZGFibGVFbGVtZW50ID0gZnVuY3Rpb24oY29udGFpbmVyKQoreworICAgIHRo aXMuX2VsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKKyAgICB0aGlzLl9l bGVtZW50LmNsYXNzTmFtZSA9ICJ0aW1lbGluZS1leHBhbmRhYmxlIjsKKworICAgIHZhciBsZWZ0 Qm9yZGVyID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgbGVmdEJvcmRlci5j bGFzc05hbWUgPSAidGltZWxpbmUtZXhwYW5kYWJsZS1sZWZ0IjsKKyAgICB0aGlzLl9lbGVtZW50 LmFwcGVuZENoaWxkKGxlZnRCb3JkZXIpOworCisgICAgY29udGFpbmVyLmFwcGVuZENoaWxkKHRo aXMuX2VsZW1lbnQpOworfQorCitXZWJJbnNwZWN0b3IuVGltZWxpbmVFeHBhbmRhYmxlRWxlbWVu dC5wcm90b3R5cGUgPSB7CisgICAgX3VwZGF0ZTogZnVuY3Rpb24ocmVjb3JkLCBpbmRleCwgYmFy UG9zaXRpb24pCisgICAgeworICAgICAgICBjb25zdCByb3dIZWlnaHQgPSBXZWJJbnNwZWN0b3Iu VGltZWxpbmVQYW5lbC5yb3dIZWlnaHQ7CisgICAgICAgIGlmIChyZWNvcmQuX3Zpc2libGVDaGls ZHJlbkNvdW50IHx8IHJlY29yZC5faW52aXNpYmxlQ2hpbGRyZW5Db3VudCkgeworICAgICAgICAg ICAgdGhpcy5fZWxlbWVudC5zdHlsZS50b3AgPSBpbmRleCAqIHJvd0hlaWdodCArICJweCI7Cisg ICAgICAgICAgICB0aGlzLl9lbGVtZW50LnN0eWxlLmxlZnQgPSBiYXJQb3NpdGlvbi5sZWZ0ICsg InB4IjsKKyAgICAgICAgICAgIHRoaXMuX2VsZW1lbnQuc3R5bGUud2lkdGggPSBNYXRoLm1heCgx MiwgYmFyUG9zaXRpb24ud2lkdGggKyAyNSkgKyAicHgiOworICAgICAgICAgICAgaWYgKCFyZWNv cmQuY29sbGFwc2VkKSB7CisgICAgICAgICAgICAgICAgdGhpcy5fZWxlbWVudC5zdHlsZS5oZWln aHQgPSAocmVjb3JkLl92aXNpYmxlQ2hpbGRyZW5Db3VudCArIDEpICogcm93SGVpZ2h0ICsgInB4 IjsKKyAgICAgICAgICAgICAgICB0aGlzLl9lbGVtZW50LmFkZFN0eWxlQ2xhc3MoInRpbWVsaW5l LWV4cGFuZGFibGUtZXhwYW5kZWQiKTsKKyAgICAgICAgICAgICAgICB0aGlzLl9lbGVtZW50LnJl bW92ZVN0eWxlQ2xhc3MoInRpbWVsaW5lLWV4cGFuZGFibGUtY29sbGFwc2VkIik7CisgICAgICAg ICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgIHRoaXMuX2VsZW1lbnQuc3R5bGUuaGVpZ2h0 ID0gcm93SGVpZ2h0ICsgInB4IjsKKyAgICAgICAgICAgICAgICB0aGlzLl9lbGVtZW50LmFkZFN0 eWxlQ2xhc3MoInRpbWVsaW5lLWV4cGFuZGFibGUtY29sbGFwc2VkIik7CisgICAgICAgICAgICAg ICAgdGhpcy5fZWxlbWVudC5yZW1vdmVTdHlsZUNsYXNzKCJ0aW1lbGluZS1leHBhbmRhYmxlLWV4 cGFuZGVkIik7CisgICAgICAgICAgICB9CisgICAgICAgICAgICB0aGlzLl9lbGVtZW50LnJlbW92 ZVN0eWxlQ2xhc3MoImhpZGRlbiIpOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIHRoaXMu X2VsZW1lbnQuYWRkU3R5bGVDbGFzcygiaGlkZGVuIik7CisgICAgfSwKKworICAgIF9kaXNwb3Nl OiBmdW5jdGlvbigpCisgICAgeworICAgICAgICB0aGlzLl9lbGVtZW50LnBhcmVudEVsZW1lbnQu cmVtb3ZlQ2hpbGQodGhpcy5fZWxlbWVudCk7CisgICAgfQorfQo=