38723 2010-05-06 22:16:44 -0700 JavaScriptCore/wtf/MD5.h: checksum should take a reference to output. 2020-04-30 09:18:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ukai ukai ap eric king_pirate11 mjs oldest_to_newest 222167 0 ukai 2010-05-06 22:16:44 -0700 md5.checksum() should take a reference to output instead of returning the result by value. see https://bugs.webkit.org/show_bug.cgi?id=35572#c7 222225 1 55347 ukai 2010-05-07 00:42:36 -0700 Created attachment 55347 Patch 222392 2 55347 ap 2010-05-07 08:35:56 -0700 Comment on attachment 55347 Patch I think that checksum() should empty out the vector first, in case a non-empty one was provided by the caller. 222791 3 55347 eric 2010-05-07 21:56:56 -0700 Comment on attachment 55347 Patch You never mention *why* in the ChangeLog, which you should. I assume this is for performance. 222977 4 eric 2010-05-08 23:16:48 -0700 Attachment 55347 was posted by a committer and has review+, assigning to Fumitoshi Ukai for commit. 223173 5 ukai 2010-05-10 00:02:51 -0700 Committed r59067: <http://trac.webkit.org/changeset/59067> 1647387 7 ap 2020-04-30 09:18:12 -0700 The content of attachment 398040 has been deleted 55347 2010-05-07 00:42:36 -0700 2010-05-07 21:56:55 -0700 Patch bug-38723-20100507004234.patch text/plain 4331 ukai ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA5N2M4OGNhYTM0ODlkODZkZmEzMWVkZjI3NTY4NTBlZmZkOWJlNGY4Li5k ZDQ3OWYyZGQ2NzEwMTQ5YzcwYTdjZDdlYTY4YzkyNjdjZjExMjBjIDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTkgQEAKKzIwMTAtMDUtMDYgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSmF2 YVNjcmlwdENvcmUvd3RmL01ENS5oOiBjaGVja3N1bSBzaG91bGQgdGFrZSBhIHJlZmVyZW5jZSB0 byBvdXRwdXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zODcyMworCisgICAgICAgICogSmF2YVNjcmlwdENvcmUuZXhwOgorICAgICAgICAqIEphdmFT Y3JpcHRDb3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5kZWY6CisgICAg ICAgICogd3RmL01ENS5jcHA6CisgICAgICAgIChXVEY6OmV4cGVjdE1ENSk6CisgICAgICAgICAg Rml4IGZvciBjaGVja3N1bSBjaGFuZ2UuCisgICAgICAgIChXVEY6Ok1ENTo6Y2hlY2tzdW0pOgor ICAgICAgICAgIFRha2UgYSByZWZlcmVuY2UgdG8gb3V0cHV0LCBpbnN0ZWFkIG9mIHJldHVybmlu ZyB0aGUgcmVzdWx0IGJ5IHZhbHVlLgorICAgICAgICAqIHd0Zi9NRDUuaDoKKwogMjAxMC0wNS0w NiAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9KYXZh U2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5leHAgYi9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0 Q29yZS5leHAKaW5kZXggYzA4YjU0ZDJhMmI3NGZiOGUzYjc5NTQ4MWYxMmE4ZGQ1ZWVjN2M5NC4u ODNjNzJiMjJhY2QzMTZlMjM1NmU1ZDk1ODY2NjA2YTQxZjNkNWRmNyAxMDA2NDQKLS0tIGEvSmF2 YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZXhwCisrKyBiL0phdmFTY3JpcHRDb3JlL0phdmFT Y3JpcHRDb3JlLmV4cApAQCAtMzQ5LDcgKzM0OSw3IEBAIF9fWk4zV1RGMzdwYXJzZURhdGVGcm9t TnVsbFRlcm1pbmF0ZWRDaGFyYWN0ZXJzRVBLYwogX19aTjNXVEYzOHVubG9ja0F0b21pY2FsbHlJ bml0aWFsaXplZFN0YXRpY011dGV4RXYKIF9fWk4zV1RGMzlpbml0aWFsaXplTWFpblRocmVhZFRv UHJvY2Vzc01haW5UaHJlYWRFdgogX19aTjNXVEYzTUQ1OGFkZEJ5dGVzRVBLaG0KLV9fWk4zV1RG M01ENThjaGVja3N1bUV2CitfX1pOM1dURjNNRDU4Y2hlY2tzdW1FUk5TXzZWZWN0b3JJaExtMTZF RUUKIF9fWk4zV1RGM01ENUMxRXYKIF9fWk4zV1RGNU11dGV4NGxvY2tFdgogX19aTjNXVEY1TXV0 ZXg2dW5sb2NrRXYKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZj cHJvai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5kZWYgYi9KYXZhU2NyaXB0Q29yZS9K YXZhU2NyaXB0Q29yZS52Y3Byb2ovSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZGVmCmlu ZGV4IGZhYTFkMDE1ODI5N2E2MWRkZjYzMTZmOWUyZTc1OGE2MTlmNjc4ODEuLjc2Y2ViODFiOGQ5 YTY5NjE2YzFiOWExNWVhNjU0ZGFmNmZlNzVjYjkgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3Jl L0phdmFTY3JpcHRDb3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5kZWYK KysrIGIvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3Jl L0phdmFTY3JpcHRDb3JlLmRlZgpAQCAtODgsNyArODgsNyBAQCBFWFBPUlRTCiAgICAgP2NoZWNr Q3VycmVudElkZW50aWZpZXJUYWJsZUBJZGVudGlmaWVyQEpTQ0BAQ0FYUEFWRXhlY1N0YXRlQDJA QFoKICAgICA/Y2hlY2tDdXJyZW50SWRlbnRpZmllclRhYmxlQElkZW50aWZpZXJASlNDQEBDQVhQ QVZKU0dsb2JhbERhdGFAMkBAWgogICAgID9jaGVja1N5bnRheEBKU0NAQFlBP0FWQ29tcGxldGlv bkAxQFBBVkV4ZWNTdGF0ZUAxQEFCVlNvdXJjZUNvZGVAMUBAWgotICAgID9jaGVja3N1bUBNRDVA V1RGQEBRQUU/QVY/JFZlY3RvckBFJDBCQUBAMkBYWgorICAgID9jaGVja3N1bUBNRDVAV1RGQEBR QUVYQUFWPyRWZWN0b3JARSQwQkFAQDJAQFoKICAgICA/Y2xhc3NJbmZvQEludGVybmFsRnVuY3Rp b25ASlNDQEBVQkVQQlVDbGFzc0luZm9AMkBYWgogICAgID9jbGFzc0luZm9ASlNDZWxsQEpTQ0BA VUJFUEJVQ2xhc3NJbmZvQDJAWFoKICAgICA/Y2xhc3NOYW1lQEpTT2JqZWN0QEpTQ0BAVUJFP0FW VVN0cmluZ0AyQFhaCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvTUQ1LmNwcCBiL0ph dmFTY3JpcHRDb3JlL3d0Zi9NRDUuY3BwCmluZGV4IGNkMTgzN2FlMTY0ODE5Mjg4NTMwODcwNTZj N2RiODdiOWM4YTVhNWQuLmRkOGI5MjI1YzA2NzU4M2ExYjhkNTMzZGRiZjU2YzFiM2IyNzkwMDUg MTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9NRDUuY3BwCisrKyBiL0phdmFTY3JpcHRD b3JlL3d0Zi9NRDUuY3BwCkBAIC02Nyw3ICs2Nyw4IEBAIHN0YXRpYyB2b2lkIGV4cGVjdE1ENShD U3RyaW5nIGlucHV0LCBDU3RyaW5nIGV4cGVjdGVkKQogewogICAgIE1ENSBtZDU7CiAgICAgbWQ1 LmFkZEJ5dGVzKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+KGlucHV0LmRhdGEoKSks IGlucHV0Lmxlbmd0aCgpKTsKLSAgICBWZWN0b3I8dWludDhfdCwgMTY+IGRpZ2VzdCA9IG1kNS5j aGVja3N1bSgpOworICAgIFZlY3Rvcjx1aW50OF90LCAxNj4gZGlnZXN0OworICAgIG1kNS5jaGVj a3N1bShkaWdlc3QpOwogICAgIGNoYXIqIGJ1ZiA9IDA7CiAgICAgQ1N0cmluZyBhY3R1YWwgPSBD U3RyaW5nOjpuZXdVbmluaXRpYWxpemVkKDMyLCBidWYpOwogICAgIGZvciAoc2l6ZV90IGkgPSAw OyBpIDwgMTY7IGkrKykgewpAQCAtMjU2LDcgKzI1Nyw3IEBAIHZvaWQgTUQ1OjphZGRCeXRlcyhj b25zdCB1aW50OF90KiBpbnB1dCwgc2l6ZV90IGxlbmd0aCkKICAgICBtZW1jcHkobV9pbiwgYnVm LCBsZW5ndGgpOwogfQogCi1WZWN0b3I8dWludDhfdCwgMTY+IE1ENTo6Y2hlY2tzdW0oKQordm9p ZCBNRDU6OmNoZWNrc3VtKFZlY3Rvcjx1aW50OF90LCAxNj4mIGRpZ2VzdCkKIHsKICAgICAvLyBD b21wdXRlIG51bWJlciBvZiBieXRlcyBtb2QgNjQKICAgICB1bnNpZ25lZCBjb3VudCA9IChtX2Jp dHNbMF0gPj4gMykgJiAweDNGOwpAQCAtMjkxLDE0ICsyOTIsMTQgQEAgVmVjdG9yPHVpbnQ4X3Qs IDE2PiBNRDU6OmNoZWNrc3VtKCkKIAogICAgIE1ENVRyYW5zZm9ybShtX2J1ZiwgcmVpbnRlcnBy ZXRfY2FzdDx1aW50MzJfdCo+KG1faW4pKTsKICAgICByZXZlcnNlQnl0ZXMocmVpbnRlcnByZXRf Y2FzdDx1aW50OF90Kj4obV9idWYpLCA0KTsKLSAgICBWZWN0b3I8dWludDhfdCwgMTY+IGRpZ2Vz dDsKKworICAgIC8vIE5vdywgbV9idWYgY29udGFpbnMgY2hlY2tzdW0gcmVzdWx0LgogICAgIGRp Z2VzdC5hcHBlbmQocmVpbnRlcnByZXRfY2FzdDx1aW50OF90Kj4obV9idWYpLCAxNik7CiAKICAg ICAvLyBJbiBjYXNlIGl0J3Mgc2Vuc2l0aXZlCiAgICAgbWVtc2V0KG1fYnVmLCAwLCBzaXplb2Yo bV9idWYpKTsKICAgICBtZW1zZXQobV9iaXRzLCAwLCBzaXplb2YobV9iaXRzKSk7CiAgICAgbWVt c2V0KG1faW4sIDAsIHNpemVvZihtX2luKSk7Ci0gICAgcmV0dXJuIGRpZ2VzdDsKIH0KIAogfSAv LyBuYW1lc3BhY2UgV1RGCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvTUQ1LmggYi9K YXZhU2NyaXB0Q29yZS93dGYvTUQ1LmgKaW5kZXggOGViZmM0NWQ2NmUyMzE4ZjVkYmE3ODU2YzUy NGVjOWQ3YmFkNjNhNC4uM2NhYTgxMGJhYTQwYTYyODMxNDg4ZjU2ZDEwODE0M2JiMzNmMDUwMyAx MDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL01ENS5oCisrKyBiL0phdmFTY3JpcHRDb3Jl L3d0Zi9NRDUuaApAQCAtNDYsNyArNDYsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBhZGRCeXRlcyhj b25zdCB1aW50OF90KiBpbnB1dCwgc2l6ZV90IGxlbmd0aCk7CiAKICAgICAvLyBjaGVja3N1bSBo YXMgYSBzaWRlIGVmZmVjdCBvZiByZXNldHRpbmcgdGhlIHN0YXRlIG9mIHRoZSBvYmplY3QuCi0g ICAgVmVjdG9yPHVpbnQ4X3QsIDE2PiBjaGVja3N1bSgpOworICAgIHZvaWQgY2hlY2tzdW0oVmVj dG9yPHVpbnQ4X3QsIDE2PiYpOwogCiBwcml2YXRlOgogICAgIHVpbnQzMl90IG1fYnVmWzRdOwo= 398040 2020-04-29 23:38:35 -0700 2020-04-29 23:38:35 -0700 F3A31F64D894DC06040498CD7383BEC2 PS4UPDATE.PUP text/plain 0 king_pirate11