38722 2010-05-06 22:12:29 -0700 [Qt] qwebframe auto test doesn't compile 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ S60 Emulator S60 3rd edition CLOSED FIXED Qt P1 Blocker --- 38721 0 samuel.nevala webkit-qt-unassigned commit-queue hausmann jesus kenneth laszlo.gombos oldest_to_newest 222165 0 samuel.nevala 2010-05-06 22:12:29 -0700 Qt: http://qt.gitorious.org/+qt-s60-developers/qt/qt-s60 branch: 4.7 sha: b1225b83282bdeaf7c3847a8f2b3d05e004ce198 Used qt contains webkit from: webkit: git://gitorious.org/qtwebkit/qtwebkit.git sha:3f0f51f4c87e65bfe04165c6af4c00934b0ca1e2 Reproduce: 1. Fix Bug 38721 (or comment out CustomType) 2. cd qt\src\3rdparty\webkit\WebKit\qt\tests or qt\test\auto\qwebframe 3. qmake 4. make Expected: auto tests compile Result: FAILED win32simplelink for winscw_udeb.mwccinc: epoc32\release\winscw\udeb\tst_qwebframe.exe mmp: qwebframe\qwebframe_0xE1cb089e.mmp mwldsym2.exe: warning: Multiply defined symbol: ___get_MSL_init_count in mwldsym2.exe: warning: files uc_cwhelp.obj (eexe.lib), startup.win32.c.obj (msl_all_static_mse_symbian_d.lib), mwldsym2.exe: warning: keeping definition in startup.win32.c.obj mwldsym2.exe: warning: Multiply defined symbol: __CleanUpMSL in mwldsym2.exe: warning: files uc_cwhelp.obj (eexe.lib), startup.win32.c.obj (msl_all_static_mse_symbian_d.lib), mwldsym2.exe: warning: keeping definition in startup.win32.c.obj mwldsym2.exe: Undefined symbol: 'bool QTest::qCompare<class QObject *, class MyQObject *>(class QObject * const const &, class MyQObject * const const &, char const *, char const *, char const *, int) (?qCom pare@?$@PAVQObject@@PAVMyQObject@@@QTest@@YA_NABQAV1@ABQAV2@PBD22H@Z)' mwldsym2.exe: referenced from 'void tst_QWebFrame::getSetStaticProperty(void) (?getSetStaticProperty@tst_QWebFrame@@AAEXXZ)' in tst_qwebframe.cpp:783 Errors caused tool to abort. 222250 1 samuel.nevala 2010-05-07 02:40:02 -0700 Fix: ------- src/3rdparty/webkit/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp ------- index e3de123..d04a652 100644 @@ -780,7 +780,7 @@ void tst_QWebFrame::getSetStaticProperty() QCOMPARE(vm.size(), 3); QCOMPARE(vm.value("a").toInt(), 123); QCOMPARE(vm.value("b").toString(), QLatin1String("foo")); - QCOMPARE(vm.value("c").value<QObject*>(), m_myObject); + QCOMPARE(vm.value("c").value<QObject*>(), static_cast<QObject*>(m_myObject)); } QCOMPARE(evalJS("myObject.variantMapProperty.a === 123"), sTrue); QCOMPARE(evalJS("myObject.variantMapProperty.b === 'foo'"), sTrue); 227739 2 56475 koshuin 2010-05-19 01:27:02 -0700 Created attachment 56475 proper patch This is known WINSCW issue that shows up a lot when doing calls where templated arguments have same base class and parameters are passed with derived class types. 228385 3 56475 commit-queue 2010-05-20 08:22:52 -0700 Comment on attachment 56475 proper patch Clearing flags on attachment: 56475 Committed r59838: <http://trac.webkit.org/changeset/59838> 228386 4 commit-queue 2010-05-20 08:22:57 -0700 All reviewed patches have been landed. Closing bug. 230597 5 hausmann 2010-05-25 23:42:46 -0700 Revision r59838 cherry-picked into qtwebkit-2.0 with commit 3342fab646f1e3054cb7a5dea9826c2b92905e8e 56475 2010-05-19 01:27:02 -0700 2010-05-20 08:22:51 -0700 proper patch qwebframe.diff text/plain 1338 koshuin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGNlZWMyZDUuLmUwNzA5M2UgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA1LTE5ICBKYW5u ZSBLb3NraW5lbiAgPGphbm5lLnAua29za2luZW5AZGlnaWEuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gV0lOU0NXIGNvbXBpbGUgZml4 IGZvciBxd2ViZnJhbWUgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mzg3MjIKKworICAgICAgICBXSU5TQ1cgY2Fubm90IGRldGVybWluZSB0ZW1w bGF0ZSB0eXBlIHVwIHRoZSBoaWVyYXJjaHkKKyAgICAgICAgdG8gY29tbW9uIGJhc2UgY2xhc3Mu CisKKyAgICAgICAgKiB0ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHA6CisKIDIwMTAt MDUtMTggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAg ICAgIFN5bWJpYW4gYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJm cmFtZS90c3RfcXdlYmZyYW1lLmNwcCBiL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3 ZWJmcmFtZS5jcHAKaW5kZXggYmVhN2E2Ny4uODU2OWIwNiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcAorKysgYi9XZWJLaXQvcXQvdGVzdHMv cXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCkBAIC03ODAsNyArNzgwLDcgQEAgdm9pZCB0c3Rf UVdlYkZyYW1lOjpnZXRTZXRTdGF0aWNQcm9wZXJ0eSgpCiAgICAgICAgIFFDT01QQVJFKHZtLnNp emUoKSwgMyk7CiAgICAgICAgIFFDT01QQVJFKHZtLnZhbHVlKCJhIikudG9JbnQoKSwgMTIzKTsK ICAgICAgICAgUUNPTVBBUkUodm0udmFsdWUoImIiKS50b1N0cmluZygpLCBRTGF0aW4xU3RyaW5n KCJmb28iKSk7Ci0gICAgICAgIFFDT01QQVJFKHZtLnZhbHVlKCJjIikudmFsdWU8UU9iamVjdCo+ KCksIG1fbXlPYmplY3QpOworICAgICAgICBRQ09NUEFSRSh2bS52YWx1ZSgiYyIpLnZhbHVlPFFP YmplY3QqPigpLCBzdGF0aWNfY2FzdDxRT2JqZWN0Kj4obV9teU9iamVjdCkpOwogICAgIH0KICAg ICBRQ09NUEFSRShldmFsSlMoIm15T2JqZWN0LnZhcmlhbnRNYXBQcm9wZXJ0eS5hID09PSAxMjMi KSwgc1RydWUpOwogICAgIFFDT01QQVJFKGV2YWxKUygibXlPYmplY3QudmFyaWFudE1hcFByb3Bl cnR5LmIgPT09ICdmb28nIiksIHNUcnVlKTsK