38710 2010-05-06 17:50:43 -0700 Fix guard around IndexedDatabase 2010-05-08 12:06:01 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue oldest_to_newest 222083 0 laszlo.gombos 2010-05-06 17:50:43 -0700 In PageGroup.h this guard seems incorrect to me: #if ENABLE(DOM_STORAGE) IndexedDatabase* indexedDatabase(); #endif 222086 1 55326 laszlo.gombos 2010-05-06 17:53:33 -0700 Created attachment 55326 proposed patch 222298 2 55326 kenneth 2010-05-07 05:52:28 -0700 Comment on attachment 55326 proposed patch > Index: ChangeLog > =================================================================== > --- ChangeLog (revision 58924) > +++ ChangeLog (working copy) > @@ -1,3 +1,12 @@ > +2010-05-06 Laszlo Gombos <laszlo.1.gombos@nokia.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [Qt] Build the ImageDiff tool for all platforms including Windows and Symbian > + https://bugs.webkit.org/show_bug.cgi?id=38706 > + > + * WebKit.pro: This ChangeLog seems to be for another patch! > 222622 3 55419 laszlo.gombos 2010-05-07 14:38:48 -0700 Created attachment 55419 remove extra ChangeLog 222919 4 55419 commit-queue 2010-05-08 12:05:56 -0700 Comment on attachment 55419 remove extra ChangeLog Clearing flags on attachment: 55419 Committed r59034: <http://trac.webkit.org/changeset/59034> 222920 5 commit-queue 2010-05-08 12:06:01 -0700 All reviewed patches have been landed. Closing bug. 55326 2010-05-06 17:53:33 -0700 2010-05-07 14:38:48 -0700 proposed patch 38710.patch text/plain 1515 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU4OTI0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDUt MDYgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQnVpbGQgdGhlIElt YWdlRGlmZiB0b29sIGZvciBhbGwgcGxhdGZvcm1zIGluY2x1ZGluZyBXaW5kb3dzIGFuZCBTeW1i aWFuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODcw NgorCisgICAgICAgICogV2ViS2l0LnBybzoKKwogMjAxMC0wNS0wNSAgQWxlamFuZHJvIEcuIENh c3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXou CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxv ZwkocmV2aXNpb24gNTg5MjUpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDEwLTA1LTA2ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29t Ym9zQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXggZ3VhcmQgYXJvdW5kIEluZGV4ZWREYXRhYmFzZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg3MTAKKworICAgICAgICBObyBuZXcg dGVzdHMsIHRoZXJlIGlzIG5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGFnZS9Q YWdlR3JvdXAuaDoKKwogMjAxMC0wNS0wNiAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUu Y29tPgogCiAgICAgICAgIE5vdCByZXZpZXdlZCwgYnVpbGQgZml4LgpJbmRleDogV2ViQ29yZS9w YWdlL1BhZ2VHcm91cC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9QYWdlR3JvdXAuaAko cmV2aXNpb24gNTg5MTMpCisrKyBXZWJDb3JlL3BhZ2UvUGFnZUdyb3VwLmgJKHdvcmtpbmcgY29w eSkKQEAgLTcwLDcgKzcwLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBTdG9yYWdl TmFtZXNwYWNlKiBsb2NhbFN0b3JhZ2UoKTsKICAgICAgICAgYm9vbCBoYXNMb2NhbFN0b3JhZ2Uo KSB7IHJldHVybiBtX2xvY2FsU3RvcmFnZTsgfQogI2VuZGlmCi0jaWYgRU5BQkxFKERPTV9TVE9S QUdFKQorI2lmIEVOQUJMRShJTkRFWEVEX0RBVEFCQVNFKQogICAgICAgICBJbmRleGVkRGF0YWJh c2UqIGluZGV4ZWREYXRhYmFzZSgpOwogI2VuZGlmCiAK 55419 2010-05-07 14:38:48 -0700 2010-05-08 12:05:56 -0700 remove extra ChangeLog 38710.patch text/plain 998 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODkzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMDcgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCBndWFyZCBhcm91bmQgSW5kZXhlZERhdGFiYXNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODcxMAorCisgICAgICAgIE5vIG5ldyB0 ZXN0cywgdGhlcmUgaXMgbm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBwYWdlL1Bh Z2VHcm91cC5oOgorCiAyMDEwLTA0LTI3ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL3BhZ2Uv UGFnZUdyb3VwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL1BhZ2VHcm91cC5oCShyZXZp c2lvbiA1ODkzNykKKysrIFdlYkNvcmUvcGFnZS9QYWdlR3JvdXAuaAkod29ya2luZyBjb3B5KQpA QCAtNzAsNyArNzAsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIFN0b3JhZ2VOYW1l c3BhY2UqIGxvY2FsU3RvcmFnZSgpOwogICAgICAgICBib29sIGhhc0xvY2FsU3RvcmFnZSgpIHsg cmV0dXJuIG1fbG9jYWxTdG9yYWdlOyB9CiAjZW5kaWYKLSNpZiBFTkFCTEUoRE9NX1NUT1JBR0Up CisjaWYgRU5BQkxFKElOREVYRURfREFUQUJBU0UpCiAgICAgICAgIEluZGV4ZWREYXRhYmFzZSog aW5kZXhlZERhdGFiYXNlKCk7CiAjZW5kaWYKIAo=