38706 2010-05-06 17:21:37 -0700 [Qt] Build the ImageDiff tool for all platforms including Windows and Symbian 2010-05-08 11:29:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 222074 0 laszlo.gombos 2010-05-06 17:21:37 -0700 With a few minor changes ImageDiff would build on every Qt supported platforms. Note sure if it make sense to run this on Symbian, but it does not hurt building it. 222081 1 55324 laszlo.gombos 2010-05-06 17:46:14 -0700 Created attachment 55324 proposed patch 222088 2 webkit.review.bot 2010-05-06 17:54:51 -0700 Attachment 55324 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/DumpRenderTree/qt/ImageDiff.cpp:20: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 222913 3 55324 commit-queue 2010-05-08 11:29:11 -0700 Comment on attachment 55324 proposed patch Clearing flags on attachment: 55324 Committed r59031: <http://trac.webkit.org/changeset/59031> 222914 4 commit-queue 2010-05-08 11:29:17 -0700 All reviewed patches have been landed. Closing bug. 55324 2010-05-06 17:46:14 -0700 2010-05-08 11:29:11 -0700 proposed patch 38706.patch text/plain 3889 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU4OTI0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDUt MDYgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQnVpbGQgdGhlIElt YWdlRGlmZiB0b29sIGZvciBhbGwgcGxhdGZvcm1zIGluY2x1ZGluZyBXaW5kb3dzIGFuZCBTeW1i aWFuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODcw NgorCisgICAgICAgICogV2ViS2l0LnBybzoKKwogMjAxMC0wNS0wNSAgQWxlamFuZHJvIEcuIENh c3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXou CkluZGV4OiBXZWJLaXQucHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC5wcm8JKHJldmlzaW9uIDU4 OTEzKQorKysgV2ViS2l0LnBybwkod29ya2luZyBjb3B5KQpAQCAtMTIsOSArMTIsOSBAQCBleGlz dHMoJCRQV0QvV2ViS2l0VG9vbHMvUXRMYXVuY2hlcik6IFNVCiBleGlzdHMoJCRQV0QvSmF2YVNj cmlwdENvcmUvanNjLnBybyk6IFNVQkRJUlMgKz0gSmF2YVNjcmlwdENvcmUvanNjLnBybwogZXhp c3RzKCQkUFdEL1dlYktpdC9xdC90ZXN0cyk6IFNVQkRJUlMgKz0gV2ViS2l0L3F0L3Rlc3RzCiBl eGlzdHMoJCRQV0QvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUu cHJvKTogU1VCRElSUyArPSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVy VHJlZS5wcm8KK2V4aXN0cygkJFBXRC9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9JbWFn ZURpZmYucHJvKTogU1VCRElSUyArPSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9JbWFn ZURpZmYucHJvCiAKICF3aW4zMjohc3ltYmlhbiB7Ci0gICAgZXhpc3RzKCQkUFdEL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL3F0L0ltYWdlRGlmZi5wcm8pOiBTVUJESVJTICs9IFdlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL3F0L0ltYWdlRGlmZi5wcm8KICAgICBleGlzdHMoJCRQV0QvV2Vi S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2Fw ZVBsdWdpbi5wcm8pOiBTVUJESVJTICs9IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L1Rl c3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4ucHJvCiB9CiAKSW5kZXg6IFdlYktp dFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDU4OTI0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDUtMDYgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gQnVpbGQgdGhlIEltYWdlRGlmZiB0b29sIGZvciBhbGwgcGxhdGZvcm1zIGlu Y2x1ZGluZyBXaW5kb3dzIGFuZCBTeW1iaWFuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zODcwNgorCisgICAgICAgIFVzZSBxbWF0aC5oIGluc3RlYWQg b2YgbWF0aC5oIHRvIG1ha2UgaXQgcG9ydGFibGUuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJl ZS9xdC9JbWFnZURpZmYuY3BwOgorICAgICAgICAobWFpbik6CisKIDIwMTAtMDUtMDYgIENzYWJh IE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIFVucmV2aWV3 ZWQgYnVpbGRmaXggYWZ0ZXIgcjU4OTE3LgpJbmRleDogV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRy ZWUvcXQvSW1hZ2VEaWZmLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVy VHJlZS9xdC9JbWFnZURpZmYuY3BwCShyZXZpc2lvbiA1ODkxMykKKysrIFdlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0ltYWdlRGlmZi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3LDEzICsx NywxNCBAQAogICAgIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSwgVVNBLgogKi8KIAorI2luY2x1ZGUg PFF0Q29yZS9xbWF0aC5oPgorCiAjaW5jbHVkZSA8UUFwcGxpY2F0aW9uPgogI2luY2x1ZGUgPFFC dWZmZXI+CiAjaW5jbHVkZSA8UUJ5dGVBcnJheT4KICNpbmNsdWRlIDxRSW1hZ2U+CiAjaW5jbHVk ZSA8UVN0cmluZ0xpc3Q+CiAKLSNpbmNsdWRlIDxtYXRoLmg+CiAjaW5jbHVkZSA8c3RkaW8uaD4K IAogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKQEAgLTEwMiw3ICsxMDMsNyBAQCBp bnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJndltdKQogICAgICAgICAgICAgICAgICAgICAgICAg cXJlYWwgZ3JlZW4gPSAocUdyZWVuKHBpeGVsKSAtIHFHcmVlbihiYXNlUGl4ZWwpKSAvIHN0YXRp Y19jYXN0PGZsb2F0PihxTWF4KDI1NSAtIHFHcmVlbihiYXNlUGl4ZWwpLCBxR3JlZW4oYmFzZVBp eGVsKSkpOwogICAgICAgICAgICAgICAgICAgICAgICAgcXJlYWwgYmx1ZSA9IChxQmx1ZShwaXhl bCkgLSBxQmx1ZShiYXNlUGl4ZWwpKSAvIHN0YXRpY19jYXN0PGZsb2F0PihxTWF4KDI1NSAtIHFC bHVlKGJhc2VQaXhlbCksIHFCbHVlKGJhc2VQaXhlbCkpKTsKICAgICAgICAgICAgICAgICAgICAg ICAgIHFyZWFsIGFscGhhID0gKHFBbHBoYShwaXhlbCkgLSBxQWxwaGEoYmFzZVBpeGVsKSkgLyBz dGF0aWNfY2FzdDxmbG9hdD4ocU1heCgyNTUgLSBxQWxwaGEoYmFzZVBpeGVsKSwgcUFscGhhKGJh c2VQaXhlbCkpKTsKLSAgICAgICAgICAgICAgICAgICAgICAgIHFyZWFsIGRpc3RhbmNlID0gc3Fy dChyZWQgKiByZWQgKyBncmVlbiAqIGdyZWVuICsgYmx1ZSAqIGJsdWUgKyBhbHBoYSAqIGFscGhh KSAvIDIuMGY7CisgICAgICAgICAgICAgICAgICAgICAgICBxcmVhbCBkaXN0YW5jZSA9IHFTcXJ0 KHJlZCAqIHJlZCArIGdyZWVuICogZ3JlZW4gKyBibHVlICogYmx1ZSArIGFscGhhICogYWxwaGEp IC8gMi4wZjsKICAgICAgICAgICAgICAgICAgICAgICAgIGludCBncmF5ID0gZGlzdGFuY2UgKiBx cmVhbCgyNTUpOwogICAgICAgICAgICAgICAgICAgICAgICAgZGlmZkltYWdlLnNldFBpeGVsKHgs IHksIHFSZ2IoZ3JheSwgZ3JheSwgZ3JheSkpOwogICAgICAgICAgICAgICAgICAgICAgICAgaWYg KGRpc3RhbmNlID49IDEgLyBxcmVhbCgyNTUpKSB7CkBAIC0xMTgsNyArMTE5LDcgQEAgaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKICAgICAgICAgICAgICAgICBpZiAoZGlmZmVyZW5j ZSA8PSB0b2xlcmFuY2UpIHsKICAgICAgICAgICAgICAgICAgICAgZGlmZmVyZW5jZSA9IDA7CiAg ICAgICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICAgICAgZGlmZmVyZW5jZSA9 IHJvdW5kKGRpZmZlcmVuY2UgKiAxMDApIC8gMTAwOworICAgICAgICAgICAgICAgICAgICBkaWZm ZXJlbmNlID0gcVJvdW5kKGRpZmZlcmVuY2UgKiAxMDApIC8gMTAwOwogICAgICAgICAgICAgICAg ICAgICBkaWZmZXJlbmNlID0gcU1heChkaWZmZXJlbmNlLCBxcmVhbCgwLjAxKSk7CiAgICAgICAg ICAgICAgICAgfQogCg==