38702 2010-05-06 15:55:01 -0700 [chromium] clear out more deprecated methods that are no longer used by chromium 2010-05-07 13:17:00 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd abarth eric webkit.review.bot oldest_to_newest 222027 0 fishd 2010-05-06 15:55:01 -0700 [chromium] clear out more deprecated methods that are no longer used by chromium 222413 1 55382 fishd 2010-05-07 09:14:20 -0700 Created attachment 55382 v1 patch Depends on http://codereview.chromium.org/1985008/show 222421 2 55382 dglazkov 2010-05-07 09:28:25 -0700 Comment on attachment 55382 v1 patch ok. 222572 3 fishd 2010-05-07 12:59:04 -0700 Landed as http://trac.webkit.org/changeset/58967 222577 4 webkit.review.bot 2010-05-07 13:10:38 -0700 http://trac.webkit.org/changeset/58967 might have broken Chromium Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/58966 http://trac.webkit.org/changeset/58967 222578 5 fishd 2010-05-07 13:17:00 -0700 Yup, it was 58967. The fix was made upstream to chromium. 55382 2010-05-07 09:14:20 -0700 2010-05-07 09:28:25 -0700 v1 patch clean_1.txt text/plain 4454 fishd SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1ODk1MSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNS0wNyAgRGFy aW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gY2xlYXIgb3V0IG1vcmUgZGVwcmVj YXRlZCBtZXRob2RzIHRoYXQgYXJlIG5vIGxvbmdlciB1c2VkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODcwMgorCisgICAgICAgICogcHVibGljL1dl YkZyYW1lLmg6CisgICAgICAgICogcHVibGljL1dlYk5vZGUuaDoKKyAgICAgICAgKiBzcmMvV2Vi RnJhbWVJbXBsLmNwcDoKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBsLmg6CisgICAgICAgICog c3JjL1dlYk5vZGUuY3BwOgorCiAyMDEwLTA1LTA2ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBX ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgJKHJldmlzaW9uIDU4OTUxKQorKysgV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00NzAsMTMgKzQ3MCw2 IEBAIHB1YmxpYzoKIAogICAgIC8vIFV0aWxpdHkgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCi0gICAgLy8gR2l2ZW4gYSByZWxh dGl2ZSBVUkwsIHJldHVybnMgYW4gYWJzb2x1dGUgVVJMIGJ5IHJlc29sdmluZyB0aGUgVVJMCi0g ICAgLy8gcmVsYXRpdmUgdG8gdGhlIGJhc2UgVVJMIG9mIHRoZSBmcmFtZSdzIGRvY3VtZW50LiAg VGhpcyB1c2VzIHRoZQotICAgIC8vIHNhbWUgYWxnb3JpdGhtIHRoYXQgV2ViS2l0IHVzZXMgdG8g cmVzb2x2ZSBoeXBlcmxpbmtzIGZvdW5kIGluIGEKLSAgICAvLyBIVE1MIGRvY3VtZW50LgotICAg IC8vIERlcHJlY2F0ZWQuIFVzZSBkb2N1bWVudCgpLmNvbXBsZXRlVVJMKCkgaW5zdGVhZC4KLSAg ICB2aXJ0dWFsIFdlYlVSTCBjb21wbGV0ZVVSTChjb25zdCBXZWJTdHJpbmcmKSBjb25zdCA9IDA7 Ci0KICAgICAvLyBSZXR1cm5zIHRoZSBjb250ZW50cyBvZiB0aGlzIGZyYW1lIGFzIGEgc3RyaW5n LiAgSWYgdGhlIHRleHQgaXMKICAgICAvLyBsb25nZXIgdGhhbiBtYXhDaGFycywgaXQgd2lsbCBi ZSBjbGlwcGVkIHRvIHRoYXQgbGVuZ3RoLiAgV0FSTklORzoKICAgICAvLyBUaGlzIGZ1bmN0aW9u IG1heSBiZSBzbG93IGRlcGVuZGluZyBvbiB0aGUgbnVtYmVyIG9mIGNoYXJhY3RlcnMKSW5kZXg6 IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTm9kZS5oDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJOb2RlLmgJKHJldmlzaW9uIDU4OTUxKQorKysgV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJOb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTg0LDggKzg0LDYgQEAg cHVibGljOgogICAgIFdFQktJVF9BUEkgV2ViU3RyaW5nIG5vZGVOYW1lKCkgY29uc3Q7CiAgICAg V0VCS0lUX0FQSSBXZWJTdHJpbmcgbm9kZVZhbHVlKCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBi b29sIHNldE5vZGVWYWx1ZShjb25zdCBXZWJTdHJpbmcmKTsKLSAgICAvLyBEZXByZWNhdGVkLiBV c2UgZG9jdW1lbnQoKS5mcmFtZSgpIGluc3RlYWQuCi0gICAgV0VCS0lUX0FQSSBXZWJGcmFtZSog ZnJhbWUoKSBjb25zdDsKICAgICBXRUJLSVRfQVBJIFdlYkRvY3VtZW50IGRvY3VtZW50KCkgY29u c3Q7CiAgICAgV0VCS0lUX0FQSSBXZWJOb2RlIGZpcnN0Q2hpbGQoKSBjb25zdDsKICAgICBXRUJL SVRfQVBJIFdlYk5vZGUgbGFzdENoaWxkKCkgY29uc3Q7CkBAIC0xMDYsMjIgKzEwNCw2IEBAIHB1 YmxpYzoKICAgICAvLyBOb3RlOiBUaGlzIG1ldGhvZCBvbmx5IHdvcmtzIHByb3Blcmx5IGFmdGVy IGxheW91dCBoYXMgb2NjdXJyZWQuCiAgICAgV0VCS0lUX0FQSSBib29sIGhhc05vbkVtcHR5Qm91 bmRpbmdCb3goKSBjb25zdDsKIAotICAgIC8vIERlcHJlY2F0ZWQuIFVzZSB0bygpIGluc3RlYWQu Ci0gICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gVCB0b0VsZW1lbnQoKQotICAgIHsKLSAgICAgICAg VCByZXM7Ci0gICAgICAgIHJlcy5XZWJOb2RlOjphc3NpZ24oKnRoaXMpOwotICAgICAgICByZXR1 cm4gcmVzOwotICAgIH0KLQotICAgIC8vIERlcHJlY2F0ZWQuIFVzZSB0b0NvbnN0KCkgaW5zdGVh ZC4KLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBjb25zdCBUIHRvQ29uc3RFbGVtZW50KCkgY29u c3QKLSAgICB7Ci0gICAgICAgIFQgcmVzOwotICAgICAgICByZXMuV2ViTm9kZTo6YXNzaWduKCp0 aGlzKTsKLSAgICAgICAgcmV0dXJuIHJlczsKLSAgICB9Ci0KICAgICB0ZW1wbGF0ZTx0eXBlbmFt ZSBUPiBUIHRvKCkKICAgICB7CiAgICAgICAgIFQgcmVzOwpJbmRleDogV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJGcmFtZUltcGwuY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJGcmFtZUltcGwuY3BwCShyZXZpc2lvbiA1ODk1MSkKKysrIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYwOCwxNCArMTYwOCw2IEBA IHZvaWQgV2ViRnJhbWVJbXBsOjpyZXNldE1hdGNoQ291bnQoKQogICAgIG1fZnJhbWVzU2NvcGlu Z0NvdW50ID0gMDsKIH0KIAotV2ViVVJMIFdlYkZyYW1lSW1wbDo6Y29tcGxldGVVUkwoY29uc3Qg V2ViU3RyaW5nJiB1cmwpIGNvbnN0Ci17Ci0gICAgaWYgKCFtX2ZyYW1lIHx8ICFtX2ZyYW1lLT5k b2N1bWVudCgpKQotICAgICAgICByZXR1cm4gV2ViVVJMKCk7Ci0KLSAgICByZXR1cm4gbV9mcmFt ZS0+ZG9jdW1lbnQoKS0+Y29tcGxldGVVUkwodXJsKTsKLX0KLQogV2ViU3RyaW5nIFdlYkZyYW1l SW1wbDo6Y29udGVudEFzVGV4dChzaXplX3QgbWF4Q2hhcnMpIGNvbnN0CiB7CiAgICAgaWYgKCFt X2ZyYW1lKQpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaA0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgJKHJldmlzaW9uIDU4 OTUxKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAkod29ya2luZyBjb3B5 KQpAQCAtMTYzLDcgKzE2Myw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcmVnaXN0ZXJQ YXNzd29yZExpc3RlbmVyKAogICAgICAgICBXZWJJbnB1dEVsZW1lbnQsIFdlYlBhc3N3b3JkQXV0 b2NvbXBsZXRlTGlzdGVuZXIqKTsKIAotICAgIHZpcnR1YWwgV2ViVVJMIGNvbXBsZXRlVVJMKGNv bnN0IFdlYlN0cmluZyYgdXJsKSBjb25zdDsKICAgICB2aXJ0dWFsIFdlYlN0cmluZyBjb250ZW50 QXNUZXh0KHNpemVfdCBtYXhDaGFycykgY29uc3Q7CiAgICAgdmlydHVhbCBXZWJTdHJpbmcgY29u dGVudEFzTWFya3VwKCkgY29uc3Q7CiAgICAgdmlydHVhbCBXZWJTdHJpbmcgcmVuZGVyVHJlZUFz VGV4dCgpIGNvbnN0OwpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJOb2RlLmNwcA0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViTm9kZS5jcHAJKHJldmlzaW9uIDU4 OTUxKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJOb2RlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtOTQsMTEgKzk0LDYgQEAgYm9vbCBXZWJOb2RlOjpzZXROb2RlVmFsdWUoY29uc3QgV2ViU3Ry aQogICAgIHJldHVybiAhZXhjZXB0aW9uQ29kZTsKIH0KIAotV2ViRnJhbWUqIFdlYk5vZGU6OmZy YW1lKCkgY29uc3QKLXsKLSAgICByZXR1cm4gV2ViRnJhbWVJbXBsOjpmcm9tRnJhbWUobV9wcml2 YXRlLT5kb2N1bWVudCgpLT5mcmFtZSgpKTsKLX0KLQogV2ViRG9jdW1lbnQgV2ViTm9kZTo6ZG9j dW1lbnQoKSBjb25zdAogewogICAgIHJldHVybiBXZWJEb2N1bWVudChtX3ByaXZhdGUtPmRvY3Vt ZW50KCkpOwo=