38697 2010-05-06 15:14:03 -0700 REGRESSION (r58299): Replying on reddit.com no longer works 2010-05-09 16:47:57 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P1 Normal --- 1 ap ap hyatt jalada+bugzilla mitz s+webkit visnupx yuzo oldest_to_newest 221997 0 ap 2010-05-06 15:14:03 -0700 STEPS TO REPRODUCE: 1) Open http://www.reddit.com/r/AskReddit/comments/a7pud/whats_your_favorite_ted_talk/ 2) Click the "Reply" link (you might need to be logged in for this). EXPECTED RESULTS: A text area opens for you to write a comment ACTUAL: It doesn't. Alternatively (if you don't have a reddit account), just click "Register" link. <rdar://problem/7931177> 221998 1 ap 2010-05-06 15:15:07 -0700 This happens because document.querySelectorAll(".login-popup:first") no longer raises an exception. 222002 2 55306 ap 2010-05-06 15:17:50 -0700 Created attachment 55306 reduced test case 222047 3 ap 2010-05-06 16:35:09 -0700 I think that this goes both ways. The new first, left and right classes are allowed outside @page rules, but also, other classes are allowed inside page rules, but they shouldn't. Correct (from the spec): page : PAGE_SYM S* IDENT? pseudo_page? S* '{' S* [ declaration | margin ]? [ ';' S* [ declaration | margin ]? ]* '}' S* ; pseudo_page : ':' [ "left" | "right" | "first" ] ; Wrong (CSSGrammar.y): page: PAGE_SYM maybe_space page_selector maybe_space ... page_selector: IDENT { ... | IDENT pseudo { ... | pseudo { ... | /* empty */ { Note that any pseudo is allowed in page rules by the grammar here, not just pseudo_page. 222053 4 55318 ap 2010-05-06 16:42:25 -0700 Created attachment 55318 naive fix 222058 5 55318 ggaren 2010-05-06 16:50:02 -0700 Comment on attachment 55318 naive fix r=me 222069 6 ap 2010-05-06 17:04:39 -0700 Committed <http://trac.webkit.org/changeset/58922>. Add a FIXME comment, as suggested by Mitz. 222071 7 55318 darin 2010-05-06 17:14:49 -0700 Comment on attachment 55318 naive fix > + document.querySelectorAll(".login-popup:first"); I'd be happier if you included test cases for all three of the affected pseudo classes. 222098 8 yuzo 2010-05-06 18:04:39 -0700 Sorry for the regression and thank you for the fix. 222099 9 yuzo 2010-05-06 18:07:19 -0700 I'll address the grammar issue under a separate bug. 222535 10 ap 2010-05-07 12:17:15 -0700 *** Bug 38729 has been marked as a duplicate of this bug. *** 222646 11 visnupx 2010-05-07 15:06:36 -0700 *** Bug 38499 has been marked as a duplicate of this bug. *** 223110 12 ap 2010-05-09 16:47:57 -0700 *** Bug 38804 has been marked as a duplicate of this bug. *** 55306 2010-05-06 15:17:50 -0700 2010-05-06 15:17:50 -0700 reduced test case test.html text/html 166 ap PGJvZHk+CjxzY3JpcHQ+CnRyeSB7CiAgICBkb2N1bWVudC5xdWVyeVNlbGVjdG9yQWxsKCIubG9n aW4tcG9wdXA6Zmlyc3QiKTsKICAgIGRvY3VtZW50LndyaXRlKCJGQUlMIik7Cn0gY2F0Y2ggKEVY KSB7CiAgICBkb2N1bWVudC53cml0ZSgiUEFTUyIpOwp9Cjwvc2NyaXB0Pgo8L2JvZHk+Cg== 55318 2010-05-06 16:42:25 -0700 2010-05-06 17:14:49 -0700 naive fix Reddit.txt text/plain 3999 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODkxOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDUtMDYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4Njk3CisgICAgICAgIFJF R1JFU1NJT04gKHI1ODI5OSk6IFJlcGx5aW5nIG9uIHJlZGRpdC5jb20gbm8gbG9uZ2VyIHdvcmtz CisKKyAgICAgICAgKiBjc3MvQ1NTU2VsZWN0b3IuY3BwOiAoV2ViQ29yZTo6Q1NTU2VsZWN0b3I6 OmV4dHJhY3RQc2V1ZG9UeXBlKTogRG9uJ3QgcmVjb2duaXplIDpmaXJzdCwKKyAgICAgICAgOmxl ZnQgYW5kIDpyaWdodC4gVGhlIGFyZW4ndCBhbGxvd2VkIGluIGFsbCBjb250ZXh0cywgYW5kIHBy b3Blcmx5IGltcGxlbWVudGluZyB0aGVtIGlzIG91dAorICAgICAgICBvZiBzY29wZSBmb3IgdGhp cyByZWdyZXNzaW9uIGZpeC4KKwogMjAxMC0wNS0wNiAgSmlhbiBMaSAgPGppYW5saUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFdlYkNvcmUv Y3NzL0NTU1NlbGVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9DU1NTZWxlY3Rv ci5jcHAJKHJldmlzaW9uIDU4OTA4KQorKysgV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC01MjUsMTAgKzUyNSwxMiBAQCB2b2lkIENTU1NlbGVjdG9yOjpleHRy YWN0UHNldWRvVHlwZSgpIGNvCiAgICAgY2FzZSBQc2V1ZG9TaW5nbGVCdXR0b246CiAgICAgY2Fz ZSBQc2V1ZG9Ob0J1dHRvbjoKICAgICBjYXNlIFBzZXVkb05vdFBhcnNlZDoKKyAgICAgICAgYnJl YWs7CiAgICAgY2FzZSBQc2V1ZG9GaXJzdFBhZ2U6CiAgICAgY2FzZSBQc2V1ZG9MZWZ0UGFnZToK ICAgICBjYXNlIFBzZXVkb1JpZ2h0UGFnZToKLSAgICAgICAgYnJlYWs7CisgICAgICAgIG1fcHNl dWRvVHlwZSA9IFBzZXVkb1Vua25vd247CisgICAgICAgIHJldHVybjsKICAgICB9CiAKICAgICBp ZiAobV9tYXRjaCA9PSBQc2V1ZG9DbGFzcyAmJiBlbGVtZW50KSB7CkluZGV4OiBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lv biA1ODkxOSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEwLTA1LTA2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODY5NworICAgICAgICBSRUdSRVNT SU9OIChyNTgyOTkpOiBSZXBseWluZyBvbiByZWRkaXQuY29tIG5vIGxvbmdlciB3b3JrcworCisg ICAgICAgICogZmFzdC9jc3MvbWlzcGxhY2VkLXBhZ2VkLW1lZGlhLXBzZXVkby1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL21pc3BsYWNlZC1wYWdlZC1tZWRpYS1wc2V1 ZG8uaHRtbDogQWRkZWQuCisKKyAgICAgICAgKiBwcmludGluZy9wYWdlLXJ1bGUtY3NzLXRleHQt ZXhwZWN0ZWQudHh0OiA6Zmlyc3QsIDpsZWZ0IGFuZCA6cmlnaHQgYXJlIG5vIGxvbmdlciByZWNv Z25pemVkLAorICAgICAgICBsYW5kaW5nIHJlZ3Jlc3NlZCByZXN1bHRzIHVudGlsIHRoZXkgY2Fu IGJlIHByb3Blcmx5IGltcGxlbWVudGVkLgorCiAyMDEwLTA1LTA2ICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIg YW5kIERhbiBCZXJuc3RlaW4uLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvbWlzcGxhY2Vk LXBhZ2VkLW1lZGlhLXBzZXVkby1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9jc3MvbWlzcGxhY2VkLXBhZ2VkLW1lZGlhLXBzZXVkby1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9taXNwbGFjZWQtcGFnZWQtbWVkaWEt cHNldWRvLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitUZXN0IGZv ciBidWcgMzg2OTc6IFJlcGx5aW5nIG9uIHJlZGRpdC5jb20gbm8gbG9uZ2VyIHdvcmtzLgorCitQ QVNTCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9taXNwbGFjZWQtcGFnZWQtbWVkaWEtcHNl dWRvLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvbWlzcGxhY2VkLXBh Z2VkLW1lZGlhLXBzZXVkby5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9j c3MvbWlzcGxhY2VkLXBhZ2VkLW1lZGlhLXBzZXVkby5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCww ICsxLDE1IEBACis8Ym9keT4KKzxwPlRlc3QgZm9yIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODY5NyI+YnVnIDM4Njk3PGEvPjoKK1JlcGx5aW5nIG9u IHJlZGRpdC5jb20gbm8gbG9uZ2VyIHdvcmtzLjwvcD4KKzxzY3JpcHQ+CitpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQo KTsKKwordHJ5IHsKKyAgICBkb2N1bWVudC5xdWVyeVNlbGVjdG9yQWxsKCIubG9naW4tcG9wdXA6 Zmlyc3QiKTsKKyAgICBkb2N1bWVudC53cml0ZSgiRkFJTCIpOworfSBjYXRjaCAoRVgpIHsKKyAg ICBkb2N1bWVudC53cml0ZSgiUEFTUyIpOworfQorPC9zY3JpcHQ+Cis8L2JvZHk+CkluZGV4OiBM YXlvdXRUZXN0cy9wcmludGluZy9wYWdlLXJ1bGUtY3NzLXRleHQtZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL3ByaW50aW5nL3BhZ2UtcnVsZS1jc3MtdGV4dC1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDU4OTA4KQorKysgTGF5b3V0VGVzdHMvcHJpbnRpbmcvcGFnZS1ydWxl LWNzcy10ZXh0LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSwxMCArMSw1IEBACiBA cGFnZSB7IG1hcmdpbi10b3A6IDVjbTsgbWFyZ2luLWJvdHRvbTogMTBjbTsgfQotQHBhZ2UgOmxl ZnQgeyBtYXJnaW4tcmlnaHQ6IDNjbTsgfQotQHBhZ2UgOnJpZ2h0IHsgbWFyZ2luLWxlZnQ6IDNj bTsgfQotQHBhZ2UgOmZpcnN0IHsgYm9yZGVyLXRvcC13aWR0aDogMXB4OyBib3JkZXItcmlnaHQt d2lkdGg6IDFweDsgYm9yZGVyLWJvdHRvbS13aWR0aDogMXB4OyBib3JkZXItbGVmdC13aWR0aDog MXB4OyB9CiBAcGFnZSBoZWxsbyB7IGNvbG9yOiBncmVlbjsgfQotQHBhZ2Ugd29ybGQ6cmlnaHQg eyBjb2xvcjogcmVkOyB9Ci1AbWVkaWEgcHJpbnQgeyBAcGFnZSBzb21lcGFnZTpmaXJzdCB7IG1h cmdpbi10b3A6IDNjbTsgbWFyZ2luLXJpZ2h0OiAzY207IG1hcmdpbi1ib3R0b206IDNjbTsgbWFy Z2luLWxlZnQ6IDNjbTsgfSB9CiBAcGFnZSBhdXRvX3BhZ2UgeyBzaXplOiBhdXRvOyB9CiBAcGFn ZSBzcXVhcmVfcGFnZSB7IHNpemU6IDRpbjsgfQogQHBhZ2UgbGV0dGVyX3BhZ2UgeyBzaXplOiBs ZXR0ZXI7IH0K