38658 2010-05-06 10:30:30 -0700 [Qt] tst_QWebFrame::popupFocus() fails on Mac OS 2011-06-14 06:07:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED WORKSFORME Qt, QtTriaged P2 Normal --- 38654 1 jesus webkit-unassigned kenneth luiz max.hong.shen menard oldest_to_newest 221789 0 jesus 2010-05-06 10:30:30 -0700 Using WebKit r58755 and Qt 4.7 HEAD 32ecf8e8ad326ea13ec9a430c99ce540e8b4efac I noticed that this test fails on Mac OS. The message is: 'view.hasFocus() && !combo->view()->hasFocus()' returned FALSE . 221918 1 jesus 2010-05-06 13:25:36 -0700 (In reply to comment #0) > Using WebKit r58755 and Qt 4.7 HEAD 32ecf8e8ad326ea13ec9a430c99ce540e8b4efac I > noticed that this test fails on Mac OS. > > The message is: 'view.hasFocus() && !combo->view()->hasFocus()' returned FALSE > . It also fails on Maemo5 with Qt 4.6 and the same stated revision of WebKit, with the message: ('combo != 0' returned FALSE). 222639 2 luiz 2010-05-07 14:57:13 -0700 (In reply to comment #1) > (In reply to comment #0) > > Using WebKit r58755 and Qt 4.7 HEAD 32ecf8e8ad326ea13ec9a430c99ce540e8b4efac I > > noticed that this test fails on Mac OS. > > > > The message is: 'view.hasFocus() && !combo->view()->hasFocus()' returned FALSE > > . > > It also fails on Maemo5 with Qt 4.6 and the same stated revision of WebKit, > with the message: ('combo != 0' returned FALSE). In Maemo5 no combo box is used. The test will not work in Maemo5. 222641 3 kenneth 2010-05-07 14:58:38 -0700 Then we should add a #ifdef or an XFAIL for maemo. I am not sure which one makes most sense. 222653 4 kenneth 2010-05-07 15:14:22 -0700 I suggest we split this bug up into two as the failures are not really related. Mac fails because it does not give the focus back to the view, and Maemo has no QComboBox, thus the test doesn't really apply and we might thus mark it XFAIL or adapt the test to make sense on Maemo. 227515 5 luiz 2010-05-18 15:01:35 -0700 The maemo issue has been handled in bug 39314. 227937 6 luiz 2010-05-19 12:05:57 -0700 Mac does not give the focus back to the view. I believe that it is a problem in Qt for Mac OS. 296775 7 71289 max.hong.shen 2010-10-20 06:55:14 -0700 Created attachment 71289 proposal fix 296776 8 max.hong.shen 2010-10-20 07:02:35 -0700 I think this test case might be incorrect. I tested both firefox and safari, and none of them give the focus back to webview after click outside of a select list. (e.g. a page has a select list and input field. First, click the list to popup the select list; then click the input field; The result is that no focus/cursor shows in the input field and you have to click the input filed again to set the focus/cursor on it). Also, I checked the Qt code and found the first click event is eaten by qcombox to hide itself. Then the second click event can reach the webview. So, I made a few changes to this test case to help pass the test. 420358 9 menard 2011-06-14 06:07:36 -0700 I'm curious I can't reproduce the failure here with QtWebKit 2.2 (or trunk) with a recent 4.7 Cocoa build. Please re-open if more informations 71289 2010-10-20 06:55:14 -0700 2010-11-03 10:10:58 -0700 proposal fix 38658.patch text/plain 2233 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNzAxNDUpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMjAgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gdHN0X1FXZWJGcmFtZTo6cG9wdXBGb2N1cygpIGZhaWxzIG9uIE1hYyBPUworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg2NTgKKworICAgICAg ICAqIHRlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcDoKKwogMjAxMC0xMC0yMCAgTHVp eiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBbnRvbmlvIEdvbWVzLgpJbmRleDogV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90 c3RfcXdlYmZyYW1lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1l L3RzdF9xd2ViZnJhbWUuY3BwCShyZXZpc2lvbiA3MDE0NCkKKysrIFdlYktpdC9xdC90ZXN0cy9x d2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2MTQsMTEgKzI2 MTQsMTkgQEAgdm9pZCB0c3RfUVdlYkZyYW1lOjpwb3B1cEZvY3VzKCkKICAgICBRT2JqZWN0KiB3 ZWJwb3B1cCA9IGZpcnN0Q2hpbGRCeUNsYXNzTmFtZSgmdmlldywgIlFDb21ib0JveCIpOwogICAg IFFDb21ib0JveCogY29tYm8gPSBxb2JqZWN0X2Nhc3Q8UUNvbWJvQm94Kj4od2VicG9wdXApOwog ICAgIFFWRVJJRlkoY29tYm8gIT0gMCk7Ci0gICAgUVRSWV9WRVJJRlkoIXZpZXcuaGFzRm9jdXMo KSAmJiBjb21iby0+dmlldygpLT5oYXNGb2N1cygpKTsgLy8gRm9jdXMgc2hvdWxkIGJlIG9uIHRo ZSBwb3B1cAorICAgIFFUZXN0OjpxV2FpdCgxMDAwKTsgLy8gdGhlIGNvbWJvYm94IGdldHMgcGFp bnRlZCBpbiB0aGUgZXZlbnQgbG9vcAorICAgIFFUUllfVkVSSUZZKCF2aWV3Lmhhc0ZvY3VzKCkg JiYgY29tYm8tPnZpZXcoKS0+aGFzRm9jdXMoKSAmJiB3ZWJDb21iby5oYXNGb2N1cygpKTsgLy8g Zm9jdXMgc2hvdWxkIGJlIG9uIHRoZSBwb3B1cAogCi0gICAgLy8gaGlkZSB0aGUgcG9wdXAgYW5k IGNoZWNrIGlmIGZvY3VzIGlzIG9uIHRoZSBwYWdlCisgICAgLy8gY2FsbCBjb21iby0+aGlkZVBv cHVwKCkgZG9lc24ndCBnaXZlIHRoZSBmb2N1cyBiYWNrIHRvIHRoZSB3ZWJ2aWV3CiAgICAgY29t Ym8tPmhpZGVQb3B1cCgpOwotICAgIFFUUllfVkVSSUZZKHZpZXcuaGFzRm9jdXMoKSAmJiAhY29t Ym8tPnZpZXcoKS0+aGFzRm9jdXMoKSk7IC8vIEZvY3VzIHNob3VsZCBiZSBiYWNrIG9uIHRoZSBX ZWJWaWV3CisgICAgUVRlc3Q6OnFXYWl0KDEwMDApOyAvLyB0aGUgY29tYm9ib3ggZ2V0cyBwYWlu dGVkIGluIHRoZSBldmVudCBsb29wCisgICAgUVRSWV9WRVJJRlkoIXZpZXcuaGFzRm9jdXMoKSAm JiB3ZWJDb21iby5oYXNGb2N1cygpKTsgLy8gZG9uJ3QgdGVzdCBjb21ibyBpbnN0YW5jZSwgd2hp Y2ggaGFzIGJlZW4gZGVsZXRlZCBpbiB0aGUgZXZlbnQgbG9vcAorCisgICAgLy8gc2VuZCBldmVu dCB0byB3ZWJ2aWV3IGRpcmVjdGx5IHRvIGdldCB0aGUgZm9jdXMgYmFjaworICAgIGNvbnN0IFFX ZWJFbGVtZW50IHdlYklucHV0ID0gdmlldy5wYWdlKCktPm1haW5GcmFtZSgpLT5kb2N1bWVudEVs ZW1lbnQoKS5maW5kRmlyc3QoUUxhdGluMVN0cmluZygiaW5wdXQiKSk7CisgICAgUVRlc3Q6Om1v dXNlQ2xpY2soJnZpZXcsIFF0OjpMZWZ0QnV0dG9uLCAwLCB3ZWJJbnB1dC5nZW9tZXRyeSgpLmNl bnRlcigpKTsKKyAgICBRVGVzdDo6cVdhaXQoMTAwMCk7IC8vIHRoZSBjb21ib2JveCBnZXRzIHBh aW50ZWQgaW4gdGhlIGV2ZW50IGxvb3AKKyAgICBRVFJZX1ZFUklGWSh2aWV3Lmhhc0ZvY3VzKCkg JiYgIXdlYkNvbWJvLmhhc0ZvY3VzKCkpOyAvLyBmb2N1cyBzaG91bGQgYmUgYmFjayBvbiB0aGUg V2ViVmlldywgdGhlIGNvbWJvIGhhcyBiZWVuIGRlbGV0ZWQgaW4gdGhlIGV2ZW50IGxvb3AKIH0K ICNlbmRpZgogCg==