38657 2010-05-06 10:27:46 -0700 [GTK] Adjustment resetting uses wrong values, and misses page_size and steps 2010-05-06 11:46:43 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 221788 0 gustavo 2010-05-06 10:27:46 -0700 That's about it. The reason we sometimes end up with a horizontal scrollbar when going back to a page is because upper is currently being confused with page_size. To clean it up, I wanted to use API instead of poking into the struct internals and emitting signals ourselves, so I am also setting the steps. 221790 1 55256 gustavo 2010-05-06 10:30:54 -0700 Created attachment 55256 fix adjustment resetting 221793 2 55256 xan.lopez 2010-05-06 10:34:27 -0700 Comment on attachment 55256 fix adjustment resetting Go go gadget review! 221860 3 gustavo 2010-05-06 11:46:43 -0700 Landed as 58897 with follow up fix as r58898. 55256 2010-05-06 10:30:54 -0700 2010-05-06 10:34:27 -0700 fix adjustment resetting 0001-Fix-adjustment-resetting.patch text/plain 3443 gustavo RnJvbSBjMzBmYTQ3NzhhZTdjOTcwOTM0OGVmZjdkMzBjODdmMDE2MTAyOWRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFRodSwgNiBNYXkgMjAxMCAxMjo0MTowOCAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eCBhZGp1c3RtZW50IHJlc2V0dGluZwoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1Nj cm9sbFZpZXdHdGsuY3BwIHwgICAyNiArKysrKysrKysrKysrKystLS0tLS0tLS0tLQogMiBmaWxl cyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDhmMzZhMWEuLmQ3 MTllMGEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDUtMDYgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAg PGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQWRqdXN0bWVudCByZXNldHRpbmcgdXNl cyB3cm9uZyB2YWx1ZXMsIGFuZCBtaXNzZXMgcGFnZV9zaXplIGFuZCBzdGVwcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg2NTcKKworICAgICAgICBG aXggcmVzZXR0aW5nIGFkanVzdG1lbnQgdmFsdWVzLiBJbiB0aGUgcGFnZSBjYWNoZSBjYXNlLCB3 ZSB3ZXJlCisgICAgICAgIGNvbmZ1c2luZyBwYWdlX3NpemUgYW5kIHVwcGVyLCBsZWFkaW5nIHRv IHN0cmF5IHNjcm9sbGJhcnMKKyAgICAgICAgc29tZXRpbWVzLgorCisgICAgICAgICogcGxhdGZv cm0vZ3RrL1Njcm9sbFZpZXdHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6 c2V0R3RrQWRqdXN0bWVudHMpOgorCiAyMDEwLTA1LTA2ICBEYXJpbiBBZGxlciAgPGRhcmluQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBCZXRoIERha2luLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsVmlld0d0ay5jcHAgYi9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9TY3JvbGxWaWV3R3RrLmNwcAppbmRleCAzZGYzY2I1Li5kZTc3MGQ1IDEwMDY0NAotLS0g YS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxWaWV3R3RrLmNwcAorKysgYi9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9TY3JvbGxWaWV3R3RrLmNwcApAQCAtMTAwLDE3ICsxMDAsMjEgQEAgdm9pZCBT Y3JvbGxWaWV3OjpzZXRHdGtBZGp1c3RtZW50cyhHdGtBZGp1c3RtZW50KiBoYWRqLCBHdGtBZGp1 c3RtZW50KiB2YWRqLCBib28KICAgICAgICAgLy8gc2V0IGluIHRoZSBub3JtYWwgY2FzZSksIHdl IG1ha2Ugc3VyZSB0aGV5IGFyZSB1cC10by1kYXRlCiAgICAgICAgIC8vIGhlcmUuIFRoaXMgaXMg bmVlZGVkIGZvciB0aGUgcGFyZW50IHNjcm9sbGluZyB3aWRnZXQgdG8gYmUKICAgICAgICAgLy8g YWJsZSB0byByZXBvcnQgY29ycmVjdCB2YWx1ZXMuCi0gICAgICAgIG1faG9yaXpvbnRhbEFkanVz dG1lbnQtPmxvd2VyID0gMDsKLSAgICAgICAgbV9ob3Jpem9udGFsQWRqdXN0bWVudC0+dXBwZXIg PSByZXNldFZhbHVlcyA/IDAgOiBmcmFtZVJlY3QoKS53aWR0aCgpOwotICAgICAgICBtX2hvcml6 b250YWxBZGp1c3RtZW50LT52YWx1ZSA9IHJlc2V0VmFsdWVzID8gMCA6IHNjcm9sbE9mZnNldCgp LndpZHRoKCk7Ci0gICAgICAgIGd0a19hZGp1c3RtZW50X2NoYW5nZWQobV9ob3Jpem9udGFsQWRq dXN0bWVudCk7Ci0gICAgICAgIGd0a19hZGp1c3RtZW50X3ZhbHVlX2NoYW5nZWQobV9ob3Jpem9u dGFsQWRqdXN0bWVudCk7Ci0KLSAgICAgICAgbV92ZXJ0aWNhbEFkanVzdG1lbnQtPmxvd2VyID0g MDsKLSAgICAgICAgbV92ZXJ0aWNhbEFkanVzdG1lbnQtPnVwcGVyID0gcmVzZXRWYWx1ZXMgPyAw IDogZnJhbWVSZWN0KCkuaGVpZ2h0KCk7Ci0gICAgICAgIG1fdmVydGljYWxBZGp1c3RtZW50LT52 YWx1ZSA9IHJlc2V0VmFsdWVzID8gMCA6IHNjcm9sbE9mZnNldCgpLmhlaWdodCgpOwotICAgICAg ICBndGtfYWRqdXN0bWVudF9jaGFuZ2VkKG1fdmVydGljYWxBZGp1c3RtZW50KTsKLSAgICAgICAg Z3RrX2FkanVzdG1lbnRfdmFsdWVfY2hhbmdlZChtX3ZlcnRpY2FsQWRqdXN0bWVudCk7CisgICAg ICAgIGJvb2wgcmVzZXRIb3Jpem9udGFsID0gcmVzZXRWYWx1ZXMgfHwgIWhTY3JvbGxiYXI7Cisg ICAgICAgIGd0a19hZGp1c3RtZW50X2NvbmZpZ3VyZShtX2hvcml6b250YWxBZGp1c3RtZW50LAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVzZXRIb3Jpem9udGFsID8gMCA6IHNj cm9sbE9mZnNldCgpLndpZHRoKCksIDAsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICByZXNldEhvcml6b250YWwgPyAwIDogY29udGVudHNTaXplKCkud2lkdGgoKSwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHJlc2V0SG9yaXpvbnRhbCA/IDAgOiBoU2Nyb2xsYmFy LT5saW5lU3RlcCgpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVzZXRIb3Jp em9udGFsID8gMCA6IGhTY3JvbGxiYXItPnBhZ2VTdGVwKCksCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICByZXNldEhvcml6b250YWwgPyAwIDogZnJhbWVSZWN0KCkud2lkdGgoKSk7 CisKKyAgICAgICAgYm9vbCByZXNldFZlcnRpY2FsID0gcmVzZXRWYWx1ZXMgfHwgIXZTY3JvbGxi YXI7CisgICAgICAgIGd0a19hZGp1c3RtZW50X2NvbmZpZ3VyZShtX3ZlcnRpY2FsQWRqdXN0bWVu dCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlc2V0VmVydGljYWwgPyAwIDog c2Nyb2xsT2Zmc2V0KCkud2lkdGgoKSwgMCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHJlc2V0VmVydGljYWwgPyAwIDogY29udGVudHNTaXplKCkud2lkdGgoKSwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHJlc2V0VmVydGljYWwgPyAwIDogdlNjcm9sbGJhci0+ bGluZVN0ZXAoKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlc2V0VmVydGlj YWwgPyAwIDogdlNjcm9sbGJhci0+cGFnZVN0ZXAoKSwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHJlc2V0VmVydGljYWwgPyAwIDogZnJhbWVSZWN0KCkud2lkdGgoKSk7CiAgICAg fSBlbHNlIHsKICAgICAgICAgU2Nyb2xsYmFyR3RrKiBoU2Nyb2xsYmFyID0gcmVpbnRlcnByZXRf Y2FzdDxTY3JvbGxiYXJHdGsqPihob3Jpem9udGFsU2Nyb2xsYmFyKCkpOwogICAgICAgICBpZiAo aFNjcm9sbGJhcikKLS0gCjEuNy4xCgo=