38656 2010-05-06 10:27:37 -0700 [GTK] [Qt] editing/selection/shift-click.html fails 2015-05-07 16:47:32 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC Linux RESOLVED WORKSFORME Qt, QtTriaged P2 Normal --- 45233 45235 1 ojan webkit-unassigned abarth chinmaya diegohcg eric gustavo mrobinson ossy tonikitoo oldest_to_newest 221787 0 ojan 2010-05-06 10:27:37 -0700 As best I can tell from looking at the test results, it looks like shift+click is getting treated as a regular click. Skipping the test for now. 221791 1 55257 ojan 2010-05-06 10:32:29 -0700 Created attachment 55257 Patch 221796 2 55257 abarth 2010-05-06 10:39:24 -0700 Comment on attachment 55257 Patch Ok, but please follow up with some of the Qt/Gtk folks by email to make sure this is how they'd like this handled. 221802 3 ojan 2010-05-06 10:42:43 -0700 Committed r58896: <http://trac.webkit.org/changeset/58896> 221847 4 mrobinson 2010-05-06 11:36:17 -0700 My intuition says this is related to the fact that GTK+ uses Mac editing behavior by default, but this test is checking the user-agent for Mac-specific strings. 221938 5 ojan 2010-05-06 13:41:42 -0700 (In reply to comment #4) > My intuition says this is related to the fact that GTK+ uses Mac editing > behavior by default, but this test is checking the user-agent for Mac-specific > strings. As best I can tell, that's not the case here. The test results don't match windows or mac editing behavior. They match the behavior of doing a regular click. 221954 6 mrobinson 2010-05-06 13:57:49 -0700 There are some other bugs with GTK+ EventSender around double-clicks. I have one patch for it and will try to get it ready for review tomorrow. I wouldn't be surprised if it's failing both because Qt and GTK+ use the Mac editing style and because of bugs in DRT. I'll try to follow up when I have a moment. 222309 7 gustavo 2010-05-07 06:15:26 -0700 Coming from the email contact. I believe Martin is the GTK+ authority of choice for such issues, so I'll let him handle the case since he's already on it =D 236147 8 tonikitoo 2010-06-09 21:22:08 -0700 test is still failing on Gtk and Qt. Reopening. 273550 9 eric 2010-09-02 13:54:30 -0700 Status? 274391 10 mrobinson 2010-09-04 15:23:17 -0700 This patch is failing on GTK+ for two reasons: 1. There is no support in the EventSender for mouseUp and mouseDown modifiers. 2. The test uses the user-agent to figure out the editing style. I'll post patches soon. 274398 11 mrobinson 2010-09-04 15:52:24 -0700 From a quick look, it appears that number 1 is also an issue with the Qt DRT. 356406 12 diegohcg 2011-02-23 14:09:36 -0800 Still reproducible at r79447 1092853 13 mrobinson 2015-05-07 16:47:32 -0700 This doesn't seem to be an issue any longer. 55257 2010-05-06 10:32:29 -0700 2010-09-07 09:38:08 -0700 Patch bug-38656-20100506103227.patch text/plain 1793 ojan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyNjk4YjZiYmE0NGM1OTc0NWQwZTQzMGE4ZjRlYWJjZDkxM2ZlZjI0Li5iM2Q2NDA2 MWMwOGU4OWQ3MmQ0MjA1MGRmZjJiOTYyOTQ4ZGY2NTI2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDUtMDYgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBlZGl0aW5nL3NlbGVjdGlvbi9z aGlmdC1jbGljay5odG1sIGZhaWxzIG9uIEdUSyBhbmQgUVQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NjU2CisKKyAgICAgICAgcjU4ODkyIGFkZGVk IHRoaXMgdGVzdC4gSXQncyB0aGUgZmlyc3QgdGVzdCBmb3Igc2hpZnQrY2xpY2sgYmVoYXZpb3Is CisgICAgICAgIHNvIGl0IGV4cG9zZWQgYnVncyBpbiBHVEsvUVQuIFNraXBwaW5nIHRvIGdyZWVu IHRoZSBib3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6CisgICAgICAgICog cGxhdGZvcm0vcXQvU2tpcHBlZDoKKwogMjAxMC0wNS0wNSAgT2phbiBWYWZhaSAgPG9qYW5AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvU2tpcHBlZAppbmRleCBkMTNkNzRhOTAwN2IwNmJlYzY0YzY4NzI3YWEwYjFkODZlYjZh NzNiLi41YTE1OTk1YTk2NzczN2RiZDJjZDU2ZDUwNDUzNTNjMmM3ZWEwYjM3IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvU2tpcHBlZApAQCAtNjAxNCwzICs2MDE0LDYgQEAgaW5zcGVjdG9yL3RpbWVsaW5l LXBhcnNlLWh0bWwuaHRtbAogCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zODU2OQogaHR0cC90ZXN0cy93b3JrZXJzL3RleHQtZW5jb2RpbmcuaHRtbAorCisjIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODY1NgorZWRpdGluZy9zZWxl Y3Rpb24vc2hpZnQtY2xpY2suaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKaW5kZXggNzg3MjBh NGQ0NmYyYzkwMjgwNmU3NTE3ZTYxZGJkODg0MzdkZDM1NS4uMjNmMTgyMWU2ZGY0ZjUzMWQ4NGJi NTYxMGZiZjNlMTU3Njk2NGNmOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQv U2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCkBAIC01MTk1LDMg KzUxOTUsNiBAQCBmYXN0L2pzL3NwdXRuaWsvVW5pY29kZS9Vbmljb2RlXzIxOC9TNy42X0EzLjEu aHRtbAogZmFzdC9qcy9zcHV0bmlrL1VuaWNvZGUvVW5pY29kZV8yMTgvUzcuNl9BMy4yLmh0bWwK IGZhc3QvanMvc3B1dG5pay9Vbmljb2RlL1VuaWNvZGVfMjE4L1M3LjZfQTUuM19UMS5odG1sCiBm YXN0L2pzL3NwdXRuaWsvVW5pY29kZS9Vbmljb2RlXzIxOC9TNy42X0E1LjNfVDIuaHRtbAorCisj IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODY1NgorZWRpdGluZy9z ZWxlY3Rpb24vc2hpZnQtY2xpY2suaHRtbAo=