38651 2010-05-06 09:45:20 -0700 WebFrame::paintDocumentRectToContext paints content at the wrong location 2010-05-06 10:39:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sfalken webkit-unassigned oldest_to_newest 221744 0 sfalken 2010-05-06 09:45:20 -0700 WebFrame::paintDocumentRectToContext paints content at the wrong location 221756 1 55252 sfalken 2010-05-06 09:53:09 -0700 Created attachment 55252 Patch 221768 2 55252 aroben 2010-05-06 10:04:24 -0700 Comment on attachment 55252 Patch > @@ -348,11 +348,8 @@ HRESULT STDMETHODCALLTYPE WebFrame::pain > gc.save(); > LONG width = rect.right - rect.left; > LONG height = rect.bottom - rect.top; > - FloatRect dirtyRect; > - dirtyRect.setWidth(width); > - dirtyRect.setHeight(height); > + FloatRect dirtyRect(rect.left, rect.top, width, height); You could get rid of the width and height variables by doing: FloatRect dirtyRect(IntRect(rect)); Too bad we don't have a way to test this. r=me 221797 3 sfalken 2010-05-06 10:39:38 -0700 Committed r58895: <http://trac.webkit.org/changeset/58895> 55252 2010-05-06 09:53:09 -0700 2010-05-06 10:04:24 -0700 Patch bug-38651-20100506095238.patch text/plain 1225 sfalken SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA1ODg4OSkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUtMDYgIFN0ZXZlIEZhbGtlbmJ1cmcgIDxz ZmFsa2VuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXZWJGcmFtZTo6cGFpbnREb2N1bWVudFJlY3RUb0NvbnRleHQgcGFpbnRzIGNv bnRlbnQgYXQgdGhlIHdyb25nIGxvY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zODY1MQorCisgICAgICAgICogV2ViRnJhbWUuY3BwOgorICAg ICAgICAoV2ViRnJhbWU6OnBhaW50RG9jdW1lbnRSZWN0VG9Db250ZXh0KToKKwogMjAxMC0wNS0w NSAgU3R1YXJ0IE1vcmdhbiAgPHN0dWFydG1vcmdhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViS2l0L3dpbi9XZWJGcmFtZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L3dpbi9XZWJGcmFtZS5jcHAJKHJldmlzaW9uIDU4NzczKQor KysgV2ViS2l0L3dpbi9XZWJGcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0OCwxMSArMzQ4 LDggQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBXZWJGcmFtZTo6cGFpbgogICAgIGdjLnNh dmUoKTsKICAgICBMT05HIHdpZHRoID0gcmVjdC5yaWdodCAtIHJlY3QubGVmdDsKICAgICBMT05H IGhlaWdodCA9IHJlY3QuYm90dG9tIC0gcmVjdC50b3A7Ci0gICAgRmxvYXRSZWN0IGRpcnR5UmVj dDsKLSAgICBkaXJ0eVJlY3Quc2V0V2lkdGgod2lkdGgpOwotICAgIGRpcnR5UmVjdC5zZXRIZWln aHQoaGVpZ2h0KTsKKyAgICBGbG9hdFJlY3QgZGlydHlSZWN0KHJlY3QubGVmdCwgcmVjdC50b3As IHdpZHRoLCBoZWlnaHQpOwogICAgIGdjLmNsaXAoZGlydHlSZWN0KTsKLSAgICBnYy50cmFuc2xh dGUoLXJlY3QubGVmdCwgLXJlY3QudG9wKTsKICAgICB2aWV3LT5wYWludENvbnRlbnRzKCZnYywg cmVjdCk7CiAgICAgZ2MucmVzdG9yZSgpOwogCg==