38648 2010-05-06 08:50:42 -0700 Ensure DRT loads GAIL (Gtk+ module), for a11y tests 2010-07-12 17:25:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 39165 41346 42103 31018 0 mario webkit-unassigned abarth commit-queue eric webkit.review.bot xan.lopez oldest_to_newest 221707 0 mario 2010-05-06 08:50:42 -0700 After some investigation while working for fixing bug 31018, I found that the AtkObject* returned by AccessibilityController::rootElement() -in AccessibilityControllerGtk.cpp- is *not a valid AtkObject* at all (ATK_ROLE_INVALID), which makes impossible to later access to its only child and therefore any AccessibleUIElement associated to the DOM's elements. As a consecuence of this, it was not possible to implement the isSelected() method in DRT to make the accessibility/aria-controls-with-tabs.html test success, as it was not possible to access to any AccessibleUIElement in the DOM starting from the root element. After some investigation I found the problem was that the GAIL Gtk module was not being loaded along with the execution of DRT (even if the environment variable was already set), and that's the reason behind those AtkObjects returned by rootElement() not being valid. Therefore, we need to make sure GAIL is always loaded with DRT if we want this kind of a11y tests (using the AccessibleUIElements starting from the root element) work properly. As side note: it seems that some a11y apps like Orca and Accerciser manually make sure the GTK_MODULES envvar is properly loaded along with their executions, so perhaps that's the way to go here, providing it would only affect to the GTK implementation of the DRT. 221715 1 mario 2010-05-06 09:08:06 -0700 Blocking bug 31018 as this issue directly affects to the possibility of implementing the isSelected() method in Gtk's DRT 221812 2 55265 mario 2010-05-06 10:47:58 -0700 Created attachment 55265 Patch to fix this issue This patch makes sure that the Gtk version of the DRT always set the GTK_MODULES variable to the proper value ("gail") before calling to gtk_init(), in a similar fashion to how Orca an Accerciser does it. 221814 3 webkit.review.bot 2010-05-06 10:49:06 -0700 Attachment 55265 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp:912: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 221816 4 55267 mario 2010-05-06 10:55:04 -0700 Created attachment 55267 Patch to fix this issue (In reply to comment #3) > Attachment 55265 [details] did not pass style-queue: > Sorry, forgot to check style. Uploading new patch 222241 5 55267 xan.lopez 2010-05-07 01:32:15 -0700 Comment on attachment 55267 Patch to fix this issue We agreed to spend some time investigating why GTK_MODULES is being thrown away by the test scripts, and whether or not it makes sense to try to be more careful when setting it in the application. 222254 6 55354 mario 2010-05-07 03:09:29 -0700 Created attachment 55354 Patch to fix this issue According to comment #5 I've been spending some time to find out why DRT is ran without considering the GTK_MODULES envvar (if already set) and I found the reason: In WebKitTools/Scripts/old-run-webkit-tests > openDumpTool() a clean environment is prepared before calling to DRT, which basically creates a hashtable with the strictly needed envvars and nothing else, and that obviously doesn't include GTK_MODULES at this point. So, I think the current patch properly addresses the problem by just setting the GTK_MODULES envvar to "gail" when running the tests for the Gtk port, as that would be a clear requirement for the a11y tests to run ok under that scenario. Wrt the doubts also commented with xan about whether to append 'gail' to the already present (if so) GTK_MODULES instead of just *setting* it to a specific value, I'd say that the right thing to do in this case is just to set it, since we don't want to put in that clean environment anything else but the strictly needed things, which in this case means (at least afaik) to load Gail as the only Gtk module. Hope this patch looks better :-) 223370 7 55354 xan.lopez 2010-05-10 10:01:43 -0700 Comment on attachment 55354 Patch to fix this issue Looks good to me, we just need to remember to update the new script when it supports GTK+. 223380 8 55354 commit-queue 2010-05-10 10:17:22 -0700 Comment on attachment 55354 Patch to fix this issue Rejecting patch 55354 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 55354, '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: 5354&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=38648&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 55354 from bug 38648. NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebKitTools/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/WebKitTools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 226177 9 55354 abarth 2010-05-15 00:03:45 -0700 Comment on attachment 55354 Patch to fix this issue Eric said this rejection was caused by a bug in svn-apply, which hopefully has been fixed. 226283 10 55354 commit-queue 2010-05-15 11:26:57 -0700 Comment on attachment 55354 Patch to fix this issue Clearing flags on attachment: 55354 Committed r59544: <http://trac.webkit.org/changeset/59544> 226284 11 commit-queue 2010-05-15 11:27:03 -0700 All reviewed patches have been landed. Closing bug. 226287 12 webkit.review.bot 2010-05-15 11:45:51 -0700 http://trac.webkit.org/changeset/59544 might have broken GTK Linux 32-bit Release 226288 13 abarth 2010-05-15 11:49:26 -0700 editing/undo/4059423-1.html crashed. Same error on GTK Linux 64-bit Release. Rolling out. 226530 14 eric 2010-05-16 13:36:41 -0700 re-opening since rolled out. We need to fix the commit-queue to re-open the original bug when landing rollout patches. 230314 15 mario 2010-05-25 09:34:27 -0700 (In reply to comment #14) > re-opening since rolled out. We need to fix the commit-queue to re-open the original bug when landing rollout patches. I can't reproduce this in my 32-bit compilation of WebKit (Gtk version), with that patch applied: $ run-webkit-tests --gtk editing/undo/4059423-1.html Running build-dumprendertree Running tests from /home/mario/work/gnome2/WebKit/LayoutTests Testing 1 test cases. editing/undo . 0.38s total testing time all 1 test cases succeeded Am I missing something, perhaps? 236371 16 mario 2010-06-10 08:09:55 -0700 (In reply to comment #15) > (In reply to comment #14) > > re-opening since rolled out. We need to fix the commit-queue to re-open the original bug when landing rollout patches. > > I can't reproduce this in my 32-bit compilation of WebKit (Gtk version), with that patch applied: Strike two: I have checked this several times again, and didn't find anything wrong with that. Moreover, considering the nature of this patch (which just adds a envvar to the script for running the tests) I'm a bit confused about how this could be causing a problem at all. It looks to me more like an issue of flackyness or something like that than this patch breaking the build. Could someone help me to clarify this? Perhaps I'm not seeing anything or not doing the proper tests, and that's all. But it would be nice to have this issue fixed as it's blocking some a11y tests in the GTK port since some stuff from DRT won't work properly without it. Thanks 244208 17 55354 xan.lopez 2010-06-29 04:51:27 -0700 Comment on attachment 55354 Patch to fix this issue I can't reproduce the crash locally either, so let's try to get this in again. 244214 18 mario 2010-06-29 05:07:12 -0700 (In reply to comment #17) > (From update of attachment 55354 [details]) > I can't reproduce the crash locally either, so let's try to get this in again. Cross fingers! :-) 244237 19 55354 commit-queue 2010-06-29 05:39:23 -0700 Comment on attachment 55354 Patch to fix this issue Clearing flags on attachment: 55354 Committed r62106: <http://trac.webkit.org/changeset/62106> 244238 20 commit-queue 2010-06-29 05:39:29 -0700 All reviewed patches have been landed. Closing bug. 244247 21 webkit.review.bot 2010-06-29 06:07:00 -0700 http://trac.webkit.org/changeset/62106 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/62105 http://trac.webkit.org/changeset/62106 244321 22 mario 2010-06-29 09:17:55 -0700 (In reply to comment #21) > http://trac.webkit.org/changeset/62106 might have broken GTK Linux 32-bit Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/62105 > http://trac.webkit.org/changeset/62106 The problem behind this broken build is not this bug, but the fact that the new tests added along with bug 36128 need to be updated to match the new code added in patch for bug 40009 (now a11y title and descriptions are prefixed by "AXTitle: " and "AXDescription: ", respectively). Hence, now reopening bug 40009 and attaching the needed patch to updated the failing test and its expected results: platform/gtk/accesibility/name-for-label. 244325 23 mario 2010-06-29 09:25:29 -0700 (In reply to comment #22) > [...] > Hence, now reopening bug 40009 and attaching the needed patch to updated the failing test and its expected results: platform/gtk/accesibility/name-for-label. Much better, filed a new bug to fix this small issue: https://bugs.webkit.org/show_bug.cgi?id=41355 244681 24 60098 mario 2010-06-30 01:38:05 -0700 Created attachment 60098 Patch to fix this issue It looks like this patch has been rolled out because it seems it broke some tests: https://bugs.webkit.org/show_bug.cgi?id=41346 http://trac.webkit.org/changeset/62110 I had no idea what could went wrong there apart that there was a missing ";" in the previous patch (I didn't realize of this since it worked in my local environment), so I'm now attaching a new patch with that simple modification to see if it helps, but no many hopes put down on there... Btw, any tip on this would be welcome, since this bug is blocking other a11y fixes and if I can't reproduce the problem locally I'm not sure I'll be able to find the proper solution for that. Thanks 245130 25 mario 2010-06-30 23:25:53 -0700 (In reply to comment #24) > Created an attachment (id=60098) [details] > Patch to fix this issue > > It looks like this patch has been rolled out because it seems it broke some tests: Btw, shouldn't we reopen this bug then? 249728 26 60098 xan.lopez 2010-07-12 02:25:33 -0700 Comment on attachment 60098 Patch to fix this issue For the horde. 249906 27 xan.lopez 2010-07-12 10:42:09 -0700 Reopen so the bot pushes the patch. 249921 28 60098 commit-queue 2010-07-12 11:18:46 -0700 Comment on attachment 60098 Patch to fix this issue Clearing flags on attachment: 60098 Committed r63101: <http://trac.webkit.org/changeset/63101> 249922 29 commit-queue 2010-07-12 11:18:52 -0700 All reviewed patches have been landed. Closing bug. 250030 30 eric 2010-07-12 13:58:58 -0700 I think this caused Gtk API test failures. 250035 31 mario 2010-07-12 14:08:36 -0700 (In reply to comment #30) > I think this caused Gtk API test failures. I'm currently trying to reproduce the error in my local machine but no success so far. Moreover, I've to recognize I'm a bit lost with this issue (which seems to be doomed :-)) since I can't see why a change in old-run-webkit-tests script can affect to the API tests which are supposed not to use this script, afaik. Now rebasing the patch against last commit from trunk in my local machine, to see if I can reproduce it... sorry for all the trouble coming all the time with this patch :-( 250051 32 xan.lopez 2010-07-12 14:22:33 -0700 This was rolled out and the API test still fails, reopening. 250053 33 60098 xan.lopez 2010-07-12 14:23:00 -0700 Comment on attachment 60098 Patch to fix this issue Hopefully last time we do this :D 250063 34 mario 2010-07-12 14:42:06 -0700 (In reply to comment #32) > This was rolled out and the API test still fails, reopening. I can reproduce the API fail with last trunk, regardless of this patch being applied or not, so the problem is somewhere else for sure... 250106 35 60098 commit-queue 2010-07-12 15:51:53 -0700 Comment on attachment 60098 Patch to fix this issue Clearing flags on attachment: 60098 Committed r63133: <http://trac.webkit.org/changeset/63133> 250107 36 commit-queue 2010-07-12 15:52:00 -0700 All reviewed patches have been landed. Closing bug. 250158 37 mario 2010-07-12 17:01:04 -0700 (In reply to comment #36) > All reviewed patches have been landed. Closing bug. JFTR, I've been bisecting for a while and found that the guilty commit breaking the API test was this one: http://trac.webkit.org/changeset/63100 I don't know whether that commit actually broke something in API tests or just unveiled a problem somewhere else, but git bisect doesn't lie and before that commit everything worked fine wrt those tests. My 2 cents so far 250176 38 mario 2010-07-12 17:25:17 -0700 (In reply to comment #37) > (In reply to comment #36) > > All reviewed patches have been landed. Closing bug. > > JFTR, I've been bisecting for a while and found that the guilty commit breaking the API test was this one: > > http://trac.webkit.org/changeset/63100 > > I don't know whether that commit actually broke something in API tests or just unveiled a problem somewhere else, but git bisect doesn't lie and before that commit everything worked fine wrt those tests. > > My 2 cents so far Hmmm.. looks like I was too slow, as Martin already filed a bug for this: https://bugs.webkit.org/show_bug.cgi?id=42114 Sorry for the spam 55265 2010-05-06 10:47:58 -0700 2010-05-06 10:55:04 -0700 Patch to fix this issue 0001-2010-05-06-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 1918 mario RnJvbSBjNjBmYjljY2ZiZWZiOTcxMGFhMzIxNzIzYjZlYWNlMDdiMjkzNDliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDYgTWF5IDIwMTAgMTk6MzY6MjcgKzAyMDAKU3ViamVjdDogW1BBVENI XSAyMDEwLTA1LTA2ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEVuc3VyZSBEUlQg bG9hZHMgR0FJTCAoR3RrKyBtb2R1bGUpLCBmb3IgYTExeSB0ZXN0cwogICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODY0OAoKICAgICAgICBQcm9wZXJseSBz ZXQgdGhlIEdUS19NT0RVTEVTIGVudnZhciB0byAiZ2FpbCIgYmVmb3JlCiAgICAgICAgY2FsbGlu ZyB0byBndGtfaW5pdCgpCgogICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJU cmVlLmNwcDoKICAgICAgICAobWFpbik6Ci0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCB8ICAgIDMgKysrCiAyIGZpbGVz IGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDBjZTI1 MzUuLjM0MTI1NWIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJL aXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNS0wNiAgTWFyaW8gU2Fu Y2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5zdXJlIERSVCBsb2FkcyBHQUlMIChHdGsrIG1v ZHVsZSksIGZvciBhMTF5IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zODY0OAorCisgICAgICAgIFByb3Blcmx5IHNldCB0aGUgR1RLX01PRFVM RVMgZW52dmFyIHRvICJnYWlsIiBiZWZvcmUKKyAgICAgICAgY2FsbGluZyB0byBndGtfaW5pdCgp CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwOgorICAg ICAgICAobWFpbik6CisKIDIwMTAtMDUtMDQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNoaW5pY2hpcm8gSGFtYWppLgpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1dlYktp dFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggMGYzY2Ez OC4uYTcxY2Q4YyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1 bXBSZW5kZXJUcmVlLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVt cFJlbmRlclRyZWUuY3BwCkBAIC05MDgsNiArOTA4LDkgQEAgc3RhdGljIHZvaWQgbG9nSGFuZGxl cihjb25zdCBnY2hhciogZG9tYWluLCBHTG9nTGV2ZWxGbGFncyBsZXZlbCwgY29uc3QgZ2NoYXIq IG0KIAogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKIHsKKyAgICAvLyBFbnN1cmUg R0FJTCBpcyBsb2FkZWQgZm9yIHRoZSBhMTF5IHRlc3RzCisgICAgZ19zZXRlbnYgKCJHVEtfTU9E VUxFUyIsICJnYWlsIiwgVFJVRSk7CisKICAgICBnX3RocmVhZF9pbml0KE5VTEwpOwogICAgIGd0 a19pbml0KCZhcmdjLCAmYXJndik7CiAKLS0gCjEuNy4wLjQKCg== 55267 2010-05-06 10:55:04 -0700 2010-05-07 03:09:29 -0700 Patch to fix this issue 0001-2010-05-06-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 1917 mario RnJvbSAwMmM5MWRiMGQ1ZDAzNDVhZDBmZGYzOWQ1YTk4MDM3ZmI1MTQyYmUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDYgTWF5IDIwMTAgMTk6MzY6MjcgKzAyMDAKU3ViamVjdDogW1BBVENI XSAyMDEwLTA1LTA2ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEVuc3VyZSBEUlQg bG9hZHMgR0FJTCAoR3RrKyBtb2R1bGUpLCBmb3IgYTExeSB0ZXN0cwogICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODY0OAoKICAgICAgICBQcm9wZXJseSBz ZXQgdGhlIEdUS19NT0RVTEVTIGVudnZhciB0byAiZ2FpbCIgYmVmb3JlCiAgICAgICAgY2FsbGlu ZyB0byBndGtfaW5pdCgpCgogICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJU cmVlLmNwcDoKICAgICAgICAobWFpbik6Ci0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCB8ICAgIDMgKysrCiAyIGZpbGVz IGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDBjZTI1 MzUuLjM0MTI1NWIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJL aXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNS0wNiAgTWFyaW8gU2Fu Y2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5zdXJlIERSVCBsb2FkcyBHQUlMIChHdGsrIG1v ZHVsZSksIGZvciBhMTF5IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zODY0OAorCisgICAgICAgIFByb3Blcmx5IHNldCB0aGUgR1RLX01PRFVM RVMgZW52dmFyIHRvICJnYWlsIiBiZWZvcmUKKyAgICAgICAgY2FsbGluZyB0byBndGtfaW5pdCgp CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwOgorICAg ICAgICAobWFpbik6CisKIDIwMTAtMDUtMDQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNoaW5pY2hpcm8gSGFtYWppLgpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1dlYktp dFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggMGYzY2Ez OC4uZDdiMjQ1YiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1 bXBSZW5kZXJUcmVlLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVt cFJlbmRlclRyZWUuY3BwCkBAIC05MDgsNiArOTA4LDkgQEAgc3RhdGljIHZvaWQgbG9nSGFuZGxl cihjb25zdCBnY2hhciogZG9tYWluLCBHTG9nTGV2ZWxGbGFncyBsZXZlbCwgY29uc3QgZ2NoYXIq IG0KIAogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKIHsKKyAgICAvLyBFbnN1cmUg R0FJTCBpcyBsb2FkZWQgZm9yIHRoZSBhMTF5IHRlc3RzCisgICAgZ19zZXRlbnYoIkdUS19NT0RV TEVTIiwgImdhaWwiLCBUUlVFKTsKKwogICAgIGdfdGhyZWFkX2luaXQoTlVMTCk7CiAgICAgZ3Rr X2luaXQoJmFyZ2MsICZhcmd2KTsKIAotLSAKMS43LjAuNAoK 55354 2010-05-07 03:09:29 -0700 2010-06-30 01:38:05 -0700 Patch to fix this issue 0001-2010-05-07-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 1895 mario RnJvbSAwOWQ4Yjk1MDAwN2NjZThmNzg4M2M1NzdlYTdkYTQ5YTdhYzJkOGM4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBGcmksIDcgTWF5IDIwMTAgMTI6MDE6MjQgKzAyMDAKU3ViamVjdDogW1BBVENI XSAyMDEwLTA1LTA3ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4K CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEVuc3VyZSBEUlQg bG9hZHMgR0FJTCAoR3RrKyBtb2R1bGUpLCBmb3IgYTExeSB0ZXN0cwogICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODY0OAoKICAgICAgICBBZGQgdGhlIEdU S19NT0RVTEVTIGVudnZhciAoc2V0IHRvICJnYWlsIikgdG8gdGhlIGNsZWFuCiAgICAgICAgZW52 aXJvbm1lbnQgd2hlbiBydW5uaW5nIERSVCBmb3IgdGhlIEd0aysgcG9ydAoKICAgICAgICAqIFNj cmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHM6Ci0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiBXZWJLaXRUb29scy9TY3JpcHRz L29sZC1ydW4td2Via2l0LXRlc3RzIHwgICAgNiArKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTcg aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9D aGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggMGNlMjUzNS4uMGU1NjYzOSAx MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA1LTA3ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8 bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBFbnN1cmUgRFJUIGxvYWRzIEdBSUwgKEd0aysgbW9kdWxlKSwgZm9yIGEx MXkgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM4NjQ4CisKKyAgICAgICAgQWRkIHRoZSBHVEtfTU9EVUxFUyBlbnZ2YXIgKHNldCB0byAiZ2Fp bCIpIHRvIHRoZSBjbGVhbgorICAgICAgICBlbnZpcm9ubWVudCB3aGVuIHJ1bm5pbmcgRFJUIGZv ciB0aGUgR3RrKyBwb3J0CisKKyAgICAgICAgKiBTY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3Rz OgorCiAyMDEwLTA1LTA0ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTaGluaWNoaXJvIEhhbWFqaS4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMgYi9XZWJLaXRUb29scy9TY3JpcHRzL29sZC1y dW4td2Via2l0LXRlc3RzCmluZGV4IGQ1ZDczNDkuLmVjMTRkYTYgMTAwNzU1Ci0tLSBhL1dlYktp dFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKKysrIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwpAQCAtMTM0Niw3ICsxMzQ2LDExIEBAIHN1YiBvcGVu RHVtcFRvb2woKQogICAgICAgICBzZXRQYXRoRm9yUnVubmluZ1dlYktpdEFwcChcJUNMRUFOX0VO Vik7CiAgICAgfQogCi0gICAgIyBQb3J0IHNwZXNpZmljcworICAgICMgUG9ydCBzcGVjaWZpY3MK KyAgICBpZiAoaXNHdGsoKSkgeworICAgICAgICAkQ0xFQU5fRU5We0dUS19NT0RVTEVTfSA9ICJn YWlsIgorICAgIH0KKwogICAgIGlmIChpc1F0KCkpIHsKICAgICAgICAgJENMRUFOX0VOVntRVFdF QktJVF9QTFVHSU5fUEFUSH0gPSBwcm9kdWN0RGlyKCkgLiAiL2xpYi9wbHVnaW5zIjsKICAgICB9 Ci0tIAoxLjcuMC40Cgo= 60098 2010-06-30 01:38:05 -0700 2010-07-12 15:51:53 -0700 Patch to fix this issue 0001-2010-06-30-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 1974 mario RnJvbSBkNWQzNGQ2MTk3ZjZiYzg2ZTJiNDg5ZjMyYTNmNWYzMGJjNDM3MTQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBXZWQsIDMwIEp1biAyMDEwIDEwOjIzOjA5ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMC0wNi0zMCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBFbnN1cmUgRFJU IGxvYWRzIEdBSUwgKEd0aysgbW9kdWxlKSwgZm9yIGExMXkgdGVzdHMKICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg2NDgKCiAgICAgICAgQWRkIHRoZSBH VEtfTU9EVUxFUyBlbnZ2YXIgKHNldCB0byAiZ2FpbCIpIHRvIHRoZSBjbGVhbgogICAgICAgIGVu dmlyb25tZW50IHdoZW4gcnVubmluZyBEUlQgZm9yIHRoZSBHdGsrIHBvcnQKCiAgICAgICAgKiBT Y3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogV2ViS2l0VG9vbHMvU2NyaXB0 cy9vbGQtcnVuLXdlYmtpdC10ZXN0cyB8ICAgIDYgKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDE3 IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv Q2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGY5ODBjNWMuLjE1MDY0NmIg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0zMCAgTWFyaW8gU2FuY2hleiBQcmFkYSAg PG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRW5zdXJlIERSVCBsb2FkcyBHQUlMIChHdGsrIG1vZHVsZSksIGZvciBh MTF5IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zODY0OAorCisgICAgICAgIEFkZCB0aGUgR1RLX01PRFVMRVMgZW52dmFyIChzZXQgdG8gImdh aWwiKSB0byB0aGUgY2xlYW4KKyAgICAgICAgZW52aXJvbm1lbnQgd2hlbiBydW5uaW5nIERSVCBm b3IgdGhlIEd0aysgcG9ydAorCisgICAgICAgICogU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0 czoKKwogMjAxMC0wNi0yOSAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwppbmRleCAwZTcwNWE5Li5iZWQwNjFkIDEwMDc1 NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCisrKyBiL1dl YktpdFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKQEAgLTEzNzAsNyArMTM3MCwx MSBAQCBzdWIgb3BlbkR1bXBUb29sKCkKICAgICAgICAgc2V0UGF0aEZvclJ1bm5pbmdXZWJLaXRB cHAoXCVDTEVBTl9FTlYpOwogICAgIH0KIAotICAgICMgUG9ydCBzcGVzaWZpY3MKKyAgICAjIFBv cnQgc3BlY2lmaWNzCisgICAgaWYgKGlzR3RrKCkpIHsKKyAgICAgICAgJENMRUFOX0VOVntHVEtf TU9EVUxFU30gPSAiZ2FpbCI7CisgICAgfQorCiAgICAgaWYgKGlzUXQoKSkgewogICAgICAgICAk Q0xFQU5fRU5We1FUV0VCS0lUX1BMVUdJTl9QQVRIfSA9IHByb2R1Y3REaXIoKSAuICIvbGliL3Bs dWdpbnMiOwogICAgICAgICAkQ0xFQU5fRU5We1FUX0RSVF9XRUJWSUVXX01PREV9ID0gJEVOVnsi UVRfRFJUX1dFQlZJRVdfTU9ERSJ9OwotLSAKMS43LjAuNAoK