38640 2010-05-06 06:36:54 -0700 [Chromium] Suggestion popup is not closed when view is scrolled 2012-06-06 23:31:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 0 romange webkit-unassigned commit-queue evan fishd jorlow playmobil romange tkent oldest_to_newest 221647 0 romange 2010-05-06 06:36:54 -0700 When suggestion popup is opened and user scrolls the view either by mouse or using the scrollbar, the popup stays in the same position relative to the screen. Expected behavior: popup should close. 221649 1 55231 romange 2010-05-06 06:43:28 -0700 Created attachment 55231 patch 221676 2 evan 2010-05-06 07:46:10 -0700 Needs a comment in the ChangeLog about testing, whether it's possible or why not. Might be good to note in the ChangeLog why this already works properly in Windows/Mac. Might be good to make it clearer that you're talking about suggestion popup. 221889 3 55231 fishd 2010-05-06 12:40:23 -0700 Comment on attachment 55231 patch > Index: src/ChromeClientImpl.cpp > =================================================================== > --- src/ChromeClientImpl.cpp (revision 58877) > +++ src/ChromeClientImpl.cpp (working copy) > @@ -507,6 +507,7 @@ void ChromeClientImpl::scroll( scroll is only called when we are doing accelerated scrolling. if the page contains a fixed position element, then invalidateRect will be used to repaint the entire view. so, this patch only solves part of the problem. i think you should really hook into the same thing that triggers the 'scroll' event being dispatched to the page. 225315 4 55983 romange 2010-05-13 08:23:20 -0700 Created attachment 55983 patch More explanations were added to the Changlelog. The popup hiding was added to the slow scroll callback as well. 226450 5 55983 playmobil 2010-05-16 01:22:34 -0700 Comment on attachment 55983 patch Informal review: Changelogs: + I think your editor is stripping trailing whitespaces from files, I don't think you want to do that for the changelog, the diff should only contain your additions. if (m_webView->client()) { WebKit coding style is no curly braces for one line ifs. void ChromeClientImpl::scroll( I'd move the call to hidePopups() to before the dx,dy variable definitions. 226453 6 56182 romange 2010-05-16 01:50:50 -0700 Created attachment 56182 patch 226454 7 56182 playmobil 2010-05-16 01:55:43 -0700 Comment on attachment 56182 patch Informal Review: LGTM 226744 8 evan 2010-05-17 06:51:24 -0700 adding some reviewers 226745 9 evan 2010-05-17 06:52:24 -0700 I suspect this is still at the wrong level. See comment #3. 226753 10 romange 2010-05-17 07:15:26 -0700 I talked to Darin via chat and after inspecting the code he approved my latest change. But I am open for suggestions. Another option would be is to expose a special interface function in ChromeClientImpl just for hiding popups but it seems an overkill for me. 226778 11 56182 fishd 2010-05-17 08:56:11 -0700 Comment on attachment 56182 patch > Index: src/ChromeClientImpl.cpp ... > void ChromeClientImpl::invalidateContentsForSlowScroll(const IntRect& updateRect, bool immediate) > { > + if (m_webView->client()) > + m_webView->hidePopups(); why do you need to null check client before calling hidePopups? 226806 12 romange 2010-05-17 10:31:45 -0700 (In reply to comment #11) > (From update of attachment 56182 [details]) > > Index: src/ChromeClientImpl.cpp > ... > > void ChromeClientImpl::invalidateContentsForSlowScroll(const IntRect& updateRect, bool immediate) > > { > > + if (m_webView->client()) > > + m_webView->hidePopups(); > > why do you need to null check client before calling hidePopups? I am being consistent with the code around. The scroll() function null checks the client so I assumed I need to do this as well. 227443 13 romange 2010-05-18 12:51:19 -0700 What needs to be done in order to proceed with this CL? 227446 14 fishd 2010-05-18 12:57:50 -0700 > > > + if (m_webView->client()) > > > + m_webView->hidePopups(); > > > > why do you need to null check client before calling hidePopups? > > I am being consistent with the code around. The scroll() function null checks the client so I assumed I need to do this as well. The null checks for m_webView->client() exist to avoid calling methods on a null m_webView->client(). It is not necessary in the case above since you are calling a method on m_webView. 228295 15 56579 romange 2010-05-20 03:14:20 -0700 Created attachment 56579 patch 228297 16 romange 2010-05-20 03:18:07 -0700 (In reply to comment #14) > > > > + if (m_webView->client()) > > > > + m_webView->hidePopups(); > > > > > > why do you need to null check client before calling hidePopups? > > > > I am being consistent with the code around. The scroll() function null checks the client so I assumed I need to do this as well. > > The null checks for m_webView->client() exist to avoid calling methods on a null m_webView->client(). It is not necessary in the case above since you are calling a method on m_webView. Oops, I was under impression that I am using client() during the call. The fixed patch is uploaded. 228899 17 56579 commit-queue 2010-05-21 07:32:51 -0700 Comment on attachment 56579 patch Rejecting patch 56579 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--force']" exit_code: 1 Last 500 characters of output: file(s). patching file ChangeLog Hunk #1 succeeded at 1 with fuzz 3. can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: src/ChromeClientImpl.cpp |=================================================================== |--- src/ChromeClientImpl.cpp (revision 59826) |+++ src/ChromeClientImpl.cpp (working copy) -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored Full output: http://webkit-commit-queue.appspot.com/results/2272442 229432 18 56816 playmobil 2010-05-23 02:05:59 -0700 Created attachment 56816 Patch for landing 229470 19 56816 commit-queue 2010-05-23 06:10:07 -0700 Comment on attachment 56816 Patch for landing Rejecting patch 56816 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 56816, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: ion=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=38640&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 56816 from bug 38640. NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebKit/chromium/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 229471 20 56820 playmobil 2010-05-23 06:19:49 -0700 Created attachment 56820 Patch for landing 229473 21 56820 commit-queue 2010-05-23 06:32:19 -0700 Comment on attachment 56820 Patch for landing Clearing flags on attachment: 56820 Committed r60044: <http://trac.webkit.org/changeset/60044> 229474 22 commit-queue 2010-05-23 06:32:26 -0700 All reviewed patches have been landed. Closing bug. 643241 23 tkent 2012-06-06 23:04:35 -0700 (In reply to comment #21) > (From update of attachment 56820 [details]) > Clearing flags on attachment: 56820 > > Committed r60044: <http://trac.webkit.org/changeset/60044> I'll roll this out because of http://code.google.com/p/chromium/issues/detail?id=114922 643252 24 tkent 2012-06-06 23:31:19 -0700 Rolled out by http://trac.webkit.org/changeset/119688. I have filed another bug for the original issue: Bug 88506 55231 2010-05-06 06:43:28 -0700 2010-05-13 08:23:20 -0700 patch patch.txt text/plain 1008 romange SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU4ODc3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDUt MDYgIFJvbWFuIEdlcnNobWFuICA8cm9tYW5nZUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gU3VnZ2VzdGlvbiBw b3B1cCBpcyBub3QgY2xvc2VkIHdoZW4gdmlldyBpcyBzY3JvbGxlZC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NjQwCisKKyAgICAgICAgKiBzcmMv Q2hyb21lQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6 OnNjcm9sbCk6CisKIDIwMTAtMDUtMDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IHNyYy9DaHJvbWVDbGll bnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAJKHJldmlz aW9uIDU4ODc3KQorKysgc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC01MDcsNiArNTA3LDcgQEAgdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpzY3JvbGwoCiAgICAgaWYg KG1fd2ViVmlldy0+Y2xpZW50KCkpIHsKICAgICAgICAgaW50IGR4ID0gc2Nyb2xsRGVsdGEud2lk dGgoKTsKICAgICAgICAgaW50IGR5ID0gc2Nyb2xsRGVsdGEuaGVpZ2h0KCk7CisgICAgICAgIG1f d2ViVmlldy0+aGlkZVBvcHVwcygpOwogICAgICAgICBtX3dlYlZpZXctPmNsaWVudCgpLT5kaWRT Y3JvbGxSZWN0KGR4LCBkeSwgY2xpcFJlY3QpOwogICAgIH0KIH0K 55983 2010-05-13 08:23:20 -0700 2010-05-16 01:50:50 -0700 patch patch.txt text/plain 12720 romange SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU5MzY2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDUt MTMgIFJvbWFuIEdlcnNobWFuICA8cm9tYW5nZUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gU3VnZ2VzdGlvbiBw b3B1cCBpcyBub3QgY2xvc2VkIHdoZW4gdmlldyBpcyBzY3JvbGxlZC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4NjQwCisKKyAgICAgICAgVGhpcyBi dWcgYXBwZWFycyBvbiBib3RoIFdpbmRvd3MgYW5kIExpbnV4IHBsYXRmb3Jtcy4KKyAgICAgICAg TWFjIE9TLCBob3dldmVyIGhhbmRsZXMgd2luZG93IG1lc3NhZ2VzIGRpZmZlcmVudGx5IGFuZAor ICAgICAgICBjbG9zZXMgcG9wdXAgbWVudSBpbiBSZW5kZXJXaWRnZXRIb3N0Vmlld01hYzo6RGVz dHJveSgpLgorCisgICAgICAgIE5vIHRlc3RzIHdlcmUgYWRkZWQgYmVjYXVzZSB0ZXN0X3NoZWxs IGRvZXMgbm90IHN1cHBvcnQgc3VnZ2VzdGlvbgorICAgICAgICBwb3B1cC4KKworICAgICAgICAq IHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50 SW1wbDo6aW52YWxpZGF0ZUNvbnRlbnRzRm9yU2xvd1Njcm9sbCk6CisgICAgICAgIChXZWJLaXQ6 OkNocm9tZUNsaWVudEltcGw6OnNjcm9sbCk6CisKIDIwMTAtMDUtMTIgIEhhbnMgV2VubmJvcmcg IDxoYW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cu CkBAIC03MywxMyArOTEsMTMgQEAKIDIwMTAtMDUtMTIgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRh QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCi0gICAgICAg IAorCiAgICAgICAgIFtDaHJvbWl1bV0gU3VwcG9ydCBIVE1MNSA8cHJvZ3Jlc3M+IGVsZW1lbnQg b24gV2luZG93cy4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM3MzA4CiAKICAgICAgICAgRXh0ZW5kZWQgQ2hyb21pdW1CcmlkZ2UgdG8gaGFuZGxlIHBy b2dyZXNzIGJhciBwYWludGluZywKICAgICAgICAgYW5kIGFkZGVkIGRlbGVnYXRpb25zIHRvIGl0 LgotICAgICAgICAKKwogICAgICAgICBObyBuZXcgdGVzdHMuIFRlc3QgY2FzZXMgc2hvdWxkIGJl IHNoYXJlZCB3aXRoIGV4aXN0aW5nIG9uZXMgZm9yCiAgICAgICAgIHByb2dyZXNzIGVsZW1lbnQu ICBFeHBlY3RhaW9ucyB3aWxsIGJlIGFkZGVkIGFmdGVyIFBST0dSRVNTX1RBRyBpcwogICAgICAg ICBlbmFibGVkIG9uIENocm9taXVtIHRyZWUuCkBAIC0xNDcsNyArMTY1LDcgQEAKICAgICAgICAg YXMgSFRNTElucHV0RWxlbWVudDo6c2l6ZSgpLiAgRHVyaW5nIGZvcm0gQXV0b0ZpbGwgQ2hyb21p dW0gbmVlZHMgdG8KICAgICAgICAgYWNjZXNzIHRoZSBpbnB1dCBlbGVtZW50J3Mgc2l6ZSBhdHRy aWJ1dGUgaW4gYWlkIG9mIGZvcm0gbWF0Y2hpbmcgYW5kCiAgICAgICAgIGZpbGxpbmcgaGV1cmlz dGljcy4KLSAgICAgICAgCisKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM4ODI1CiAKICAgICAgICAgKiBwdWJsaWMvV2ViSW5wdXRFbGVtZW50Lmg6CkBA IC0zMDksOSArMzI3LDkgQEAKICAgICAgICAgSSdtIGtlZXBpbmcgdGhlIG9sZCBtZXRob2QgYXJv dW5kIHVudGlsIHBhdGNoZXMgY2FuIGxhbmQgaW4gYm90aCByZXBvc2l0b3JpZXMKICAgICAgICAg dGhhdCBtYWtlIHRoZSBvbGQgbWV0aG9kIG9ic29sZXRlIGFuZCB1bm5lZWRlZC4gVGhlcmUncyBh IEZJWE1FIGZvciB0aGF0LgogCi0gICAgICAgIEFsc28gc29tZXdoYXQgcmVsYXRlZCBidXQgaW5k ZXBlbmRlbnQgY2hhbmdlIHRvIHByb3BhZ2F0ZSB0aGUgcnVudGltZSBlbmFibGVkIAorICAgICAg ICBBbHNvIHNvbWV3aGF0IHJlbGF0ZWQgYnV0IGluZGVwZW5kZW50IGNoYW5nZSB0byBwcm9wYWdh dGUgdGhlIHJ1bnRpbWUgZW5hYmxlZAogICAgICAgICBmbGFnIHRocnUgdG8gdGhlIHBhZ2Ugc2V0 dGluZ3MgaW5zdGFuY2UgdXNlZCBieSB0aGUgJ3NoYWRvdyBwYWdlJy4KLSAKKwogICAgICAgICAq IHB1YmxpYy9XZWJTaGFyZWRXb3JrZXIuaDogQWRkIHRoZSBuZXcgcGFyYW0gKGJ1dCBrZWVwIHRo ZSBvbGQgaW50ZXJmYWNlIGFyb3VuZCBmb3Igbm93IHRvbykKICAgICAgICAgKFdlYktpdDo6V2Vi U2hhcmVkV29ya2VyOjpzdGFydFdvcmtlckNvbnRleHQpOgogICAgICAgICAqIHNyYy9TaGFyZWRX b3JrZXJSZXBvc2l0b3J5LmNwcDogUHJvdmlkZSB0aGUgdmFsdWUgd2hlbiBjYWxsaW5nIG91dCB0 byBjaHJvbWUuCkBAIC0zNTUsMTEgKzM3MywxMSBAQAogCiAgICAgICAgIFtjaHJvbWl1bV06IEZp eGluZyBGaW5kIGluIHBhZ2UgY3Jhc2ggb24gc2l0ZXMuZ29vZ2xlLmNvbQogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1OTEKLSAgICAgICAgCisKICAg ICAgICAgc2V0TWFya2VyQWN0aXZlIHNob3VsZCBub3QgdHJ5IHRvIHNldCBhIGNvbGxhcHNlZCBt YXJrZXIgYXMKICAgICAgICAgYWN0aXZlLiBUaGlzIGNhbiBoYXBwZW4gd2hlbiB5b3UgRWRpdCBh IFNpdGVzIHBhZ2UgYWZ0ZXIgZG9pbmcKICAgICAgICAgYSBGaW5kIG9wZXJhdGlvbiBhbmQgdGhl biB5b3UgcHJlc3MgRmluZE5leHQuCi0gICAgICAgIAorCiAgICAgICAgICogc3JjL1dlYkZyYW1l SW1wbC5jcHA6CiAgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lSW1wbDo6c2V0TWFya2VyQWN0aXZl KToKIApAQCAtNjcyLDcgKzY5MCw3IEBACiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFsbG93IGVk aXRpbmcgc2NyaXB0IHJlc291cmNlcyB3aGVuIHJlc291cmNlIHRyYWNraW5nIGlzIGVuYWJsZWQu CiAKICAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgyNjkK LSAKKwogICAgICAgICAqIHNyYy9qcy9EZWJ1Z2dlckFnZW50LmpzOgogICAgICAgICAqIHNyYy9q cy9JbnNwZWN0b3JDb250cm9sbGVySW1wbC5qczoKICAgICAgICAgKC5kZXZ0b29scy5JbnNwZWN0 b3JCYWNrZW5kSW1wbC5wcm90b3R5cGUuc2V0QnJlYWtwb2ludCk6CkBAIC03MDQsNyArNzIyLDcg QEAKIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgogCi0gICAgICAgIEZpeGVk IHBhc3NpbmcgYnJlYWtwb2ludHMgdG8gVjguIAorICAgICAgICBGaXhlZCBwYXNzaW5nIGJyZWFr cG9pbnRzIHRvIFY4LgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzgyNjYKIAogICAgICAgICAqIHNyYy9qcy9JbnNwZWN0b3JDb250cm9sbGVySW1wbC5q czoKQEAgLTcxNiw3ICs3MzQsNyBAQAogCiAgICAgICAgIFN1cHBvcnQgcGF1c2Ugb24gZXhjZXB0 aW9ucyBpbiB2OCBpbXBsZW1lbnRhdGlvbiBvZiBTY3JpcHREZWJ1Z1NlcnZlci4KIAotICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgyMDUgICAgICAgIAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgyMDUKIAog ICAgICAgICAqIHNyYy9qcy9EZWJ1Z2dlclNjcmlwdC5qczoKICAgICAgICAgKGRlYnVnZ2VyU2Ny aXB0Q29uc3RydWN0b3IuRGVidWdnZXJTY3JpcHQuZ2V0U2NyaXB0cyk6CkBAIC03NTQsNyArNzcy LDcgQEAKICAgICAgICAgKFdlYktpdDo6V2ViV29ya2VyQmFzZTo6ZGlkQ3JlYXRlRGF0YVNvdXJj ZSkKICAgICAgICAgKFdlYktpdDo6V2ViV29ya2VyQmFzZTo6Y3JlYXRlQXBwbGljYXRpb25DYWNo ZUhvc3QpCiAgICAgICAgICogc3JjL1dlYldvcmtlckJhc2UuaDogZGl0dG8KLSAgICAgICAgKiBz cmMvV2ViV29ya2VyQ2xpZW50SW1wbC5oOiBhZGQgYSBzdHViIGltcGwgb2YgdGhlIGZhY3Rvcnkg bWV0aG9kIAorICAgICAgICAqIHNyYy9XZWJXb3JrZXJDbGllbnRJbXBsLmg6IGFkZCBhIHN0dWIg aW1wbCBvZiB0aGUgZmFjdG9yeSBtZXRob2QKICAgICAgICAgKFdlYktpdDo6V2ViV29ya2VyQ2xp ZW50SW1wbDo6Y3JlYXRlQXBwbGljYXRpb25DYWNoZUhvc3QpOgogCiAyMDEwLTA0LTI3ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KQEAgLTEzMTQsMTUgKzEzMzIsMTUgQEAKICAg ICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw6OmJlZ2luUGFpbnQpOgog CiAyMDEwLTA0LTE2ICBKYXJra28gU2Fra2luZW4gIDxqYXJra28uai5zYWtraW5lbkBnbWFpbC5j b20+Ci0gCisKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCi0gCisKICAgICAg ICAgW1F0XSBXZWJHTCBpcyBub3QgdmlzaWJsZSB3aGVuIFFHTFdpZGdldCB2aWV3cG9ydCBpcyB1 c2VkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzA3 MAotIAorCiAgICAgICAgIEFkZGVkIEhvc3RXaW5kb3cgcGFyYW1ldGVyIHRvIHRoZSBjb25zdHJ1 Y3RvciBvZiBHcmFwaGljc0NvbnRleHQzRC4KICAgICAgICAgU2hhcmVkIE9wZW5HTCBjb250ZXh0 IGlzIGluaXRpYWxpemVkIHdpdGggcGFyZW50IFFHTFdpZGdldC4KLSAKKwogICAgICAgICAqIHNy Yy9HcmFwaGljc0NvbnRleHQzRC5jcHA6CiAgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRl eHQzRDo6R3JhcGhpY3NDb250ZXh0M0QpOgogCkBAIC0xODAyLDcgKzE4MjAsNyBAQAogICAgICAg ICBNb3ZlIHRoZSBJREI6Om9wZW4gRXhjZXB0aW9uQ29kZSBwYXJhbXRlciB0byBiZSBsYXN0CiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzI3NwogCi0g ICAgICAgIE1vdmUgdGhlIEV4Y2VwdGlvbkNvZGUgcGFyYW10ZXIgdG8gdGhlIGxhc3QgcG9zaXRp b24gaW4gCisgICAgICAgIE1vdmUgdGhlIEV4Y2VwdGlvbkNvZGUgcGFyYW10ZXIgdG8gdGhlIGxh c3QgcG9zaXRpb24gaW4KICAgICAgICAgSW5kZXhlZERhdGFiYXNlUmVxdWVzdDo6b3BlbiBhbmQg ZnJpZW5kcy4gIEl0IHNob3VsZCBkZWZpbml0ZWx5CiAgICAgICAgIGdvIGFmdGVyIHRoZSBjYWxs YmFja3MgdG8ga2VlcCB0aGUgcGFyYW1ldGVycyB0aGF0IGNvbWUgZGlyZWN0bHkKICAgICAgICAg ZnJvbSBqYXZhc2NyaXB0IHRvZ2V0aGVyLiAgQW5kIGhhdmluZyBvdXRwdXQgcGFyYW1ldGVycyBh cHBlYXIKQEAgLTIwNjAsNyArMjA3OCw3IEBACiAKIDIwMTAtMDQtMDQgIFBhdmVsIEZlbGRtYW4g IDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKLSAgICAgICAgTm90IHJldmlld2VkLiBSb2xsaW5n IG91dCBjaHJvbWl1bSBjaGFuZ2VzIHI1NzAyOCBhbmQgcjU3MDMyIAorICAgICAgICBOb3QgcmV2 aWV3ZWQuIFJvbGxpbmcgb3V0IGNocm9taXVtIGNoYW5nZXMgcjU3MDI4IGFuZCByNTcwMzIKICAg ICAgICAgZm9yIGJyZWFraW5nIGNocm9taXVtIGxheW91dCB0ZXN0cy4KIAogICAgICAgICAqIHB1 YmxpYy9XZWJWaWV3Q2xpZW50Lmg6CkBAIC0yMTU5LDcgKzIxNzcsNyBAQAogCiAgICAgICAgIFJl dmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCiAKLSAgICAgICAgSW1wbGVtZW50IEluc3BlY3RvckZy b250ZW5kQ2xpZW50IGluIENocm9taXVtIGFuZCByZW1vdmUgYWxsIGN1c3RvbSBiaW5kaW5ncyBm b3IgdGhlIGhvc3QgbWV0aG9kcyBmcm9tIFdlYkRldlRvb2xzRnJvbnRlbmRJbXBsLiAKKyAgICAg ICAgSW1wbGVtZW50IEluc3BlY3RvckZyb250ZW5kQ2xpZW50IGluIENocm9taXVtIGFuZCByZW1v dmUgYWxsIGN1c3RvbSBiaW5kaW5ncyBmb3IgdGhlIGhvc3QgbWV0aG9kcyBmcm9tIFdlYkRldlRv b2xzRnJvbnRlbmRJbXBsLgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zNjgxNwogCkBAIC0yMjI0LDcgKzIyNDIsNyBAQAogICAgICAgICB0aGUgaW52 YWxpZGF0ZVJlY3QgZXhwZWN0cyBmcmFtZSBjb29yZGluYXRlcy4KIAogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY5ODIKLSAgICAgICAgCisKICAgICAg ICAgKiBzcmMvV2ViRnJhbWVJbXBsLmNwcDoKICAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBs OjppbnZhbGlkYXRlQXJlYSk6CiAKQEAgLTIzOTEsNyArMjQwOSw3IEBACiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEZpc2hlci4KIAogICAgICAgICBSZW5hbWUgLyB0aWR5IHVwIEdlb2xvY2F0 aW9uIGJyaWRnZToKLSAgICAgICAgUmVuYW1lIEdlb2xvY2F0aW9uU2VydmljZUJyaWRnZUNocm9t aXVtLmNwcCB0byBXZWJHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2VJbXBsLmNwcCAgICAgICAgICAg IAorICAgICAgICBSZW5hbWUgR2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdlQ2hyb21pdW0uY3BwIHRv IFdlYkdlb2xvY2F0aW9uU2VydmljZUJyaWRnZUltcGwuY3BwCiAgICAgICAgIFVzZXMgYSB0ZW1w b3JhcnkgY29tcGF0aWJpbGl0eSBsYXllciBpbiBHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2VDaHJv bWl1bS5oLgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zNjUzNQpAQCAtMzQ4Nyw5ICszNTA1LDkgQEAKIDIwMTAtMDMtMTggIE5hdGUgQ2hhcGluICA8 amFwaGV0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXpr b3YuCi0gICAgICAgIAorCiAgICAgICAgIFJlbW92ZSBhbGwgcmVmZXJlbmNlcyB0byBWOEluZGV4 LmggYW5kIFY4Q2xhc3NJbmRleC4KLSAgICAgICAgCisKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDc3CiAKICAgICAgICAgKiBzcmMvV2ViQmluZGlu Z3MuY3BwOgpAQCAtMzgzMSw3ICszODQ5LDcgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZp ZCBMZXZpbi4KIAotICAgICAgICBbQ2hyb21pdW1dIENtZC1jbGlja2luZyBzdWJtaXQgYnV0dG9u cyBzaG91bGQgc3VibWl0IGluIG5ldyB0YWIgCisgICAgICAgIFtDaHJvbWl1bV0gQ21kLWNsaWNr aW5nIHN1Ym1pdCBidXR0b25zIHNob3VsZCBzdWJtaXQgaW4gbmV3IHRhYgogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYwMjMKIAogICAgICAgICBUYWtl IG1vZGlmaWVycyBpbnRvIGFjY291bnQgd2hlbiBjbGlja2luZyBmb3JtIGJ1dHRvbnMuIEUuZy4K QEAgLTQxMTgsNyArNDEzNiw3IEBACiAKICAgICAgICAgQnVnIDI4MjkzIC0gIFtDaHJvbWl1bV0g ZXZlbnQuZGF0YXRyYW5zZmVyLmdldGRhdGEoInRleHQvdXJpLWxpc3QiKSBpcyB0cmVhdGVkIHRo ZSBzYW1lIGFzIGdldGRhdGEoIlVSTCIpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yODI5MwotICAgICAgICAKKwogICAgICAgICBDaGFuZ2UgQ2hyb21p dW1EYXRhT2JqZWN0IHN1Y2ggdGhhdCBpdCB0cmVhdHMgdHlwZXMgIlVSTCIgYW5kICJ0ZXh0L3Vy aS1saXN0IgogICAgICAgICBjb3JyZWN0bHkgZm9yIGV2ZW50LmRhdGFUcmFuc2Zlci5nZXREYXRh L3NldERhdGEuIEN1cnJlbnRseSBib3RoIGFyZSB0cmVhdGVkCiAgICAgICAgIGFzIHN5bm9ueW1z LCBidXQgZm9yICJVUkwiLCBnZXREYXRhIGlzIHN1cHBvc2VkIHRvIG9ubHkgcmV0dXJuIHRoZSBm aXJzdCB2YWxpZCBVUkwKQEAgLTQxNjEsOCArNDE3OSw4IEBACiAgICAgICAgIFJldmlld2VkIGJ5 IFBhdmVsIEZlbGRtYW4uCiAKICAgICAgICAgVXNlIGNsZWFuIGdsb2JhbCBvYmplY3QgZm9yIGRl dnRvb2xzIHV0aWxpdHkgY29udGV4dCBpbnN0ZWFkIG9mCi0gICAgICAgIHRyeWluZyB0byBzaW11 bGF0ZSBpbnNwZWN0ZWQgY29udGV4dC4gCi0gICAgCisgICAgICAgIHRyeWluZyB0byBzaW11bGF0 ZSBpbnNwZWN0ZWQgY29udGV4dC4KKwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzU5MjMKIAogICAgICAgICAqIHNyYy9EZWJ1Z2dlckFnZW50SW1wbC5j cHA6CkBAIC00NDExLDcgKzQ0MjksNyBAQAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhh dGNoZXIuCiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIHR3byBsYXN0IHN5bmNocm9u b3VzIGNhbGxzIGZyb20gZnJvbnQtZW5kIHRvIEluc3BlY3RvckJhY2tlbmQuCi0gICAgICAgIAor CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTcyMAog CiAgICAgICAgICogc3JjL2pzL0luc3BlY3RvckNvbnRyb2xsZXJJbXBsLmpzOgpAQCAtNDg4Nyw3 ICs0OTA1LDcgQEAKIAogICAgICAgICBBZGQgYW4gaXNJbWFnZUJsb2NrZWQgYm9vbCB0byB0aGUg V2ViQ29udGV4dE1lbnVEYXRhIHN0cnVjdC4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM1MTM2Ci0gICAgICAgIAorCiAgICAgICAgIFRoaXMgbGV0cyB1 cyBwcm9wZXJseSBlbmFibGUvZGlzYWJsZSB0aGUgIkNvcHkgSW1hZ2UiIGNvbnRleHQgbWVudSBl bnRyeQogICAgICAgICAoYW5kLCBpbiB0aGUgZnV0dXJlLCBtYXliZSBhZGQgYSAiTG9hZCBJbWFn ZSIgZnVuY3Rpb24pLgogCkBAIC00OTQwLDcgKzQ5NTgsNyBAQAogICAgICAgICBSZXZpZXdlZCBi eSBBZGFtIEJhcnRoLgogCiAgICAgICAgIEV4cG9zaW5nIHRoZSB0aXRsZSBpbiBXZWJEb2N1bWVu dC4KLSAgICAgICAgCisKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM1MDU4CiAKICAgICAgICAgKiBwdWJsaWMvV2ViRG9jdW1lbnQuaDoKQEAgLTUzMTcs NyArNTMzNSw3IEBACiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KIAogICAgICAg ICBbQ2hyb21pdW1dIEFkZCBmdW5jdGlvbiBmb3IgYWNjZXNzaWJpbGl0eSBvYmplY3Qgc3RhdGUg Y2hhbmdlIG5vdGlmaWNhdGlvbnMuCi0gICAgICAgIAorCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDQ2NAogCiAgICAgICAgICogZ3lwX3dlYmtpdDoK QEAgLTYzNjcsNyArNjM4NSw3IEBACiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4K IAogICAgICAgICBbQ2hyb21pdW1dIEFkZCBmdW5jdGlvbiBmb3IgQWNjZXNzaWJpbGl0eU9iamVj dCBzdGF0ZSBjaGFuZ2Ugbm90aWZpY2F0aW9ucy4KLSAgICAgICAgCisKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0NDY0CiAKICAgICAgICAgKiBwdWJs aWMvV2ViVmlld0NsaWVudC5oOgpAQCAtNjg1Nyw3ICs2ODc1LDcgQEAKIAogICAgICAgICBSZXZp ZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCiAKLSAgICAgICAgQWRkaW5nIG1pc3NpbmcgV2ViTXV0 YXRpb25FdmVudC5jcHAgZmlsZSB0byBmaXggYnVpbGQgYnVzdGFnZS4gCisgICAgICAgIEFkZGlu ZyBtaXNzaW5nIFdlYk11dGF0aW9uRXZlbnQuY3BwIGZpbGUgdG8gZml4IGJ1aWxkIGJ1c3RhZ2Uu CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzg4Mgog CiAgICAgICAgICogcHVibGljL1dlYk11dGF0aW9uRXZlbnQuaDogUmVtb3ZlIHVubmVjZXNzYXJ5 IGNvbnN0cnVjdG9yLgpAQCAtNzA1OSw3ICs3MDc3LDcgQEAKIAogICAgICAgICBCdW1wcyB0aGUg cmVmY291bnQgd2hlbiBXZWJOb2RlOjp0b0VsZW1lbnQvdG9Db25zdEVsZW1lbnQgYXJlIGNhbGxl ZC4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzOTc3 Ci0gICAgICAgIAorCiAgICAgICAgIEVuc3VyZXMgdGhhdCB3aGVuIGEgd3JhcHBlciBhcm91bmQg YSBXZWJOb2RlIGlzIGNyZWF0ZSB2aWEgdGhlCiAgICAgICAgIHRvRWxlbWVudCgpIG9yIHRvQ29u c3RFbGVtZW50KCkgY2FsbHMgdGhhdCB0aGUgcmVmY291bnQgb24gdGhlIFdlYk5vZGUKICAgICAg ICAgaXMgaW5jcmVhc2VkLCBieSBmb3JjaW5nIGEgY2FsbCB0byBXZWJOb2RlOjphc3NpZ24oKS4g IFRoaXMgaXMgbmVlZGVkCkBAIC03MTg5LDcgKzcyMDcsNyBAQAogCiAgICAgICAgIFtDaHJvbWl1 bV0gUmVtb3ZlIGFuIG9sZCBydW5GaWxlQ2hvb3NlcigpIG1ldGhvZC4KICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNzc4Ci0gICAgICAgIAorCiAgICAg ICAgIENocm9taXVtIGNvZGUgc3dpdGNoZWQgdG8gbmV3IHJ1bkZpbGVDaG9vc2VyKCkgaW50cm9k dWNlZCBieQogICAgICAgICByNTMyNjkuIFRoZSBvbGQgb25lIGlzIG5vdCBuZWVkZWQgYW55bW9y ZS4KIApAQCAtNzI2NCw3ICs3MjgyLDcgQEAKIAogICAgICAgICBEcmFnIGFuZCBEcm9wIHNvdXJj ZS9kZXN0aW5hdGlvbiBjb2RlIG5lZWRzIGNsZWFudXAuCiAgICAgICAgIDxodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM2OTE+LgotICAgICAgICAKKwogICAgICAgICBV cGRhdGUgdG8gbmV3IHdheSBvZiBjYWxsaW5nIHNvdXJjZU9wZXJhdGlvbi4KIAogICAgICAgICAq IHNyYy9EcmFnQ2xpZW50SW1wbC5jcHA6CkBAIC03MzYwLDcgKzczNzgsNyBAQAogCiAyMDEwLTAx LTEzICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgogCi0gICAgICAgIE5vIHJl dmlld2VyLiAgTW9yZSBvciBsZXNzIGEgYnVpbGQgZml4LiAgTXkgNTMxODAgYnJva2Ugc29tZSAK KyAgICAgICAgTm8gcmV2aWV3ZXIuICBNb3JlIG9yIGxlc3MgYSBidWlsZCBmaXguICBNeSA1MzE4 MCBicm9rZSBzb21lCiAgICAgICAgIHN0dWZmIG9uIHRoZSBDaHJvbWl1bSBwb3J0IHNvIEknbSBy ZXZlcnRpbmcuCiAKICAgICAgICAgKiBwdWJsaWMvV2ViS2l0Q2xpZW50Lmg6CkBAIC03NzY5LDcg Kzc3ODcsNyBAQAogCiAgICAgICAgIFtDaHJvbWl1bV0gV2ViR0wgY3Jhc2hlcyBpbnRlcm1pdHRl bnRseSBvbiBMaW51eAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzI4NDUKLSAgICAgICAgCisKICAgICAgICAgVGhlIGRsY2xvc2UnaW5nIG9mIGxpYkdM LnNvLjEgYW5kIGRsb3Blbidpbmcgb2YgaXQgZWFjaCB0aW1lIGEKICAgICAgICAgR3JhcGhpY3ND b250ZXh0M0Qgd2FzIGNyZWF0ZWQgd2FzIG9jY2FzaW9uYWxseSBjYXVzaW5nIGl0IHRvIGJlCiAg ICAgICAgIHJlLW1hcHBlZCBhdCBhIGRpZmZlcmVudCBiYXNlIGFkZHJlc3MuIFNpbmNlIEdMRVcg aXMgbm90CkBAIC04NTAzLDcgKzg1MjEsNyBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMg U2VpZGVsLgogCi0gICAgICAgIFNhbml0aXplIHdlYiBmb250cyB1c2luZyB0aGUgT1RTIGxpYnJh cnkgCisgICAgICAgIFNhbml0aXplIHdlYiBmb250cyB1c2luZyB0aGUgT1RTIGxpYnJhcnkKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxMTA2CiAKICAg ICAgICAgKiBERVBTOiBBZGRlZCBkZXBlbmRlbmN5IHRvIHRoZSBPcGVuVHlwZSBzYW5pdGl6ZXIg bGlicmFyeS4KQEAgLTg5NjYsOCArODk4NCw4IEBACiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGlt aXRyaSBHbGF6a292LgogCi0gICAgICAgIFJvbGxpbmcgQ2hyb21pdW0gZGVwZW5kZW5jaWVzIHRv IG1hdGNoIENocm9taXVtIHJldmlzaW9uIDMxODM0LiAKLSAgICAgICAgCisgICAgICAgIFJvbGxp bmcgQ2hyb21pdW0gZGVwZW5kZW5jaWVzIHRvIG1hdGNoIENocm9taXVtIHJldmlzaW9uIDMxODM0 LgorCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTQ0 NQogCiAgICAgICAgICogREVQUzoKSW5kZXg6IHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDU4OTc1KQorKysg c3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OTcsNyArNDk3LDEw IEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6aW52YWxpZGF0ZUNvbnRlbnQKIAogdm9pZCBDaHJv bWVDbGllbnRJbXBsOjppbnZhbGlkYXRlQ29udGVudHNGb3JTbG93U2Nyb2xsKGNvbnN0IEludFJl Y3QmIHVwZGF0ZVJlY3QsIGJvb2wgaW1tZWRpYXRlKQogewotICAgIGludmFsaWRhdGVDb250ZW50 c0FuZFdpbmRvdyh1cGRhdGVSZWN0LCBpbW1lZGlhdGUpOworICAgaWYgKG1fd2ViVmlldy0+Y2xp ZW50KCkpIHsKKyAgICAgbV93ZWJWaWV3LT5oaWRlUG9wdXBzKCk7CisgICB9CisgICBpbnZhbGlk YXRlQ29udGVudHNBbmRXaW5kb3codXBkYXRlUmVjdCwgaW1tZWRpYXRlKTsKIH0KIAogdm9pZCBD aHJvbWVDbGllbnRJbXBsOjpzY3JvbGwoCkBAIC01MDcsNiArNTEwLDcgQEAgdm9pZCBDaHJvbWVD bGllbnRJbXBsOjpzY3JvbGwoCiAgICAgaWYgKG1fd2ViVmlldy0+Y2xpZW50KCkpIHsKICAgICAg ICAgaW50IGR4ID0gc2Nyb2xsRGVsdGEud2lkdGgoKTsKICAgICAgICAgaW50IGR5ID0gc2Nyb2xs RGVsdGEuaGVpZ2h0KCk7CisgICAgICAgIG1fd2ViVmlldy0+aGlkZVBvcHVwcygpOwogICAgICAg ICBtX3dlYlZpZXctPmNsaWVudCgpLT5kaWRTY3JvbGxSZWN0KGR4LCBkeSwgY2xpcFJlY3QpOwog ICAgIH0KIH0K 56182 2010-05-16 01:50:50 -0700 2010-05-20 03:14:20 -0700 patch patch.txt text/plain 1688 romange SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU5NTcw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDUt MTMgIFJvbWFuIEdlcnNobWFuICA8cm9tYW5nZUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gU3VnZ2VzdGlvbiBw b3B1cCBpcyBub3QgY2xvc2VkIHdoZW4gdGhlIHZpZXcgaXMgc2Nyb2xsZWQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODY0MAorCisgICAgICAgIFRo aXMgYnVnIGFwcGVhcnMgb24gYm90aCBXaW5kb3dzIGFuZCBMaW51eCBwbGF0Zm9ybXMuCisgICAg ICAgIE1hYyBPUywgaG93ZXZlciBoYW5kbGVzIHdpbmRvdyBtZXNzYWdlcyBkaWZmZXJlbnRseSBh bmQKKyAgICAgICAgY2xvc2VzIHBvcHVwIG1lbnUgaW4gUmVuZGVyV2lkZ2V0SG9zdFZpZXdNYWM6 OkRlc3Ryb3koKS4KKworICAgICAgICBObyB0ZXN0cyB3ZXJlIGFkZGVkIGJlY2F1c2UgdGVzdF9z aGVsbCBkb2VzIG5vdCBzdXBwb3J0IHN1Z2dlc3Rpb24KKyAgICAgICAgcG9wdXAuCisKKyAgICAg ICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNs aWVudEltcGw6OmludmFsaWRhdGVDb250ZW50c0ZvclNsb3dTY3JvbGwpOgorICAgICAgICAoV2Vi S2l0OjpDaHJvbWVDbGllbnRJbXBsOjpzY3JvbGwpOgorCiAyMDEwLTA1LTE1ICBEYXJpbiBGaXNo ZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0 aC4KSW5kZXg6IHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzcmMvQ2hy b21lQ2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDU5NTcwKQorKysgc3JjL0Nocm9tZUNsaWVudElt cGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MDAsNiArNTAwLDggQEAgdm9pZCBDaHJvbWVDbGll bnRJbXBsOjppbnZhbGlkYXRlQ29udGVudAogCiB2b2lkIENocm9tZUNsaWVudEltcGw6OmludmFs aWRhdGVDb250ZW50c0ZvclNsb3dTY3JvbGwoY29uc3QgSW50UmVjdCYgdXBkYXRlUmVjdCwgYm9v bCBpbW1lZGlhdGUpCiB7CisgICAgaWYgKG1fd2ViVmlldy0+Y2xpZW50KCkpCisgICAgICAgIG1f d2ViVmlldy0+aGlkZVBvcHVwcygpOwogICAgIGludmFsaWRhdGVDb250ZW50c0FuZFdpbmRvdyh1 cGRhdGVSZWN0LCBpbW1lZGlhdGUpOwogfQogCkBAIC01MDgsNiArNTEwLDcgQEAgdm9pZCBDaHJv bWVDbGllbnRJbXBsOjpzY3JvbGwoCiAgICAgY29uc3QgSW50UmVjdCYgY2xpcFJlY3QpCiB7CiAg ICAgaWYgKG1fd2ViVmlldy0+Y2xpZW50KCkpIHsKKyAgICAgICAgbV93ZWJWaWV3LT5oaWRlUG9w dXBzKCk7CiAgICAgICAgIGludCBkeCA9IHNjcm9sbERlbHRhLndpZHRoKCk7CiAgICAgICAgIGlu dCBkeSA9IHNjcm9sbERlbHRhLmhlaWdodCgpOwogICAgICAgICBtX3dlYlZpZXctPmNsaWVudCgp LT5kaWRTY3JvbGxSZWN0KGR4LCBkeSwgY2xpcFJlY3QpOwo= 56579 2010-05-20 03:14:20 -0700 2010-05-23 02:05:50 -0700 patch patch.txt text/plain 1657 romange SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU5ODI2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDUt MTMgIFJvbWFuIEdlcnNobWFuICA8cm9tYW5nZUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gU3VnZ2VzdGlvbiBw b3B1cCBpcyBub3QgY2xvc2VkIHdoZW4gdGhlIHZpZXcgaXMgc2Nyb2xsZWQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODY0MAorCisgICAgICAgIFRo aXMgYnVnIGFwcGVhcnMgb24gYm90aCBXaW5kb3dzIGFuZCBMaW51eCBwbGF0Zm9ybXMuCisgICAg ICAgIE1hYyBPUywgaG93ZXZlciBoYW5kbGVzIHdpbmRvdyBtZXNzYWdlcyBkaWZmZXJlbnRseSBh bmQKKyAgICAgICAgY2xvc2VzIHBvcHVwIG1lbnUgaW4gUmVuZGVyV2lkZ2V0SG9zdFZpZXdNYWM6 OkRlc3Ryb3koKS4KKworICAgICAgICBObyB0ZXN0cyB3ZXJlIGFkZGVkIGJlY2F1c2UgdGVzdF9z aGVsbCBkb2VzIG5vdCBzdXBwb3J0IHN1Z2dlc3Rpb24KKyAgICAgICAgcG9wdXAuCisKKyAgICAg ICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNs aWVudEltcGw6OmludmFsaWRhdGVDb250ZW50c0ZvclNsb3dTY3JvbGwpOgorICAgICAgICAoV2Vi S2l0OjpDaHJvbWVDbGllbnRJbXBsOjpzY3JvbGwpOgorCiAyMDEwLTA1LTE5ICBWYW5nZWxpcyBL b2trZXZpcyAgPHZhbmdlbGlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBGaXNoZXIuCkluZGV4OiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCShyZXZpc2lvbiA1OTgyNikKKysrIHNyYy9DaHJv bWVDbGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTAwLDYgKzUwMCw3IEBAIHZvaWQg Q2hyb21lQ2xpZW50SW1wbDo6aW52YWxpZGF0ZUNvbnRlbnQKIAogdm9pZCBDaHJvbWVDbGllbnRJ bXBsOjppbnZhbGlkYXRlQ29udGVudHNGb3JTbG93U2Nyb2xsKGNvbnN0IEludFJlY3QmIHVwZGF0 ZVJlY3QsIGJvb2wgaW1tZWRpYXRlKQogeworICAgIG1fd2ViVmlldy0+aGlkZVBvcHVwcygpOwog ICAgIGludmFsaWRhdGVDb250ZW50c0FuZFdpbmRvdyh1cGRhdGVSZWN0LCBpbW1lZGlhdGUpOwog fQogCkBAIC01MDcsNiArNTA4LDcgQEAgdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpzY3JvbGwoCiAg ICAgY29uc3QgSW50U2l6ZSYgc2Nyb2xsRGVsdGEsIGNvbnN0IEludFJlY3QmIHNjcm9sbFJlY3Qs CiAgICAgY29uc3QgSW50UmVjdCYgY2xpcFJlY3QpCiB7CisgICAgbV93ZWJWaWV3LT5oaWRlUG9w dXBzKCk7CiAgICAgaWYgKG1fd2ViVmlldy0+Y2xpZW50KCkpIHsKICAgICAgICAgaW50IGR4ID0g c2Nyb2xsRGVsdGEud2lkdGgoKTsKICAgICAgICAgaW50IGR5ID0gc2Nyb2xsRGVsdGEuaGVpZ2h0 KCk7Cg== 56816 2010-05-23 02:05:59 -0700 2010-05-23 06:19:36 -0700 Patch for landing bug-38640-20100523120556.patch text/plain 1870 playmobil ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGM4MjU2ZDk2MjQ3ZWVlOGYwYjFiM2IwOThlMzA1NTRmYTlhZTY1M2Yu Ljg2NWJjOTY3ZjM3ZGQwNTFmMzA3MmEwYzIwYmFlMjM3ZTFkNTBhNzMgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDIxIEBACisyMDEwLTA1LTEzICBSb21hbiBHZXJzaG1hbiAgPHJvbWFuZ2VAZ29v Z2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQ2hyb21pdW1dIFN1Z2dlc3Rpb24gcG9wdXAgaXMgbm90IGNsb3NlZCB3aGVuIHRoZSB2aWV3 IGlzIHNjcm9sbGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mzg2NDAKKworICAgICAgICBUaGlzIGJ1ZyBhcHBlYXJzIG9uIGJvdGggV2luZG93cyBh bmQgTGludXggcGxhdGZvcm1zLgorICAgICAgICBNYWMgT1MsIGhvd2V2ZXIgaGFuZGxlcyB3aW5k b3cgbWVzc2FnZXMgZGlmZmVyZW50bHkgYW5kCisgICAgICAgIGNsb3NlcyBwb3B1cCBtZW51IGlu IFJlbmRlcldpZGdldEhvc3RWaWV3TWFjOjpEZXN0cm95KCkuCisKKyAgICAgICAgTm8gdGVzdHMg d2VyZSBhZGRlZCBiZWNhdXNlIHRlc3Rfc2hlbGwgZG9lcyBub3Qgc3VwcG9ydCBzdWdnZXN0aW9u CisgICAgICAgIHBvcHVwLgorCisgICAgICAgICogc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwOgor ICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnRJbXBsOjppbnZhbGlkYXRlQ29udGVudHNGb3JT bG93U2Nyb2xsKToKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6c2Nyb2xsKToK KwogMjAxMC0wNS0yMiAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9t aXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21l Q2xpZW50SW1wbC5jcHAKaW5kZXggMWEzNjZiYzhjODQzMTdkMTFmY2ZkMDNlMzE3NWE3MjZhOWI4 Nzk5Ny4uZDU0ZjMyOGI3YTFlOWY5ZWIwZmNjMzBhN2MwNmVlNzU2NDg0ODY3NSAxMDA2NDQKLS0t IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAorKysgYi9XZWJLaXQv Y2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCkBAIC01MDAsNiArNTAwLDcgQEAgdm9p ZCBDaHJvbWVDbGllbnRJbXBsOjppbnZhbGlkYXRlQ29udGVudHNBbmRXaW5kb3coY29uc3QgSW50 UmVjdCYgdXBkYXRlUmVjdCwgYm8KIAogdm9pZCBDaHJvbWVDbGllbnRJbXBsOjppbnZhbGlkYXRl Q29udGVudHNGb3JTbG93U2Nyb2xsKGNvbnN0IEludFJlY3QmIHVwZGF0ZVJlY3QsIGJvb2wgaW1t ZWRpYXRlKQogeworICAgIG1fd2ViVmlldy0+aGlkZVBvcHVwcygpOwogICAgIGludmFsaWRhdGVD b250ZW50c0FuZFdpbmRvdyh1cGRhdGVSZWN0LCBpbW1lZGlhdGUpOwogfQogCkBAIC01MDcsNiAr NTA4LDcgQEAgdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpzY3JvbGwoCiAgICAgY29uc3QgSW50U2l6 ZSYgc2Nyb2xsRGVsdGEsIGNvbnN0IEludFJlY3QmIHNjcm9sbFJlY3QsCiAgICAgY29uc3QgSW50 UmVjdCYgY2xpcFJlY3QpCiB7CisgICAgbV93ZWJWaWV3LT5oaWRlUG9wdXBzKCk7CiAgICAgaWYg KG1fd2ViVmlldy0+Y2xpZW50KCkpIHsKICAgICAgICAgaW50IGR4ID0gc2Nyb2xsRGVsdGEud2lk dGgoKTsKICAgICAgICAgaW50IGR5ID0gc2Nyb2xsRGVsdGEuaGVpZ2h0KCk7Cg== 56820 2010-05-23 06:19:49 -0700 2010-05-23 06:32:18 -0700 Patch for landing bug-38640-20100523161945.patch text/plain 1868 playmobil ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGM4MjU2ZDk2MjQ3ZWVlOGYwYjFiM2IwOThlMzA1NTRmYTlhZTY1M2Yu LjZjMGEwZmEyZTAyMTQ4Yjc3OTAwZWQxMTE1YWEyYWVjOTgzMTQxMmUgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDIxIEBACisyMDEwLTA1LTEzICBSb21hbiBHZXJzaG1hbiAgPHJvbWFuZ2VAZ29v Z2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCisKKyAgICAgICAg W0Nocm9taXVtXSBTdWdnZXN0aW9uIHBvcHVwIGlzIG5vdCBjbG9zZWQgd2hlbiB0aGUgdmlldyBp cyBzY3JvbGxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM4NjQwCisKKyAgICAgICAgVGhpcyBidWcgYXBwZWFycyBvbiBib3RoIFdpbmRvd3MgYW5k IExpbnV4IHBsYXRmb3Jtcy4KKyAgICAgICAgTWFjIE9TLCBob3dldmVyIGhhbmRsZXMgd2luZG93 IG1lc3NhZ2VzIGRpZmZlcmVudGx5IGFuZAorICAgICAgICBjbG9zZXMgcG9wdXAgbWVudSBpbiBS ZW5kZXJXaWRnZXRIb3N0Vmlld01hYzo6RGVzdHJveSgpLgorCisgICAgICAgIE5vIHRlc3RzIHdl cmUgYWRkZWQgYmVjYXVzZSB0ZXN0X3NoZWxsIGRvZXMgbm90IHN1cHBvcnQgc3VnZ2VzdGlvbgor ICAgICAgICBwb3B1cC4KKworICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6aW52YWxpZGF0ZUNvbnRlbnRzRm9yU2xv d1Njcm9sbCk6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OnNjcm9sbCk6CisK IDIwMTAtMDUtMjIgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1 bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNs aWVudEltcGwuY3BwCmluZGV4IDFhMzY2YmM4Yzg0MzE3ZDExZmNmZDAzZTMxNzVhNzI2YTliODc5 OTcuLmQ1NGYzMjhiN2ExZTlmOWViMGZjYzMwYTdjMDZlZTc1NjQ4NDg2NzUgMTAwNjQ0Ci0tLSBh L1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKKysrIGIvV2ViS2l0L2No cm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcApAQCAtNTAwLDYgKzUwMCw3IEBAIHZvaWQg Q2hyb21lQ2xpZW50SW1wbDo6aW52YWxpZGF0ZUNvbnRlbnRzQW5kV2luZG93KGNvbnN0IEludFJl Y3QmIHVwZGF0ZVJlY3QsIGJvCiAKIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6aW52YWxpZGF0ZUNv bnRlbnRzRm9yU2xvd1Njcm9sbChjb25zdCBJbnRSZWN0JiB1cGRhdGVSZWN0LCBib29sIGltbWVk aWF0ZSkKIHsKKyAgICBtX3dlYlZpZXctPmhpZGVQb3B1cHMoKTsKICAgICBpbnZhbGlkYXRlQ29u dGVudHNBbmRXaW5kb3codXBkYXRlUmVjdCwgaW1tZWRpYXRlKTsKIH0KIApAQCAtNTA3LDYgKzUw OCw3IEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6c2Nyb2xsKAogICAgIGNvbnN0IEludFNpemUm IHNjcm9sbERlbHRhLCBjb25zdCBJbnRSZWN0JiBzY3JvbGxSZWN0LAogICAgIGNvbnN0IEludFJl Y3QmIGNsaXBSZWN0KQogeworICAgIG1fd2ViVmlldy0+aGlkZVBvcHVwcygpOwogICAgIGlmICht X3dlYlZpZXctPmNsaWVudCgpKSB7CiAgICAgICAgIGludCBkeCA9IHNjcm9sbERlbHRhLndpZHRo KCk7CiAgICAgICAgIGludCBkeSA9IHNjcm9sbERlbHRhLmhlaWdodCgpOwo=